Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Clarify type evolution of uabi_node/uabi_engines

2023-10-04 Thread Mathias Krause
On 03.10.23 09:32, Tvrtko Ursulin wrote: > On 29/09/2023 12:00, Tvrtko Ursulin wrote: >> [...] >> Thanks again! >> >> Reviewed-by: Tvrtko Ursulin > > Patches pushed to drm-intel-gt-next. > Thanks, Tvrtko! I guess this implies no backport of the first patch to older kernels, as it affects v6.3+

[Intel-gfx] [PATCH v2 1/2] drm/i915: Register engines early to avoid type confusion

2023-09-28 Thread Mathias Krause
by: sanitiy checks in grsecurity Suggested-by: Tvrtko Ursulin Fixes: 1ec23ed7126e ("drm/i915: Use uabi engines for the default engine map") Signed-off-by: Mathias Krause Cc: Jonathan Cavitt Cc: Tvrtko Ursulin --- Tested on my ADL systems just fine, no rb-tree related type confusi

[Intel-gfx] [PATCH v2 2/2] drm/i915: Clarify type evolution of uabi_node/uabi_engines

2023-09-28 Thread Mathias Krause
gines more visible by putting all members into an anonymous union and use the correctly typed member in its various users. This allows us to drop quite some ugly casts and, hopefully, make the evolution of the members better recognisable to avoid future mistakes. Signed-off-by: Mathias Krause --

[Intel-gfx] [PATCH v2 0/2] drm/i915: fix rb-tree/llist/list confusion

2023-09-28 Thread Mathias Krause
vrtko) v1: https://lore.kernel.org/intel-gfx/20230905113921.14071-1-mini...@grsecurity.net/ Please apply! Thanks, Mathias Mathias Krause (2): drm/i915: Register engines early to avoid type confusion drm/i915: Clarify type evolution of uabi_node/uabi_engines drivers/gpu/drm/i915/gt/intel_e

Re: [Intel-gfx] [PATCH 0/2] drm/i915: fix rb-tree/llist/list confusion

2023-09-28 Thread Mathias Krause
On 28.09.23 13:15, Tvrtko Ursulin wrote: > Hi, > > On 21/09/2023 07:24, Mathias Krause wrote: >> On 05.09.23 13:39, Mathias Krause wrote: >>> Commit 1ec23ed7126e ("drm/i915: Use uabi engines for the default engine >>> map") introduced a bug regarding e

Re: [Intel-gfx] [PATCH 0/2] drm/i915: fix rb-tree/llist/list confusion

2023-09-25 Thread Mathias Krause
On 05.09.23 13:39, Mathias Krause wrote: > Commit 1ec23ed7126e ("drm/i915: Use uabi engines for the default engine > map") introduced a bug regarding engine iteration in default_engines() > as the rb tree isn't set up yet that early during driver initialization. > This

[Intel-gfx] [PATCH 1/2] Revert "drm/i915: Use uabi engines for the default engine map"

2023-09-05 Thread Mathias Krause
-by: sanitiy checks in grsecurity Fixes: 1ec23ed7126e ("drm/i915: Use uabi engines for the default engine map") Signed-off-by: Mathias Krause Cc: Jonathan Cavitt Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(

[Intel-gfx] [PATCH 0/2] drm/i915: fix rb-tree/llist/list confusion

2023-09-05 Thread Mathias Krause
rnels, fixed by reverting the offending commit (patch 1) and giving the type-multiplexed members some more visibility to avoid making a similar mistake again in the future (patch 2). Please apply! Thanks, Mathias Mathias Krause (2): Revert "drm/i915: Use uabi engines for the default engine map&

[Intel-gfx] [PATCH 2/2] drm/i915: Clarify type evolution of uabi_node/uabi_engines

2023-09-05 Thread Mathias Krause
bi_engines more visible by putting all members into an anonymous union and use the correctly typed member in its various users. This allows us to drop quite some ugly casts and, hopefully, make the evolution of the members better recognisable to avoid future mistakes. Signed-off-by: Mathias Krause --

[Intel-gfx] [PATCH] drm/i915: Remove bogus __init annotation from DMI callbacks

2014-08-29 Thread Mathias Krause
: Add DMI override to skip CRT...") Fixes: 425d244c8670 ("drm/i915: ignore LVDS on intel graphics systems...") Signed-off-by: Mathias Krause Cc: Daniel Vetter Cc: Duncan Laurie Cc: Jarod Wilson Cc: Rusty Russell# Can modpost be fixed? Cc: sta...@vger.kernel.org --- In the long run