Re: [Intel-gfx] [RFC PATCH] tests/gem_userptr_blits: Check for banned mmap-offset

2021-04-15 Thread Marcin Bernatowicz
igt_describe("Test process exit with busy userptr > object mmapped via mmap-offset"); > - igt_subtest_with_dynamic("process-exit-mmap-busy") > - for_each_mmap_offset_type(fd, t) > - igt_dynamic(t->name) > - test_process_exit(fd, t, > PE_BUSY); > + test_process_exit(fd, PE_BUSY); > > igt_subtest("create-destroy-sync") > test_create_destroy(fd, 5); > @@ -2655,18 +2401,11 @@ igt_main_args("c:", NULL, help_str, > opt_handler, NULL) > } > } > > - igt_describe("Invalidate pages of idle userptr with > mmap-offset on top"); > - igt_subtest_with_dynamic("mmap-offset-invalidate-idle") > + igt_describe("Verify mmap_offset to userptr is > banned"); > + igt_subtest_with_dynamic("mmap-offset-banned") > for_each_mmap_offset_type(fd, t) > igt_dynamic_f("%s", t->name) > - test_mmap_offset_invalidate(fd, > t, 0); > - > - igt_describe("Invalidate pages of active userptr with > mmap-offset on top"); > - igt_subtest_with_dynamic("mmap-offset-invalidate- > active") > - for_each_mmap_offset_type(fd, t) > - igt_dynamic_f("%s", t->name) > - test_mmap_offset_invalidate(fd, > t, > -MMOI > _ACTIVE); > + test_mmap_offset_banned(fd, t); > > igt_subtest("coherency-sync") > test_coherency(fd, count); > @@ -2748,7 +2487,4 @@ igt_main_args("c:", NULL, help_str, > opt_handler, NULL) > > igt_subtest("access-control") > test_access_control(fd); > - > - igt_fixture > - free(can_mmap); > } LGTM, Reviewed-by: Marcin Bernatowicz ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [RFC PATCH 2/2] intel-ci: Unblock core_hotunplug@*hot*bind* subtests

2021-04-14 Thread Marcin Bernatowicz
op.org/drm/intel/-/issues/2644 > -igt@core_hotunplug@.*(hot|plug).* > +# *plug* subtests still fail and leave the > +# machine in a very bad state, causing coverage > +# loss for other tests. IOMMU related. > +igt@core_hotunplug@.*plug.* LGTM, Acked-by: Marcin

Re: [Intel-gfx] [RFC PATCH 1/2] tests/core_hotunplug: Add perf health check

2021-04-14 Thread Marcin Bernatowicz
> 'debugfs_test', > @@ -361,6 +360,13 @@ test_executables += executable('perf', > install : true) > test_list += 'perf' > > +test_executables += executable('core_hotunplug', 'core_hotunplug.c', > +dependencies : test_deps + [ lib_igt_i915_perf ], > +install_dir : libexecdir, > +install_rpath : libexecdir_rpathdir, > +install : true) > +test_list += 'core_hotunplug' > + > executable('testdisplay', ['testdisplay.c', > 'testdisplay_hotplug.c'], > dependencies : test_deps, > install_dir : libexecdir, LGTM, Acked-by: Marcin Bernatowicz ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] tests/core_hotunplug: Reduce debug noise on stdout

2021-01-19 Thread Marcin Bernatowicz
ound "); > igt_assert_eq(priv->fd.drm, -1); > > - healthcheck(priv, false); > + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); > } > > static void hotreplug_lateclose(struct hotunplug *priv) > { > - igt_assert_eq(priv->fd.drm, -1);

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/core_hotunplug: Take care of closing fences before failing

2020-10-15 Thread Marcin Bernatowicz
+ /* Assume gem_close() failure is unrecoverable */ > gem_close(i915, obj.handle); > > - igt_assert_eq(sync_fence_wait(fence, -1), 0); > - igt_assert_eq(sync_fence_status(fence), 1); > - close(fence); > + if (err < 0) > + r

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v3] tests/core_hotunplug: Restore i915 debugfs health check

2020-10-15 Thread Marcin Bernatowicz
t; @@ -317,6 +317,16 @@ static void node_healthcheck(struct hotunplug > *priv, unsigned flags) > priv->failure = NULL; > } > > + if (!priv->failure) { > + char path[200]; > + > + priv->failure = "Device sysfs healthck