Re: [PATCH] drm/i915: replace in_atomic() with manually set flag

2025-02-03 Thread Maciej Patelczyk
Krzysztof Looks good to me. Reviewed-by: Maciej Patelczyk

Re: [PATCH] drm/i915: replace in_atomic() with manually set flag

2025-01-23 Thread Maciej Patelczyk
On 10.01.2025 16:46, Krzysztof Karas wrote: GuC code uses in_atomic() function to determine if the current context is atomic. As noted by the function's description it should not be used in driver code, as it is not guaranteed to determine atomicity correctly in every instance. This is also poin

Re: [PATCH v3] drm/i915/gt: Use spin_lock_irqsave() in interruptible context

2025-01-16 Thread Maciej Patelczyk
* the wakeref immediately but per function spec usage call this after unlock. Looked at this and wasn't seeing it. There is spin_lock_irqsave() used earlier. Reviewed-by: Maciej Patelczyk

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return

2021-12-02 Thread Maciej Patelczyk
Andi Shyti writes: > Change functions that always return '0' to be void type. > > Signed-off-by: Andi Shyti > Cc: Maciej Patelczyk > --- > drivers/gpu/drm/i915/gt/intel_gt_debugfs.c| 7 --- > drivers/gpu/drm/i915/gt/intel_gt_debugfs.h|