Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA

2016-04-20 Thread Luis R. Rodriguez
On Wed, Apr 20, 2016 at 01:17:30PM +0200, Daniel Vetter wrote: > On Wed, Apr 20, 2016 at 11:10:54AM +0200, Luis R. Rodriguez wrote: > > Reason I ask is since I noticed a while ago a lot of drivers > > were using info->fix.smem_start and info->fix.smem_len consistently > >

Re: [Intel-gfx] [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-20 Thread Luis R. Rodriguez
On Wed, Apr 20, 2016 at 08:14:32PM +0100, Chris Wilson wrote: > On Wed, Apr 20, 2016 at 08:58:44PM +0200, Luis R. Rodriguez wrote: > > On Wed, Apr 20, 2016 at 07:42:13PM +0100, Chris Wilson wrote: > > > The ioremap() hidden behind the io_mapping_map_wc() convenience helper >

Re: [Intel-gfx] [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-20 Thread Luis R. Rodriguez
n > Cc: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: David Airlie > Cc: Yishai Hadas > Cc: Dan Williams > Cc: Ingo Molnar > Cc: "Peter Zijlstra (Intel)" > Cc: David Hildenbrand > Cc: Luis R. Rodriguez > Cc: intel-gfx@lists.freed

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA

2016-04-20 Thread Luis R. Rodriguez
On Tue, Apr 19, 2016 at 01:33:58PM +0100, Chris Wilson wrote: > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 6ce2c31b9a81..9ef47329e8ae 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -3346,6 +3346,15 @@ static vo

Re: [Intel-gfx] [PATCH v2 2/4] io-mapping: Specify mapping size for io_mapping_map_wc()

2016-04-19 Thread Luis R. Rodriguez
On Tue, Apr 19, 2016 at 01:02:25PM +0100, Chris Wilson wrote: > On Mon, Apr 18, 2016 at 12:14:00PM +0100, Chris Wilson wrote: > > The ioremap() hidden behind the io_mapping_map_wc() convenience helper > > can be used for remapping multiple pages. Extend the helper so that > > future callers can use

Re: [Intel-gfx] [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Luis R. Rodriguez
On Fri, Nov 30, 2012 at 11:18 AM, Luis R. Rodriguez wrote: > On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel wrote: >> So what is the rationale here. During mainlining our drivers we had to >> remove all uses of 'typedef struct foo foo_t;'. The Linux CodingStyle &

Re: [Intel-gfx] [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Luis R. Rodriguez
On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel wrote: > So what is the rationale here. During mainlining our drivers we had to > remove all uses of 'typedef struct foo foo_t;'. The Linux CodingStyle > (chapter 5 Typedefs) is spending a number of lines explaining why. > > So is spinlock_t an ex

[Intel-gfx] [PATCH 6/6] ie6xx_wdt: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. CHECK drivers/watchdog/ie6xx_wdt.c CC [M] drivers/watchdog/ie6xx_wdt.o Building modules, stage 2. MODPOST 43 modules LD [M] drivers/watchdog/ie6xx_wdt.ko Cc: Alexander Stein Reported-by: Hauke Mehrtens Sig

[Intel-gfx] [PATCH 5/6] brcmfmac: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. LD drivers/net/wireless/brcm80211/built-in.o CHECK drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c CC [M] drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.o CHECK drivers/net/wireless/brcm8021

[Intel-gfx] [PATCH 4/6] s5p-jpeg: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. Could not get this to build with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/media/platform/s5p-jpeg WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers

[Intel-gfx] [PATCH 3/6] s5p-fimc: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. Could not get this to build with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/media/platform/s5p-fimc/ WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers

[Intel-gfx] [PATCH 2/6] i915: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. LD drivers/gpu/drm/i915/built-in.o CHECK drivers/gpu/drm/i915/i915_drv.c CC [M] drivers/gpu/drm/i915/i915_drv.o CHECK drivers/gpu/drm/i915/i915_dma.c CC [M] drivers/gpu/drm/i915/i915_dma.o CHECK drive

[Intel-gfx] [PATCH 1/6] ux500: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. I was unable to build test with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/crypto/ux500/ WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers is missing; mo

[Intel-gfx] [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Turns out a few drivers have strayed away from using the spinlock_t typedef and decided to use struct spinlock directly. This series converts these drivers to use spinlock_t. Each change has been compile tested with allmodconfig and sparse checked. Driver deve