Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-02-13 Thread Liang, Kan
On 2025-02-13 9:28 a.m., Tvrtko Ursulin wrote: > > On 13/02/2025 13:36, Liang, Kan wrote: >> On 2025-02-12 11:13 p.m., Lucas De Marchi wrote: >>> On Tue, Jan 21, 2025 at 12:19:15PM -0500, Liang, Kan wrote: >>>> >>>> >>>> On 2025-01-2

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-02-13 Thread Liang, Kan
On 2025-02-12 11:13 p.m., Lucas De Marchi wrote: > On Tue, Jan 21, 2025 at 12:19:15PM -0500, Liang, Kan wrote: >> >> >> On 2025-01-21 11:59 a.m., Lucas De Marchi wrote: >>> On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: >>>> >>>&g

Re: [PATCH v2] drm/i915/pmu: Drop custom hotplug code

2025-02-03 Thread Liang, Kan
On 2025-01-31 6:11 p.m., Lucas De Marchi wrote: > Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with > a scope"), there's generic support for system-wide counters and > integration with cpu hotplug. > > The i915 counters are system-wide, even though the migration code > is

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-21 Thread Liang, Kan
On 2025-01-21 11:59 a.m., Lucas De Marchi wrote: > On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: >> >> >> On 2025-01-21 9:29 a.m., Lucas De Marchi wrote: >>> On Mon, Jan 20, 2025 at 08:42:41PM -0500, Liang, Kan wrote: >>>>>>>

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-21 Thread Liang, Kan
On 2025-01-21 9:29 a.m., Lucas De Marchi wrote: > On Mon, Jan 20, 2025 at 08:42:41PM -0500, Liang, Kan wrote: >>>>> -static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node >>>>> *node) >>>>> -{ >>>>> -    struct i915_p

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-20 Thread Liang, Kan
On 2025-01-20 5:57 p.m., Lucas De Marchi wrote: > On Mon, Jan 20, 2025 at 10:08:39AM -0500, Liang, Kan wrote: >> >> >> On 2025-01-16 5:24 p.m., Lucas De Marchi wrote: >>> Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with >>> a

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-20 Thread Liang, Kan
On 2025-01-16 5:24 p.m., Lucas De Marchi wrote: > Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with > a scope"), there's generic support for system-wide counters and > integration with cpu hotplug. Set our scope to PERF_PMU_SCOPE_SYS_WIDE > instead of all the boilerplate c