[Intel-gfx] [PATCH v2] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
This commit add check for return value of init_ring_common() in the init_render_ring(). Now, when failure is detected the error code is propagated to the caller instead of being ignored. Signed-off-by: Konrad Zapalowicz --- v2: - remove from commit message references to the Oops. drivers

Re: [Intel-gfx] [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
On 06/19, Daniel Vetter wrote: > On Thu, Jun 19, 2014 at 12:38 AM, Konrad Zapalowicz > wrote: > > This commit add check for return value of init_ring_common() in the > > init_render_ring(). Now, when failure is detected the error code is > > propagated to the caller layer

[Intel-gfx] [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
: Konrad Zapalowicz --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 279488a..d205b0d 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()

2014-06-19 Thread Konrad Zapalowicz
On 06/19, Daniel Vetter wrote: > On Thu, Jun 19, 2014 at 4:35 PM, Daniel Vetter wrote: > > The actual bug we seem to have is blowing up on the ggtt_unpin in > > context_fini. Which is doubly-impossible: Gen4 doesn't have hw > > contexts, so should have dctx->obj == NULL. And ring init failures > >