Re: [RFC PATCH 0/3] Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2

2024-05-10 Thread Kenneth Graunke
On Tuesday, May 7, 2024 3:56:57 PM PDT Matt Roper wrote: > On Mon, May 06, 2024 at 09:52:35PM +0300, Juha-Pekka Heikkila wrote: > > These patches introduce I915_FORMAT_MOD_4_TILED_XE2_CCS modifier, which, > > from the kernel's perspective, behaves similarly to `I915_FORMAT_MOD_4_TILED`. > > This n

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

2024-01-24 Thread Kenneth Graunke
versions with known bugs before enabling features like async > > compute. > > There was > https://patchwork.freedesktop.org/patch/560704/?series=124592&rev=1 > which does everything in one go so would be my preference. Joonas's patch posted here is: Reviewed-by: Kenne

Re: [Intel-gfx] [PATCH v3 0/7] Fix ctx workarounds for non-masked regs

2023-06-30 Thread Kenneth Graunke
in clr_set() > > drivers/gpu/drm/i915/gt/intel_workarounds.c | 129 ++-- > 1 file changed, 66 insertions(+), 63 deletions(-) Whole series is now: Reviewed-by: Kenneth Graunke Thanks a lot for fixing this, Lucas! signature.asc Description: This is a digitally signed message part.

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-27 Thread Kenneth Graunke
WA is intentionally > overwriting all the bits to avoid a read-modify-write. > > v2: Reword commit message wrt GEN12_FF_MODE2 and the changed behavior > on preparatory patches. > > Cc: Kenneth Graunke > Cc: Matt Roper > Link: > https://gitlab.freedesktop.org/mesa/me

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER

2023-06-27 Thread Kenneth Graunke
On Saturday, June 24, 2023 10:17:57 AM PDT Lucas De Marchi wrote: > The comment on the parameter being 0 to avoid the read back doesn't > apply as this is not a call to wa_mcr_add(), but rather to > wa_mcr_clr_set(). So, this register is actually checked and it's > according to the Bspec that the r

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-23 Thread Kenneth Graunke
On Friday, June 23, 2023 8:49:05 AM PDT Lucas De Marchi wrote: > On Thu, Jun 22, 2023 at 04:37:21PM -0700, Kenneth Graunke wrote: > >On Thursday, June 22, 2023 11:27:30 AM PDT Lucas De Marchi wrote: > >> Most of the context workarounds tweak masked registers, but not all. For >

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Move wal_get_fw_for_rmw()

2023-06-22 Thread Kenneth Graunke
workarounds.c | 32 ++--- > 1 file changed, 16 insertions(+), 16 deletions(-) Patches 1 and 3 are: Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part.

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-22 Thread Kenneth Graunke
On Thursday, June 22, 2023 11:27:30 AM PDT Lucas De Marchi wrote: > Most of the context workarounds tweak masked registers, but not all. For > masked registers, when writing the value it's sufficient to just write > the wa->set_bits since that will take care of both the clr and set bits > as well a

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at BO creation

2023-04-04 Thread Kenneth Graunke
On Monday, April 3, 2023 9:48:40 AM PDT Ville Syrjälä wrote: > On Mon, Apr 03, 2023 at 09:35:32AM -0700, Matt Roper wrote: > > On Mon, Apr 03, 2023 at 07:02:08PM +0300, Ville Syrjälä wrote: > > > On Fri, Mar 31, 2023 at 11:38:30PM -0700, fei.y...@intel.com wrote: > > > > From: Fei Yang > > > > >

Re: [Intel-gfx] [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-21 Thread Kenneth Graunke
Thanks! Series is: Acked-by: Kenneth Graunke https://gitlab.freedesktop.org/kwg/mesa/-/commits/iris-userptr-probe is an untested Mesa branch that makes use of the new probe uAPI. On Thursday, July 15, 2021 3:15:35 AM PDT Matthew Auld wrote: > From: Chris Wilson > > Jason Ekstrand

Re: [Intel-gfx] [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-21 Thread Kenneth Graunke
Thanks for this! Series is: Acked-by: Kenneth Graunke https://gitlab.freedesktop.org/kwg/mesa/-/commits/iris-userptr-probe is an untested branch that uses the new probe API in Mesa. On Thursday, July 15, 2021 3:15:35 AM PDT Matthew Auld wrote: > From: Chris Wilson > > Jason

Re: [Intel-gfx] [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-15 Thread Kenneth Graunke
On Thursday, July 15, 2021 4:27:44 AM PDT Tvrtko Ursulin wrote: > > On 15/07/2021 12:07, Daniel Vetter wrote: > > On Thu, Jul 15, 2021 at 11:33:10AM +0100, Tvrtko Ursulin wrote: > >> > >> On 15/07/2021 11:15, Matthew Auld wrote: > >>> From: Chris Wilson > >>> > >>> Jason Ekstrand requested a more

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/uapi: reject caching ioctls for discrete

2021-07-13 Thread Kenneth Graunke
gt; through a new gem_create_ext extension. > > v2: add some kernel doc for the discrete changes, and document the > implicit rules > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst > Cc: Tvrtko Ursulin > Cc: Jo

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/uapi: reject set_domain for discrete

2021-07-12 Thread Kenneth Graunke
On Friday, July 2, 2021 12:22:58 PM PDT Daniel Vetter wrote: > On Fri, Jul 02, 2021 at 03:31:08PM +0100, Tvrtko Ursulin wrote: > > > > On 01/07/2021 16:10, Matthew Auld wrote: > > > The CPU domain should be static for discrete, and on DG1 we don't need > > > any flushing since everything is alread

Re: [Intel-gfx] Enabling sample_c optimization for Broadwell GPUs

2021-05-05 Thread Kenneth Graunke
Hello, Yes, that bit only exists on Haswell. On Haswell, sample_c operations were processed at 1 pixel/clock unless you set that bit, in which case they get processed at 4 pixels/clock. The downside is that it breaks some obscure media feature that apparently no one used. Broadwell and later al

Re: [Intel-gfx] [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Kenneth Graunke
Auld > Cc: Joonas Lahtinen > Cc: Thomas Hellström > Cc: Daniele Ceraolo Spurio > Cc: Lionel Landwerlin > Cc: Jon Bloomfield > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Dave Airlie > Cc: dri-de...@lists.freedesktop

Re: [Intel-gfx] [PATCH 6/9] drm/i915/uapi: implement object placement extension

2021-04-28 Thread Kenneth Graunke
e/create-ext-placement-each > Testcase: igt/gem_create/create-ext-placement-all > Signed-off-by: Matthew Auld > Signed-off-by: CQ Tang > Cc: Joonas Lahtinen > Cc: Daniele Ceraolo Spurio > Cc: Lionel Landwerlin > Cc: Jordan Justen > Cc: Daniel Vetter > Cc:

Re: [Intel-gfx] [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Kenneth Graunke
On Wednesday, April 28, 2021 9:56:25 AM PDT Jason Ekstrand wrote: > On Wed, Apr 28, 2021 at 11:41 AM Matthew Auld wrote: [snip] > > Slightly orthogonal: what does Mesa do here for snooped vs LLC > > platforms? Does it make such a distinction? Just curious. > > In Vulkan on non-LLC platforms, we o

Re: [Intel-gfx] [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-28 Thread Kenneth Graunke
On Monday, April 26, 2021 2:38:53 AM PDT Matthew Auld wrote: > +Existing uAPI issues > + > +Some potential issues we still need to resolve. > + > +I915 MMAP > +- > +In i915 there are multiple ways to MMAP GEM object, including mapping the > same > +object using differen

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Put HDC flush pipe_control bit in the right dword

2020-05-04 Thread Kenneth Graunke
ven on Icelake / Gen11 - so it might make sense to call this gen11_emit_pipe_control() and use it on the Icelake functions. That said, i915 never sets HDC_PIPELINE_FLUSH until Gen12, so we don't actually have a bug to fix on Icelake today. But if someone started trying to set it on Gen11, we wou

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2

2019-09-11 Thread Kenneth Graunke
On Wednesday, September 11, 2019 1:00:51 AM PDT Chris Wilson wrote: > Quoting Chris Wilson (2019-09-11 08:42:22) > > Quoting Kenneth Graunke (2019-09-11 02:48:01) > > > This allows userspace to use "legacy" mode for push constants, where > > > they are c

[Intel-gfx] [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2

2019-09-10 Thread Kenneth Graunke
ew" way. Conflating push constants with binding tables is painful for userspace, we would like to be able to avoid doing so. Signed-off-by: Kenneth Graunke Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/d

[Intel-gfx] [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2

2019-09-10 Thread Kenneth Graunke
This allows userspace to use "legacy" mode for push constants, where they are committed at 3DPRIMITIVE or flush time, rather than being committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11 both use the "legacy" behavior - only Gen9 works in the "new" way. Conflating push constant

[Intel-gfx] [PATCH] drm/i915: Disable SAMPLER_STATE prefetching on all Gen11 steppings.

2019-06-25 Thread Kenneth Graunke
failures in the dEQP-GLES31.functional.copy_image.non_compressed.* tests. After applying this workaround, the tests reliably pass. BSpec: 9663 Cc: sta...@vger.kernel.org Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + 1 file changed, 5 insertions

[Intel-gfx] [PATCH] drm/i915: Disable SAMPLER_STATE prefetching on all Gen11 steppings.

2019-06-24 Thread Kenneth Graunke
The Demand Prefetch workaround (binding table prefetching) only applies to Icelake A0/B0. But the Sampler Prefetch workaround needs to be applied to all Gen11 steppings, according to a programming note in the SARCHKMD documentation. Using the Intel Gallium driver, I have seen intermittent failure

Re: [Intel-gfx] [PATCH] drm/i915/perf: fix ICL perf register offsets

2019-06-10 Thread Kenneth Graunke
>perf.oa.ctx_oactxctrl_offset = 0x124; > + dev_priv->perf.oa.ctx_flexeu0_offset = 0x78e; > + } > dev_priv->perf.oa.gen8_valid_ctx_bit = (1<<16); > } > } > Sounds believable. Ac

Re: [Intel-gfx] [PATCH] drm/i915/perf: fix whitelist on Gen10+

2019-06-03 Thread Kenneth Graunke
dwerlin > --- > drivers/gpu/drm/i915/i915_perf.c | 1 + > drivers/gpu/drm/i915/i915_reg.h | 1 + > 2 files changed, 2 insertions(+) Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Enable render context support for gen4 (Broadwater to Cantiga)

2019-04-19 Thread Kenneth Graunke
TANT_BUFFER from the context image, thereby completely avoiding > the GPU hangs from chasing invalid pointers. This appears to be the > default behaviour for gen5, and so we just need to tweak gen4 to match. > > Signed-off-by: Chris Wilson > Cc: Ville Syrjälä > Cc: Kenneth Graunk

Re: [Intel-gfx] [PATCH 2/3] iris: Create a composite context for both compute and render pipelines

2019-03-26 Thread Kenneth Graunke
On Tuesday, March 26, 2019 12:16:20 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2019-03-26 05:52:10) > > On Monday, March 25, 2019 3:58:59 AM PDT Chris Wilson wrote: > > > iris currently uses two distinct GEM contexts to have distinct logical > > > HW contexts

Re: [Intel-gfx] [PATCH 2/3] iris: Create a composite context for both compute and render pipelines

2019-03-25 Thread Kenneth Graunke
be > constructed as the user desires. > > Cc: Joonas Lahtinen > Cc: Kenneth Graunke > --- > src/gallium/drivers/iris/iris_batch.c | 16 ++- > src/gallium/drivers/iris/iris_batch.h | 5 +-- > src/gallium/drivers/iris/iris_context.c | 56 - > 3

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Enable render context support for gen4 (Broadwater to Cantiga)

2019-01-09 Thread Kenneth Graunke
On Tuesday, January 8, 2019 5:02:59 PM PST Chris Wilson wrote: > Quoting Chris Wilson (2019-01-08 12:28:18) > > Broadwater and the rest of gen4 do support being able to saving and > > reloading context specific registers between contexts, providing isolation > > of the basic GPU state (as programm

Re: [Intel-gfx] [PATCH] drm/i915/icl: Apply WaEnablePreemptionGranularityControlByUMD

2019-01-08 Thread Kenneth Graunke
On Tuesday, January 8, 2019 7:53:05 AM PST Joonas Lahtinen wrote: > + Ken/Jason for Mesa > Quoting Matt Roper (2019-01-07 21:19:31) > > On Mon, Jan 07, 2019 at 01:23:50PM +0100, Michał Winiarski wrote: > > > On Mon, Jan 07, 2019 at 01:01:16PM +0200, Joonas Lahtinen wrote: > > > > Quoting José Rober

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove partial attempt to swizzle on pread/pwrite

2018-11-16 Thread Kenneth Graunke
it17 and 9xx hardware are before my time. :( I've copied Ian in case he remembers anything from that era. It looks like the only users of pwrite and pread in Mesa's i915 driver are for linear buffer objects, not miptrees which could be tiled. So I think this is fine...(famous las

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere

2018-07-17 Thread Kenneth Graunke
> Cc: Joonas Lahtinen > Cc: Mika Kuoppala > Cc: Matthew Auld > Reviewed-by: Joonas Lahtinen > Cc: Jason Ekstrand > Cc: Kenneth Graunke > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --gi

Re: [Intel-gfx] [PATCH] drm/i915: Enable provoking vertex fix on Gen9 systems.

2018-06-15 Thread Kenneth Graunke
On Friday, June 15, 2018 12:06:05 PM PDT Chris Wilson wrote: > From: Kenneth Graunke > > The SF and clipper units mishandle the provoking vertex in some cases, > which can cause misrendering with shaders that use flat shaded inputs. > > There are chicken bits in 3D_CHI

[Intel-gfx] [PATCH] drm/i915: Enable provoking vertex fix on Gen9+ systems.

2018-06-14 Thread Kenneth Graunke
The SF and clipper units mishandle the provoking vertex in some cases, which can cause misrendering with shaders that use flat shaded inputs. There are chicken bits in 3D_CHICKEN3 (for SF) and FF_SLICE_CHICKEN (for the clipper) that work around the issue. These registers are unfortunately not par

Re: [Intel-gfx] [Mesa-dev] [PATCH] intel: Future-proof ring names for aubinator_error_decode

2018-01-18 Thread Kenneth Graunke
ko > Cc: Tvrtko Ursulin > Cc: Lionel Landwerlin Thanks Chris! Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-05 Thread Kenneth Graunke
t (it doesn't have a name). Signed-off-by: Kenneth Graunke Acked-by: Rodrigo Vivi Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/i915_reg.h| 2 ++ drivers/gpu/drm/i915/intel_engine_cs.c | 5 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Kenneth Graunke
On Thursday, January 4, 2018 4:41:35 PM PST Rodrigo Vivi wrote: > On Thu, Jan 04, 2018 at 11:39:23PM +0000, Kenneth Graunke wrote: > > On Thursday, January 4, 2018 1:23:06 PM PST Chris Wilson wrote: > > > Quoting Kenneth Graunke (2018-01-04 19:38:05) > > > > Gemini

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Kenneth Graunke
On Thursday, January 4, 2018 1:23:06 PM PST Chris Wilson wrote: > Quoting Kenneth Graunke (2018-01-04 19:38:05) > > Geminilake requires the 3D driver to select whether barriers are > > intended for compute shaders, or tessellation control shaders, by > > whacking a

[Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Kenneth Graunke
this means it needs to switch mid-batch, so only userspace can properly set it. To facilitate this, the kernel needs to whitelist the register. Signed-off-by: Kenneth Graunke Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/i915_reg.h| 2 ++ drivers/gpu/drm/i915/intel_engine_cs.c |

Re: [Intel-gfx] [PATCH] i965: Always try to create a logical context

2017-11-20 Thread Kenneth Graunke
state uploads for the older platforms. > > Cc: Jason Ekstrand > Cc: Kenneth Graunke Nice, I saw Ironlake RC6 go by and was wondering if contexts were up next :) It makes sense to use them if the kernel supports them. Reviewed-by: Kenneth Graunke signature.asc Description: Thi

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-25 Thread Kenneth Graunke
On Wednesday, October 25, 2017 7:33:41 AM PDT Jason Ekstrand wrote: > On October 25, 2017 06:05:16 Joonas Lahtinen wrote: [snip] > > There indeed seems to be quite a lot of missing registers from the i915 > > driver where the context is initialized. (Psst. You can read that as: > > "all the 33 non-

Re: [Intel-gfx] [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-23 Thread Kenneth Graunke
On Monday, October 23, 2017 3:53:15 PM PDT Rodrigo Vivi wrote: > On Mon, Oct 23, 2017 at 10:32:43PM +, Jordan Justen wrote: > > On 2017-10-19 16:30:44, Kristian Høgsberg wrote: > > > On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke > > > wrote: > > > >

Re: [Intel-gfx] [PATCH i-g-t v2] intel_aubdump: Default to 48-bit AUBs when the gen is unknown

2017-10-10 Thread Kenneth Graunke
On Tuesday, October 10, 2017 4:05:17 PM PDT Jordan Justen wrote: > v2: > * Use 48-bit rather than 64-bit (Ken) > * Use 'addr_bits' rather than 'use_64bit' > > Signed-off-by: Jordan Justen Reviewed-by: Kenneth Graunke and pushed. signature.asc Desc

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES

2017-10-10 Thread Kenneth Graunke
c.c | 9 + > drivers/gpu/drm/i915/intel_pm.c | 6 -- > 7 files changed, 23 insertions(+), 24 deletions(-) Series is: Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. __

Re: [Intel-gfx] [PATCH] intel_aubdump: Default to 64-bit AUBs when the gen is unknown

2017-10-09 Thread Kenneth Graunke
to clarify that this isn't about 32-bit or 64-bit OSes. Either way, Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] New #intel-3d IRC channel on Freenode

2017-08-23 Thread Kenneth Graunke
Hello, The Intel Mesa team would like to welcome you to a new public IRC channel on Freenode: #intel-3d. The topic is Mesa development for Intel GPUs, in particular the "i965" OpenGL and "anv" Vulkan drivers. The open source graphics community has grown a lot over the last few years, and as a re

Re: [Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

2017-08-01 Thread Kenneth Graunke
On Tuesday, August 1, 2017 3:47:53 PM PDT Ben Widawsky wrote: > On 17-08-01 15:43:50, Kenneth Graunke wrote: > >On Tuesday, August 1, 2017 9:58:17 AM PDT Ben Widawsky wrote: > >> v2: > >> - Support sprite plane. > >> - Support pipe C/D limitation on

Re: [Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

2017-08-01 Thread Kenneth Graunke
> + if (modifier == I915_FORMAT_MOD_Y_TILED_CCS || > + modifier == I915_FORMAT_MOD_Yf_TILED_CCS) > + return true; > case DRM_FORMAT_RGB565: > case DRM_FORMAT_XRGB2101010: > case DRM_FORMAT_XBGR2101010: > @@ -1230,7

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Allow execbuffer to use the first object as the batch

2017-07-07 Thread Kenneth Graunke
On Friday, July 7, 2017 3:17:22 AM PDT Daniel Vetter wrote: > On Fri, Mar 17, 2017 at 12:15 PM, Joonas Lahtinen > wrote: > > On to, 2017-03-16 at 13:20 +, Chris Wilson wrote: > >> Currently, the last object in the execlist is the always the batch. > >> However, when building the batch buffer w

Re: [Intel-gfx] [PATCH] drm/i915: Update MOCS settings for gen 9

2017-05-05 Thread Kenneth Graunke
On Friday, May 5, 2017 9:21:54 AM PDT Dmitry Rogozhkin wrote: > > My point largely stands, when redirected - someone is developing a > > broken closed source userspace driver and is apparently unwilling to > > change it. That's the real problem. > Broken? Have you ever attempted to run functional

Re: [Intel-gfx] [PATCH] drm/i915: Update MOCS settings for gen 9

2017-05-05 Thread Kenneth Graunke
On Thursday, May 4, 2017 7:46:34 PM PDT Dmitry Rogozhkin wrote: > > On 5/4/2017 9:51 AM, Kenneth Graunke wrote: > > MediaSDK is not a benchmark. If I'm not mistaken, it's a userspace > > driver produced by Intel engineers, one which Intel has the full > >

Re: [Intel-gfx] [PATCH] drm/i915: Update MOCS settings for gen 9

2017-05-04 Thread Kenneth Graunke
On Thursday, May 4, 2017 7:47:21 AM PDT David Weinehall wrote: > On Thu, May 04, 2017 at 10:35:33AM +0200, Arkadiusz Hiler wrote: > > Thanks for rephrasing - that's exactly what I am concerned with. > > > > Did you just use the MediaSDK as it is - meaning that MOCS entries > > beyond the set of th

Re: [Intel-gfx] [Mesa-dev] [RFC 1/2] drm/i915: Engine discovery uAPI

2017-04-18 Thread Kenneth Graunke
On Tuesday, April 18, 2017 9:56:14 AM PDT Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Engine discovery uAPI allows userspace to probe for engine > configuration and features without needing to maintain the > internal PCI id based database. I don't understand why I would want to query the ex

Re: [Intel-gfx] [libdrm PATCH] intel: Make unsynchronized GTT mappings work on systems with snooping.

2017-03-12 Thread Kenneth Graunke
On Sunday, March 12, 2017 6:21:12 AM PDT Chris Wilson wrote: > On Fri, Mar 10, 2017 at 05:14:32PM -0800, Kenneth Graunke wrote: > > On systems without LLC, drm_intel_gem_bo_map_unsynchronized() has > > had the surprising behavior of doing a synchronized GTT mapping. > > This

[Intel-gfx] [libdrm PATCH] intel: Make unsynchronized GTT mappings work on systems with snooping.

2017-03-10 Thread Kenneth Graunke
ch enables unsynchronized mappings for reusable buffers on all Gen6+ hardware (which have either LLC or snooping). On Broxton, this improves the performance of Unigine Valley 1.0 on Low settings at 1280x720 by about 45%, and Unigine Heaven 4.0 (same settings) by about 53%. Signed-off-by: Kenneth Graunke

[Intel-gfx] [PATCH] drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters.

2017-02-15 Thread Kenneth Graunke
#x27;t think anyone wants this on Gen4-5. Based on a patch by Dave Gordon. v3: Return -ENODEV for the getparam, as this is what we do for other obsolete features. Suggested by Chris Wilson. Cc: sta...@vger.kernel.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92448 Signed-off-by

Re: [Intel-gfx] [PATCH v2] drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters.

2017-02-15 Thread Kenneth Graunke
On Wednesday, February 15, 2017 12:12:50 AM PST Chris Wilson wrote: > On Tue, Feb 14, 2017 at 08:17:51PM -0800, Kenneth Graunke wrote: > > This patch makes the I915_PARAM_HAS_EXEC_CONSTANTS getparam return 0 > > (indicating the optional feature is not supported), and makes exe

[Intel-gfx] [PATCH v2] drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters.

2017-02-14 Thread Kenneth Graunke
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92448 Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915/i915_drv.c| 2 +- drivers/gpu/drm/i915/i915_drv.h| 2 -- drivers/gpu/drm/i915/i915_gem.c| 2 -- drivers/gpu/drm/i915/i915_gem_ex

[Intel-gfx] [PATCH] drm/i915: Drop support for I915_EXEC_CONSTANTS_* execbuf parameters.

2017-02-14 Thread Kenneth Graunke
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92448 Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915/i915_drv.c| 2 +- drivers/gpu/drm/i915/i915_drv.h| 2 -- drivers/gpu/drm/i915/i915_gem.c| 2 -- drivers/gpu/drm/i915/i915_gem_ex

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915/perf: Improve handling of OA tail race

2017-02-12 Thread Kenneth Graunke
On Friday, January 27, 2017 9:42:00 AM PST Robert Bragg wrote: > Folds in Matthew Auld's feedback; thanks. > > Robert Bragg (5): > drm/i915/perf: fix gen7_append_oa_reports comment > drm/i915/perf: avoid poll, read, EAGAIN busy loops > drm/i915/perf: avoid read back of head register > drm/

[Intel-gfx] [PATCH] aubdump: Fix intel_aubdump -o

2016-11-23 Thread Kenneth Graunke
This looks like a mistake in 1f43677f895a88ae880b35f9b18cc7e6869d0ca6. --- tools/intel_aubdump.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This code still looks really weird. ${foo:bar} means "the value of $foo, unless it's unset/empty, in which case 'bar'. But if $file is empty...

Re: [Intel-gfx] [PATCH] i965: Embrace "unlimited" GTT mmap support

2016-08-25 Thread Kenneth Graunke
t within the mappable aperture. > > Signed-off-by: Chris Wilson > Cc: Kenneth Graunke Cool! I didn't realize we could do page faulting here, since it's CPU-related. It's definitely nice to be able to map an unlimited amount of space, at least as a fallback, even if other met

Re: [Intel-gfx] [PATCH igt v3] igt/gem_exec_parse: Simple exercise for MI_LOAD_REGISTER_REG

2016-05-09 Thread Kenneth Graunke
; > Signed-off-by: Chris Wilson Much more thorough than my test. Thanks :) Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.fr

Re: [Intel-gfx] [PATCH v2] drm/i915: Allow MI_LOAD_REGISTER_REG between whitelisted registers.

2016-05-07 Thread Kenneth Graunke
On Friday, May 6, 2016 8:50:14 AM PDT Chris Wilson wrote: > From: Kenneth Graunke > > Allowing register copies where the source and destination are both > whitelisted should be safe, and is useful. For example, Mesa uses > this to load the command streamer math registers wit

[Intel-gfx] [PATCH] igt/gem_exec_parse: Add a MI_LOAD_REGISTER_REG test.

2016-05-05 Thread Kenneth Graunke
This stores a known value to a register, copies it using MI_LOAD_REGISTER_REG, then stores from the second register back to memory, and verifies the value. This ensures that MI_LOAD_REGISTER_REG is allowed by the command parser, and actually takes effect. Cc: Chris Wilson Signed-off-by: Kenneth

[Intel-gfx] [PATCH] drm/i915: Allow MI_LOAD_REGISTER_REG between whitelisted registers.

2016-05-05 Thread Kenneth Graunke
Allowing register copies where the source and destination are both whitelisted should be safe, and is useful. For example, Mesa uses this to load the command streamer math registers with data from the pipeline statistics counters. Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] Revert "i965: Always use Y-tiled buffers on SKL+"

2016-05-02 Thread Kenneth Graunke
On Monday, May 2, 2016 3:40:14 PM PDT Daniel Stone wrote: > This commit broke Weston/KMS, and presumably also xf86-video-modesetting. For me, xf86-video-modesetting, and xf86-video-intel/SNA+DRI3 both work fine with Y-tiling enabled. However, it does break UXA+DRI3. I'm curious why xf86-video-mo

Re: [Intel-gfx] [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

2016-05-01 Thread Kenneth Graunke
On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > On 28 April 2016 at 19:13, Eric Engestrom wrote: > > On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: > >> On 21 April 2016 at 11:24, Eric Engestrom wrote: > >> > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all

Re: [Intel-gfx] RFC: libdrm: Support Iris Graphics 540 & 550 (Skylake GT3e)

2016-04-27 Thread Kenneth Graunke
On Wednesday, April 27, 2016 9:37:07 AM PDT Thorsten Leemhuis wrote: > Thorsten Leemhuis wrote on 26.04.2016 13:41: > > Lo! Below patch adds the PCI-ID for the Intel(R) Iris Graphics 550 (Skylake > > GT3e mobile) to libdrm. It afaics is the last piece that is missing to > > make those GPUs work pr

Re: [Intel-gfx] [PATCH] drm/i915: Allow fuzzy matching in intel_compare_link_m_n

2016-01-06 Thread Kenneth Graunke
e m > values. > > Signed-off-by: Maarten Lankhorst > Tested-by: Tested-by: Kenneth Graunke > -- > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/ intel_display.c > index 7afbdc45a278..aa4f1e69b92e 100644 > --- a/drivers/gpu/drm/i915/intel_di

Re: [Intel-gfx] [PATCH libdrm] intel: Restore formatting of offsets in debug statements

2015-12-22 Thread Kenneth Graunke
gt; > intel: Add support for softpin > > Let's restore previous, more readable format. > > Cc: Kristian Høgsberg Kristensen > Signed-off-by: Michał Winiarski > --- > intel/intel_bufmgr_gem.c | 23 ++- > 1 file changed, 14 insertion

Re: [Intel-gfx] [PATCH] drm/i915: Fix IPS related flicker

2015-05-28 Thread Kenneth Graunke
OSTING_READ(reg); This fixes a bug on my Lenovo X250 (Broadwell GT2). 1. Boot 2. startx using SNA and KDE 5 3. Quit X Prior to this patch, the screen was all scrambled. With this patch, it works perfectly. Thanks, Rodrigo! Tested-by: Kenneth Graunke signature.asc Descr

Re: [Intel-gfx] [Mesa-dev] [PATCH 1/2] i965: Make intel_emit_linear_blit handle Gen8+ alignment restrictions.

2015-05-06 Thread Kenneth Graunke
On Wednesday, May 06, 2015 08:25:28 PM Mika Kuoppala wrote: > Chris Wilson writes: > > > On Wed, May 06, 2015 at 03:38:44PM +0200, Daniel Vetter wrote: > >> On Tue, Apr 21, 2015 at 10:13:31PM -0700, Kenneth Graunke wrote: > >> > The BLT engine on Gen8+ require

Re: [Intel-gfx] [Mesa-dev] [PATCH 1/4] i965: Transplant PIPE_CONTROL routines to brw_pipe_control

2015-05-01 Thread Kenneth Graunke
G BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT

[Intel-gfx] [PATCH v2 3/3] drm/i915: Ensure the HiZ RAW Stall Optimization is on for Cherryview.

2015-01-13 Thread Kenneth Graunke
ormance in OglVSInstancing by about 2.7x on Braswell. Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915/intel_ringbuffer.c | 5 + 1 file changed, 5 insertions(+) Split, as requested by Ben. diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c ind

[Intel-gfx] [PATCH v2 1/3] drm/i915: Improve HiZ throughput on Cherryview.

2015-01-13 Thread Kenneth Graunke
Found by reading the HIZ_CHICKEN documentation. Improves performance in a HiZ microbenchmark by around 50%. Improves performance in OglZBuffer by around 18%. Thanks to Chris Wilson for helping me figure out where to put this. Signed-off-by: Kenneth Graunke Reviewed-by: Ville Syrjälä

[Intel-gfx] [PATCH v2 2/3] drm/i915: Enable the HiZ RAW Stall Optimization on Broadwell.

2015-01-13 Thread Kenneth Graunke
ormance in OglVSInstancing by 3.2x on Broadwell GT3e (Iris Pro 6200). Thanks to Jesse Barnes and Ben Widawsky for their help in tracking this down. Thanks to Chris Wilson for showing me the new workarounds system. Signed-off-by: Kenneth Graunke Cc: Jesse Barnes --- drivers/gpu/drm/i915/intel_ringbuf

Re: [Intel-gfx] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-12 Thread Kenneth Graunke
On Monday, January 12, 2015 02:32:20 PM Ville Syrjälä wrote: > On Sat, Jan 10, 2015 at 06:44:49PM -0800, Kenneth Graunke wrote: > > This is an important optimization for avoiding read-after-write (RAW) > > stalls in the HiZ buffer. Certain workloads would run very slowly with >

Re: [Intel-gfx] [Mesa-dev] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-11 Thread Kenneth Graunke
On Sunday, January 11, 2015 05:46:09 PM Ben Widawsky wrote: > On Sun, Jan 11, 2015 at 04:05:25PM -0800, Kenneth Graunke wrote: > > On Sunday, January 11, 2015 01:49:41 PM Ben Widawsky wrote: > > > On Sat, Jan 10, 2015 at 06:44:49PM -0800, Kenneth Graunke wrote: > >

Re: [Intel-gfx] [Mesa-dev] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-11 Thread Kenneth Graunke
On Sunday, January 11, 2015 05:46:09 PM Ben Widawsky wrote: > On Sun, Jan 11, 2015 at 04:05:25PM -0800, Kenneth Graunke wrote: > > On Sunday, January 11, 2015 01:49:41 PM Ben Widawsky wrote: > > > On Sat, Jan 10, 2015 at 06:44:49PM -0800, Kenneth Graunke wrote: > >

Re: [Intel-gfx] [Mesa-dev] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-11 Thread Kenneth Graunke
On Sunday, January 11, 2015 01:49:41 PM Ben Widawsky wrote: > On Sat, Jan 10, 2015 at 06:44:49PM -0800, Kenneth Graunke wrote: > > This is an important optimization for avoiding read-after-write (RAW) > > stalls in the HiZ buffer. Certain workloads would run very slowly with >

[Intel-gfx] [PATCH] drm/i915: Enable the HiZ RAW Stall Optimization on Gen8.

2015-01-11 Thread Kenneth Graunke
ormance in OglVSInstancing by 3.2x on Broadwell GT3e (Iris Pro 6200). Thanks to Jesse Barnes for finding this missing bit! Thanks to Chris Wilson for helping me find where to set it. Signed-off-by: Kenneth Graunke Cc: Jesse Barnes --- drivers/gpu/drm/i915/intel_ringbuffer.c | 15 +++ 1 fi

[Intel-gfx] [PATCH] drm/i915: Improve HiZ throughput on Cherryview.

2015-01-11 Thread Kenneth Graunke
Found by reading the HIZ_CHICKEN documentation. Improves performance in a HiZ microbenchmark by around 50%. Improves performance in OglZBuffer by around 18%. Thanks to Chris Wilson for helping me figure out where to put this. Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Kenneth Graunke
On Tuesday, January 06, 2015 02:39:36 PM Xiang, Haihao wrote: > On Mon, 2015-01-05 at 21:54 -0800, Kenneth Graunke wrote: > > On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote: > > > > > > Hi Kenneth, > > > > > > How did you test OSD ? I

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Kenneth Graunke
On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote: > > Hi Kenneth, > > How did you test OSD ? I can't reproduce the issue you mentioned, OSD > works well for me when using mplayer-vaapi with the latest > libva/libva-intel-driver master branch. > > I tried your patch, what surprised me

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Kenneth Graunke
On Monday, January 05, 2015 02:19:15 PM Daniel Vetter wrote: > On Wed, Dec 31, 2014 at 04:23:00PM -0800, Kenneth Graunke wrote: > > Haswell significantly improved the performance of sampler_c messages, > > but the optimization appears to be off by default. Later platforms > >

[Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-12-31 Thread Kenneth Graunke
appears to have been broken for at least a year, so I couldn't observe a regression from this. Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions(+) Resubmitting the patch to unconditionally enab

Re: [Intel-gfx] [PATCH] drm/i915: Add the predicate source registers to the register whitelist

2014-11-07 Thread Kenneth Graunke
fine MI_PREDICATE_SRC0 (0x2400) > +#define MI_PREDICATE_SRC1(0x2408) > > #define MI_PREDICATE_RESULT_2(0x2214) > #define LOWER_SLICE_ENABLED (1<<0) > Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Kenneth Graunke
On Thursday, October 30, 2014 09:26:01 PM Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 10:32:38AM -0700, Kenneth Graunke wrote: > > On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: > > > On Thu, Oct 30, 2014 at 02:32:40AM -0700, Kenneth Graunke wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Kenneth Graunke
On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 02:32:40AM -0700, Kenneth Graunke wrote: > > On Thursday, October 30, 2014 11:00:51 AM Ville Syrjälä wrote: > > > On Thu, Oct 30, 2014 at 10:50:03AM +0200, Ville Syrjälä wrote: > > >

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Kenneth Graunke
On Thursday, October 30, 2014 11:00:51 AM Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 10:50:03AM +0200, Ville Syrjälä wrote: > > On Wed, Oct 29, 2014 at 03:12:43PM -0700, Kenneth Graunke wrote: > > > Haswell significantly improved the performance of sampler_c messa

[Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-29 Thread Kenneth Graunke
gs on Iris Pro. No Piglit regressions. Signed-off-by: Kenneth Graunke --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 77fce96..340821a 10

Re: [Intel-gfx] [PATCH] drm/i915: Reinstate error level message for non-simulated gpu hangs

2014-10-01 Thread Kenneth Graunke
On Wednesday, October 01, 2014 10:29:07 AM Daniel Vetter wrote: > On Wed, Oct 01, 2014 at 09:19:50AM +0100, Chris Wilson wrote: > > On Wed, Oct 01, 2014 at 10:13:00AM +0200, Daniel Vetter wrote: > > > On Wed, Oct 01, 2014 at 07:28:39AM +0100, Chris Wilson wrote: > > > > On Wed, Oct 01, 2014 at 01:0

Re: [Intel-gfx] [PATCH 0/2 xf86-video-intel] Two DRI3/Present bug fixes for UXA

2014-09-12 Thread Kenneth Graunke
fx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx Both are: Tested-by: Kenneth Graunke I tested them using DRI3/Present + UXA and DRI3/Present + Glamor on Haswell GT3e. 1. Plug external 2560x1440 DisplayPort monitor into laptop. 2. echo 'exec startkde' >

Re: [Intel-gfx] [PATCH 00/68] Broadwell 48b addressing and prelocations (no relocs)

2014-08-21 Thread Kenneth Graunke
On Friday, August 22, 2014 07:30:37 AM Chris Wilson wrote: > On Thu, Aug 21, 2014 at 08:11:23PM -0700, Ben Widawsky wrote: > > The primary goal of these patches is to introduce what I've started > > calling, "prelocations" on Broadwell. A prelocation is like a > > relocation, except not. When a GPU

[Intel-gfx] [PATCH] rendercopy/gen8: Also emit 3DSTATE_WM_DEPTH_STENCIL.

2014-06-03 Thread Kenneth Graunke
/show_bug.cgi?id=78891 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78935 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78936 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78937 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78938 Signed-off-by: Kenneth Graunke Cc

Re: [Intel-gfx] [Mesa-dev] How user space applications load registers on HSW?

2014-05-12 Thread Kenneth Graunke
On 05/12/2014 01:02 AM, Yang, Rong R wrote: > Hi, Ken, > > Thanks for your patch. But how do you release your driver on the HSW > products? If can't LRI/LRM from userspace batches, almost all of > OpenCL application can't run. So if I want to announce that the > OpenCL driver support HSW, it must

Re: [Intel-gfx] [Mesa-dev] [rong.r.y...@intel.com: How user space applications load registers on HSW?]

2014-05-06 Thread Kenneth Graunke
On 05/06/2014 08:26:15 AM, Yang, Rong R wrote: > Hi, > > I am developing the HSW’s OCL driver in the linux. I encounter a LRI > problem on HSW. > > > Some gpgpu's applications, which use the shared local memory, must load > the L3CTRLREG2 and L3CTRLREG3 registers to allocate the SLM in the L3 >

  1   2   3   >