ing QUIRK_NO_PCH_PWM_ENABLE for a couple of Dell XPS models which
> broke in 3.14.
Confirmed: This patch (restore QUIRK_NO_PCH_PWM_ENABLE) on top of 3.14.2
does fix it again for the two affected models.
Tested-by: Kamal Mostafa
Thanks, Jani!
-Kamal
> There is no such revert upstream.
s that had needed the NO_PCH_PWM_ENABLE
quirk.
Tested-by: Kamal Mostafa
Thanks Jani!
-Kamal
> AFAICT the quirk removed by the above commit effectively resulted in
> i915 not driving the backlight PWM output, thus not messing things up.
>
> Bugzilla: https://bugs.freedesktop.org/show_
On Wed, 2013-09-11 at 11:21 +0300, Jani Nikula wrote:
> On Wed, 11 Sep 2013, Rodrigo Vivi wrote:
> > From: Kamal Mostafa
> >
> > Boot params quirks_set and quirks_mask allow the user to enable or
> > inhibit any dmi-matched quirks, overriding the dmi match table
QUIRK_NO_PCH_PWM_ENABLE
i915.quirks_mask=0xFF - disables all quirks
Signed-off-by: Kamal Mostafa
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/i915/intel_display.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915
On Tue, 2013-09-03 at 19:50 +0200, Daniel Vetter wrote:
> On Tue, Sep 3, 2013 at 7:37 PM, Kamal Mostafa wrote:
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=47941
> >
> > Some BIOS configurations of Dell XPS13 are adversely affected by e85843b
> > ("d
set to
-1: auto (default; allows the disabling of pch_pwm by dmi quirk table match)
0: inhibits the disabling of pch_pwm (overrides dmi quirk table match)
1: forces the disabling of pch_pwm
Signed-off-by: Kamal Mostafa
---
drivers/gpu/drm/i915/i915_drv.c | 4
drivers/gpu/drm/i915/
On Thu, 2013-07-25 at 16:46 +0200, Daniel Vetter wrote:
> On Thu, Jul 25, 2013 at 07:43:17AM -0700, Kamal Mostafa wrote:
> > On Thu, 2013-07-25 at 15:00 +0200, Rafael J. Wysocki wrote:
> > > On Monday, July 22, 2013 09:54:21 PM Rafael J. Wysocki wrote:
> > > > On Mon
n
> acpi_video_backlight_quirks() introduced by it, because another
> commit on top of it uses that function.
>
> References: https://lkml.org/lkml/2013/7/21/119
> References: https://lkml.org/lkml/2013/7/22/261
> References: https://lkml.org/lkml/2013/7/23/429
> References: http
quirk to Dell XPS 13 models.
Tested-by: Eric Griffith
Tested-by: Kent Baxley
Cc: # v3.8+
Signed-off-by: Kamal Mostafa
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/intel_display.c | 16
drivers/gpu/drm/i915/intel_panel.c | 3 ++-
3 files changed, 19
On Fri, Feb 8, 2013 at 8:36 PM, Kamal Mostafa wrote:
> > Daniel's backlight fixes which landed in 3.6 did enable working
> > backlight controls on the XPS13, but it appears that this commit from
> > Paolo broke it again:
> > a4f32fc drm/i915: don't forg
Hi Daniel-
Reminding you of this issue... I've sent the register dump you asked
for... You said you had an idea?
Thanks very much for looking into it,
-Kamal
On Fri, 2012-04-27 at 14:55 -0700, Kamal Mostafa wrote:
> On Fri, 2012-04-27 at 23:25 +0200, Daniel Vetter wrote:
> &g
consider applying this patch 1/2.
Thanks,
-Kamal
[0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/954661/comments/27
On Thu, 2012-04-26 at 22:07 +0200, Daniel Vetter wrote:
> On Wed, Apr 25, 2012 at 10:28:41AM -0700, Kamal Mostafa wrote:
> > i915.enable_backlight=0 can be used t
On Fri, 2012-04-27 at 23:25 +0200, Daniel Vetter wrote:
> Hm. Can you please install intel-gpu-tools and attach the output of
> intel_reg_dumper? I have an idea ...
Here it is with intel_backlight/brightness set to 1 ("strobe light"
behavior occurring):
PGETBL_CTL: 0x
be (quite) happy to test a proper intel_backlight fix, but in the
meantime disabling it by quirk seems appropriate for this machine, since
that allows the acpi_video0 interface to work out of the box.
Thanks for considering it,
-Kamal
On Wed, 2012-04-25 at 10:28 -0700, Kamal Mostafa wrote:
&g
On Thu, 2012-04-26 at 22:07 +0200, Daniel Vetter wrote:
> On Wed, Apr 25, 2012 at 10:28:41AM -0700, Kamal Mostafa wrote:
> > i915.enable_backlight=0 can be used to disable i915 backlight control
> > and the /sys/class/backlight/intel_backlight interface -- useful for
&g
From: Robert Hooker
Dell XPS 13z exhibits problems (backlight flashing/pulsating) when
intel_backlight is enabled at all, so disable it.
BugLink: https://launchpad.net/bugs/954661
Signed-off-by: Robert Hooker
Signed-off-by: Kamal Mostafa
---
drivers/gpu/drm/i915/intel_display.c | 17
i915.enable_backlight=0 can be used to disable i915 backlight control
and the /sys/class/backlight/intel_backlight interface -- useful for
systems where intel_backight conflicts with BIOS backlight control.
BugLink: https://launchpad.net/bugs/954661
Signed-off-by: Kamal Mostafa
---
drivers/gpu
dy committed fix[0]) does
indeed fix the problem[1] for me. Thanks!
Tested-by: Kamal Mostafa
-Kamal
[0] f52c619a590fa75276c07dfcaf380dee53e4ea4c
drm/i915/panel: Always record the backlight level again (but cleverly)
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/872652
&g
to restore the brightness.
> intel_panel_disable_backlight merely sets the brightness to 0. Commenting
> out this call allows the correct brightness value to be saved.
>
> Signed-off-by: Alex Davis
> Tested-by: Kamal Mostafa
> -
> diff --git a/drivers/gpu/drm/i915/int
Link: http://bugs.launchpad.net/bugs/831542
Signed-off-by: Kamal Mostafa
---
drivers/gpu/drm/i915/intel_display.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index ee1d701..5a1ae9f 100644
--- a/drivers/gp
e2c268c7b06ec9a544a2b647 Mon Sep 17 00:00:00 2001
>
> I'll merge this version, with the change to make
> intel_panel_init_backlight static (it's not declared in a header, and
> isn't used outside of intel_panel.c).
That version works also works fine for me.
Tested-by:
ll Studio 1558). My thanks to
you and Matthew!
Tested-by: Kamal Mostafa
-Kamal
> From 2c17b1ae587289501029daa5c0692818b88d21a6 Mon Sep 17 00:00:00 2001
> From: Matthew Garrett
> Date: Fri, 14 Jan 2011 14:24:22 -0500
> Subject: [PATCH] i915: Add native backlight control
>
> N
Several months ago, Matthew Garrett submitted a set of backlight
patches[1], all but one of which landed in 2.6.39-rc1. The one that
never did get merged is the bit that exposes the "intel_backlight"
interface:
[PATCH 2/5] i915: Add native backlight control
http://lists.freedeskto
ch Matthew!
FYI, I have published an experimental Ubuntu Maverick PPA kernel[2]
which includes your patches, plus my dell_laptop tweaks to inhibit the
broken dell_backlight by a module param or dmi blacklist table (in lieu
of a yet to be implemented more fine-grained check).
-Kamal Mostafa
[
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/568611
Override acpi brightness control with i915-opregion method.
Signed-off-by: Kamal Mostafa
---
drivers/gpu/drm/i915/i915_opregion.c | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/568611
New acpi_brightness_hook_register lets another driver (e.g. i915) override
the often-dysfunctional native acpi brightness control methods.
Signed-off-by: Kamal Mostafa
---
drivers/acpi/video.c | 149
Requesting comments on this idea (proposed by Matthew Garrett) and my
implementation. Note especially the KNOWN PROBLEM with a "GM45" GPU.
-Kamal
...
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/568611
In order to avoid the often-dysfunctional native acpi brightness contr
27 matches
Mail list logo
