[Intel-gfx] [PATCH] bitops: Always inline sign extension helpers

linux. Reported-by: Randy Dunlap Signed-off-by: Josh Poimboeuf --- include/linux/bitops.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/bitops.h b/include/linux/bitops.h index 47f54b459c26..9acf654f0b19 100644 --- a/include/linux/bitops.h +++ b/include/

Re: [Intel-gfx] [PATCH] drm/i915: Minimize uaccess exposure in i915_gem_execbuffer2_ioctl()

On Thu, Feb 27, 2020 at 10:26:00PM +, Chris Wilson wrote: > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > @@ -2947,6 +2947,13 @@ i915_gem_execbuffer2_ioctl(struct drm_device *dev, > > void *data, > >

Re: [Intel-gfx] [PATCH] drm/i915: Minimize uaccess exposure in i915_gem_execbuffer2_ioctl()

On Thu, Feb 27, 2020 at 10:35:42PM +, Al Viro wrote: > On Thu, Feb 27, 2020 at 04:08:26PM -0600, Josh Poimboeuf wrote: > > With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports: > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > i915_ge

[Intel-gfx] [PATCH] drm/i915: Minimize uaccess exposure in i915_gem_execbuffer2_ioctl()

unlap Signed-off-by: Josh Poimboeuf --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index d5a0f5ae4a8b..183cab13e028 1

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

; > > On Fri, 26 Jul 2019, Chris Wilson wrote: > > > > > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > > > > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > > > > > > > > > Objtool reports: > > > > > > >

[Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

;i915: fix missing user_access_end() in page fault exception case") Reported-by: Thomas Gleixner Reported-by: Sedat Dilek Acked-by: Peter Zijlstra (Intel) Tested-by: Nick Desaulniers Tested-by: Sedat Dilek Link: https://github.com/ClangBuiltLinux/linux/issues/617 Signed-off-by: Josh

Re: [Intel-gfx] [patch V3 24/29] tracing: Remove the last struct stack_trace usage

On Thu, Apr 25, 2019 at 11:45:17AM +0200, Thomas Gleixner wrote: > Simplify the stack retrieval code by using the storage array based > interface. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Steven Rostedt (VMware) > --- > kernel/trace/trace_stack.c | 37

Re: [Intel-gfx] [patch V3 00/29] stacktrace: Consolidate stack trace usage

- Removed the '-1' oddity from the tracer > > - Restricted the tracer nesting to 4 > > - Restored the lockdep magic to prevent redundant stack traces > > - Addressed the small nitpicks here and there > > - Picked up Acked/Reviewed tags Other t

Re: [Intel-gfx] [patch V3 21/29] tracing: Use percpu stack trace buffer more intelligently

On Thu, Apr 25, 2019 at 11:45:14AM +0200, Thomas Gleixner wrote: > @@ -2788,29 +2798,32 @@ static void __ftrace_trace_stack(struct >*/ > preempt_disable_notrace(); > > - use_stack = __this_cpu_inc_return(ftrace_stack_reserve); > + stackidx = __this_cpu_inc_return(ftrace_stac

Re: [Intel-gfx] [patch V2 28/29] stacktrace: Provide common infrastructure

On Fri, Apr 19, 2019 at 11:07:17AM +0200, Peter Zijlstra wrote: > On Fri, Apr 19, 2019 at 10:32:30AM +0200, Thomas Gleixner wrote: > > On Fri, 19 Apr 2019, Peter Zijlstra wrote: > > > On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote: > > > > > > > +typedef bool (*stack_trace_consume

Re: [Intel-gfx] [patch V2 28/29] stacktrace: Provide common infrastructure

On Fri, Apr 19, 2019 at 09:02:11AM +0200, Peter Zijlstra wrote: > On Thu, Apr 18, 2019 at 05:42:55PM +0200, Thomas Gleixner wrote: > > On Thu, 18 Apr 2019, Josh Poimboeuf wrote: > > > > Another idea I had (but never got a chance to work on) was to extend the > > &g

Re: [Intel-gfx] [patch V2 28/29] stacktrace: Provide common infrastructure

On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote: > All architectures which support stacktrace carry duplicated code and > do the stack storage and filtering at the architecture side. > > Provide a consolidated interface with a callback function for consuming the > stack entries pro

Re: [Intel-gfx] [patch V2 01/29] tracing: Cleanup stack trace code

On Thu, Apr 18, 2019 at 10:41:20AM +0200, Thomas Gleixner wrote: > - Remove the extra array member of stack_dump_trace[]. It's not required as > the stack tracer stores at max array size - 1 entries so there is still > an empty slot. What is the empty slot used for? -- Josh _