[PATCH] drm/i915: Increase I915_PARAM_MMAP_GTT_VERSION version to indicate support for partial mmaps

2025-03-15 Thread José Roberto de Souza
ps. Fixes: 255fc1703e42 ("drm/i915/gem: Calculate object page offset for partial memory mapping") Cc: Andi Shyti Cc: Nirmoy Das Cc: Lionel Landwerlin Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 5 - 1 file changed, 4 insertions(+), 1 delet

[PATCH] drm/i915/display: Fix lfp_vbt_mode memory leak

2024-07-31 Thread José Roberto de Souza
return; 851 852 fill_detail_timing_data(i915, panel_fixed_mode, panel_dvo_timing); 853 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c in

[PATCH] drm/i915: Do not print 'pxp init failed with 0' when it succeed

2024-03-20 Thread José Roberto de Souza
It is misleading, if the intention was to also print something in case it succeed it should have a different string. Cc: Alan Previn Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v4 3/3] drm/xe: Use intel_wakeref_t in intel_runtime_pm functions

2024-01-04 Thread José Roberto de Souza
Now intel_wakeref_t is a unsigned long and Xe KMD version of those functions should use the same type, so changing from bool to intel_wakeref_t. Cc: Maarten Lankhorst Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 10 +- 1 file changed, 5

[PATCH v4 2/3] drm/xe: Fix definition of intel_wakeref_t

2024-01-04 Thread José Roberto de Souza
play_trace.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_wa.o CC [M] drivers/gpu/drm/i915/i915_query.o Fixes: 44e694958b95 ("drm/xe/display: Implement display support") Cc: Maarten Lankhorst Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/xe/compat-i915-headers/in

[PATCH v4 1/3] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread José Roberto de Souza
://gitlab.freedesktop.org/drm/xe/kernel/-/issues/989 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1031 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1072 Cc: Animesh Manna Cc: Rodrigo Vivi Cc: Jani Nikula Cc: Francois Dugast Signed-off-by: José Roberto de Souza

[PATCH v3 2/2] drm/xe: Fix definition of intel_wakeref_t

2024-01-04 Thread José Roberto de Souza
m/i915/i915_gem_evict.o CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_trace.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_wa.o CC [M] drivers/gpu/drm/i915/i915_query.o Fixes: 44e694958b95 ("drm/xe/display: Implement display support&qu

[PATCH v3 1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread José Roberto de Souza
://gitlab.freedesktop.org/drm/xe/kernel/-/issues/989 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1031 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1072 Cc: Animesh Manna Cc: Rodrigo Vivi Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915

[PATCH v2] drm/i915: Disable DSB in Xe KMD

2024-01-03 Thread José Roberto de Souza
: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1031 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1072 Cc: Animesh Manna Cc: Rodrigo Vivi Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_device.h | 5 + 1 file changed, 5

[PATCH] drm/i915: Disable DSB in Xe KMD

2024-01-03 Thread José Roberto de Souza
/-/issues/1031 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1072 Cc: Animesh Manna Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dsb.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b

[Intel-gfx] [PATCH v2 11/15] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-25 Thread José Roberto de Souza
Nikula Cc: Maarten Lankhorst Reviewed-by: Lucas De Marchi Signed-off-by: José Roberto de Souza Link: https://patchwork.freedesktop.org/patch/msgid/20230420170558.35398-1-jose.so...@intel.com (cherry picked from commit bfa010f608491036327db20aad1d15e28da0189e) --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 11/15] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-24 Thread José Roberto de Souza
Nikula Cc: Maarten Lankhorst Reviewed-by: Lucas De Marchi Signed-off-by: José Roberto de Souza Link: https://patchwork.freedesktop.org/patch/msgid/20230420170558.35398-1-jose.so...@intel.com (cherry picked from commit bfa010f608491036327db20aad1d15e28da0189e) --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v5] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-20 Thread José Roberto de Souza
Nikula Cc: Maarten Lankhorst Reviewed-by: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_driver.c | 2 ++ drivers/gpu/drm/i915/display/intel_dkl_phy.c| 9 + drivers/gpu/drm/i915/display/intel_dkl_phy.h| 1 + drivers/gpu/drm

[Intel-gfx] [PATCH v4] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-18 Thread José Roberto de Souza
v2: - added intel_display_locks_init() v3: - rebased v4: - drop intel_display_locks_init() Cc: intel-gfx@lists.freedesktop.org Cc: intel...@lists.freedesktop.org Cc: Rodrigo Vivi Cc: Ville Syrjälä Cc: Jani Nikula Cc: Maarten Lankhorst Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i

[Intel-gfx] [PATCH v3] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-17 Thread José Roberto de Souza
v2: - added intel_display_locks_init() v3: - rebased Cc: intel-gfx@lists.freedesktop.org Cc: intel...@lists.freedesktop.org Cc: Rodrigo Vivi Cc: Ville Syrjälä Cc: Jani Nikula Cc: Maarten Lankhorst Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_driver.c | 8 drivers/g

[Intel-gfx] [PATCH v2] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-11 Thread José Roberto de Souza
v2: - added intel_display_locks_init() Cc: intel-gfx@lists.freedesktop.org Cc: intel...@lists.freedesktop.org Cc: Rodrigo Vivi Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 9 + drivers/gpu/drm/i915/display/intel_dkl_phy.c | 6

[Intel-gfx] [PATCH v3 2/6] drm/i915: Only initialize dlk phy lock in display 12 and newer

2023-04-10 Thread José Roberto de Souza
This spin lock will not be used in older display versions, so no need to initialize it. Cc: intel-gfx@lists.freedesktop.org Cc: intel...@lists.freedesktop.org Reviewed-by: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dkl_phy.c | 3 ++- 1 file changed

[Intel-gfx] [PATCH v3 1/6] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-10 Thread José Roberto de Souza
616a6180650 [ 202.489396] Cc: intel-gfx@lists.freedesktop.org Cc: intel...@lists.freedesktop.org Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/display/intel_dkl_phy.c | 6 ++ drivers/gpu/drm/i

[Intel-gfx] [PATCH 2/2] drm/i915: Only initialize dlk phy lock in display 12 and newer

2023-04-10 Thread José Roberto de Souza
This spin lock will not be used in older display versions, so no need to initialize it. Cc: intel-gfx@lists.freedesktop.org Cc: intel...@lists.freedesktop.org Reviewed-by: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dkl_phy.c | 3 ++- 1 file changed

[Intel-gfx] [PATCH 1/2] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-10 Thread José Roberto de Souza
616a6180650 [ 202.489396] Cc: intel-gfx@lists.freedesktop.org Cc: intel...@lists.freedesktop.org Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/display/intel_dkl_phy.c | 6 ++ drivers/gpu/drm/i

[Intel-gfx] [PATCH v2 rebased 3/6] drm/i915: Only initialize dlk phy lock in display 12 and newer

2023-04-06 Thread José Roberto de Souza
This spin lock will not be used in older display versions, so no need to initialize it. Cc: intel-gfx@lists.freedesktop.org Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dkl_phy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 rebased 1/6] drm/i915: Nuke unused dsparb_lock

2023-04-06 Thread José Roberto de Souza
dsparb_lock it not used anymore, nuke it. Cc: intel-gfx@lists.freedesktop.org Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_core.h | 3 --- drivers/gpu/drm/i915/i915_driver.c| 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH v2 rebased 2/6] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-06 Thread José Roberto de Souza
004 R08: R09: 0002 [ 202.475250] R10: 000e R11: 0246 R12: 5616a617fe60 [ 202.482319] R13: 5616a617f340 R14: R15: 5616a6180650 [ 202.489396] Cc: intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi Signed-off-by: José

[Intel-gfx] [PATCH v2 3/6] drm/i915: Only initialize dlk phy lock in display 12 and newer

2023-04-03 Thread José Roberto de Souza
This spin lock will not be used in older display versions, so no need to initialize it. Cc: intel-gfx@lists.freedesktop.org Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dkl_phy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 1/6] drm/i915: Nuke unused dsparb_lock

2023-04-03 Thread José Roberto de Souza
dsparb_lock it not used anymore, nuke it. Cc: intel-gfx@lists.freedesktop.org Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_core.h | 3 --- drivers/gpu/drm/i915/i915_driver.c| 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH v2 2/6] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-03 Thread José Roberto de Souza
004 R08: R09: 0002 [ 202.475250] R10: 000e R11: 0246 R12: 5616a617fe60 [ 202.482319] R13: 5616a617f340 R14: R15: 5616a6180650 [ 202.489396] Cc: intel-gfx@lists.freedesktop.org Signed-off-by: José Rober

[Intel-gfx] [PATCH 1/5] drm/i915: Split display locks init from i915_driver_early_probe()

2023-04-03 Thread José Roberto de Souza
No behavior changes here, just adding a function to make clear what locks initialized here are display related or not. Cc: intel-gfx@lists.freedesktop.org Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_driver.c | 23 +++ 1 file changed, 15 insertions

[Intel-gfx] [PATCH v2] drm/i915: Extend Wa_1607297627 to Alderlake-P

2022-10-17 Thread José Roberto de Souza
-by: Lucas De Marchi Cc: Tvrtko Ursulin Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workaroun

[Intel-gfx] [PATCH] i915: Extend Wa_1607297627 to Alderlake-P

2022-10-13 Thread José Roberto de Souza
BSpec: 54369 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index b8eb20a155f0d..e1d5df3a5756e

[Intel-gfx] [PATCH] drm/i915: Add new ADL-S pci id

2022-08-24 Thread José Roberto de Souza
New PCI id recently added. BSpec: 53655 Signed-off-by: José Roberto de Souza --- include/drm/i915_pciids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 278031aa2e848..4a4c190f76984 100644 --- a/include/drm/i915_pciids.h +++ b

[Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state"

2022-07-14 Thread José Roberto de Souza
. This reverts commit 75f664903d8672897333b86bb450335ec6486ad5. Cc: Jouni Högander Cc: Stanislav Lisovskiy Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 53 ++-- 1 file changed, 22 insertions(+), 31 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe

2022-07-14 Thread José Roberto de Souza
then using the new_crtc_state to check if PSR needs to be disabled. Cc: Jouni Högander Cc: Stanislav Lisovskiy Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: Drain freed object after suspend display

2022-06-29 Thread José Roberto de Souza
issues. So here draining all freed objects released by display fixing suspend issues. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index

[Intel-gfx] [PATCH] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-06-24 Thread José Roberto de Souza
ned-off-by: Hangyu Hua Reviewed-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index 061b277e5ce78..14d2a64193b2d 100644 --- a/drive

[Intel-gfx] [PATCH] drm/i915: Call i915_gem_suspend() only after display is turned off

2022-06-17 Thread José Roberto de Souza
calling i915_gem_suspend() and by consequence i915_gem_drain_freed_objects() only after display is down making sure all buffers are freed. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915/display: Fix handling of enable_psr parameter

2022-06-08 Thread José Roberto de Souza
Cc: Jani Nikula Cc: Jouni Högander Cc: Mika Kahola Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c

[Intel-gfx] [PATCH] drm/i915/display/fbc: Do not apply WA 22014263786 to DG2

2022-06-02 Thread José Roberto de Souza
This workaround brings some regressions to DG2 and if really necessary for DG2 an alternative workaround will be implemented. BSpec: 54077 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_fbc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[Intel-gfx] [PATCH 15/16] drm/i915: Drop has_logical_ring_contexts from device info

2022-05-07 Thread José Roberto de Souza
and compare with platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 +-- drivers/gpu/drm/i915/i915_pci.c | 4 drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 1 insertion(+), 7 deletions

[Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db from device info

2022-05-07 Thread José Roberto de Souza
to check the macro and compare with platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 3

[Intel-gfx] [PATCH 13/16] drm/i915: Drop has_heci_gscfi from device info

2022-05-07 Thread José Roberto de Souza
platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 12 drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 5 insertions(+), 10 deletions

[Intel-gfx] [PATCH 14/16] drm/i915: Drop has_runtime_pm from device info

2022-05-07 Thread José Roberto de Souza
rely on to check the macro and compare with platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- drivers/gpu/drm/i915/i915_pci.c | 7 +-- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed

[Intel-gfx] [PATCH 12/16] drm/i915: Drop has_heci_gscfi from device info

2022-05-07 Thread José Roberto de Souza
being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 +-- drivers/gpu/drm/i915/i915_pci.c | 3 +-- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 09/16] drm/i915: Drop has_global_mocs from device info

2022-05-07 Thread José Roberto de Souza
compare with platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 2 -- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 11/16] drm/i915: Drop has_pxp from device info

2022-05-07 Thread José Roberto de Souza
macro and compare with platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 4 +--- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 2 insertions(+), 5

[Intel-gfx] [PATCH 08/16] drm/i915: Drop has_64bit_reloc from device info

2022-05-07 Thread José Roberto de Souza
check the macro and compare with platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 6 +- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 2 insertions

[Intel-gfx] [PATCH 10/16] drm/i915: Drop has_guc_deprivilege from device info

2022-05-07 Thread José Roberto de Souza
compare with platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 +-- drivers/gpu/drm/i915/i915_pci.c | 1 - drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff

[Intel-gfx] [PATCH 07/16] drm/i915: Drop has_4tile from device info

2022-05-07 Thread José Roberto de Souza
rely on to check the macro and compare with platform being used and IP versions of it. BSpec: 44917 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 1 - drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files

[Intel-gfx] [PATCH 05/16] drm/i915: Drop has_psr_hw_tracking from device info

2022-05-07 Thread José Roberto de Souza
removal this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check the macro and compare with platform being used and IP versions of it. v2: - moved macro to intel_psr.c Cc: Matt Roper Cc: Jani Nikula Signed-off-by: José Roberto de Souza

[Intel-gfx] [PATCH 06/16] drm/i915: Drop supports_tv from device info

2022-05-07 Thread José Roberto de Souza
platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_pci.c | 4 drivers/gpu/drm/i915/intel_device_info.h | 3 +-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] [PATCH 04/16] drm/i915: Drop has_rc6p from device info

2022-05-07 Thread José Roberto de Souza
with platform being used and IP versions of it. v2: - simplified check Cc: Matt Roper Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3

[Intel-gfx] [PATCH 02/16] drm/i915: Drop has_ipc from device info

2022-05-07 Thread José Roberto de Souza
compare with platform being used and IP versions of it. v2: - making this available to all platforms 9 and newer Cc: Ville Syrjälä Cc: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers

[Intel-gfx] [PATCH 03/16] drm/i915/display: Disable DSB for DG2 and Alderlake-P

2022-05-07 Thread José Roberto de Souza
this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check the macro and compare with platform being used and IP versions of it. Fixes: 99510e1afb48 ("drm/i915: Disable DSB usage for now") Cc: Ville Syrjälä Cc: Uma Shankar Signed-off

[Intel-gfx] [PATCH 01/16] drm/i915: Drop has_llc from device info

2022-05-07 Thread José Roberto de Souza
load anymore and developers will have to rely on to check the macro and compare with platform being used and IP versions of it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_llc.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 5 - drivers/gpu/drm/i915

[Intel-gfx] [PATCH CI 7/7] drm/i915: Drop has_psr from device info

2022-05-05 Thread José Roberto de Souza
with platform being used and IP versions of it. Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 1 insertion(+), 5

[Intel-gfx] [PATCH CI 5/7] drm/i915: Drop has_ddi from device info

2022-05-05 Thread José Roberto de Souza
macro and compare with platform being used and IP versions of it. Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed

[Intel-gfx] [PATCH CI 6/7] drm/i915: Drop has_dp_mst from device info

2022-05-05 Thread José Roberto de Souza
being used and IP versions of it. Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 1 insertion(+), 5 deletions

[Intel-gfx] [PATCH CI 4/7] drm/i915: Drop has_logical_ring_elsq from device info

2022-05-05 Thread José Roberto de Souza
compare with platform being used and IP versions of it. Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 +-- drivers/gpu/drm/i915/i915_pci.c | 4 +--- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 2 insertions

[Intel-gfx] [PATCH CI 2/7] drm/i915: Drop has_rc6 from device info

2022-05-05 Thread José Roberto de Souza
check the macro and compare with platform being used and IP versions of it. Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_pci.c | 8 drivers/gpu/drm/i915/intel_device_info.h | 1 - 3

[Intel-gfx] [PATCH CI 3/7] drm/i915: Drop has_reset_engine from device info

2022-05-05 Thread José Roberto de Souza
compare with platform being used and IP versions of it. Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_reset.c| 2 +- drivers/gpu/drm/i915/i915_pci.c | 5 - drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 1 insertion

[Intel-gfx] [PATCH CI 1/7] drm/i915: Drop has_gt_uc from device info

2022-05-05 Thread José Roberto de Souza
macro and compare with platform being used and IP versions of it. Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c| 2 +- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 12/12] drm/i915: Drop supports_tv from device info

2022-05-04 Thread José Roberto de Souza
Only four platforms ever support this feature so we can elimitate this from device info and use platform checks instead. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_pci.c | 4 drivers/gpu/drm/i915

[Intel-gfx] [PATCH 09/12] drm/i915: Drop has_dp_mst from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as the requirement to support it is the DDI support. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915/intel_device_info.h

[Intel-gfx] [PATCH 11/12] drm/i915: Drop has_psr_hw_tracking from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as this feature was only supported by display 9, display 11, tigerlake and DG1, no newer platform will have this feature. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 6 -- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 10/12] drm/i915: Drop has_psr from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as all platforms with display version 9 or newer has this feature. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 07/12] drm/i915: Drop has_logical_ring_elsq from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as all platforms with graphics version 11 or newer has this feature. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 +-- drivers/gpu/drm/i915/i915_pci.c | 4 +--- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 08/12] drm/i915: Drop has_ddi from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as all platforms with display version 9 or newer, haswell or broadwell supports it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers

[Intel-gfx] [PATCH 06/12] drm/i915: Drop has_reset_engine from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as all platforms with graphics version 7 or newer can reset engines. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_reset.c| 2 +- drivers/gpu/drm/i915/i915_pci.c | 5 - drivers/gpu/drm/i915

[Intel-gfx] [PATCH 04/12] drm/i915: Drop has_rc6 from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as all platforms with graphics version 6 or newer have software support for this feature. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_pci.c | 8

[Intel-gfx] [PATCH 05/12] drm/i915: Drop has_rc6p from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as it was only supported in graphics version 6 and 7 not including haswell. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm

[Intel-gfx] [PATCH 03/12] drm/i915: Drop has_gt_uc from device info

2022-05-04 Thread José Roberto de Souza
No need to have this parameter in intel_device_info struct as all platforms with graphics version 9 or newer has graphics microcontroller. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c| 2 +- drivers/gpu/drm

[Intel-gfx] [PATCH 02/12] drm/i915/display: Disable DSB for DG2 and Alderlake-P

2022-05-04 Thread José Roberto de Souza
15: Disable DSB usage for now") Cc: Ville Syrjälä Cc: Uma Shankar Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_pci.c | 4 +--- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 3 insertions(+),

[Intel-gfx] [PATCH 01/12] drm/i915: Drop IPC from display 13 and newer

2022-05-04 Thread José Roberto de Souza
Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_pci.c | 3 --- drivers/gpu/drm/i915/intel_device_info.h | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu

[Intel-gfx] [PATCH v2 2/3] drm/i915/display/dp: Try to fallback to previous link config if modeset is not allowed

2022-05-02 Thread José Roberto de Souza
the new state. Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dp.c | 86 - 1 file changed, 85 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index

[Intel-gfx] [PATCH v2 3/3] drm/i915/display: Implement seamless mode switch

2022-05-02 Thread José Roberto de Souza
n values in intel_crtc_copy_fastset() when doing a seamless_mode_switch Cc: Vidya Srinivas Cc: Sean Paul Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +++ drivers/gpu/drm/i915/display/intel_display.c | 61 ---

[Intel-gfx] [PATCH v2 1/3] drm/i915/display: Allow DRRS to be enabled during driver load

2022-05-02 Thread José Roberto de Souza
here checking if platform has only one set of m_n registers that can change on the fly between high and low clock, if yes we can keep DRRS enabled. Cc: Vidya Srinivas Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 7 -- drivers/gpu

[Intel-gfx] [PATCH 2/3] drm/i915/display: Allow DRRS to be enabled during driver load

2022-04-28 Thread José Roberto de Souza
here checking if platform has only one set of m_n registers that can change on the fly between high and low clock, if yes we can keep DRRS enabled. Cc: Vidya Srinivas Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 7 -- drivers/gpu

[Intel-gfx] [PATCH 3/3] drm/i915/display: Implement seamless mode switch

2022-04-28 Thread José Roberto de Souza
ean Paul Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 drivers/gpu/drm/i915/display/intel_display.c | 59 --- .../drm/i915/display/intel_display_debugfs.c | 3 + .../drm/i915/display/intel_display_types.h

[Intel-gfx] [PATCH 1/3] drm/i915/display: Do not schedule DRRS work thread when it is not active

2022-04-28 Thread José Roberto de Souza
-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_drrs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/intel_drrs.c index 166caf293f7bc..04bc296761be0 100644 --- a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 3/3] drm/i915/display: Implement seamless mode switch

2022-04-21 Thread José Roberto de Souza
executed and it supports the mode. Cc: Vidya Srinivas Cc: Sean Paul Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_crtc.c | 10 +++ drivers/gpu/drm/i915/display/intel_display.c | 5 +- .../drm/i915/display/intel_display_debugfs.c | 5 +

[Intel-gfx] [PATCH 1/3] drm: Add infrastructure to allow seamless mode switches

2022-04-21 Thread José Roberto de Souza
nge between old and new mode will return 0 otherwise it should return the appropried errno. So here adding basic drm infrastructure to that be supported by i915 and other drivers. Cc: Vidya Srinivas Cc: Sean Paul Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/d

[Intel-gfx] [PATCH 2/3] drm/i915/display: Replace crtc_state's has_drrs by drrs_downclock_mode

2022-04-21 Thread José Roberto de Souza
behavior has has_drrs. Cc: Vidya Srinivas Cc: Sean Paul Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 4 ++-- drivers/gpu/drm/i915/display/intel_display_types.h | 4

[Intel-gfx] [PATCH v2 2/2] drm/i915/dg2: Add workaround 18019627453

2022-04-19 Thread José Roberto de Souza
A new DG2 workaround added to fix some corner cases hangs. v2: - implementing the second and preferred option for this workaround BSpec: 54077 BSpec: 68173 BSpec: 71488 Cc: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 1 file changed

[Intel-gfx] [PATCH v2 1/2] drm/i915/display: Add workaround 22014263786

2022-04-19 Thread José Roberto de Souza
This workaround fixes screen flickers with FBC. BSpec: 33450 BSpec: 52890 BSpec: 54369 BSpec: 66624 Reviewed-by: Matt Roper Cc: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_fbc.c | 9 + drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files

[Intel-gfx] [PATCH 2/2] drm/i915/display: Add workaround 22014263786

2022-04-19 Thread José Roberto de Souza
This workaround fixes screen flickers with FBC. BSpec: 33450 BSpec: 52890 BSpec: 54369 BSpec: 66624 Cc: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_fbc.c | 9 + drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 10 insertions

[Intel-gfx] [PATCH 1/2] drm/i915/dg2: Add workaround 18019627453

2022-04-19 Thread José Roberto de Souza
A new DG2 workaround added to some corner cases hangs. BSpec: 54077 BSpec: 68173 BSpec: 71488 Cc: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 2 files changed, 4 insertions(+) diff

[Intel-gfx] [PATCH 1/2] drm/i915/display/drrs: Split the DRRS status per connector

2022-04-18 Thread José Roberto de Souza
Syrjälä Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_debugfs.c | 65 +-- 1 file changed, 46 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index

[Intel-gfx] [PATCH 2/2] drm/i915/display/drrs: Remove repeated DRRS in i915_drrs_status

2022-04-18 Thread José Roberto de Souza
User-space parsing of i915_drrs_status is already broken so lets use this oportunity to drop those repeated "DRRS". It is the DRRS status debugfs so all of this information is related to DRRS and there is no need to mention it each time. Cc: Ville Syrjälä Signed-off-by: José Robert

[Intel-gfx] [PATCH v3 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-14 Thread José Roberto de Souza
r invalidations") Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5634 Cc: Jouni Högander Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH v3 1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-14 Thread José Roberto de Souza
jumping to a section that unset enable_psr2_sel_fetch in case of failure to support PSR2. Fixes: 6e43e276b8c9 ("drm/i915: Initial implementation of PSR2 selective fetch") Cc: Jouni Högander Reviewed-by: Jouni Högander Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH v2 1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-13 Thread José Roberto de Souza
jumping to a section that unset enable_psr2_sel_fetch in case of failure to support PSR2. Fixes: 6e43e276b8c9 ("drm/i915: Initial implementation of PSR2 selective fetch") Cc: Jouni Högander Reviewed-by: Jouni Högander Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH v2 2/2] drm/i915/display/psr: Do not check for PSR2_MAN_TRK_CTL_ENABLE on alderlake-P

2022-04-13 Thread José Roberto de Souza
rm/i915/display: Match PSR2 selective fetch sequences with specification") Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/

[Intel-gfx] [PATCH 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-12 Thread José Roberto de Souza
r invalidations") Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5634 Cc: Jouni Högander Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH 1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-12 Thread José Roberto de Souza
jumping to a section that unset enable_psr2_sel_fetch in case of failure to support PSR2. Fixes: 6e43e276b8c9 ("drm/i915: Initial implementation of PSR2 selective fetch") Cc: Jouni Högander Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_

[Intel-gfx] [PATCH] drm/i915/display: Fix warnings about PSR lock not held

2022-04-06 Thread José Roberto de Souza
ock before the earlier return in intel_pipe_update_start/end(). Cc: Jouni Högander Reported-by: Imre Deak Fixes: 3b6f409547fb ("drm/i915/display/psr: Lock and unlock PSR around pipe updates") Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_crtc.c | 8

[Intel-gfx] [PATCH CI 2/3] drm/i915/display/psr: Lock and unlock PSR around pipe updates

2022-04-05 Thread José Roberto de Souza
k and unlock functions and calls, the proper PSR2 selective fetch handling will come in a separated patch. v2: - fixed new functions documentation Reviewed-by: Jouni Högander Cc: Jouni Högander Cc: Mika Kahola Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_crtc.c

[Intel-gfx] [PATCH CI 3/3] drm/i915/display/psr: Use continuos full frame to handle frontbuffer invalidations

2022-04-05 Thread José Roberto de Souza
Almahallawy Cc: Shawn C Lee Cc: Jouni Högander Cc: Mika Kahola Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_psr.c | 88 --- 2 files changed, 77 insertions(+), 12 deletions(-) diff --git a

[Intel-gfx] [PATCH CI 1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch

2022-04-05 Thread José Roberto de Souza
od idea so here also setting the man_trk_ctl_enable_bit() that is required in TGL and only doing a register write. v2: - not doing a rmw v3: - removing the inline from functions that return PSR2_MAN_TRK_CTL bits Reviewed-by: Jouni Högander Cc: Jouni Högander Cc: Mika Kahola Signed-off-by: J

[Intel-gfx] [PATCH 3/3] drm/i915/display/psr: Use continuos full frame to handle frontbuffer invalidations

2022-04-01 Thread José Roberto de Souza
Cc: Jouni Högander Cc: Mika Kahola Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_psr.c | 88 --- 2 files changed, 77 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch

2022-04-01 Thread José Roberto de Souza
od idea so here also setting the man_trk_ctl_enable_bit() that is required in TGL and only doing a register write. v2: - not doing a rmw Cc: Jouni Högander Cc: Mika Kahola Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 18 +++--- 1 file changed,

[Intel-gfx] [PATCH 2/3] drm/i915/display/psr: Lock and unlock PSR around pipe updates

2022-04-01 Thread José Roberto de Souza
k and unlock functions and calls, the proper PSR2 selective fetch handling will come in a separated patch. Cc: Jouni Högander Cc: Mika Kahola Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_crtc.c | 6 +- drivers/gpu/drm/i915/display/intel_psr.c

  1   2   3   4   5   6   7   8   9   10   >