Re: [Intel-gfx] [PATCH v2 08/22] drm/i915/guc: Update GuC sample-forcewake command

2019-04-16 Thread John Spotswood
On Fri, 2019-04-12 at 17:10 -0700, Ceraolo Spurio, Daniele wrote: > > On 4/11/19 1:44 AM, Michal Wajdeczko wrote: > > > > New GuC firmwares use different action code value for this command. > > > > Signed-off-by: Michal Wajdeczko > > Cc: John Spots

Re: [Intel-gfx] [PATCH v2 10/22] drm/i915/guc: Always ask GuC to update power domain states

2019-04-16 Thread John Spotswood
> Signed-off-by: Michal Wajdeczko > > Cc: Daniele Ceraolo Spurio > > Cc: John Spotswood > Reviewed-by: Daniele Ceraolo Spurio > > Daniele Reviewed-by: John Spotswood > > > > > --- > >   drivers/gpu/drm/i915/intel_guc_submission.c | 4 > &

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: updated suspend/resume protocol

2019-04-16 Thread John Spotswood
. > > v2: include changes for polling and shared page > > Signed-off-by: Michal Wajdeczko > Signed-off-by: Daniele Ceraolo Spurio m> > Cc: Joonas Lahtinen > Cc: John Spotswood Reviewed-by: John Spotswood > --- >  drivers/gpu/drm/i915/intel_guc.c  | 50 ++

Re: [Intel-gfx] [PATCH v2 07/22] drm/i915/guc: Update GuC sleep status values

2019-04-15 Thread John Spotswood
t; > Thanks, > Daniele > If running with HuC authentication only, the GuC will have nothing to do once authentication is completed, so GuC will go to sleep on its own.  The driver can remove those suspend/resume calls if GuC submission is disabled. John > > > > > >

Re: [Intel-gfx] [PATCH 19/21] drm/i915/huc: New HuC status register for Gen11

2018-08-30 Thread John Spotswood
t; Cc: Tony Ye > Cc: Vinay Belgaumkar > Cc: Michel Thierry > Cc: John Spotswood > Cc: Anusha Srivatsa Reviewed-by: John Spotswood > --- >  drivers/gpu/drm/i915/intel_guc_reg.h |  3 ++ >  drivers/gpu/drm/i915/intel_huc.c | 58 > +++

Re: [Intel-gfx] [PATCH 03/21] drm/i915/guc: Simplify preparation of GuC parameter block

2018-08-30 Thread John Spotswood
On Wed, 2018-08-29 at 12:10 -0700, Wajdeczko, Michal wrote: > Definition of the parameters block passed to GuC is about to change. > Slightly refactor code now to make upcoming patch smaller. > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: John Spotswood

Re: [Intel-gfx] [PATCH 04/21] drm/i915/guc: Support dual Gen9/Gen11 parameters block

2018-08-30 Thread John Spotswood
nas Lahtinen > Cc: Rodrigo Vivi > Cc: Daniele Ceraolo Spurio > Cc: Michel Thierry > Cc: John Spotswood > Cc: Vinay Belgaumkar > Cc: Tony Ye > Cc: Anusha Srivatsa > Cc: Jeff Mcgee > Cc: Antonio Argenziano > Cc: Sujaritha Sundaresan Reviewed-by: John Spots

Re: [Intel-gfx] [PATCH 02/21] drm/i915/guc: Don't allow GuC submission on pre-Gen11

2018-08-30 Thread John Spotswood
that > we > can enable HuC authentication but nothing else on pre-Gen11. > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Daniele Ceraolo Spurio > Cc: Michel Thierry > Cc: John Spotswood > Cc: Vinay Belgaumkar > Cc: Tony Y

Re: [Intel-gfx] [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume

2018-06-22 Thread John Spotswood
gt; > Do we need a fixes: tag? Not sure we want this backported since GuC > is  > off by default. > > > > > Credits to: Daniele Ceraolo Spurio > > > > Cc: John Spotswood > > Cc: Oscar Mateo > > Cc: Daniele Ceraolo Spurio > > Signed-off-by: Anusha Srivats

Re: [Intel-gfx] [PATCH 2/3] drm/i915/huc: Load HuC v03.00.2555 for Geminilake.

2018-05-17 Thread John Spotswood
On Fri, 2018-04-27 at 16:33 -0700, Anusha Srivatsa wrote: > load the v03.00.2555 huC on geminilake. > > Cc: Tomi Sarvela > Cc: Jani Saarinen > Signed-off-by: Anusha Srivatsa > --- >  drivers/gpu/drm/i915/intel_huc_fw.c | 12 >  1 file changed, 12 insertions(+) > > diff --git a/driv

Re: [Intel-gfx] [PATCH 5/5] drm/i915/icl/huc: Define the HuC firmware version for Icelake

2018-05-08 Thread John Spotswood
> Cc: Michal Wajdeczko > Cc: John Spotswood Reviewed-by: John Spotswood > Cc: Anusha Srivatsa > --- >  drivers/gpu/drm/i915/intel_huc_fw.c | 11 +++ >  1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c > b/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 4/5] drm/i915/icl/huc: Correctly authenticate the HuC for Icelake

2018-05-08 Thread John Spotswood
x duplicate Cc > > BSpec: 19686 > > Signed-off-by: Oscar Mateo > Cc: Tony Ye > Cc: Vinay Belgaumkar > Cc: Michel Thierry > Cc: Michal Wajdeczko > Cc: John Spotswood Reviewed-by: John Spotswood > Cc: Anusha Srivatsa > --- >  drivers/gpu/drm/i915/intel_gu

Re: [Intel-gfx] [PATCH 3/5] drm/i915/icl/guc: Define the GuC firmware version for Icelake

2018-05-08 Thread John Spotswood
igned-off-by: Michel Thierry > Signed-off-by: Oscar Mateo > Cc: Michal Wajdeczko > Cc: John Spotswood Reviewed-by: John Spotswood > Cc: Tony Ye > Cc: Joonas Lahtinen > Cc: Daniele Ceraolo Spurio > Cc: Anusha Srivatsa > --- >  drivers/gpu/drm/i915/intel_guc_f

Re: [Intel-gfx] [PATCH 1/5] drm/i915/icl/guc: Do not allow GuC submission on Icelake for now

2018-05-08 Thread John Spotswood
gt; the > GuC with guarantees. > > Signed-off-by: Oscar Mateo > Cc: Joonas Lahtinen > Cc: Michal Wajdeczko > Cc: John Spotswood Reviewed-by: John Spotswood > Cc: Tony Ye > Cc: Anusha Srivatsa > --- >  drivers/gpu/drm/i915/intel_uc.c | 10 ++ >  1 file

Re: [Intel-gfx] [PATCH 2/5] drm/i915/icl/guc: Pass the bare minimum GuC init parameters for Icelake

2018-05-08 Thread John Spotswood
On Wed, 2018-05-02 at 12:03 -0700, Oscar Mateo wrote: > Only enough to achieve HuC authentication. No GuC submission > or any other feature for the time being. > > v2: Fix extra space > > Signed-off-by: Oscar Mateo > Cc: Joonas Lahtinen > Cc: Michal Wajdeczko > Cc

Re: [Intel-gfx] [PATCH 4/5] drm/i915/icl/huc: Correctly authenticate the HuC for Icelake

2018-05-04 Thread John Spotswood
x duplicate Cc > > BSpec: 19686 > > Signed-off-by: Oscar Mateo > Cc: Tony Ye > Cc: Vinay Belgaumkar > Cc: Michel Thierry > Cc: Michal Wajdeczko > Cc: John Spotswood > Cc: Anusha Srivatsa > --- >  drivers/gpu/drm/i915/intel_guc_reg.h |  3 +++ >  driver

Re: [Intel-gfx] [PATCH 3/5] drm/i915/icl/guc: Define the GuC firmware version for Icelake

2018-04-30 Thread John Spotswood
so we don't accidentally push it > before linux-firmware (Joonas) > > v5: Use the latest firmware (v23.120) > v6: Use the latest firmware (v26.171) > v7: Rebased (remove guc-core-family) > v8: Use the latest firmware (v27.182) > > Cc: Michal Wajdeczko > Cc: John Spotsw

Re: [Intel-gfx] [PATCH 2/5] drm/i915/icl/guc: Pass the bare minimum GuC init parameters for Icelake

2018-04-30 Thread John Spotswood
On Fri, 2018-04-27 at 14:31 -0700, Oscar Mateo wrote: > Only enough to achieve HuC authentication. No GuC submission > or any other feature for the time being. > > Signed-off-by: Oscar Mateo > Cc: Joonas Lahtinen > Cc: Michal Wajdeczko > Cc: John Spotswood > Cc: Tony

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915: Add code to accept valid locked WOPCM register values

2018-04-13 Thread John Spotswood
il the GuC/HuC firmware loading even if the locked register > values > are different from the calculated ones. > > v2: >  - Update WOPCM register only if it's not locked > > Signed-off-by: Jackie Li > Cc: Michal Wajdeczko > Cc: Sagar Arun Kamble > Cc: Michal

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Always set HUC_LOADING_AGENT_GUC bit in WOPCM offset register

2018-04-13 Thread John Spotswood
ays locked with HUC_LOADING_AGENT_GUC bit set to 1 > which > will guarantee successful uploading of both GuC and HuC FW. We will > further > take care of the locked values in the following enhancement patch. > > Signed-off-by: Jackie Li > Cc: Michal Wajdeczko > Cc: Sagar Ar

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915: Always do WOPCM partitioning based on real firmware sizes

2018-04-13 Thread John Spotswood
ebase > > Signed-off-by: Jackie Li > Cc: Michal Wajdeczko > Cc: Sagar Arun Kamble > Cc: Michal Winiarski > Cc: John Spotswood > Cc: Joonas Lahtinen Reviewed-by: John Spotswood > --- >  drivers/gpu/drm/i915/intel_uc.c| 14 -- >  drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915/guc: Removed unused GuC parameters.

2018-03-06 Thread John Spotswood
On Mon, 2018-03-05 at 03:12 -0800, Piorkowski, Piotr wrote: > On Fri, 2018-03-02 at 12:53 +0530, Sagar Arun Kamble wrote: > > > > > > On 3/2/2018 12:44 AM, John Spotswood wrote: > > > > > > On Thu, 2018-03-01 at 17:35 +0530, Sagar Arun Kamble wrote: >

Re: [Intel-gfx] [PATCH] drm/i915/guc: Removed unused GuC parameters.

2018-03-01 Thread John Spotswood
On Thu, 2018-03-01 at 17:35 +0530, Sagar Arun Kamble wrote: > > On 3/1/2018 1:32 PM, Chris Wilson wrote: > > > > Quoting Michel Thierry (2018-02-28 22:07:51) > > > > > > On 28/02/18 12:26, Michel Thierry wrote: > > > > > > > > On 28/02/18 10:42, Piotr Piórkowski wrote: > > > > > > > > > > In t

Re: [Intel-gfx] [PATCH 2/2] drm/i915/GLK/HuC: Load HuC on GLK

2017-03-30 Thread John Spotswood
On Thu, 2017-03-30 at 13:24 -0700, Anusha Srivatsa wrote: > Load HuC version 1.07.1748 on GLK. > > v2: rebased. > v3: Use name of the right platform(John Spotswood) > v4: rebased. > > Cc: Jeff Mcgee > Cc: John Spotswood > Cc: Rodrigo Vivi > Signed-off-by: Anush

Re: [Intel-gfx] [PATCH 1/2] drm/i915/GuC/GLK: Load GuC on GLK

2017-03-30 Thread John Spotswood
eff mcgee > Cc: Rodrigo Vivi > Cc: John Spotswood > Signed-off-by: Anusha Srivatsa Reviewed-by: John Spotswood > --- >  drivers/gpu/drm/i915/intel_guc_loader.c | 9 + >  1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/GuC/GLK: Load GuC on GLK

2017-03-28 Thread John Spotswood
On Tue, 2017-03-28 at 17:01 -0700, Vivi, Rodrigo wrote: > On Tue, 2017-03-28 at 22:11 +, Srivatsa, Anusha wrote: > > > > > > > > > > -Original Message- > > > From: Spotswood, John A > > > Sent: Tuesday, March 28, 2017 2:35 PM > > > To: Srivatsa, Anusha ; intel- > > > g...@lists.freed

Re: [Intel-gfx] [PATCH 1/2] drm/i915/GuC/GLK: Load GuC on GLK

2017-03-28 Thread John Spotswood
On Tue, 2017-03-21 at 14:09 -0700, Anusha Srivatsa wrote: > Load GuC 10.56 on GLK. Work on firmware is still > in progress. Testing has not been done yet. > This patch addresses the initial need to load the GuC > firmware for HuC authentication > > Cc: Jeff mcgee > Cc: Rod

Re: [Intel-gfx] [PATCH] drm/i915/GLK/HuC: Load HuC on GLK

2017-03-28 Thread John Spotswood
On Tue, 2017-03-21 at 17:29 -0700, Anusha Srivatsa wrote: > Load HuC version 1.07.1748 on GLK. > > v2: rebased. > v3: Use name of the right platform(John Spotswood) > > Cc: Jeff Mcgee > Cc: John Spotswood > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa &g

Re: [Intel-gfx] [PATCH 2/2] drm/i915/HuC/GLK: Load HuC on GLK

2017-03-21 Thread John Spotswood
On 03/21/2017 02:10 PM, Anusha Srivatsa wrote: Load HuC version 1.07.1748 on GLK. Cc: Jeff Mcgee Cc: John Spotswood Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_huc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915