Re: [PATCH 6/7] drivers: Repace get_task_comm() with %pTN

2024-12-12 Thread Jiri Slaby
Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: David Airlie Cc: Simona Vetter Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: Greg Kroah-Hartman Cc: Jiri Slaby --- drivers/accel/habanalabs/common/context.c | 5 ++--- .../accel/habanal

[PATCH 21/21] drm/i915: remove intel_memory_region_ops::flags

2024-02-15 Thread Jiri Slaby (SUSE)
intel_memory_region_ops::flags was never used since its addition in commit 232a6ebae419 (drm/i915: introduce intel_memory_region). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 20/21] drm/i915: remove i915_vma::obj_hash

2024-02-15 Thread Jiri Slaby (SUSE)
i915_vma::obj_hash was never used since its addition in commit 4ff4b44cbb70 (drm/i915: Store a direct lookup from object handle to vma). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc

[PATCH 19/21] drm/i915: remove execute_cb::signal

2024-02-15 Thread Jiri Slaby (SUSE)
execute_cb::signal is not used since commit 5ac545b8b014 (drm/i915/request: Remove the hook from await_execution). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel

[PATCH 18/21] drm/i915: remove intel_gvt_irq::pending_events

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_irq::pending_events was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 17/21] drm/i915: remove intel_gvt_event_info::policy

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_event_info::policy was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 16/21] drm/i915: remove intel_gvt_irq_info::warned

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_irq_info::warned was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 15/21] drm/i915: remove gvt_mmio_block::device

2024-02-15 Thread Jiri Slaby (SUSE)
gvt_mmio_block::device is not used since commit e0f74ed4634d (i915/gvt: Separate the MMIO tracking table from GVT-g). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc

[PATCH 14/21] drm/i915: remove intel_vgpu::intx_trigger

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu::intx_trigger was never used since its addition in commit f30437c5e7bf (drm/i915/gvt: add KVMGT support). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc

[PATCH 13/21] drm/i915: remove intel_vgpu_opregion::mapped

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu_opregion::mapped is not used since commit 367748066eeb (drm/i915/gvt: remove enum hypervisor_type). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx

[PATCH 12/21] drm/i915: remove intel_vgpu_fence::base

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu_fence::base was never used since its addition in commit 28a60dee2ce6 (drm/i915/gvt: vGPU HW resource management). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin

[PATCH 11/21] drm/i915: remove intel_vgpu_gtt::active_ppgtt_mm_bitmap

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vgpu_gtt::active_ppgtt_mm_bitmap was never used since its addition in commit 2707e4446688 (drm/i915/gvt: vGPU graphics memory virtualization). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo

[PATCH 10/21] drm/i915: remove i915_perf_stream::size_exponent

2024-02-15 Thread Jiri Slaby (SUSE)
i915_perf_stream::size_exponent was never used since its addition in commit a37f08a882b0 (drm/i915/perf: Refactor oa object to better manage resources). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc

[PATCH 09/21] drm/i915: remove i915_drm_client::id

2024-02-15 Thread Jiri Slaby (SUSE)
i915_drm_client::id is not used since commit e894b724c316 (drm/i915: Use the fdinfo helper). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx

[PATCH 07/21] drm/i915: remove intel_vbt_panel_data::edp::initialized

2024-02-15 Thread Jiri Slaby (SUSE)
intel_vbt_panel_data::edp::initialized is not used since commit 9f0e7ff4b366 (drm/i915: fetch eDP configuration data from the VBT). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH 08/21] drm/i915: remove intel_guc::ads_engine_usage_size

2024-02-15 Thread Jiri Slaby (SUSE)
intel_guc::ads_engine_usage_size was never used since its addition in commit 77cdd054dd2c (drm/i915/pmu: Connect engine busyness stats from GuC to pmu). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc

[PATCH 06/21] drm/i915: remove intel_vgpu_workload::{ring_context, restore_inhibit}

2024-02-15 Thread Jiri Slaby (SUSE)
-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/scheduler.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/scheduler.h b/drivers/gpu/drm

[PATCH 05/21] drm/i915: remove intel_gvt_mmio_info::{device, addr_range}

2024-02-15 Thread Jiri Slaby (SUSE)
://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/mmio.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/mmio.h b

[PATCH 04/21] drm/i915: remove intel_gvt_gtt::{mm_alloc_page_table, mm_free_page_table}

2024-02-15 Thread Jiri Slaby (SUSE)
intel_gvt_gtt::{mm_alloc_page_table,mm_free_page_table} are not used since commit ede9d0cfcb78 (drm/i915/gvt: Rework shadow graphic memory management code). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc

[PATCH 00/21] drm/i915: remove unused structure members

2024-02-15 Thread Jiri Slaby (SUSE)
Hi, this series removes unused i915 structure members as found by clang-struct (and manually checked by me). Cc: intel-gfx@lists.freedesktop.org Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Jiri Slaby (SUSE) (21): drm/i915: remove unused intel_dvo_dev_ops hooks

[PATCH 02/21] drm/i915: remove structs intel_vgpu_pipe_format and intel_vgpu_fb_format

2024-02-15 Thread Jiri Slaby (SUSE)
Both struct intel_vgpu_pipe_format and intel_vgpu_fb_format were never used since its addition in commit 9f31d1063b43 (drm/i915/gvt: Add framebuffer decoder support). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas

[PATCH 01/21] drm/i915: remove unused intel_dvo_dev_ops hooks

2024-02-15 Thread Jiri Slaby (SUSE)
struct intel_dvo_dev_ops's ::create_resources(), ::prepare(), ::commit::, and get_modes() are all unused since their addition in 79e539453b34 (DRM: i915: add mode setting support). Drop all of them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc:

[PATCH 03/21] drm/i915: remove intel_dsi::{port_bits,hs}

2024-02-15 Thread Jiri Slaby (SUSE)
/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/display/intel_dsi.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH v2 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Jiri Slaby
~64 bytes per sentinel (further information Link : https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bombadil.infradead.org/) Remove sentinel from tty_table Signed-off-by: Joel Granados Reviewed-by: Jiri Slaby thanks, -- js suse labs

Re: [Intel-gfx] [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Jiri Slaby
On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Move abs_diff() to math.h

2023-07-23 Thread Jiri Slaby
On 21. 07. 23, 15:53, Andy Shevchenko wrote: abs_diff() belongs to math.h. Move it there. This will allow others to use it. Signed-off-by: Andy Shevchenko Reviewed-by: Jiri Slaby # tty/serial -- -- js suse labs

[Intel-gfx] [PATCH v2] drm/i915: remove circ_buf.h includes

2022-11-14 Thread Jiri Slaby (SUSE)
intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Jiri Slaby (SUSE) --- Notes: [v2] fixed e-mail setup drivers/gpu/drm/i915/display/intel_pipe_crc.c | 1 - drivers/gpu/drm/i915/i915_irq.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drive

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: fix randconfig build

2022-10-10 Thread Jiri Slaby
On 04. 10. 22, 12:52, Jani Nikula wrote: On Tue, 04 Oct 2022, "Jiri Slaby (SUSE)" wrote: When DRM_I915=y and BACKLIGHT_CLASS_DEVICE=m, the build fails: ld: drivers/gpu/drm/i915/display/intel_backlight.o: in function `intel_backlight_device_register': intel_backlight.

[Intel-gfx] [PATCH 1/2] drm/i915/display: fix randconfig build

2022-10-10 Thread Jiri Slaby (SUSE)
Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Reported-by: Martin Liška Signed-off-by: Jiri Slaby (SUSE) --- drivers/gpu/drm/i915/display/intel_backlight.c | 2 +-

[Intel-gfx] [PATCH 2/2] drm/i915: remove circ_buf.h includes

2022-10-10 Thread Jiri Slaby (SUSE)
intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Jiri Slaby (SUSE) --- drivers/gpu/drm/i915/display/intel_pipe_crc.c | 1 - drivers/gpu/drm/i915/i915_irq.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_pip

[Intel-gfx] [PATCH] drm/i915: remove circ_buf.h includes

2021-12-16 Thread Jiri Slaby
The last user of macros from that include was removed in 2018 by the commit below. Fixes: 6cc42152b02b ("drm/i915: Remove support for legacy debugfs crc interface") Signed-off-by: Jiri Slaby Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie

Re: [Intel-gfx] [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function

2020-08-20 Thread Jiri Slaby
On 19. 08. 20, 15:24, Gerd Hoffmann wrote: > On Wed, Aug 19, 2020 at 02:43:28PM +0200, Jiri Slaby wrote: >> On 09. 07. 20, 14:33, Daniel Vetter wrote: >>> Exactly matches the one in the helpers. >> >> It's not that exact. The order of modeset_enables and planes

Re: [Intel-gfx] [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function

2020-08-19 Thread Jiri Slaby
On 19. 08. 20, 14:43, Jiri Slaby wrote: > On 09. 07. 20, 14:33, Daniel Vetter wrote: >> Exactly matches the one in the helpers. > > It's not that exact. The order of modeset_enables and planes is > different. And this causes a regression -- no fb in qemu. > > So if

Re: [Intel-gfx] [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function

2020-08-19 Thread Jiri Slaby
On 09. 07. 20, 14:33, Daniel Vetter wrote: > Exactly matches the one in the helpers. It's not that exact. The order of modeset_enables and planes is different. And this causes a regression -- no fb in qemu. So if I run drm-tip, no fb. If I revert 73f15a9, it works. If I then switch the two calls

Re: [Intel-gfx] [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

2020-04-07 Thread Jiri Slaby
On 06. 07. 18, 22:30, Rodrigo Vivi wrote: > On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote: >> This was sort of annoying me: >> >> random:~$ dmesg | tail -1 >> [523884.039227] [drm] Reducing the compressed framebuffer size. This may >> lead to less power savings than a non-reduced-siz

Re: [Intel-gfx] [PATCH] drm/i915: disable KASAN for handlers

2017-07-17 Thread Jiri Slaby
On 03/31/2017, 01:23 PM, Arnd Bergmann wrote: > On Fri, Mar 31, 2017 at 12:29 PM, Jani Nikula > wrote: >> On Fri, 31 Mar 2017, Zhenyu Wang wrote: >>> On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >>>> Handlers are currently the only blocker to compile the ker

[Intel-gfx] [PATCH] drm/i915: disable KASAN for handlers

2017-03-30 Thread Jiri Slaby
. INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an offset. There are too many for KASAN to keep up. So disable KASAN for this file. Signed-off-by: Jiri Slaby Cc: Martin Liska Cc: Zhenyu Wang Cc: Zhi Wang Cc: Daniel Vetter Cc: Jani Nikula Cc: David Airlie Cc: intel-gvt

[Intel-gfx] [PATCH 3.12 014/113] drm/i915: Don't leak edid in intel_crt_detect_ddc()

2017-03-06 Thread Jiri Slaby
kula Link: http://patchwork.freedesktop.org/patch/msgid/1484922525-6131-1-git-send-email-ander.conselvan.de.olive...@intel.com (cherry picked from commit c96b63a6a7ac4bd670ec2e663793a9a31418b790) Signed-off-by: Jani Nikula Signed-off-by: Jiri Slaby --- drivers/gpu/drm/i915/intel_crt.c | 9 ++

[Intel-gfx] [patch added to 3.12-stable] drm/i915: Don't leak edid in intel_crt_detect_ddc()

2017-02-16 Thread Jiri Slaby
Reviewed-by: Jani Nikula Link: http://patchwork.freedesktop.org/patch/msgid/1484922525-6131-1-git-send-email-ander.conselvan.de.olive...@intel.com (cherry picked from commit c96b63a6a7ac4bd670ec2e663793a9a31418b790) Signed-off-by: Jani Nikula Signed-off-by: Jiri Slaby --- drivers/gp

[Intel-gfx] 3.9.0-rc7-next: i915: render error detected

2013-04-19 Thread Jiri Slaby
Hi, with today's -next I got this: [drm] capturing error event; look for more information in /sys/kernel/debug/dri/0/i915_error_state i915: render error detected, EIR: 0x0010 i915: page table error i915: PGTBL_ER: 0x0002 [drm:i915_report_and_clear_eir] *ERROR* EIR stuck: 0x0010, mask