Daniel Thompson
> Signed-off-by: Sinan Kaya
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/video/backlight/apple_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/apple_bl.c
> b/drivers/video/backlight/appl
On Thursday, August 28, 2014 1:33 PM, Sonika Sonika wrote:
> On 8/28/2014 6:25 AM, Jingoo Han wrote:
> > On Friday, August 08, 2014 7:54 PM, Sonika Jindal wrote:
> >>
> >> From: Sonika Jindal
> >>
> >> Rename the defines to have levels instead of valu
s a rule when submitting patches.
Please, fix it as follows.
+ buf[lane] = DP_TRAIN_PRE_EMPHASIS_LEVEL_0|
+ DP_TRAIN_VOLTAGE_SWING_LEVEL_0;
Best regards,
Jingoo Han
>
> retval = exynos_dp_write_bytes_to_dpcd(dp, DP_TRAINING_LANE0_SET,
> lane_count, buf);
> --
> 1.7.10
gt; > macros for each value seems isn't either.
> >
> I feel _LEVEL_* makes it more readable and since there are only 4 values
> possible, it is ok to have 4 different macros for readability purpose.
> What do you think?
(+cc Damien Lespiau)
P
you said at '[PATCH 0/6] Rename DP
training vswing/pre-emph defines'.
Best regards.
Jingoo Han
>
> Signed-off-by: Sonika Jindal
> ---
> include/drm/drm_dp_helper.h | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git
ank you.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> include/drm/drm_dp_helper.h | 78
> +
> 1 file changed, 78 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index c
en 'DP MST' and '1.2 MST'?
If there is no difference, would you use the same comment
as below?
+# define DP_DOWN_REP_MSG_RDY (1 << 4) /* 1.2 MST */
+# define DP_UP_REQ_MSG_RDY (1 << 5) /* 1.2 MST */
Best regards,
Jingoo Han
[.]
__
