Re: [Intel-gfx] [PATCH v5 22/22] drm/sun4i: tv: Convert to the new TV mode property

2022-10-17 Thread Jernej Škrabec
Dne petek, 14. oktober 2022 ob 09:38:10 CEST je Maxime Ripard napisal(a): > Hi Jernej, > > On Thu, Oct 13, 2022 at 08:23:51PM +0200, Jernej Škrabec wrote: > > Dne četrtek, 13. oktober 2022 ob 15:19:06 CEST je Maxime Ripard napisal(a): > > > Now that the core can deal f

Re: [Intel-gfx] [PATCH v5 22/22] drm/sun4i: tv: Convert to the new TV mode property

2022-10-17 Thread Jernej Škrabec
Hi Maxime, Dne četrtek, 13. oktober 2022 ob 15:19:06 CEST je Maxime Ripard napisal(a): > Now that the core can deal fine with analog TV modes, let's convert the > sun4i TV driver to leverage those new features. > > Acked-by: Noralf Trønnes > Signed-off-by: Maxime Ripard > > --- > Changes in v5

Re: [Intel-gfx] [PATCH v2 37/41] drm/sun4i: tv: Remove useless function

2022-09-12 Thread Jernej Škrabec
Dne ponedeljek, 29. avgust 2022 ob 15:11:51 CEST je Maxime Ripard napisal(a): > The drm_connector_to_sun4i_tv() function isn't used anywhere in the driver, > so let's remove it. > > Signed-off-by: Maxime Ripard Acked-by: Jernej Skrabec Best regards, Jernej

Re: [Intel-gfx] [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable

2022-09-12 Thread Jernej Škrabec
Dne sreda, 07. september 2022 ob 09:41:34 CEST je Maxime Ripard napisal(a): > On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej Škrabec wrote: > > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard napisal(a): > > > Our mode_set implementation can be merged into

Re: [Intel-gfx] [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable

2022-09-12 Thread Jernej Škrabec
Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard napisal(a): > Our mode_set implementation can be merged into our atomic_enable > implementation to simplify things, so let's do this. Are you sure this is a good thing in long term? What if user wants to change mode? Unlikely, but

Re: [Intel-gfx] [PATCH v2 35/41] drm/sun4i: tv: Convert to atomic hooks

2022-09-12 Thread Jernej Škrabec
Dne ponedeljek, 29. avgust 2022 ob 15:11:49 CEST je Maxime Ripard napisal(a): > The sun4i TV driver still uses legacy enable and disable hook > implementation. Let's convert to the atomic variants. > > Signed-off-by: Maxime Ripard Acked-by: Jernej Skrabec BTW, I suggest you merge fixes/cleanup

Re: [Intel-gfx] [PATCH] gpu: move from strlcpy with unused retval to strscpy

2022-08-29 Thread Jernej Škrabec
Dne četrtek, 18. avgust 2022 ob 23:00:07 CEST je Wolfram Sang napisal(a): > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: > https://lore.kernel.org/r/CAHk-=wgfRnXz0

Re: [Intel-gfx] [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default

2021-05-21 Thread Jernej Škrabec
Dne petek, 21. maj 2021 ob 11:09:54 CEST je Daniel Vetter napisal(a): > No need to set it explicitly. > > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Phi

Re: [Intel-gfx] [v3, 4/5] drm/connector: Add a helper to attach the colorspace property

2021-05-07 Thread Jernej Škrabec
Hi! Dne petek, 30. april 2021 ob 11:44:50 CEST je Maxime Ripard napisal(a): > The intel driver uses the same logic to attach the Colorspace property > in multiple places and we'll need it in vc4 too. Let's move that common > code in a helper. > > Signed-off-by: Maxime Ripard > --- > > Changes f

Re: [Intel-gfx] [v3, 5/5] drm/vc4: hdmi: Signal the proper colorimetry info in the infoframe

2021-05-07 Thread Jernej Škrabec
Hi! Dne petek, 30. april 2021 ob 11:44:51 CEST je Maxime Ripard napisal(a): > Our driver while supporting HDR didn't send the proper colorimetry info > in the AVI infoframe. > > Let's add the property needed so that the userspace can let us know what > the colorspace is supposed to be. > > Signe

Re: [Intel-gfx] [PATCH v6 20/24] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-08-09 Thread Jernej Škrabec
Hi! Dne petek, 26. julij 2019 ob 19:23:14 CEST je Andrzej Pietrasiewicz napisal(a): > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Jernej Skrabec Thanks! Best regards, Jernej > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6