Re: [PATCH] fbdev: Introduce devm_register_framebuffer()

2024-08-30 Thread Helge Deller
On 8/30/24 12:16, Helge Deller wrote: On 8/30/24 11:45, Thomas Weißschuh wrote: Introduce a device-managed variant of register_framebuffer() which automatically unregisters the framebuffer on device destruction. This can simplify the error handling and resource management in drivers. Signed

Re: [PATCH] fbdev: Introduce devm_register_framebuffer()

2024-08-30 Thread Helge Deller
On 8/30/24 11:45, Thomas Weißschuh wrote: Introduce a device-managed variant of register_framebuffer() which automatically unregisters the framebuffer on device destruction. This can simplify the error handling and resource management in drivers. Signed-off-by: Thomas Weißschuh --- This is a fi

Re: [PATCH v4 6/6] fbdev/viafb: Make I2C terminology more inclusive

2024-07-11 Thread Helge Deller
On 7/11/24 07:27, Easwar Hariharan wrote: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage e

Re: [PATCH v4 5/6] fbdev/smscufx: Make I2C terminology more inclusive

2024-07-11 Thread Helge Deller
On 7/11/24 07:27, Easwar Hariharan wrote: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage e

Re: [Intel-gfx] [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support

2023-11-19 Thread Helge Deller
On 11/19/23 21:51, Heiner Kallweit wrote: On 19.11.2023 21:48, Heiner Kallweit wrote: On 19.11.2023 21:28, Helge Deller wrote: On 11/19/23 12:28, Heiner Kallweit wrote: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver

Re: [Intel-gfx] [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support

2023-11-19 Thread Helge Deller
emove this class completely now. Preferably this series should be applied via the i2c tree. The fbdev changes look at least ok so far, so: Acked-by: Helge Deller#fbdev v2: - change tag in commit subject of patch 03 - add ack tags v3: - fix a compile error in patch 5 Signed-off-by: Heine

Re: [Intel-gfx] [linux-next:master] BUILD REGRESSION e1f6a8eaf1c271a0158114a03e3605f4fba059ad

2023-07-05 Thread Helge Deller
On 7/5/23 18:07, kernel test robot wrote: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e1f6a8eaf1c271a0158114a03e3605f4fba059ad Add linux-next specific files for 20230705 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/2023

Re: [Intel-gfx] linux-next: manual merge of the fbdev tree with the drm-misc tree

2023-01-16 Thread Helge Deller
On 1/16/23 01:54, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the fbdev tree got a conflict in: include/linux/fb.h between commit: 5b6373de4351 ("drm/fbdev: Remove aperture handling and FBINFO_MISC_FIRMWARE") from the drm-misc tree and commit: 72ac3535c2c5 ("fbdev:

Re: [Intel-gfx] [PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2022-07-04 Thread Helge Deller
ch resolutions. Furthermore, with the upcoming patches to fbcon (which prevents crashes on invalid userspace input), you will face a kernel WARNING if you call fbset to switch screen resolutions with DRM drivers. So, from my side (although I'd prefer a better fix for DRM): Acked-by:

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 14:45, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 12:01 PM Helge Deller wrote: >> On 2/1/22 11:36, Daniel Vetter wrote: >>> On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: >>>> >>>> On 1/31/22 22:05, Daniel Vetter wrote: >>&

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 11:36, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: >> >> On 1/31/22 22:05, Daniel Vetter wrote: >>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated >>> scrolling"), but behind the FRAMEBU

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Helge Deller
s group maintained, I expect that to continue like > we've done before, so no new expectations that patches all go through > my hands. That would be silly. This also means I'm happy to put any > other volunteer's name in the M: line, but otherwise git log says I'm &

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 1/31/22 22:05, Daniel Vetter wrote: > This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated > scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION > option. you have two trivial copy-n-paste errors in this patch which still prevent the console acceleration. > diff -

Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 11:16, Helge Deller wrote: > On 1/31/22 22:05, Daniel Vetter wrote: >> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated >> scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION >> option. > > you have two trivial co

Re: [Intel-gfx] [PATCH v4 7/9] parisc/perf: open access for CAP_SYS_PERFMON privileged process

2020-01-27 Thread Helge Deller
iscouraged with respect to CAP_SYS_PERFMON capability. > > Signed-off-by: Alexey Budankov Acked-by: Helge Deller > --- > arch/parisc/kernel/perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/parisc/kernel/perf.c b/arch/parisc/kernel/perf.

[Intel-gfx] [PATCH 05/14] i915: Use %pS printk format for direct addresses

2017-09-27 Thread Helge Deller
Use the %pS printk format for printing symbols from direct addresses. This is important for the ia64, ppc64 and parisc64 architectures, while on other architectures there is no difference between %pS and %pF. Fix it for consistency across the kernel. Signed-off-by: Helge Deller Cc: Jani Nikula