Re: [Intel-gfx] [PATCH 7/7] drm/i915: Enable GGTT updates with binder in MTL

Hi Nirmoy, https://gfxspecs.intel.com/Predator/Home/Index/52885?dstFilter=MTL&mode=Filter I can't find Wa_13010847436 and Wa_14019519902 in the above link, where can I check these WA? Br, G.G. On 9/18/23 8:02 PM, Nirmoy Das wrote: MTL can hang because of a HW bug while parallel reading/wri

Re: [Intel-gfx] [PATCH v3 0/2] Fix error propagation amongst request

Hi Andi, After applying these two patches, deadlock is being detected in the call stack below. Please review whether the patch to update the intel_context_migrate_copy() part affected the deadlock. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114451v1/bat-dg2-8/igt@i915_module_l...@loa

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

On 2/2/23 11:28 AM, Andi Shyti wrote: Hi GG, On Thu, Feb 02, 2023 at 10:22:30AM +0200, Gwan-gyeong Mun wrote: Hi Andi, You gave a lot of explanations, and confirmed that this patch solves the problem, but the root cause of this problem still seems to be unclear. In the logs where this

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Enable PL1 power limit

looks good to me, but could you please add bpsec# to commit log? Reviewed-by: Gwan-gyeong Mun On 2/2/23 4:52 AM, Ashutosh Dixit wrote: Previous documentation suggested that PL1 power limit is always enabled. However we now find this not to be the case on some platforms (such as ATSM

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

Hi Andi, You gave a lot of explanations, and confirmed that this patch solves the problem, but the root cause of this problem still seems to be unclear. In the logs where this problem was reported, the logs were output in the following order. link : https://intel-gfx-ci.01.org/tree/drm-ti

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

On 1/27/23 11:00 AM, Andi Shyti wrote: Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan 2023, Andi Shyti wrote: From: Aravind Iddamsetty During module load not all the punit transaction have completed and we might end up timing out, as shown by the following warn

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use "%zu" to format size_t

This fix has nothing to do with IGT Possible regression. This fixes the code that raised build warnings in 32-bit environments. And this patch has been merged. On 12/30/22 9:37 PM, Patchwork wrote: *Patch Details* *Series:* drm/i915: Use "%zu" to format size_t *URL:* https://patchwork.fr

Re: [Intel-gfx] [PATCH] drm/i915: Use "%zu" to format size_t

Nirmoy, thanks for fixing it Reviewed-by: Gwan-gyeong Mun On 12/30/22 8:35 PM, Nirmoy Das wrote: Switch to %zu for printing size_t which will fix compilation warning for 32-bit build. Reported-by: kernel test robot Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

On 12/28/22 9:51 PM, Patchwork wrote: == Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112279/ State : warning == Summary == Error: dim checkpa

[Intel-gfx] [PATCH v16 5/6] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

Wilson Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH v16 6/6] drm/i915: Remove truncation warning for large objects

warning put in place to remind us to complete the review. Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Testcase: igt@gem_create@create-massive Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991 Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun

[Intel-gfx] [PATCH v16 3/6] drm/i915: Check for integer truncation on the configuration of ttm place

to two steps, first overflow check, and second assignment. Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Cc: Jani Nikula Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Reported-by: kernel test robot Reviewed-by: Andrzej Hajda

[Intel-gfx] [PATCH v16 4/6] drm/i915: Check if the size is too big while creating shmem file

32, size > MAX_LFS_FILESIZE is always false, so it checks only when BITS_PER_LONG is 64. Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reported-by: kernel test robot Reviewed-by: Andr

[Intel-gfx] [PATCH v16 2/6] drm/i915: Check for integer truncation on scatterlist creation

Gwan-gyeong Mun Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda Acked-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 7 +-- drivers/gpu/drm/i915/gem/i915_gem_object.h | 3 --- driver

[Intel-gfx] [PATCH v16 1/6] drm/i915/gem: Typecheck page lookups

ve an unnecessary header include line. (G.G) v16: Fix "ERROR:SPACING" Checkpatch report (G.G) Cc: Tvrtko Ursulin Cc: Matthew Auld Cc: Thomas Hellström Cc: Kees Cook Signed-off-by: Chris Wilson Co-developed-by: Gwan-gyeong Mun Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das (v2) Rev

[Intel-gfx] [PATCH v16 0/6] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

Remove truncation warning for large objects Gwan-gyeong Mun (3): drm/i915: Check for integer truncation on the configuration of ttm place drm/i915: Check if the size is too big while creating shmem file drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

[Intel-gfx] [PATCH v15 6/6] drm/i915: Remove truncation warning for large objects

warning put in place to remind us to complete the review. Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Testcase: igt@gem_create@create-massive Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991 Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun

[Intel-gfx] [PATCH v15 5/6] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

Wilson Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH v15 4/6] drm/i915: Check if the size is too big while creating shmem file

32, size > MAX_LFS_FILESIZE is always false, so it checks only when BITS_PER_LONG is 64. Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reported-by: kernel test robot Reviewed-by: Andr

[Intel-gfx] [PATCH v15 3/6] drm/i915: Check for integer truncation on the configuration of ttm place

to two steps, first overflow check, and second assignment. Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Cc: Jani Nikula Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Reported-by: kernel test robot Reviewed-by: Andrzej Hajda

[Intel-gfx] [PATCH v15 0/6] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

t/?id=4b21d25bf519c9487935a664886956bb18f04f6d [2] https://patchwork.freedesktop.org/series/111963/ Chris Wilson (3): drm/i915/gem: Typecheck page lookups drm/i915: Check for integer truncation on scatterlist creation drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun (3): drm/i915: Check for in

[Intel-gfx] [PATCH v15 2/6] drm/i915: Check for integer truncation on scatterlist creation

citly overflow check where the scatterlist creation APIs are called. (Jani) v15: Add missing returning of error code when the WARN_ON() has been detected. (Jani) Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Co-developed-by: Gwan-gyeong Mun Signed-off-by:

[Intel-gfx] [PATCH v15 1/6] drm/i915/gem: Typecheck page lookups

ve an unnecessary header include line. (G.G) Cc: Tvrtko Ursulin Cc: Matthew Auld Cc: Thomas Hellström Cc: Kees Cook Co-developed-by: Gwan-gyeong Mun Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Reviewed-by: Andrzej

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reset twice

re get proper WA guidance as a next step. Reviewed-by: Gwan-gyeong Mun Br, G.G. Thank you, Andi

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reset twice

On 12/15/22 10:07 PM, Rodrigo Vivi wrote: On Wed, Dec 14, 2022 at 11:37:19PM +0100, Andi Shyti wrote: Hi Rodrigo, On Tue, Dec 13, 2022 at 01:18:48PM +, Vivi, Rodrigo wrote: On Tue, 2022-12-13 at 00:08 +0100, Andi Shyti wrote: Hi Rodrigo, On Mon, Dec 12, 2022 at 11:55:10AM -0500, Rodri

Re: [Intel-gfx] [PATCH v15 1/7] overflow: Introduce overflows_type() and castable_to_type()

On 12/15/22 5:09 PM, Andrzej Hajda wrote: On 15.12.2022 13:52, Gwan-gyeong Mun wrote: From: Kees Cook Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert

[Intel-gfx] [PATCH v15 7/7] drm/i915: Remove truncation warning for large objects

warning put in place to remind us to complete the review. Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Testcase: igt@gem_create@create-massive Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991 Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun

[Intel-gfx] [PATCH v15 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

Wilson Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH v15 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

to two steps, first overflow check, and second assignment. Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Cc: Jani Nikula Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Reported-by: kernel test robot Reviewed-by: Andrzej Hajda

[Intel-gfx] [PATCH v15 5/7] drm/i915: Check if the size is too big while creating shmem file

32, size > MAX_LFS_FILESIZE is always false, so it checks only when BITS_PER_LONG is 64. Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reported-by: kernel test robot Reviewed-by: Andr

[Intel-gfx] [PATCH v15 3/7] drm/i915: Check for integer truncation on scatterlist creation

citly overflow check where the scatterlist creation APIs are called. (Jani) v15: Add missing returning of error code when the WARN_ON() has been detected. (Jani) Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Co-developed-by: Gwan-gyeong Mun Signed-off-by:

[Intel-gfx] [PATCH v15 2/7] drm/i915/gem: Typecheck page lookups

ve an unnecessary header include line. (G.G) Cc: Tvrtko Ursulin Cc: Matthew Auld Cc: Thomas Hellström Cc: Kees Cook Co-developed-by: Gwan-gyeong Mun Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Reviewed-by: Andrzej

[Intel-gfx] [PATCH v15 1/7] overflow: Introduce overflows_type() and castable_to_type()

enryck Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Tom Rix Cc: Daniel Latypov Cc: Vitor Massaru Iha Cc: "Gustavo A. R. Silva" Cc: Jani Nikula Cc: Mauro Carvalho Chehab Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-by: Gwan-gyeong Mun Signed-off-by: Gwa

[Intel-gfx] [PATCH v15 0/7] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

creation drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun (3): drm/i915: Check for integer truncation on the configuration of ttm place drm/i915: Check if the size is too big while creating shmem file drm/i915: Use error code as -E2BIG when the size of gem ttm object i

Re: [Intel-gfx] [PATCH v14 3/7] drm/i915: Check for integer truncation on scatterlist creation

On 11/2/22 4:53 PM, Gwan-gyeong Mun wrote: From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev2)

On 11/3/22 9:07 AM, Patchwork wrote: *Patch Details* *Series:* Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev2) *URL:* https://patchwork.freedesktop.org/series/110413/

Re: [Intel-gfx] [PATCH v14 1/7] overflow: Introduce overflows_type() and castable_to_type()

This patch has merged to linux-next. On 11/2/22 4:53 PM, Gwan-gyeong Mun wrote: From: Kees Cook Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert() (which

[Intel-gfx] [PATCH v14 7/7] drm/i915: Remove truncation warning for large objects

warning put in place to remind us to complete the review. Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Testcase: igt@gem_create@create-massive Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991 Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun

[Intel-gfx] [PATCH v14 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

Wilson Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH v14 5/7] drm/i915: Check if the size is too big while creating shmem file

32, size > MAX_LFS_FILESIZE is always false, so it checks only when BITS_PER_LONG is 64. Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reported-by: kernel test robot Reviewed-by: Andr

[Intel-gfx] [PATCH v14 3/7] drm/i915: Check for integer truncation on scatterlist creation

citly overflow check where the scatterlist creation APIs are called. (Jani) Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Co-developed-by: Gwan-gyeong Mun Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das Reviewed-by:

[Intel-gfx] [PATCH v14 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

to two steps, first overflow check, and second assignment. Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Cc: Jani Nikula Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Reported-by: kernel test robot Reviewed-by: Andrzej Hajda

[Intel-gfx] [PATCH v14 1/7] overflow: Introduce overflows_type() and castable_to_type()

enryck Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Tom Rix Cc: Daniel Latypov Cc: Vitor Massaru Iha Cc: "Gustavo A. R. Silva" Cc: Jani Nikula Cc: Mauro Carvalho Chehab Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-by: Gwan-gyeong Mun Signed-off-by: Gwa

[Intel-gfx] [PATCH v14 2/7] drm/i915/gem: Typecheck page lookups

ve an unnecessary header include line. (G.G) Cc: Tvrtko Ursulin Cc: Matthew Auld Cc: Thomas Hellström Cc: Kees Cook Co-developed-by: Gwan-gyeong Mun Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Reviewed-by: Andrzej

[Intel-gfx] [PATCH v14 0/7] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

ypecheck page lookups drm/i915: Check for integer truncation on scatterlist creation drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun (3): drm/i915: Check for integer truncation on the configuration of ttm place drm/i915: Check if the size is too big while creati

[Intel-gfx] [PATCH v14 0/7] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

ypecheck page lookups drm/i915: Check for integer truncation on scatterlist creation drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun (3): drm/i915: Check for integer truncation on the configuration of ttm place drm/i915: Check if the size is too big while creati

Re: [Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

On 11/2/22 1:06 AM, Kees Cook wrote: On Sat, Oct 29, 2022 at 11:01:38AM +0300, Gwan-gyeong Mun wrote: On 10/29/22 10:32 AM, Kees Cook wrote: On Sat, Oct 29, 2022 at 08:55:43AM +0300, Gwan-gyeong Mun wrote: Hi Kees, Hi! :) I've updated to v5 with the last comment of Nathan. Coul

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

On 11/2/22 8:32 AM, Joonas Lahtinen wrote: Quoting Jani Nikula (2022-10-28 11:46:21) On Fri, 28 Oct 2022, Gwan-gyeong Mun wrote: Resend, because some content was accidentally omitted from the previous reply. Please ignore the previous email. Hi all, I should have written the original

Re: [Intel-gfx] [PATCH v2] drm/i915/hwmon: Fix a build error used with clang compiler

On 10/31/22 7:19 AM, Dixit, Ashutosh wrote: On Fri, 28 Oct 2022 21:42:30 -0700, Gwan-gyeong Mun wrote: diff --git a/drivers/gpu/drm/i915/i915_hwmon.c b/drivers/gpu/drm/i915/i915_hwmon.c index 9e9781493025..c588a17f97e9 100644 --- a/drivers/gpu/drm/i915/i915_hwmon.c +++ b/drivers/gpu/drm

Re: [Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

On 10/29/22 10:32 AM, Kees Cook wrote: On Sat, Oct 29, 2022 at 08:55:43AM +0300, Gwan-gyeong Mun wrote: Hi Kees, Hi! :) I've updated to v5 with the last comment of Nathan. Could you please kindly review what more is needed as we move forward with this patch? It looks fine to me

Re: [Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

Hi Kees, I've updated to v5 with the last comment of Nathan. Could you please kindly review what more is needed as we move forward with this patch? Br, G.G. On 10/24/22 11:11 PM, Gwan-gyeong Mun wrote: From: Kees Cook Implement a robust overflows_type() macro to test if a variab

[Intel-gfx] [PATCH v2] drm/i915/hwmon: Fix a build error used with clang compiler

v2: Use REG_FIELD_PREP() macro instead of FIELD_PREP() (Jani) Fixes: 99f55efb7911 ("drm/i915/hwmon: Power PL1 limit and TDP setting") Cc: Ashutosh Dixit Cc: Anshuman Gupta Cc: Andi Shyti Cc: Jani Nikula Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/i915_hwmon.c | 12 +++-

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

Resend, because some content was accidentally omitted from the previous reply. Please ignore the previous email. Hi all, I should have written the original commit message more accurately, but it seems that it was written inaccurately. If the FIELD_PREP macro is expanded, the following macros

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

Hi all, I should have written the commit message more accurately, but it seems that it was written inaccurately. If the FIELD_PREP macro is expanded, the following macros are used. #define FIELD_PREP(_mask, _val) \ ({

[Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

: note: expanded from macro '__compiletime_assert' if (!(condition)) \ Fixes: 99f55efb7911 ("drm/i915/hwmon: Power PL1 limit and TDP setting") Cc: Ashutosh Dixit Cc: Anshuman Gupta Cc: Andi Shyti Signed-off-by: Gwan-gyeong Mun

[Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

ab Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-by: Gwan-gyeong Mun Signed-off-by: Gwan-gyeong Mun Signed-off-by: Kees Cook --- v5: drop the cc-disable-warning and just disable the warning directly (Nathan) v4: - move version v2 changelog commit message to under t

[Intel-gfx] [PATCH v4] overflow: Introduce overflows_type() and castable_to_type()

ab Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-by: Gwan-gyeong Mun Signed-off-by: Gwan-gyeong Mun Signed-off-by: Kees Cook --- v4: - move version v2 changelog commit message to under the --- marker (Mauro) - remove the #pragma addition in the code and modify the Ma

[Intel-gfx] [PATCH v3] overflow: Introduce overflows_type() and castable_to_type()

assaru Iha Cc: "Gustavo A. R. Silva" Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-by: Gwan-gyeong Mun Signed-off-by: Gwan-gyeong Mun Signed-off-by: Kees Cook --- drivers/gpu/drm/i915/i915_user_extensions.c | 2 +- drivers/gpu/drm/i915/i915_utils.h

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

On 9/28/22 8:09 PM, Linus Torvalds wrote: On Wed, Sep 28, 2022 at 1:15 AM Gwan-gyeong Mun wrote: + if (check_assign(obj->base.size >> PAGE_SHIFT, &npages)) + return -E2BIG; I have to say, I find that new "check_assign()" macro use to be disgust

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

Linus and Kees, I also understood that I should not make and use the macro that performs assignment and checking at the same time, and I will drop it and update it. Kees, the overflows_type() macro had several updates as input from you and the community, and there is an advantage when moving t

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

On 9/28/22 11:51 AM, Jani Nikula wrote: On Wed, 28 Sep 2022, Gwan-gyeong Mun wrote: diff --git a/drivers/gpu/drm/i915/i915_scatterlist.h b/drivers/gpu/drm/i915/i915_scatterlist.h index 9ddb3e743a3e..1d1802beb42b 100644 --- a/drivers/gpu/drm/i915/i915_scatterlist.h +++ b/drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915/gt: Remove unused function prototype

Remove unused function prototype; intel_gt_create_kobj() Cc: Andi Shyti Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sysfs.h b/drivers/gpu/drm/i915/gt/intel_gt_sysfs.h index

Re: [Intel-gfx] [PATCH v2] overflow: Introduce overflows_type() and castable_to_type()

d_overflow (type1 a, type2 b, Cc: Luc Van Oostenryck Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Tom Rix Cc: Daniel Latypov Cc: Vitor Massaru Iha Cc: "Gustavo A. R. Silva" Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-by: Gwan-gyeong Mun Signed-off

[Intel-gfx] [PATCH v13 9/9] drm/i915: Remove truncation warning for large objects

warning put in place to remind us to complete the review. Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Testcase: igt@gem_create@create-massive Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991

[Intel-gfx] [PATCH v13 8/9] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH v13 7/9] drm/i915: Check if the size is too big while creating shmem file

32, size > MAX_LFS_FILESIZE is always false, so it checks only when BITS_PER_LONG is 64. Signed-off-by: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reported-by: kernel test robot Reviewed-by: Andr

[Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

macro into drm_util header (Jani N) v5: Fix macros to be enclosed in parentheses for complex values Fix too long line warning v8: Replace safe_conversion() with check_assign() (Kees) Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld

[Intel-gfx] [PATCH v13 6/9] drm/i915: Check for integer truncation on the configuration of ttm place

() macro call from safe_conversion_gem_bug_on() v6: Fix to follow general use case for GEM_BUG_ON(). (Jani) v7: Fix to use WARN_ON() macro where GEM_BUG_ON() macro was used. (Jani) v8: Replace safe_conversion() with check_assign() (Kees) Signed-off-by: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew

[Intel-gfx] [PATCH v13 2/9] overflow: Introduce check_assign() and check_assign_user_ptr()

_type() macro will be added in a subsequent patch (G.G) Signed-off-by: Gwan-gyeong Mun Cc: Thomas Hellström Cc: Matthew Auld Cc: Nirmoy Das Cc: Jani Nikula Cc: Andi Shyti Cc: Andrzej Hajda Cc: Mauro Carvalho Chehab Cc: Kees Cook Reviewed-by: Mauro Carvalho Chehab (v5) Reviewed-by: An

[Intel-gfx] [PATCH v13 1/9] overflow: Allow mixed type arguments

org Signed-off-by: Kees Cook Signed-off-by: Gwan-gyeong Mun Reviewed-by: Andrzej Hajda Reviewed-by: Gwan-gyeong Mun Tested-by: Gwan-gyeong Mun --- include/linux/overflow.h | 72 lib/overflow_kunit.c | 101 --- 2 files ch

[Intel-gfx] [PATCH v13 4/9] drm/i915/gem: Typecheck page lookups

ve an unnecessary header include line. (G.G) Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Matthew Auld Cc: Thomas Hellström Cc: Kees Cook Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Reviewed-by: Andrzej Hajda (v5) --- drivers/gpu/drm

[Intel-gfx] [PATCH v13 3/9] overflow: Introduce overflows_type() and castable_to_type()

.@lists.linux.dev Co-developed-by: Gwan-gyeong Mun Signed-off-by: Gwan-gyeong Mun Signed-off-by: Kees Cook --- drivers/gpu/drm/i915/i915_utils.h | 4 - include/linux/compiler.h | 1 + include/linux/overflow.h | 48 lib/overflow_kunit.c | 388 +

[Intel-gfx] [PATCH v13 0/9] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

5/gem: Typecheck page lookups drm/i915: Check for integer truncation on scatterlist creation drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun (4): overflow: Introduce check_assign() and check_assign_user_ptr() drm/i915: Check for integer truncation on the configuration o

Re: [Intel-gfx] [PATCH v2] overflow: Introduce overflows_type() and castable_to_type()

Built-in Function: bool __builtin_add_overflow (type1 a, type2 b, Cc: Luc Van Oostenryck Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Tom Rix Cc: Daniel Latypov Cc: Vitor Massaru Iha Cc: "Gustavo A. R. Silva" Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-b

Re: [Intel-gfx] [PATCH v11.5] overflow: Introduce overflows_type() and __castable_to_type()

atypov Cc: Vitor Massaru Iha Cc: "Gustavo A. R. Silva" Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-by: Gwan-gyeong Mun Signed-off-by: Gwan-gyeong Mun Signed-off-by: Kees Cook --- include/linux/compiler.h | 1 + include/linux/overflow.h | 48 +

[Intel-gfx] [PATCH v12 9/9] drm/i915: Remove truncation warning for large objects

warning put in place to remind us to complete the review. Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Testcase: igt@gem_create@create-massive Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991

[Intel-gfx] [PATCH v12 8/9] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH v12 7/9] drm/i915: Check if the size is too big while creating shmem file

32, size > MAX_LFS_FILESIZE is always false, so it checks only when BITS_PER_LONG is 64. Signed-off-by: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reported-by: kernel test robot Reviewed-by: Andr

[Intel-gfx] [PATCH v12 6/9] drm/i915: Check for integer truncation on the configuration of ttm place

() macro call from safe_conversion_gem_bug_on() v6: Fix to follow general use case for GEM_BUG_ON(). (Jani) v7: Fix to use WARN_ON() macro where GEM_BUG_ON() macro was used. (Jani) v8: Replace safe_conversion() with check_assign() (Kees) Signed-off-by: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew

[Intel-gfx] [PATCH v12 5/9] drm/i915: Check for integer truncation on scatterlist creation

macro into drm_util header (Jani N) v5: Fix macros to be enclosed in parentheses for complex values Fix too long line warning v8: Replace safe_conversion() with check_assign() (Kees) Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld

[Intel-gfx] [PATCH v12 4/9] drm/i915/gem: Typecheck page lookups

off_t() macro. (Kees) v11: Change the use of assert_typable to assert_same_typable (G.G) v12: Change to use static_assert(__castable_to_type(n ,T)) style since the assert_same_typable() macro has been dropped. (G.G) Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursuli

[Intel-gfx] [PATCH v12 2/9] overflow: Introduce check_assign() and check_assign_user_ptr()

_type() macro will be added in a subsequent patch (G.G) Signed-off-by: Gwan-gyeong Mun Cc: Thomas Hellström Cc: Matthew Auld Cc: Nirmoy Das Cc: Jani Nikula Cc: Andi Shyti Cc: Andrzej Hajda Cc: Mauro Carvalho Chehab Cc: Kees Cook Reviewed-by: Mauro Carvalho Chehab (v5) Reviewed-by: An

[Intel-gfx] [PATCH v12 3/9] overflow: Introduce overflows_type() and __castable_to_type()

Cc: Nick Desaulniers Cc: Tom Rix Cc: Daniel Latypov Cc: Vitor Massaru Iha Cc: "Gustavo A. R. Silva" Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Cc: Thomas Hellström Cc: Matthew Auld Cc: Nirmoy Das Cc: Andi Shyti Cc: Andrzej Hajda Cc: Mauro Carvalho Chehab Co-developed

[Intel-gfx] [PATCH v12 1/9] overflow: Allow mixed type arguments

org Signed-off-by: Kees Cook Signed-off-by: Gwan-gyeong Mun Reviewed-by: Andrzej Hajda Reviewed-by: Gwan-gyeong Mun Tested-by: Gwan-gyeong Mun --- include/linux/overflow.h | 72 lib/overflow_kunit.c | 101 --- 2 files ch

[Intel-gfx] [PATCH v12 0/9] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

emove temporal SAFE_CONVERSION() macro. (G.G.) Chris Wilson (3): drm/i915/gem: Typecheck page lookups drm/i915: Check for integer truncation on scatterlist creation drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun (4): overflow: Introduce check_assign() and check_as

Re: [Intel-gfx] [PATCH v11.5] overflow: Introduce overflows_type() and __castable_to_type()

a, type2 b, type3 *res) Cc: Luc Van Oostenryck Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Tom Rix Cc: Daniel Latypov Cc: Vitor Massaru Iha Cc: "Gustavo A. R. Silva" Cc: linux-harden...@vger.kernel.org Cc: l...@lists.linux.dev Co-developed-by: Gwan-gyeon

[Intel-gfx] [PATCH v11 9/9] drm/i915: Remove truncation warning for large objects

warning put in place to remind us to complete the review. Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld Cc: Thomas Hellström Testcase: igt@gem_create@create-massive Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991

[Intel-gfx] [PATCH v11 7/9] drm/i915: Check if the size is too big while creating shmem file

32, size > MAX_LFS_FILESIZE is always false, so it checks only when BITS_PER_LONG is 64. Signed-off-by: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reported-by: kernel test robot Reviewed-by: Andr

[Intel-gfx] [PATCH v11 8/9] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH v11 4/9] drm/i915/gem: Typecheck page lookups

off_t() macro. (Kees) v11: Change the use of assert_typable to assert_same_typable (G.G) Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Matthew Auld Cc: Thomas Hellström Cc: Kees Cook Reviewed-by: Nirmoy Das (v2) Reviewed-by: Mauro Carvalho Chehab (v3) Review

[Intel-gfx] [PATCH v11 6/9] drm/i915: Check for integer truncation on the configuration of ttm place

() macro call from safe_conversion_gem_bug_on() v6: Fix to follow general use case for GEM_BUG_ON(). (Jani) v7: Fix to use WARN_ON() macro where GEM_BUG_ON() macro was used. (Jani) v8: Replace safe_conversion() with check_assign() (Kees) Signed-off-by: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew

[Intel-gfx] [PATCH v11 5/9] drm/i915: Check for integer truncation on scatterlist creation

macro into drm_util header (Jani N) v5: Fix macros to be enclosed in parentheses for complex values Fix too long line warning v8: Replace safe_conversion() with check_assign() (Kees) Signed-off-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Brian Welty Cc: Matthew Auld

[Intel-gfx] [PATCH v11 3/9] compiler_types.h: Add assert_same_type to catch type mis-match while compiling

Signed-off-by: Gwan-gyeong Mun Cc: Thomas Hellström Cc: Matthew Auld Cc: Nirmoy Das Cc: Jani Nikula Cc: Andi Shyti Cc: Mauro Carvalho Chehab Cc: Andrzej Hajda Cc: Kees Cook Cc: Rasmus Villemoes --- include/linux/compiler.h | 1 + include/linux/compiler_types.h | 43 + include

[Intel-gfx] [PATCH v11 1/9] overflow: Allow mixed type arguments

org Signed-off-by: Kees Cook Signed-off-by: Gwan-gyeong Mun Reviewed-by: Andrzej Hajda --- include/linux/overflow.h | 72 lib/overflow_kunit.c | 101 --- 2 files changed, 113 insertions(+), 60 deletions(-) diff --git a/inc

[Intel-gfx] [PATCH v11 2/9] overflow: Move and add few utility macros into overflow

macro and drop overflows_ptr() macro(Kees) v11: Fix incorrect type assignment between different address spaces caused by the wrong use of __user macro. (kernel test robot) Update macro description (G.G) Signed-off-by: Gwan-gyeong Mun Cc: Thomas Hellström Cc: Matthew Auld Cc: Nirmoy Da

[Intel-gfx] [PATCH v11 0/9] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

terlist creation drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun (5): overflow: Move and add few utility macros into overflow compiler_types.h: Add assert_same_type to catch type mis-match while compiling drm/i915: Check for integer truncation on the configuration of ttm

Re: [Intel-gfx] [PATCH v10 3/9] compiler_types.h: Add assert_type to catch type mis-match while compiling

On 9/13/22 3:01 PM, Kees Cook wrote: On Fri, Sep 09, 2022 at 07:59:07PM +0900, Gwan-gyeong Mun wrote: It adds assert_type and assert_typable macros to catch type mis-match while compiling. The existing typecheck() macro outputs build warnings, but the newly added assert_type() macro uses the

Re: [Intel-gfx] [PATCH v3 01/37] drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files

en7_append_oa_reports - Copies all buffered OA reports into * userspace read() buffer. If there is no problem when using the same form as gen8_append_oa_reports when generating kernel-doc, it seems to be indented to match the existing i915 style. However, if there is a

Re: [Intel-gfx] [PATCH v3 02/37] drm/i915: display: fix kernel-doc markup warnings

Looks good to me. Reviewed-by: Gwan-gyeong Mun On 9/9/22 10:34 AM, Mauro Carvalho Chehab wrote: There are a couple of issues at i915 display kernel-doc markups: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning: Function parameter or member 'intel_connector

  1   2   3   4   5   6   7   8   >