Hi Dmitry,
CC sfr
On Tue, Jan 21, 2025 at 11:44 AM Dmitry Baryshkov
wrote:
> On Tue, 21 Jan 2025 at 11:13, Geert Uytterhoeven wrote:
> > On Tue, Jan 7, 2025 at 12:31 PM Dmitry Baryshkov
> > wrote:
> > > On Sat, 14 Dec 2024 15:37:04 +0200, Dmitry Baryshkov wrote:
>
misc/drm-misc-next' into drm-tip").
What am I missing?
Thanks!
P.S. Sima: noticed while resolving a merge conflict using drm-tip. Thx!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In p
ine int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
> +static inline __maybe_unused int rcar_cmm_read(struct rcar_cmm *rcmm, u32
> reg)
> {
> return ioread32(rcmm->base + reg);
> }
This function was never used. Why not remove it instead?
Gr{oetje,eeting}s,
d int
color_mode)
+{
+ u32 fourcc = drm_driver_color_mode_format(dev, color_mode);
+
+ drm_client_setup_with_fourcc(dev, fourcc);
+}
+EXPORT_SYMBOL(drm_client_setup_with_color_mode);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There'
lient_setup_with_fourcc()
>
> Signed-off-by: Thomas Zimmermann
> Cc: Laurent Pinchart
> Cc: Geert Uytterhoeven
> Reviewed-by: Laurent Pinchart
Reviewed-by: Geert Uytterhoeven
Tested-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeve
homas Zimmermann
Cc: Yannick Fertre
Cc: Raphael Gallais-Pou
Cc: Philippe Cornu
Cc: Maxime Coquelin
Cc: Alexandre Torgue
Acked-by: Raphael Gallais-Pou
Acked-by: Raphael Gallais-Pou
WARNING: Duplicate signature
Gr{oetje,eeting}s,
Geert
--
the holes in structures.
>
> Thanks! I don't see a __packed attribute on struct drm_connector, but
> I'll put it near by other bools in case that changes in the future.
FTR, don't add __packed unless you have a very good reason to do so.
With __packed, the compiler will emit
...@linux-m68k.org
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
gt;66 | static inline int rzg2l_du_vsp_init(struct rzg2l_du_vsp *vsp,
> > struct device_node *np,
> > | ^~~~~
> >
> > Caused by commit
> >
> > 768e9e61b3b9 ("drm: renesas: Add RZ/G2L DU Support")
> >
> &g
Hi Maxime, Dave,
On Thu, Feb 15, 2024 at 5:45 PM Geert Uytterhoeven wrote:
> On Thu, Feb 15, 2024 at 5:09 PM Maxime Ripard wrote:
> On Thu, Feb 15, 2024 at 01:41:24PM +0100, Geert Uytterhoeven wrote:
> > > On Thu, 15 Feb 2024, Maxime Ripard wrote:
> > > > Matthew
Hi Maxime,
On Thu, Feb 15, 2024 at 5:09 PM Maxime Ripard wrote:
On Thu, Feb 15, 2024 at 01:41:24PM +0100, Geert Uytterhoeven wrote:
> > On Thu, 15 Feb 2024, Maxime Ripard wrote:
> > > Matthew Auld (1):
> > > drm/tests/drm_buddy: add alloc_contiguous test
>
ko] undefined!
Reverting commit a64056bb5a3215bd ("drm/tests/drm_buddy: add
alloc_contiguous test") fixes the issue.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In persona
(vdev)) {
+ if (!ivpu_hw_37xx_is_idle(vdev))
ivpu_warn(vdev, "VPU not idle during power down\n");
- if (ivpu_hw_37xx_reset(vdev))
- ivpu_warn(vdev, "Failed to reset the VPU\n");
- }
- if (ivpu_pll_disable(vdev)) {
-
Fix misspellings of "semaphore".
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Hamza Mahfooz
---
v2:
- Add Reviewed-by.
---
drivers/gpu/drm/i915/i915_request.c | 2 +-
drivers/gpu/drm/radeon/cik.c| 2 +-
drivers/gpu/drm/radeon/r600.c | 2 +-
include/drm/task
in the
shmob_drm-specific subclasses of drm_{crtc,connector,plane} to "base".
https://lore.kernel.org/dri-devel/b3daca80f82625ba14e3aeaf2fca6dcefa056e47.1687423204.git.geert+rene...@glider.be
> Also the functions that deal with both a struct device and a struct
> drm_device ofte
uot; | sort | uniq -c | sort -rn |
> head -20
> 38494 struct device *dev
> 16388 struct net_device *dev
>4184 struct drm_device *dev
>2780 struct pci_dev *dev
>1916 struct comedi_device *dev
>1510 struct mlx5_core_dev *dev
> 1057 struct mlx4_dev *dev
return -EFAULT;
> > + /* only for kernel-internal use */
> > + var.activate &= ~FB_ACTIVATE_KD_TEXT;
> > console_lock();
> > lock_fb_info(info);
> > ret = fbcon_modechange_possible(info, &var);
Hi Marc,
On Tue, Apr 11, 2023 at 12:49 PM Marc Dionne wrote:
> On Tue, Apr 11, 2023 at 7:44 AM Geert Uytterhoeven
> wrote:
> >
> > Fix a misspelling of "rendez-vouz".
> >
> > Signed-off-by: Geert Uytterhoeven
> > --- a/include/drm/task_
Fix a misspelling of "rendez-vous".
Signed-off-by: Geert Uytterhoeven
---
v2:
- s/vouz/vous/.
---
include/drm/task_barrier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h
index 217c1cf21c1ab7d5..f6e6ed
Fix misspellings of "semaphore".
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/i915/i915_request.c | 2 +-
drivers/gpu/drm/radeon/cik.c| 2 +-
drivers/gpu/drm/radeon/r600.c | 2 +-
include/drm/task_barrier.h | 2 +-
4 files changed, 4 insertions(+), 4
Fix a misspelling of "rendez-vouz".
Signed-off-by: Geert Uytterhoeven
---
include/drm/task_barrier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h
index 217c1cf21c1ab7d5..59ead429acb2afb0 100644
--- a/i
Fix misspellings of "semaphore".
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/i915/i915_request.c | 2 +-
drivers/gpu/drm/radeon/cik.c| 2 +-
drivers/gpu/drm/radeon/r600.c | 2 +-
include/drm/task_barrier.h | 2 +-
4 files changed, 4 insertions(+), 4
Hi Daniel,
On Tue, Aug 9, 2022 at 5:03 PM Daniel Vetter wrote:
> On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote:
> > On 6/29/22 12:56, Geert Uytterhoeven wrote:
> > > The DRM fbdev emulation layer does not support pushing back
> > > changes
by: Laurent Pinchart
Signed-off-by: Dmitry Baryshkov
Thanks for your patch!
This gets rids of the warning splats on e.g. Renesas Koelsch and
Salvator-XS, so
Tested-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's
v4: adjusted indentation (Heiko)
> arch/m68k/include/asm/cmpxchg.h | 6 +++---
Acked-by: Geert Uytterhoeven [m68k]
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with t
On Thu, Dec 29, 2022 at 12:34 PM Andrzej Hajda wrote:
> __xchg will be used for non-atomic xchg macro.
>
> Signed-off-by: Andrzej Hajda
> Reviewed-by: Arnd Bergmann
Acked-by: Geert Uytterhoeven [m68k]
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- The
ity header.
>
> If the idea is OK there are still 2 qestions to answer:
>
> 1. Name of the helper, __xchg follows kernel conventions,
> but for me Rust names are also OK.
Before I realized the missing "&", I wondered how this is different
from swap(), so naming is important
on, except
for bandwidth limitations.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
what a pixel clock of 13.5 MHz really means ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm ta
Perhaps "generic" variants of NSTC and PAL/SECAM should be added, which
would really just mean 525/60 resp. 625/50.
Alternatively, the tv_mode field could be split in two parts (either
two separate fields, or bitwise), to maintain a clear separation between
lines/field
alog, using
60 Hz and 525 lines. Add "TV" to the name?
> - DRM_MODE_ANALOG_JM / DRM_MODE_ANALOG_BDGHIKLN (after corresponding ITU
> System
> Letter Designations)
Or DRM_MODE_ITU_*?
But given the long list of letters, this looks fragile to me.
Gr{oetje,eeting}s,
turn false;
> +
> + /*
> + * Having a mode that starts by a letter (and thus is named)
> +* and an at-sign (used to specify a refresh rate) is
> +* disallowed.
> +*/
> +
tree).
Thanks for the hint! After reverting that commit, drm-next (sort of[1])
merges cleanly into upstream again.
[1] There's still a small conflict due to the removal of
force_dpms_off, cfr. the difference between commits
3283c83eb6fcfbda and cc79950bf0904f58 ("drm/amd/display:
buffer config cannot be changed anyway. This makes the fbdev
core aware that making changes to the frame buffer config is not
supported, so it will always return the current config.
Signed-off-by: Geert Uytterhoeven
---
The only remaining DRM driver that implements fb_ops.fb_check_var() is
also
d for compiling userspace.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "prog
>
> > Let me know if you think that makes sense and I can attempt to write a fix.
>
> I still think unregistering the platform_dev properly makes the most
That doesn't sound very driver-model-aware to me. The device is what
the driver binds to; it does not cease to exist.
&
epth - 1,
> > of course.
>
> Well, no, the condition should be while (--i) instead to also match the
> values the original loop takes. ;D
"There are two hard things in computer science: cache invalidation,
naming things, and off-by-one errors."
Gr{oetje,eeting}s,
On Tue, Feb 1, 2022 at 9:50 PM Daniel Vetter wrote:
> I didn't bother with any code movement to fix the others, these just
> got a bit in the way.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
G
um_registered_fb __read_mostly;
> +#if IS_ENABLED(CONFIG_OLPC_DCON)
CONFIG_FB_OLPC_DCON (everywhere), cfr. the build failure reported
by the robot.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In person
onvert them all to bitfields?
unsigned int initialized : 1;
...
> > introtate;
> > intcur_rotate;
> > char *cursor_data;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
te that drm-misc is group maintained, I expect that to continue like
> we've done before, so no new expectations that patches all go through
> my hands. That would be silly. This also means I'm happy to put any
> other volunteer's name in the M: line, but otherwise git log s
Hi Borislav,
On Mon, Nov 8, 2021 at 4:59 PM Borislav Petkov wrote:
> On Mon, Nov 08, 2021 at 04:25:47PM +0100, Geert Uytterhoeven wrote:
> > I'm not against returning proper errors codes. I'm against forcing
> > callers to check things that cannot fail and to add indi
Hi Borislav,
On Mon, Nov 8, 2021 at 3:21 PM Borislav Petkov wrote:
> On Mon, Nov 08, 2021 at 03:07:03PM +0100, Geert Uytterhoeven wrote:
> > I think the addition of __must_check is overkill, leading to the
> > addition of useless error checks and message printing.
>
checks and message printing. Many callers
call this where it cannot fail, and where nothing can be done in the
very unlikely event that the call would ever start to fail.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux
s on (OF && COMMON_CLK) || COMPILE_TEST
+ depends on OF || COMPILE_TEST
to keep a better separation between hard and soft dependencies.
Note that the "depends on OF || COMPILE_TEST" can even be
deleted, as the dependency on ARCH_QCOM || SOC_IMX5 implies OF.
>
sed uninitialized" warnings thrown up by gcc-4.1, until
(a bit later than) support for that compiler was removed...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal con
Hi Daniel,
Replying "early" (see below), as this was applied to
drm-misc/for-linux-next.
On Sat, Oct 31, 2020 at 3:17 PM Daniel Vetter wrote:
> On Sat, Oct 31, 2020 at 11:28 AM Geert Uytterhoeven
> wrote:
> > On Thu, 29 Oct 2020, Daniel Vetter wrote:
> > > So eve
SCROLL_PAN_REDRAW;
- } else {
- if (reading_fast || (fast_copyarea && !fast_imageblit))
- p->scrollmode = SCROLL_MOVE;
- else
- p->scrollmode = SCROLL_REDRAW;
- }
}
#define PITCH(w) (((w) + 7) >> 3)
--
2.28.0
_
Hi Daniel,
On Wed, Feb 19, 2020 at 11:57 AM Daniel Vetter wrote:
> On Wed, Feb 19, 2020 at 11:30 AM Geert Uytterhoeven
> wrote:
> > On Wed, Feb 19, 2020 at 11:22 AM Daniel Vetter
> > wrote:
> > > It's right above the drm_dev_put().
> > >
&g
this patch series.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say &qu
Fix sent
https://lore.kernel.org/lkml/20190813093046.4976-1-geert+rene...@glider.be/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical peop
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/i915/intel_dpll_mgr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.h
b/drivers/gpu/drm/i915/intel_dpll_mgr.h
index 8835dd20f1d27e05..79a53c5439a8e6db 100644
--- a/drivers/gpu/drm
rom when this was originally introduced
> in
>
> commit 6011bdeaa6089d49c02de69f05980da7bad314ab
> Author: Guennadi Liakhovetski
> Date: Wed Jul 21 10:13:21 2010 +
>
> fbdev: sh-mobile: HDMI support for SH-Mobile SoCs
>
> So let's just remove it.
>
&
On Mon, May 20, 2019 at 10:25 AM Daniel Vetter wrote:
> It's dead code, and removing it avoids me having to understand
> what it's doing with lock_fb_info.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
out preprocessing anyway ;-)
$ cat $(type -p unhexdump)
#!/bin/sh
sed 's/^[0-9a-f]*//' $1 | xxd -r -p | dd conv=swab
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal con
_TC1 = 0,
> > +PORT_TC2,
> > +PORT_TC3,
> > +PORT_TC4,
> > +
> > +I915_MAX_TC_PORTS
> > +};
> > +
> > +enum tc_port_type {
> > +TC_PORT_UNKNOWN = 0,
> > +TC_PORT_TYPEC,
> > +TC_PORT_TBT,
> >
mac8390.c:402: error: expected ‘;’ before ‘{’ token
Apparently this depends on patch [01/12], which wasn't CCed to
linux-m...@lists.linux-m68k.org?
Please don't split CCs if all patches in the a series are not independent.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 6d8e29abbc333c87..74fdd8ca2cb2a347 100644
--- a/drivers
+ * Authors:
> + *Vetter
> + */
The above chunk doesn't sound appropriate for extracting existing code...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myse
w to
interprete the tuples).
The fb_bitfield structs do have RGB-centric names, but you could use them
for e.g. Y, Cb, Cr, and alpha, giving a proper visual. Unfortunately the
YCbCr visuals haven't made it into mainline.
FOURCC unifies all of that in (not so) unique 32-bit IDs.
Gr{oetje
ot;Attempting to bind an object larger than the
> aperture: object=%zd > %s aperture=%ld\n",
> + DRM_ERROR("Attempting to bind an object larger than the
> aperture: object=%zd > %s aperture=%zd\n",
size_t is unsigned, so you better change it to %z
61 matches
Mail list logo
