[Intel-gfx] [PATCH 09/20] drm: fix inclusion of drm.h in exynos_sarea.h

Using `#include "drm.h"` instead of `#include ` allow drm headers to be moved in another directory without changes, like for the libdrm imports. Signed-off-by: Gabriel Laskar CC: Emil Velikov CC: Mikko Rapeli --- include/uapi/drm/i915_drm.h | 2 +- 1 file changed, 1 insertion(+),

Re: [Intel-gfx] [PATCH v4 0/5] drm: Add decoding for DRM/KMS and i915 ioctls

; xlat/drm_i915_setparams.in | 4 + > 11 files changed, 1125 insertions(+) > create mode 100644 drm.c > create mode 100644 drm_i915.c > create mode 100644 xlat/drm_i915_getparams.in > create mode 100644 xlat/drm_i915_ioctls.in > create mode 100644 xlat/drm_i915_setparams.in > -- Gabriel Laskar ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

; > > > Maybe it's time to deal with this issue in a more generic way. > > > > Yes, I'm thinking SYS_FUNC(ioctl) could be improved. But on the other hand how > likely is it that we fail in umove and what chance do we have to recover from > that anyway? All I can think of is OOM. umove() can fail in multiple ways. For example, if the memory is not valid in the tracee, umove() will fail. Anyway, SYS_FUNC(ioctl) is a bit complicated, and the handling of the fallbacks on failure should be more generic. -- Gabriel Laskar ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 0/5] drm: Add decoding for DRM/KMS and i915 ioctls

o look at this yet? Besides the 2 or 3 remarks inlined in the patches, this looks good to me. -- Gabriel Laskar ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 4/5] drm: Add decoding of i915 ioctls

000..21c3397 > --- /dev/null > +++ b/xlat/drm_i915_ioctls.in > @@ -0,0 +1,51 @@ > +/* Unfortunately i915 collides with other DRM drivers so we must specify > these */ > +DRM_IOCTL_I915_INIT > +DRM_IOCTL_I915_FLUSH > +DRM_IOCTL_I915_FLIP > +DRM_IOCTL_I915_BATCHBUFFER > +DRM_IOCTL_I915_IRQ_EMIT > +DRM_IOCTL_I915_IRQ_WAIT > +DRM_IOCTL_I915_GETPARAM > +DRM_IOCTL_I915_SETPARAM > +DRM_IOCTL_I915_ALLOC > +DRM_IOCTL_I915_FREE > +DRM_IOCTL_I915_INIT_HEAP > +DRM_IOCTL_I915_CMDBUFFER > +DRM_IOCTL_I915_DESTROY_HEAP > +DRM_IOCTL_I915_SET_VBLANK_PIPE > +DRM_IOCTL_I915_GET_VBLANK_PIPE > +DRM_IOCTL_I915_VBLANK_SWAP > +DRM_IOCTL_I915_HWS_ADDR > +DRM_IOCTL_I915_GEM_INIT > +DRM_IOCTL_I915_GEM_EXECBUFFER > +DRM_IOCTL_I915_GEM_EXECBUFFER2 > +DRM_IOCTL_I915_GEM_PIN > +DRM_IOCTL_I915_GEM_UNPIN > +DRM_IOCTL_I915_GEM_BUSY > +DRM_IOCTL_I915_GEM_SET_CACHING > +DRM_IOCTL_I915_GEM_GET_CACHING > +DRM_IOCTL_I915_GEM_THROTTLE > +DRM_IOCTL_I915_GEM_ENTERVT > +DRM_IOCTL_I915_GEM_LEAVEVT > +DRM_IOCTL_I915_GEM_CREATE > +DRM_IOCTL_I915_GEM_PREAD > +DRM_IOCTL_I915_GEM_PWRITE > +DRM_IOCTL_I915_GEM_MMAP > +DRM_IOCTL_I915_GEM_MMAP_GTT > +DRM_IOCTL_I915_GEM_SET_DOMAIN > +DRM_IOCTL_I915_GEM_SW_FINISH > +DRM_IOCTL_I915_GEM_SET_TILING > +DRM_IOCTL_I915_GEM_GET_TILING > +DRM_IOCTL_I915_GEM_GET_APERTURE > +DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID > +DRM_IOCTL_I915_GEM_MADVISE > +DRM_IOCTL_I915_OVERLAY_PUT_IMAGE > +DRM_IOCTL_I915_OVERLAY_ATTRS > +DRM_IOCTL_I915_SET_SPRITE_COLORKEY > +DRM_IOCTL_I915_GET_SPRITE_COLORKEY > +DRM_IOCTL_I915_GEM_WAIT > +DRM_IOCTL_I915_GEM_CONTEXT_CREATE > +DRM_IOCTL_I915_GEM_CONTEXT_DESTROY > +DRM_IOCTL_I915_REG_READ > +DRM_IOCTL_I915_GET_RESET_STATS > +DRM_IOCTL_I915_GEM_USERPTR > diff --git a/xlat/drm_i915_setparams.in b/xlat/drm_i915_setparams.in > new file mode 100644 > index 000..d93d2ea > --- /dev/null > +++ b/xlat/drm_i915_setparams.in > @@ -0,0 +1,4 @@ > +I915_SETPARAM_USE_MI_BATCHBUFFER_START > +I915_SETPARAM_TEX_LRU_LOG_GRANULARITY > +I915_SETPARAM_ALLOW_BATCHBUFFER > +I915_SETPARAM_NUM_USED_FENCES -- Gabriel Laskar ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 5/5] drm: Add decoding of DRM and KMS ioctls

(tcp, code, arg); > } > > + switch (code) { > + case DRM_IOCTL_VERSION: > + return drm_version(tcp, code, arg); > + case DRM_IOCTL_GET_UNIQUE: > + return drm_get_unique(tcp, code, arg); > + case DRM_IOCTL_GET_MAGIC: > + r

Re: [Intel-gfx] [PATCH 4/4] drm: Add decoding of DRM and KMS ioctls

On Tue, 9 Jun 2015 16:29:31 +0200 Patrik Jakobsson wrote: > On Tue, Jun 09, 2015 at 03:51:08PM +0200, Gabriel Laskar wrote: > > On Tue, 9 Jun 2015 13:26:44 +0200 > > Patrik Jakobsson wrote: > > > > > This patch adds many of the DRM and KMS ioctls. The res

Re: [Intel-gfx] [PATCH 2/4] drm: Add dispatcher and driver identification for DRM

return drm_decode_number(tcp, arg); > default: > return 0; > } > @@ -252,6 +260,8 @@ ioctl_decode(struct tcb *tcp, unsigned int code, long arg) > return ubi_ioctl(tcp, code, arg); > case 'V': > return v4l2

Re: [Intel-gfx] [PATCH 4/4] drm: Add decoding of DRM and KMS ioctls

ANK: > + return drm_wait_vblank(tcp, code, arg); > + case DRM_IOCTL_MODE_GETRESOURCES: > + return drm_mode_get_resources(tcp, code, arg); > + case DRM_IOCTL_MODE_GETCRTC: > + return drm_mode_get_crtc(tcp, code, arg); > + case DRM_IOCTL_MODE_SETCRTC: > + return drm_mode_set_crtc(tcp, code, arg); > + case DRM_IOCTL_MODE_CURSOR: > + return drm_mode_cursor(tcp, code, arg); > + case DRM_IOCTL_MODE_CURSOR2: > + return drm_mode_cursor2(tcp, code, arg); > + case DRM_IOCTL_MODE_GETGAMMA: > + return drm_mode_get_gamma(tcp, code, arg); > + case DRM_IOCTL_MODE_SETGAMMA: > + return drm_mode_set_gamma(tcp, code, arg); > + case DRM_IOCTL_MODE_GETENCODER: > + return drm_mode_get_encoder(tcp, code, arg); > + case DRM_IOCTL_MODE_GETCONNECTOR: > + return drm_mode_get_connector(tcp, code, arg); > + case DRM_IOCTL_MODE_ATTACHMODE: > + return drm_mode_attachmode(tcp, code, arg); > + case DRM_IOCTL_MODE_DETACHMODE: > + return drm_mode_detachmode(tcp, code, arg); > + case DRM_IOCTL_MODE_GETPROPERTY: > + return drm_mode_get_property(tcp, code, arg); > + case DRM_IOCTL_MODE_SETPROPERTY: > + return drm_mode_set_property(tcp, code, arg); > + case DRM_IOCTL_MODE_GETPROPBLOB: > + return drm_mode_get_prop_blob(tcp, code, arg); > + case DRM_IOCTL_MODE_GETFB: > + return drm_mode_get_fb(tcp, code, arg); > + case DRM_IOCTL_MODE_ADDFB: > + return drm_mode_add_fb(tcp, code, arg); > + case DRM_IOCTL_MODE_RMFB: > + return drm_mode_rm_fb(tcp, code, arg); > + case DRM_IOCTL_MODE_PAGE_FLIP: > + return drm_mode_page_flip(tcp, code, arg); > + case DRM_IOCTL_MODE_DIRTYFB: > + return drm_mode_dirty_fb(tcp, code, arg); > + case DRM_IOCTL_MODE_CREATE_DUMB: > + return drm_mode_create_dumb(tcp, code, arg); > + case DRM_IOCTL_MODE_MAP_DUMB: > + return drm_mode_map_dumb(tcp, code, arg); > + case DRM_IOCTL_MODE_DESTROY_DUMB: > + return drm_mode_destroy_dumb(tcp, code, arg); > + case DRM_IOCTL_GEM_CLOSE: > + return drm_gem_close(tcp, code, arg); > + } > + > return 0; > } -- Gabriel Laskar ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 0/4] drm: Add decoding for DRM/KMS and i915 ioctls

d to me. I have just tested it a little. You should rebase to master, it does not apply for the moment, and add the Changelog info in your commits (looks at the log, the global Changelog is extracted from the commit messages). Other little remarks are inlines in the patches. -- Gabriel Laskar

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

On Tue, 12 May 2015 14:35:28 +0200 Patrik Jakobsson wrote: > On Mon, May 11, 2015 at 08:08:19PM +0200, Gabriel Laskar wrote: > > On Mon, 11 May 2015 15:54:24 +0200 > > Patrik Jakobsson wrote: > > > > > On Mon, May 11, 2015 at 12:50:36PM +0200, Gabriel Laskar wrot

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

On Mon, 11 May 2015 15:54:24 +0200 Patrik Jakobsson wrote: > On Mon, May 11, 2015 at 12:50:36PM +0200, Gabriel Laskar wrote: > > On Wed, 6 May 2015 16:48:01 +0200 > > Patrik Jakobsson wrote: > > > > > This patch set aims to make strace more useful when tracin

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

5-ioctls.c -o i915-ioctls $ sudo strace -e ioctl ./i915-ioctls ioctl(3, _IOC(_IOC_WRITE, 0x64, 0x41, 0x04), 0) = 0 +++ exited with 0 +++ $ sudo ~/source/strace/strace -e ioctl ./i915-ioctls ioctl(3, 0x40046441 /* I915_IOCTL_??? */, 0) = 0 +++ exited with 0 +++ -- Gabriel Laskar ___