On 17.05.2016 15:12, Marius Vlad wrote:
An attempt to have piglit not taking too much time when listing tests,
but also keep tests/gem_concurrent_blit into list of tests.
This was added in a633ad03c6 (tests: Separate tests with lots of subtests) and
tried to be fixed c785a89ee (autotools/: All
On 17.05.2016 13:02, Daniel Vetter wrote:
On Mon, May 16, 2016 at 06:09:27PM +0300, Marius Vlad wrote:
Trivial. Pushed.
On Mon, May 16, 2016 at 01:36:48PM +0300, Marius Vlad wrote:
Introduced by a633ad03c6 (tests: Separate tests with lots of subtests).
v2: Fix commit typo (Jani Nikula).
Si
Repairing the damage I caused not reading properly Daniel's comment in:
https://patchwork.freedesktop.org/patch/81600/
Leaving gem_concurrent_all only in the EXTRA set
Cc: Daniel Vetter
Cc: Marius Vlad
Signed-off-by: Gabriel Feceoru
---
tests/Makefile.sources | 2 +-
1 file chang
On 17.05.2016 12:59, Daniel Vetter wrote:
On Wed, Apr 20, 2016 at 05:21:58PM +0300, Gabriel Feceoru wrote:
Currently, when trying to run i-g-t tests with piglit, it takes up
to 20s until the first test is executed.
The main reason is that gem_concurrent_all has ~500k subtests,
overkilling
On 13.05.2016 15:00, Chris Wilson wrote:
On Fri, May 13, 2016 at 02:45:09PM +0300, Gabriel Feceoru wrote:
basic-flip-vs-wf_vblank subtest sometimes fails asserting counted frames to
be aproximately equal with the estimated number.
This is a false negative, one of the reasons being the
Cc: Daniel Vetter
Signed-off-by: Gabriel Feceoru
---
tests/kms_flip.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index eda2fcc..6ec97d0 100644
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1182,13 +1182,13 @@ static void
On 10.05.2016 18:39, Jani Nikula wrote:
On Tue, 10 May 2016, Gabriel Feceoru wrote:
If count == 100 and expected == 99 this condition fails (99*101/100 = 99.99).
(v2): Increased the tolerance range, as suggested by Jani.
Cc: Jani Nikula
Cc: Daniel Vetter
Signed-off-by: Gabriel Feceoru
If count == 100 and expected == 99 this condition fails (99*101/100 = 99.99).
(v2): Increased the tolerance range, as suggested by Jani.
Cc: Jani Nikula
Cc: Daniel Vetter
Signed-off-by: Gabriel Feceoru
---
tests/kms_flip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On 10.05.2016 16:52, Jani Nikula wrote:
On Tue, 10 May 2016, Gabriel Feceoru wrote:
Comparing 2 numbers with 1% accuracy depends on which one is the
reference. If count == 100 and expected == 99 this condition fails,
although it should pass.
Well, the expectation should be the reference
Comparing 2 numbers with 1% accuracy depends on which one is the
reference. If count == 100 and expected == 99 this condition fails,
although it should pass.
Signed-off-by: Gabriel Feceoru
---
tests/kms_flip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm/i915/intel_hdmi.c
index 4d65f69..bedb9ef 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu
Hi Dave, Daniel,
This is a regression causing many failures in intel-gfx CI.
[ 295.164523] [drm:drm_debugfs_init] *ERROR* Cannot create
/sys/kernel/debug/dri/0
[ 295.164531] [drm:drm_minor_register] *ERROR* DRM: Failed to
initialize /sys/kernel/debug/dri.
[ 295.167544] i915: probe of 000
These checks may fail in runtime and will cause confusing
flipping skip/pass results.
Signed-off-by: Gabriel Feceoru
---
tests/gem_exec_suspend.c | 2 +-
tests/gem_exec_whisper.c | 2 +-
tests/gem_reloc_overflow.c | 2 +-
tests/gem_ringfill.c | 2 +-
tests
and test-list-full.txt.
The piglit can now enumerate the i-g-t tests within a decent few seconds.
The second list could be used when trying to execute specific these tests.
v2: Rebased
Signed-off-by: Gabriel Feceoru
---
tests/Makefile.am | 12 +---
tests/Makefile.sources | 22
Piglit changed the format of the result json file, replacing time attribute
float with a TimeAttribute object, which stores a start time and an end time.
Fixed this script by calculating the duration when reading the json results.
Signed-off-by: Gabriel Feceoru
---
scripts/quick-testlist.py
and test-list-full.txt.
The piglit can now enumerate the i-g-t tests within a decent few seconds.
The second list could be used when trying to execute specific these tests.
Signed-off-by: Gabriel Feceoru
---
tests/Makefile.am | 6 ++
tests/Makefile.sources | 22 --
2
This almost fixes the problem , but with this:
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
b/drivers/gpu/drm/i915/intel_fbdev.c
index 5029f92..a6d3c58 100644
--- a/drivers/gpu/drm/i915/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/intel_fbdev.c
@@ -123,8 +123,9 @@ static struct intel_fbdev
*int
On 31.03.2016 00:35, Lukas Wunner wrote:
Hi Gabriel,
On Wed, Mar 30, 2016 at 08:20:26PM +0300, Gabriel Feceoru wrote:
This commit causes a hang while running kms suspend tests
(kms_pipe_crc_basic@suspend-read-crc-pipe-*) on ILK/SNB/IVB, affecting CI.
This happened with v1 but not with v2
This commit causes a hang while running kms suspend tests
(kms_pipe_crc_basic@suspend-read-crc-pipe-*) on ILK/SNB/IVB, affecting CI.
Probably the same problem with the one in v2, but on older HW.
commit a7442b93cf32c1e1ddb721a26cd1f92302e2a222
Author: Lukas Wunner
Date: Wed Mar 9 12:52:53 2
Anybody wants to take a look at this?
Thanks,
Gabriel.
On 19.02.2016 14:34, Gabriel Feceoru wrote:
On BSW all pipeA and pipeB kms_plane subtests fail.
The root cause is a HW limitation in Cherryview - PipeC is directly connected
to PortD.
Also, if no monitor is connected, all subtests pass
On 18.03.2016 16:02, Rodrigo Vivi wrote:
The following piglit commit adds one option to overwrite files:
commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db
Author: Dylan Baker
Date: Mon Feb 1 15:08:23 2016 -0800
framework/programs/run.py: Add option for overwriting files
So our run-scri
reference.
This clears the flip-flops in kms tests on HSW/BDW.
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/intel_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index
Since I915_MAX_PLANES = PLANE_CURSOR + 1, explicit clearing the wm
values for PLANE_CURSOR is already done earlier by a memset.
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/intel_pm.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu
Piglit changed its behaviour to prevent overwriting the results
directory unless explicitly specified with -o
Added -o flag in run-tests.sh to keep user experience.
Signed-off-by: Gabriel Feceoru
---
scripts/run-tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Use the pipe which is given from the possible_crcs for that connected port
instead.
On BSW there are constrains for the crtc<-->connector, this fix make this test
passing on BSW.
Signed-off-by: Gabriel Feceoru
---
tests/kms_frontbuffer_tracking.c | 3 ++-
1 file changed, 2 insertions
This could happen when the selected pipe cannot be used with the connected
port due do HW constrains.
v2: Apply review comment (Marius)
bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86763
Signed-off-by: Gabriel Feceoru
---
tests/kms_plane.c | 4 +++-
1 file changed, 3 insertions(+), 1
)
Signed-off-by: Gabriel Feceoru
---
lib/igt_kms.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 90c8da7..6163a6d 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1669,6 +1669,7 @@ static int do_display_commit(igt_display_t *display
On 23.02.2016 21:36, Dave Gordon wrote:
On 23/02/16 14:39, Tvrtko Ursulin wrote:
On 23/02/16 14:03, Chris Wilson wrote:
On Tue, Feb 23, 2016 at 01:31:17PM +, Tvrtko Ursulin wrote:
On 23/02/16 13:06, Gabriel Feceoru wrote:
On 23.02.2016 13:05, Tvrtko Ursulin wrote:
Hi,
On 23/02
On 23.02.2016 13:05, Tvrtko Ursulin wrote:
Hi,
On 23/02/16 10:52, Gabriel Feceoru wrote:
Return error when I915_EXEC_BSD_RING2 flag is set but BSD2 ring
is not available in the HW.
What is the reasoning behind this? So far kernel was allowing userspace
to select these bits and execute on
Return error when I915_EXEC_BSD_RING2 flag is set but BSD2 ring
is not available in the HW.
v2: Reworked
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
b/drivers
Return error when I915_EXEC_BSD_RING2 flag is set but BSD2 ring
is not available in the HW.
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915
This could happen when the selected pipe cannot be used with the connected
port due do HW constrains.
bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86763
Signed-off-by: Gabriel Feceoru
---
tests/kms_plane.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests
On Cherryview PIPE_C can only be connected to PORT_D (bspec).
The driver properly reports the crtc_mask for the encoder, however the
mismatch between pipe and port is not reported back to the test.
Add support for detecting this case so the test can be skipped.
Signed-off-by: Gabriel Feceoru
When no display is connected all kms_plane subtests pass although
no testing is done.
Change it by reporting the subtests as skipped.
Signed-off-by: Gabriel Feceoru
---
tests/kms_plane.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/tests/kms_plane.c b
: https://bugs.freedesktop.org/show_bug.cgi?id=86763
Gabriel Feceoru (3):
tests/kms_plane: Skip on no connected outputs
lib/igt_kms: Add fail exit branch in do_display_commit()
tests/kms_plane: Skip the test when configuration couldn't be applied
lib/igt_kms.c | 9 ++---
On 15.02.2016 14:57, Takashi Iwai wrote:
On Mon, 15 Feb 2016 13:57:00 +0100,
Gabriel Feceoru wrote:
On 15.02.2016 12:23, Takashi Iwai wrote:
On Fri, 12 Feb 2016 17:47:21 +0100,
Gabriel Feceoru wrote:
!!! This caused a regression in the i-g-t drv_module_reload_basic test.
Reproducible
On 15.02.2016 12:23, Takashi Iwai wrote:
On Fri, 12 Feb 2016 17:47:21 +0100,
Gabriel Feceoru wrote:
!!! This caused a regression in the i-g-t drv_module_reload_basic test.
Reproducible easily on HSW (i5-4460) with:
#rmmod snd_hda_intel
I couldn't reproduce this on my HSW machine.
!!! This caused a regression in the i-g-t drv_module_reload_basic test.
Reproducible easily on HSW (i5-4460) with:
#rmmod snd_hda_intel
The bisect shows this as the offending commit:
commit 25e4abb33df3aafa7d1efba8f82f9178268efab1
Author: Libin Yang
Date: Tue Jan 12 11:13:27 2016 +0800
Some platforms have ring BSD available but no BSD2.
Because of the current verification, tests involving ring BSD1
will be skipped if no BSD2 is available.
Decoupling the checks will allow running the BSD1 specific tests
on these platforms.
Signed-off-by: Gabriel Feceoru
---
lib
Moved gem_quiescent_gpu() call to the run path.
Signed-off-by: Gabriel Feceoru
---
tests/gem_ringfill.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/gem_ringfill.c b/tests/gem_ringfill.c
index 407b747..2e8c7c1 100644
--- a/tests/gem_ringfill.c
+++ b/tests
already exists
on ivybridge (Ville)
v3: Remove unnecessary MMIO read, correct the description (Damien)
v4: Be more specific in description (Patrick)
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/i915_dma.c | 3 +++
drivers/gpu/drm/i915/i915_reg.h | 1 +
2 files changed, 4 insertions
ivybridge (Ville)
v3: Remove unnecessary MMIO read, correct the description (Damien)
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/i915_dma.c | 3 +++
drivers/gpu/drm/i915/i915_reg.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915
Starting with Gen7 (IVB) Display PipeC can be fused off on some production
parts. When disabled, display hardware will prevent the pipe C register bit
from being set to 1.
Fixed by adjusting pipe_count to reflect this.
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/i915_dma.c | 3
On 11.01.2016 19:56, Ville Syrjälä wrote:
On Mon, Dec 21, 2015 at 01:57:22PM +0200, Gabriel Feceoru wrote:
On some HSW boards all pipeC tests fail with various dmesg errors.
This seems to be caused by Pipe C beeing disabled in FUSE_STRAP and
thus reading back the PIPECONF register is always
/0x10
v2:
Fixed return value in skl_ddi_pll_get_hw_state
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/intel_ddi.c | 50 +---
1 file changed, 37 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915
/0x10
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/intel_ddi.c | 48 ++--
1 file changed, 36 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index e6408e5..4ba9f2c 100644
--- a/drivers
On 30.12.2015 15:03, Joonas Lahtinen wrote:
Hi,
On ti, 2015-12-29 at 12:55 +0200, Gabriel Feceoru wrote:
This fixes an issue added with: "1f814da drm/i915: add support for
checking
if we hold an RPM reference", noticed while running
drv_module_reload_basic.
WARNING: CPU: 1 PI
0x20/0xc1c [i915]
Reported-by: Marius Vlad
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915/i915_dma.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 988a380..08ad01f0 100644
--- a/drivers/gpu/drm/i915/
On some HSW boards all pipeC tests fail with various dmesg errors.
This seems to be caused by Pipe C beeing disabled in FUSE_STRAP and
thus reading back the PIPECONF register is always zero.
Fixed by adjusting pipe_count to 2 and thus the pipeC igt tests will
be skipped.
Signed-off-by: Gabriel
On 26.11.2015 18:43, Thomas Wood wrote:
On 25 November 2015 at 12:12, Gabriel Feceoru wrote:
This is a placeholder for the feature list file. Its content is just
an example.
It would be useful if the example applied directly to intel-gpu-tools
tests. Perhaps just a single feature to start
, Gabriel
Date: Tue Nov 3 17:50:41 2015 +0200
framework: Add support for feature readiness.
v2:
- Moved the file to tests directory
- Replaced the example with a real feature
Signed-off-by: Gabriel Feceoru
---
tests/feat_profile.json | 7 +++
1 file changed, 7 insertions
This script takes multiple test results and prints the diffs, useful
for detecting noise in subsequent executions.
It gives the option to re-run these tests.
Signed-off-by: Gabriel Feceoru
---
scripts/retest-diff.sh | 72 ++
1 file changed, 72
f16d011db75b08ceae241e7370599146691340ab
Author: Feceoru, Gabriel
Date: Tue Nov 3 17:50:41 2015 +0200
framework: Add support for feature readiness.
Signed-off-by: Gabriel Feceoru
---
scripts/feat_profile.json | 12
1 file changed, 12 insertions(+)
create mode 100644 scripts/feat_profile.json
diff
On 16.11.2015 17:53, Jani Nikula wrote:
On Mon, 16 Nov 2015, Maarten Lankhorst
wrote:
When diagnosing a unrelated bug for someone on irc, it would seem the hardware
can
be brought up by the BIOS with the embedded displayport using the SPLL for
spread spectrum.
Right now this is not handle
On 12.11.2015 10:28, Lankhorst, Maarten wrote:
Hey,
Gabriel Feceoru schreef op wo 11-11-2015 om 20:27 [+0200]:
On 11.11.2015 16:21, Jani Nikula wrote:
On Wed, 11 Nov 2015, Ander Conselvan De Oliveira wrote:
On Tue, 2015-11-10 at 14:53 +0200, Jani Nikula wrote:
Ander, Maarten, where are
On 11.11.2015 16:21, Jani Nikula wrote:
On Wed, 11 Nov 2015, Ander Conselvan De Oliveira wrote:
On Tue, 2015-11-10 at 14:53 +0200, Jani Nikula wrote:
Ander, Maarten, where are we with this? Is it horribly wrong to merge
the original patch in this ever-growing and diverging thread?
I think
Using 2 connectors (DVI and VGA) will cause wrpll to be set for
INTEL_OUTPUT_HDMI but never reset if switching to INTEL_OUTPUT_VGA
Supresses errors like these:
[drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in dpll_hw_state.wrpll
Signed-off-by: Gabriel Feceoru
---
drivers/gpu/drm/i915
57 matches
Mail list logo