Dmitry Vyukov wrote:
> On Wed, Aug 1, 2018 at 12:35 PM, Florian Westphal wrote:
> > Dmitry Vyukov wrote:
> >> Still can't grasp all details.
> >> There is state that we read without taking ct->ct_general.use ref
> >> first, namely ct->state and wh
Dmitry Vyukov wrote:
> If that scenario is possible that a fix would be to make
Looks possible.
> __nf_conntrack_find_get ever return NULL iff it got NULL from
> nf_conntrack_find (not if any of the checks has failed).
I don't see why we need to restart on nf_ct_is_dying(), but other
than t
Dmitry Vyukov wrote:
> Still can't grasp all details.
> There is state that we read without taking ct->ct_general.use ref
> first, namely ct->state and what's used by nf_ct_key_equal.
> So let's say the entry we want to find is in the list, but
> nf_conntrack_find finds a wrong entry earlier b
Andrey Ryabinin wrote:
> Guys, it seems that we have a lot of code using SLAB_TYPESAFE_BY_RCU cache
> without constructor.
> I think it's nearly impossible to use that combination without having bugs.
> It's either you don't really need the SLAB_TYPESAFE_BY_RCU, or you need to
> have a construct
