Re: [Intel-gfx] [PATCH i-g-t] tests/prime_vgem: Give meaningful messages on SKIP

2019-12-12 Thread Ewelina Musial
r. > Fix it. > > Signed-off-by: Janusz Krzysztofik > Cc: Ewelina Musial > --- > tests/prime_vgem.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c > index 6595818c..3bdb2300 100644 > --- a

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/drv_suspend: Suspend under memory pressure

2018-06-08 Thread Ewelina Musial
On Thu, Jun 07, 2018 at 09:50:54PM +0100, Chris Wilson wrote: > Recently we discovered that we have a race between swapping and > suspend in our resume path (we might be trying to page in an object > after disabling the block devices). Let's try to exercise that by > exhausting all of system memory

Re: [Intel-gfx] [igt-dev] [PATCH] selftests/i915_gem_gtt: Create igt_ggtt_scratch subtest

2018-04-11 Thread Ewelina Musial
On Wed, Apr 11, 2018 at 11:43:34AM +0100, Chris Wilson wrote: > Quoting Ewelina Musial (2018-04-11 11:20:56) > > On Wed, Apr 11, 2018 at 09:48:21AM +0100, Chris Wilson wrote: > > > Quoting Ewelina Musial (2018-04-11 09:27:12) > > > > Test have similar functionality

Re: [Intel-gfx] [igt-dev] [PATCH] selftests/i915_gem_gtt: Create igt_ggtt_scratch subtest

2018-04-11 Thread Ewelina Musial
On Wed, Apr 11, 2018 at 09:48:21AM +0100, Chris Wilson wrote: > Quoting Ewelina Musial (2018-04-11 09:27:12) > > Test have similar functionality that gem_cs_prefetch IGT test > > but gem_cs_prefetch is not up to date and there was an idea > > to move this test to kselftests s

[Intel-gfx] [PATCH i-g-t] gem_cs_prefetch: Remove gem_cs_prefetch from IGT

2018-04-11 Thread Ewelina Musial
gem_cs_prefetch is replaced by igt_ggtt_scratch subtest in i915_gem_gtt kselftest --- tests/Makefile.sources | 1 - tests/gem_cs_prefetch.c | 149 --- tests/intel-ci/blacklist.txt | 1 - tests/meson.build| 1 - 4 files changed, 1

[Intel-gfx] [PATCH] selftests/i915_gem_gtt: Create igt_ggtt_scratch subtest

2018-04-11 Thread Ewelina Musial
Test have similar functionality that gem_cs_prefetch IGT test but gem_cs_prefetch is not up to date and there was an idea to move this test to kselftests so this is respond for this request. There is another patch on igt_dev which is removing gem_cs_prefetch test from IGT. --- drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH igt 08/10] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-12-04 Thread Ewelina Musial
> worse, that work is wasted if the subtest will be skipped. > > pm_rc6_residency is one such example that measured all the residencies > up front before skipping, each skip was therefore taking in excess of > 10s. > > Signed-off-by: Chris Wilson Reviewed-by: Ewelina Musial

Re: [Intel-gfx] [PATCH igt 08/10] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-12-04 Thread Ewelina Musial
On Mon, Dec 04, 2017 at 09:27:29AM +, Chris Wilson wrote: > CI doesn't run in whole-test mode, but runs each subtest individually. > Tests that are designed to do a block of work to be shared between many > subtests end up running that work multiple times (once per subtest) and > worse, that wo

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-29 Thread Ewelina Musial
On Tue, Nov 28, 2017 at 01:16:50PM +0200, Arkadiusz Hiler wrote: > On Mon, Nov 27, 2017 at 09:10:37PM +0530, Sagar Arun Kamble wrote: > > I feel we generally tend to ignore the results mails for series that > > we are not actively involved on (although we might be interested in > > series itself).

Re: [Intel-gfx] [PATCH 3/4] drm/i915: expose engine availability through sysfs

2017-11-21 Thread Ewelina Musial
On Mon, Nov 20, 2017 at 03:57:49PM +, Tvrtko Ursulin wrote: > > On 20/11/2017 12:23, Lionel Landwerlin wrote: > > This enables userspace to discover the engines available on the GPU. > > Here is the layout on a Skylake GT4: > > > > /sys/devices/pci:00/:00:02.0/drm/card0/gt > > ├── bcs

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: fix 64bit divide

2017-11-13 Thread Ewelina Musial
Use div64_u64 (Matthew) > > v3: store frequency in kHz to avoid 64bit divs (Chris/Ville) > > Fixes: dab9178333 ("drm/i915: expose command stream timestamp frequency to > userspace") > Reported-by: Matthew Auld > Signed-off-by: Lionel Landwerlin Reviewed-by: E

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/perf: replace .reg accesses with i915_mmio_reg_offset

2017-11-13 Thread Ewelina Musial
On Mon, Nov 13, 2017 at 11:34:52PM +, Lionel Landwerlin wrote: > This replaces accesses to the reg field of the i915_reg_t structure > with the i915_mmio_reg_offset() inline function. > > Suggested-by: Chris Wilson > Signed-off-by: Lionel Landwerlin Reviewed-by:

Re: [Intel-gfx] [PATCH 4/7] drm/i915: fix register naming

2017-11-12 Thread Ewelina Musial
t; Hence why the name isn't used anywhere. > > v2: Fix register name again RPC->RCP (Matthew) > > Signed-off-by: Lionel Landwerlin Reviewed-by: Ewelina Musial > --- > drivers/gpu/drm/i915/i915_reg.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Intel-gfx] [PATCH 2/7] drm/i915/perf: add support for Coffeelake GT3

2017-11-12 Thread Ewelina Musial
On Fri, Nov 10, 2017 at 07:08:40PM +, Lionel Landwerlin wrote: > We can enable GT3 as well as GT2. > > Signed-off-by: Lionel Landwerlin > Reviewed-by: Matthew Auld Reviewed-by: Ewelina Musial > --- > drivers/gpu/drm/i915/Makefile | 3 +- > drivers/gp

Re: [Intel-gfx] [PATCH 1/7] drm/i915/perf: complete whitelisting for OA programming on HSW

2017-11-12 Thread Ewelina Musial
On Fri, Nov 10, 2017 at 07:08:39PM +, Lionel Landwerlin wrote: > We were missing some registers and also can name one for which we only had > the offset. > > Signed-off-by: Lionel Landwerlin > Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/i915/i915_perf.c | 3 ++- > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: expose command stream timestamp frequency to userspace

2017-11-07 Thread Ewelina Musial
On Thu, Nov 02, 2017 at 04:29:46PM +, Lionel Landwerlin wrote: > We use to have this fixed per generation, but starting with CNL userspace > cannot tell just off the PCI ID. Let's make this information available. This > is particularly useful for performance monitoring where much of the > norma

Re: [Intel-gfx] [PATCH i-g-t v5 04/11] tests/perf: rc6: try to guess when rc6 is disabled

2017-10-02 Thread Ewelina Musial
On Thu, Aug 31, 2017 at 11:35:08AM +0100, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > tests/perf.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/tests/perf.c b/tests/perf.c > index bd139bde..5fe0a332 100644 > --- a/tests/perf.c > +++ b/tests/perf

Re: [Intel-gfx] [PATCH 08/31] drm/i915: Rename intel_enable_rc6 to intel_rc6_enabled

2017-09-26 Thread Ewelina Musial
ed-off-by: Sagar Arun Kamble Reviewed-by: Ewelina Musial - Ewelina > --- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > drivers/gpu/drm/i915/i915_sysfs.c | 2 +- > drivers/gpu/drm/i915/intel_drv.h | 2 +- > drivers/gpu/drm/i915/intel_guc.c | 3 ++- > drivers/gpu/drm/i915/in

Re: [Intel-gfx] [PATCH i-g-t 7/9] tests/perf: Add testcase to verify mmio

2017-09-21 Thread Ewelina Musial
"/proc/sys/dev/i915/perf_stream_paranoid", 1); > + > + igt_fork(child, 1) { > + int prop_size = ARRAY_SIZE(properties); > + int num_reports = 10; > + int report_size = get_perf_report_size(properties, prop_size, &

Re: [Intel-gfx] [PATCH i-g-t 3/9] tests/perf: Add testcase to verify ctx id

2017-09-21 Thread Ewelina Musial
On Wed, Sep 13, 2017 at 04:22:02PM +0530, Sagar Arun Kamble wrote: > This subtest verifies that the CS perf samples contains > proper HW context ID as captured through CONTEXT_PARAM_HW_ID. > > v2: Updated property enum names. > > Signed-off-by: Sagar Arun Kamble Reviewed-

Re: [Intel-gfx] [PATCH i-g-t 2/9] tests/perf: Test i915 assisted command stream based perf metrics capture

2017-09-21 Thread Ewelina Musial
; Cc: Lionel Landwerlin > Signed-off-by: Sagar Arun Kamble Reviewed-by: Ewelina Musial > --- > tests/Makefile.sources | 1 + > tests/intel_perf_dapc.c | 811 > > 2 files changed, 812 insertions(+) > create mode

Re: [Intel-gfx] [PATCH 1/2] dim: make dim tag-next generate annotated tags

2017-09-11 Thread Ewelina Musial
On Mon, Sep 11, 2017 at 04:15:59PM +0300, Jani Nikula wrote: > Presumably an oversight while converting update-next-continue to use > annotated tags. > > Cc: Daniel Vetter > Signed-off-by: Jani Nikula Reviewed-by: Ewelina Musial > --- > dim | 2 +- > 1 file changed, 1

[Intel-gfx] [PATCH i-g-t 2/2] tests/drv_suspend: Add subtests to check that forcewake is kept after resume

2017-07-25 Thread Ewelina Musial
In some cases we observed that forcewake isn't kept after resume and checking RC6 residency is a simple way to verify that. If forcewake is kept after resume residency should be constant. Cc: Lukasz Fiedorowicz Cc: Radoslaw Szwichtenberg Cc: Michal Winiarski Signed-off-by: Ewelina M

[Intel-gfx] [PATCH i-g-t 1/2] igt: Move read_rc6_residency function to lib

2017-07-25 Thread Ewelina Musial
Gem_mocs_settings and pm_rc6_residency tests are defining the same functionality to read residency from sysfs. Moving that function to lib/igt_aux and updating tests. Signed-off-by: Ewelina Musial --- lib/igt_aux.c | 8 lib/igt_aux.h | 5 + tests

[Intel-gfx] [PATCH i-g-t] igt: Move read_rc6_residency function to lib

2017-07-25 Thread Ewelina Musial
Gem_mocs_settings and pm_rc6_residency tests are defining the same functionality to read residency from sysfs. Moving that function to lib/igt_aux and updating tests. Signed-off-by: Ewelina Musial --- lib/igt_aux.c | 8 lib/igt_aux.h | 5 + tests

[Intel-gfx] [PATCH i-g-t] tests/pm_rc6_residency: Add subtest to check RC6 suspend handling

2017-04-24 Thread Ewelina Musial
In some cases we observed that forcewake isn't kept after resume and then RC6 residency is not constant. References: HSD#1804921797 Cc: Arkadiusz Hiler Cc: Michal Winiarski Cc: Lukasz Fiedorowicz Signed-off-by: Ewelina Musial --- tests/pm_rc6_residency.c