Re: [PATCH] drm/i915/dp: Fix connector DSC HW state readout

2024-02-05 Thread Drew Davenport
vs. the connector's atomic state. > > Fixes: b2608c6b3212 ("drm/i915/dp_mst: Enable MST DSC decompression for all > streams") > Reported-by: Drew Davenport > Closes: https://lore.kernel.org/all/zb0q8idvxs0hx...@chromium.org > Signed-off-by: Imre Deak

Re: [v5, 25/30] drm/i915/dp_mst: Enable MST DSC decompression for all streams

2024-02-02 Thread Drew Davenport
On Tue, Nov 07, 2023 at 02:15:03AM +0200, Imre Deak wrote: > Enable DSC decompression for all streams. In particular atm if a sink is > connected to a last branch device that is downstream of the first branch > device connected to the source, decompression is not enabled for it. > Similarly it's no

Re: [Intel-gfx] [PATCH] drm/i915/display: assume some pixelrate for src smaller than 1

2023-01-11 Thread Drew Davenport
On Wed, Jan 11, 2023 at 09:39:26PM +0200, Ville Syrjälä wrote: > On Wed, Jan 11, 2023 at 11:28:51AM -0700, Drew Davenport wrote: > > On Wed, Jan 11, 2023 at 04:19:00PM +0200, Ville Syrjälä wrote: > > > On Wed, Jan 04, 2023 at 02:44:48PM +0200, Juha-Pekka Heikkila wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2023-01-11 Thread Drew Davenport
suming that something earlier on would catch and reject a src with zero width/height. Drew > > > ...alan > > On Mon, 2022-12-26 at 22:53 -0700, Drew Davenport wrote: > > The error message suggests that the height of the src rect must be at > > least 1. Rejec

Re: [Intel-gfx] [PATCH] drm/i915/display: assume some pixelrate for src smaller than 1

2023-01-11 Thread Drew Davenport
On Wed, Jan 11, 2023 at 04:19:00PM +0200, Ville Syrjälä wrote: > On Wed, Jan 04, 2023 at 02:44:48PM +0200, Juha-Pekka Heikkila wrote: > > intel_adjusted_rate() didn't take into account src rectangle > > can be less than 1 in width or height. > > This should not get called in those cases. What does

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2023-01-10 Thread Drew Davenport
t struct intel_crtc_state > *crtc_state, > > > What do you think? I'll in any case come up with some test for this in igt. I see that you've posted your fix to the list already. Adding a test to cover this in IGT also sounds great. Thanks! Breadcrumbs to Juha-Pekka's pat

[Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2022-12-26 Thread Drew Davenport
The error message suggests that the height of the src rect must be at least 1. Reject source with height of 0. Signed-off-by: Drew Davenport --- I was investigating some divide-by-zero crash reports on ChromeOS which pointed to the intel_adjusted_rate function. Further prodding showed that I

Re: [Intel-gfx] [v7 1/5] drm/edid: seek for available CEA and DisplayID block from specific EDID block index

2022-03-15 Thread Drew Davenport
On Tue, Mar 15, 2022 at 03:21:05PM +, Lee, Shawn C wrote: > On Tuesday, March 15, 2022 8:33 PM, Nikula, Jani > wrote: > >On Mon, 14 Mar 2022, Drew Davenport wrote: > >> On Mon, Mar 14, 2022 at 10:40:47AM +0200, Jani Nikula wrote: > >>> On Sun

Re: [Intel-gfx] [v7 1/5] drm/edid: seek for available CEA and DisplayID block from specific EDID block index

2022-03-14 Thread Drew Davenport
earch available > > DisplayID block. > > > > Cc: Jani Nikula > > Cc: Ville Syrjala > > Cc: Ankit Nautiyal > > Cc: Drew Davenport > > Cc: intel-gfx > > Signed-off-by: Lee Shawn C > > --- > > drivers/gpu/drm/drm_displayid.c | 10 +

Re: [Intel-gfx] [v6 1/5] drm/edid: seek for available CEA block from specific EDID block index

2022-03-11 Thread Drew Davenport
On Fri, Mar 11, 2022 at 09:22:14AM +0800, Lee Shawn C wrote: > drm_find_cea_extension() always look for a top level CEA block. Pass > ext_index from caller then this function to search next available > CEA ext block from a specific EDID block pointer. > > v2: save proper extension block index if C