[PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Brian Geffon
t shmem_sg_free_table() to use a folio_batch") Signed-off-by: Brian Geffon Suggested-by: Tomasz Figa --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/

Re: [PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Brian Geffon
On Mon, Jan 27, 2025 at 1:47 PM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 10:53:40AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > P

Re: [PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-24 Thread Brian Geffon
On Wed, Jan 22, 2025 at 10:07 PM Srinivas, Vidya wrote: > > Hello Brian, Many thanks for the fix. I am adding my tested-by. > Tested-by: Vidya Srinivas Thanks for testing Vidya. Can we get a maintainer to take a look? > > > > -Original Message- > > From:

[PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
rnel.org/lkml/20250116135636.410164-1-bgef...@google.com/ Fixes: 0b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch") Signed-off-by: Brian Geffon Suggested-by: Tomasz Figa --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 3 +-- drivers/gpu/drm/i915/gem

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:38 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > > When converting to folios the cleanup path of shmem_get_pages() was > > >

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > P

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > P

[PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
isn't handling compound pages correctly. Link: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13487 Fixes: 0b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch") Signed-off-by: Brian Geffon Suggested-by: Tomasz Figa --- drivers/gpu/drm/i915/gem/i

Re: [PATCH 3/4] drm/i915/dpt: Evict all DPT VMAs on suspend

2024-12-03 Thread Brian Geffon
On Tue, Dec 3, 2024 at 3:25 AM Ville Syrjälä wrote: > > On Tue, Dec 03, 2024 at 10:20:23AM +0200, Ville Syrjälä wrote: > > On Mon, Dec 02, 2024 at 10:40:36AM -0500, Brian Geffon wrote: > > > On Wed, Nov 27, 2024 at 1:11 AM Ville Syrjala > > > wrote: >

Re: [PATCH 3/4] drm/i915/dpt: Evict all DPT VMAs on suspend

2024-12-02 Thread Brian Geffon
e() has nothing to do. > To guarantee that all the DPT VMAs are evictable by > intel_dpt_suspend() we need to flush the cleanup workqueue > after the display output has been shut down. > > And for good measure throw in a few extra WARNs to catch > any mistakes. > >

Re: [PATCH 4/4] Revert "drm/i915/dpt: Make DPT object unshrinkable"

2024-11-27 Thread Brian Geffon
T objects. > > Cc: Brian Geffon > Cc: Vidya Srinivas > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12965 > Signed-off-by: Ville Syrjälä Acked-by: Brian Geffon > --- > drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 +--- > 1 file changed, 1 insertion

Re: [PATCH 2/2] [RFC] drm/i915: Unbind the vma in suspend if it was bound

2024-11-25 Thread Brian Geffon
On Mon, Nov 25, 2024 at 3:51 PM Vidya Srinivas wrote: > > In i915_ggtt_suspend_vm, if the vma was bound, the path > to unbind/evict is not hitting during suspend. This is > causing issues with DPT where DPT gets shrunk but the > framebuffer is still on the DPT's bound list. This > causes system re