Re: [Intel-gfx] [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-23 Thread Benson Leung
t8_t address; > + }; > +} __packed; > + > +/* Read various CEC parameters */ > +#define EC_CMD_CEC_GET 0x00BB > + > +struct ec_params_cec_get { > + uint8_t cmd; /* enum cec_command */ > +} __packed; > + > +struct ec_response_cec_get { > + union { > +

Re: [Intel-gfx] [PATCH 1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper

2018-05-22 Thread Benson Leung
ne DP_DPCD_REV_12 0x12 > +# define DP_DPCD_REV_13 0x13 > +# define DP_DPCD_REV_14 0x14 > > #define DP_MAX_LINK_RATE0x001 > > -- > 2.17.0 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google In

Re: [Intel-gfx] [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4

2018-03-16 Thread Benson Leung
changes > V5: typo > V6: print statement revisions, DP_REV to DPCD_REV, comment correction > V7: typo > V8: Style > > Signed-off-by: Matt Atwood Tested-by: Benson Leung This version still passes link training on the panel with 8th bit set in DPCD 0x000e. Thanks, Benson --

Re: [Intel-gfx] [PATCH] drm/i915: make edp optimize config

2018-03-08 Thread Benson Leung
; s/then/than > Signed-off-by: Matt Atwood Tested-by: Benson Leung Tested this on a panel and system with the following source and sink rates: [1.623225] [drm:intel_dp_print_rates] source rates: 162000, 216000, 27, 324000, 432000, 54 [1.623230] [drm:intel_dp_print_ra

Re: [Intel-gfx] [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4

2018-03-07 Thread Benson Leung
gt; V4: style changes > V5: typo > > Signed-off-by: Matt Atwood Tested-by: Benson Leung V5 passes link training on that same panel from before with 8th bit set in DPCD 0x000e. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromiu

Re: [Intel-gfx] [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4

2018-03-07 Thread Benson Leung
rce/src/third_party/kernel/v4.14/drivers/gpu/drm/drm_dp_helper.c:131:1: error: expected ';' before '}' token } ^ make[4]: *** [/mnt/host/source/src/third_party/kernel/v4.14/scripts/Makefile.build:320: drivers/gpu/drm/drm_dp_helper.o]

Re: [Intel-gfx] v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-06 Thread Benson Leung
Hi Daniel, I've just tried drm-intel-fixes merged into v3.9-rc1, and so far it's looking good. No suspicious timeouts. Thanks for the quick response! Benson On Wed, Mar 6, 2013 at 12:14 AM, Daniel Vetter wrote: > On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung wrote: >> I