Looks good to me, thanks for the test case (btw maybe it's worth
mentioning in the commit message that the test fails without doing
gt.resume?)
Reviewed-by: Jakub Bartmiński
On Thu, 2018-08-30 at 14:48 +0100, Chris Wilson wrote:
> Although we cannot do a full system-level test of suspend/hiberna
On Thu, 2018-08-30 at 10:52 +0100, Chris Wilson wrote:
> +static int igt_gem_suspend(void *arg)
[...]
> + if (i915_gem_suspend(i915)) {
> + pr_err("i915_gem_suspend failed\n");
> + err = -EINVAL;
> + goto out;
> + }
> +
> + i915_gem_suspend_late(i915
On Thu, 2018-08-02 at 10:14 +0100, Chris Wilson wrote:
> Quoting Bartminski, Jakub (2018-08-02 09:56:10)
> > On Wed, 2018-08-01 at 15:22 +0100, Chris Wilson wrote:
> > > Quoting Jakub Bartmiński (2018-08-01 14:56:11)
> > > > [...]
> > > Though the argume
On Wed, 2018-08-01 at 15:22 +0100, Chris Wilson wrote:
> Quoting Jakub Bartmiński (2018-08-01 14:56:11)
> > [...]
> > + /* We have already tried preempting, but the hardware did
> > not react */
> > + if (engine->hangcheck.try_preempt)
> > + return false;
> > +
> > +
On Fri, 2018-07-27 at 10:51 +0100, Chris Wilson wrote:
> Quoting Patchwork (2018-07-27 10:35:57)
> > == Series Details ==
> >
> > Series: series starting with [v6,1/6] drm/i915/guc: Avoid wasting
> > memory on incorrect GuC pin bias
> > URL : https://patchwork.freedesktop.org/series/47328/
> > S
On Tue, 2018-07-17 at 14:19 +0200, Michal Wajdeczko wrote:
> On Tue, 17 Jul 2018 13:55:58 +0200, Jakub Bartmiński
> wrote:
>
> > It would seem that we are using uninitialized WOPCM variables when
> > setting the GuC pin bias. The pin bias has to be set after the
> > WOPCM,
> > but before the ca
