Re: [Intel-gfx] [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-14 Thread Andrey Grodzovsky
On 2021-07-13 12:45 p.m., Daniel Vetter wrote: On Tue, Jul 13, 2021 at 6:11 PM Andrey Grodzovsky wrote: On 2021-07-13 5:10 a.m., Daniel Vetter wrote: On Tue, Jul 13, 2021 at 9:25 AM Christian König wrote: Am 13.07.21 um 08:50 schrieb Daniel Vetter: On Tue, Jul 13, 2021 at 8:35 AM

Re: [Intel-gfx] [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-13 Thread Andrey Grodzovsky
uld be enough, but we actually requiring ordering between that and the queue state. v2: Put smp_rmp() in the right place and fix up comment (Andrey) Signed-off-by: Daniel Vetter Cc: "Christian König" Cc: Steven Price Cc: Daniel Vetter Cc: Andrey Grodzovsky Cc: Lee Jones Cc: Boris Bre

Re: [Intel-gfx] [PATCH v3 03/20] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-08 Thread Andrey Grodzovsky
need full barriers here, at first I thought store-release and load-acquire on ->last_scheduled would be enough, but we actually requiring ordering between that and the queue state. Signed-off-by: Daniel Vetter Cc: "Christian König" Cc: Steven Price Cc: Daniel Vetter Cc: Andrey Grodzo

[Intel-gfx] [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-20 Thread Andrey Grodzovsky
ommit where such probelm can be identified. v2: Fix typos and extra newlines. Change-Id: I3ee28ffae35fd1e8bfe553146c44da53da02e6f8 Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/drm_atomic.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gp

Re: [Intel-gfx] [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-19 Thread Andrey Grodzovsky
On 06/19/2017 03:24 PM, Sean Paul wrote: On Mon, Jun 19, 2017 at 11:35:28AM -0400, Harry Wentland wrote: On 2017-06-09 05:30 PM, Andrey Grodzovsky wrote: Problem: While running IGT kms_atomic_transition test suite i encountered a hang in drmHandleEvent immidietly follwoing an atomic_commit

Re: [Intel-gfx] [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-15 Thread Andrey Grodzovsky
Just a reminder. Thanks. On 06/09/2017 05:30 PM, Andrey Grodzovsky wrote: Problem: While running IGT kms_atomic_transition test suite i encountered a hang in drmHandleEvent immidietly follwoing an atomic_commit. After dumping the atomic state I relized that in this case there was not even one

Re: [Intel-gfx] [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-12 Thread Andrey Grodzovsky
On 06/12/2017 07:08 AM, Maarten Lankhorst wrote: Op 09-06-17 om 23:30 schreef Andrey Grodzovsky: Problem: While running IGT kms_atomic_transition test suite i encountered a hang in drmHandleEvent immidietly follwoing an atomic_commit. After dumping the atomic state I relized that in this case

[Intel-gfx] [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-09 Thread Andrey Grodzovsky
ng on user side will happen. Fix: Explicitly fail by failing atomic_commit early in drm_mode_atomic_commit where such problem can be identified. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/drm_atomic.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/dr