Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-26 Thread Alex Elder
main implementation is renamed as pm_runtime_get_conditional(). Signed-off-by: Sakari Ailus Reviewed-by: Alex Elder # drivers/net/ipa/ipa_smp2p.c I actually intended my "Reviewed-by" to cover the entire patch. I checked every caller and they all lo

Re: [Intel-gfx] [greybus-dev] [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Alex Elder
On 2/27/22 5:11 PM, Linus Torvalds wrote: On Sun, Feb 27, 2022 at 3:04 PM Alex Elder wrote: Glancing at the Greybus code, I don't believe there's any reason it needs to shift a negative value. Such warnings could be fixed by making certain variables unsigned, for example. As me

Re: [Intel-gfx] [greybus-dev] [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Alex Elder
On 2/27/22 3:52 PM, Arnd Bergmann wrote: From: Arnd Bergmann During a patch discussion, Linus brought up the option of changing the C standard version from gnu89 to gnu99, which allows using variable declaration inside of a for() loop. While the C99, C11 and later standards introduce many other

Re: [Intel-gfx] [PATCH v2 2/4] clk: bcm/kona: use DIV_ROUND_CLOSEST_ULL()

2015-03-24 Thread Alex Elder
On 03/24/2015 09:03 AM, Javi Merino wrote: > Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal > implementation and use the kernel one. > > Cc: Mike Turquette > Cc: Stephen Boyd > Cc: Alex Elder Acked-by: Alex Elder > Signed-off-by: Javi Merino

Re: [Intel-gfx] [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

2015-03-23 Thread Alex Elder
On 03/20/2015 06:14 AM, Javi Merino wrote: > We have grown a number of different implementations of > DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to > kernel.h so that it can be reused. > > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: David Airlie > Cc: Darrick J. Wong > Cc: G

Re: [Intel-gfx] [PATCH 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

2015-03-23 Thread Alex Elder
On 03/20/2015 12:27 PM, Javi Merino wrote: > On Fri, Mar 20, 2015 at 01:51:36PM +0000, Alex Elder wrote: >> On 03/20/2015 06:14 AM, Javi Merino wrote: >>> Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal >>> implementation and use the kernel one.

Re: [Intel-gfx] [PATCH 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

2015-03-23 Thread Alex Elder
On 03/20/2015 06:14 AM, Javi Merino wrote: > Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal > implementation and use the kernel one. > > Cc: Antti Palosaari > Cc: Mauro Carvalho Chehab > Signed-off-by: Javi Merino > --- > I've only compile-tested it, I don't have the ha