✓ i915.CI.BAT: success for drm/i915: Precompute plane SURF address/etc.

2025-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Precompute plane SURF address/etc. URL : https://patchwork.freedesktop.org/series/147097/ State : success == Summary == CI Bug Log - changes from CI_DRM_16361 -> Patchwork_147097v1 Summary --- *

Re: [PATCH v6 4/8] drm/i915/gem: Add i915_gem_object_panic_map()

2025-04-01 Thread Jocelyn Falempe
On 01/04/2025 19:47, Ville Syrjälä wrote: On Tue, Apr 01, 2025 at 02:51:10PM +0200, Jocelyn Falempe wrote: Prepare the work for drm_panic support. This is used to map the current framebuffer, so the CPU can overwrite it with the panic message. Signed-off-by: Jocelyn Falempe --- v5: * Use io

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Precompute plane SURF address/etc.

2025-04-01 Thread Patchwork
== Series Details == Series: drm/i915: Precompute plane SURF address/etc. URL : https://patchwork.freedesktop.org/series/147097/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/147097/revisions/1/mbox/ not found

[PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test

2025-04-01 Thread Vinay Belgaumkar
Add a basic test that uses PMU to read GT actual and requested frequencies while running a workload. Cc: Lucas De Marchi Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 93 1 file changed, 93 insertions(+) diff --git a/t

[PATCH i-g-t 0/2] Add PMU tests for GT frequency

2025-04-01 Thread Vinay Belgaumkar
Also move some frequency helpers to lib. Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/xe_gt: Move get/set GT freq utils to lib tests/xe_pmu: Add frequency test lib/xe/xe_gt.c | 59 ++ lib/xe/xe_gt.h | 2 + tests/intel/xe_gt_freq.c | 164 +

[PATCH i-g-t 1/2] lib/xe_gt: Move get/set GT freq utils to lib

2025-04-01 Thread Vinay Belgaumkar
These can be used from other tests as well. Signed-off-by: Vinay Belgaumkar --- lib/xe/xe_gt.c | 59 ++ lib/xe/xe_gt.h | 2 + tests/intel/xe_gt_freq.c | 164 +++ 3 files changed, 125 insertions(+), 100 deletions(-) diff --gi

[PATCH 5/9] drm/i915: Remove unused dpt_total_entries()

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä dpt_total_entries() is not used anywhere. Remove it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpt.c b/drivers/gpu/drm/i915/display/intel_dpt.c index 2bf

[PATCH 0/9] drm/i915: Precompute plane SURF address/etc.

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä Include a precomputed plane SURF address in the plane state, so that all the vma stuff is contained in the *_fb_pin.c code. Additionally we can also now easily include the SURF address in some of the plane tracepoints to aid in eg. analyzing faults. Ville Syrjälä (9): drm/i

[PATCH 8/9] drm/i915: Add tracepoint for plane faults

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä When analying plane faults the exact sequence/timing of things can be important. Add a tracepoint for plane faults that can then be correclated against other tracepoints to figure out what happened and when. Signed-off-by: Ville Syrjälä --- .../gpu/drm/i915/display/intel_di

[PATCH 9/9] drm/i915: Include plane ctl/surf registers in the plane update_arm() tracepoint

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä The plane fault tracepoints report the plane control and surface register values. In order to correlate those against the plane update tracepoints it might be helpful to also include that information in the plane update tracepoints as well. The one caveat here is that the pre

[PATCH 3/9] drm/i915: Move the intel_dpt_offset() check into intel_plane_pin_fb()

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä Now that we handle all the other vma offset stuff in intel_plane_pin_fb() it seems more proper to do the dpt_vma offset check there as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fb_pin.c| 7 +++ drivers/gpu/drm/i915/display/skl_uni

[PATCH 6/9] drm/i915: Don't pass crtc_state to foo_plane_ctl() & co.

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä The *_plane_ctl() functions only consider the state of the plane (the state of the crtc is handled by the corresponding *_plane_ctl_crtc()), and thus they don't need the crtc_state at all. Don't pass it in. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i9xx_

[PATCH 1/9] drm/i915: Precompute plane SURF address

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä Currently we pre-compute the plane surface/base address partially (only for cursor_needs_physical cases) in intel_plane_pin_fb() and finish the calculation in the plane->update_arm(). Let's just precompute the whole thing instead. One benefit is that we get rid of all the vma

[PATCH 4/9] drm/i915: Use i915_vma_offset() in intel_dpt_offset()

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä Replace the open coded vma mm node stuff in intel_dpt_offset() with i915_vma_offset(). This will also include the VT-d guard in the result. Granted that should always be 0 for DPT, but it seems prudent to include that in our DPT vma offset check anyway. Signed-off-by: Ville S

Re: [PATCH 3/4] drm/i915/gem: Allow EXEC_CAPTURE on recoverable contexts on DG1

2025-04-01 Thread Andi Shyti
Hi Ville, > > if (i915_gem_context_is_recoverable(eb->gem_context) && > > - (IS_DGFX(eb->i915) || GRAPHICS_VER_FULL(eb->i915) > > > IP_VER(12, 0))) > > + GRAPHICS_VER_FULL(eb->i915) > IP_VER(12, 10)) > > How is this is more relaxed than the old version? n

Re: [PATCH v6 4/8] drm/i915/gem: Add i915_gem_object_panic_map()

2025-04-01 Thread Jocelyn Falempe
On 01/04/2025 19:57, Ville Syrjälä wrote: On Tue, Apr 01, 2025 at 08:47:50PM +0300, Ville Syrjälä wrote: On Tue, Apr 01, 2025 at 02:51:10PM +0200, Jocelyn Falempe wrote: Prepare the work for drm_panic support. This is used to map the current framebuffer, so the CPU can overwrite it with the pan

[PATCH 4/4] drm/i915/pci: Remove force_probe requirement for DG1

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä Dunno why we still have .require_force_probe=1 on DG1 after all this time. I'm not aware of any real problems with DG1, so get rid of the force_probe requirement. Generally the difficulty with DG1 is that it requires a 4GiB BAR for the local memory, and that's not something t

✓ i915.CI.BAT: success for drm/i915/display: Add link rate and lane count to i915_display_info (rev2)

2025-04-01 Thread Patchwork
== Series Details == Series: drm/i915/display: Add link rate and lane count to i915_display_info (rev2) URL : https://patchwork.freedesktop.org/series/146468/ State : success == Summary == CI Bug Log - changes from CI_DRM_16360 -> Patchwork_146468v2 ===

Re: [PATCH v6 2/8] drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes

2025-04-01 Thread Jocelyn Falempe
On 01/04/2025 19:38, Ville Syrjälä wrote: On Tue, Apr 01, 2025 at 02:51:08PM +0200, Jocelyn Falempe wrote: drm_panic draws in linear framebuffer, so it's easier to re-use the current framebuffer, and disable tiling in the panic handler, to show the panic screen. Signed-off-by: Jocelyn Falempe

Re: [PATCH] x86/platform/iosf_mbi: Remove unused iosf_mbi_unregister_pmic_bus_access_notifier

2025-04-01 Thread Ingo Molnar
* Dr. David Alan Gilbert wrote: > * Ingo Molnar (mi...@kernel.org) wrote: > > > > * li...@treblig.org wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > The last use of iosf_mbi_unregister_pmic_bus_access_notifier() was > > > removed in 2017 by > > > commit a5266db4d314 ("drm/i915

✓ i915.CI.BAT: success for drm/i915: DG1 fixes

2025-04-01 Thread Patchwork
== Series Details == Series: drm/i915: DG1 fixes URL : https://patchwork.freedesktop.org/series/147081/ State : success == Summary == CI Bug Log - changes from CI_DRM_16358 -> Patchwork_147081v1 Summary --- **SUCCESS** No regressi

✗ Fi.CI.SPARSE: warning for drm/i915: DG1 fixes

2025-04-01 Thread Patchwork
== Series Details == Series: drm/i915: DG1 fixes URL : https://patchwork.freedesktop.org/series/147081/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning: unrepl

Re: [PATCH v6 4/8] drm/i915/gem: Add i915_gem_object_panic_map()

2025-04-01 Thread Ville Syrjälä
On Tue, Apr 01, 2025 at 08:47:50PM +0300, Ville Syrjälä wrote: > On Tue, Apr 01, 2025 at 02:51:10PM +0200, Jocelyn Falempe wrote: > > Prepare the work for drm_panic support. This is used to map the > > current framebuffer, so the CPU can overwrite it with the panic > > message. > > > > Signed-off-

Re: [PATCH 3/4] drm/i915/gem: Allow EXEC_CAPTURE on recoverable contexts on DG1

2025-04-01 Thread Ville Syrjälä
On Tue, Apr 01, 2025 at 07:34:11PM +0200, Andi Shyti wrote: > Hi Ville, > > On Tue, Apr 01, 2025 at 07:37:51PM +0300, Ville Syrjala wrote: > > The intel-media-driver is currently broken on DG1 because > > it uses EXEC_CAPTURE with recovarable contexts. Relax the > > check to allow that. > > > > I

Re: [PATCH 4/5] kbuild: hdrtest: place header test files in .hdrtest subdirectories

2025-04-01 Thread Masahiro Yamada
On Tue, Apr 1, 2025 at 9:19 PM Jani Nikula wrote: > > The header tests track whether headers have been checked using empty > *.hdrtest files in the build tree. This pollutes the build directories, > as the files live in the same "name space" as the real output files, > messing with TAB completion

Re: [PATCH v6 4/8] drm/i915/gem: Add i915_gem_object_panic_map()

2025-04-01 Thread Ville Syrjälä
On Tue, Apr 01, 2025 at 02:51:10PM +0200, Jocelyn Falempe wrote: > Prepare the work for drm_panic support. This is used to map the > current framebuffer, so the CPU can overwrite it with the panic > message. > > Signed-off-by: Jocelyn Falempe > --- > > v5: > * Use iosys_map for intel_bo_panic_m

Re: [PATCH v6 2/8] drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes

2025-04-01 Thread Ville Syrjälä
On Tue, Apr 01, 2025 at 02:51:08PM +0200, Jocelyn Falempe wrote: > drm_panic draws in linear framebuffer, so it's easier to re-use the > current framebuffer, and disable tiling in the panic handler, to show > the panic screen. > > Signed-off-by: Jocelyn Falempe > --- > drivers/gpu/drm/i915/displ

Re: [PATCH 4/4] drm/i915/pci: Remove force_probe requirement for DG1

2025-04-01 Thread Andi Shyti
Hi Ville, On Tue, Apr 01, 2025 at 07:37:52PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Dunno why we still have .require_force_probe=1 on DG1 after > all this time. I'm not aware of any real problems with DG1, > so get rid of the force_probe requirement. Excellent! > Generally the d

Re: [PATCH 3/4] drm/i915/gem: Allow EXEC_CAPTURE on recoverable contexts on DG1

2025-04-01 Thread Andi Shyti
Hi Ville, On Tue, Apr 01, 2025 at 07:37:51PM +0300, Ville Syrjala wrote: > The intel-media-driver is currently broken on DG1 because > it uses EXEC_CAPTURE with recovarable contexts. Relax the > check to allow that. > > I've also submitted a fix for the intel-media-driver: > https://github.com/in

Re: [PATCH v11 0/5] Expose modifiers/formats supported by async flips

2025-04-01 Thread Ville Syrjälä
On Tue, Apr 01, 2025 at 01:27:14PM +, Kumar, Naveen1 wrote: > Hi Ville, > > >-Original Message- > >From: Ville Syrjälä > >Sent: Monday, March 31, 2025 9:28 PM > >To: Murthy, Arun R > >Cc: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; intel- > >x...@lists.freedeskt

[PATCH 2/4] drm/i915: Simplify combo PLL frac w/a

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä We are applying the combo PLL frac w/a to all TGL+ platforms, except RKL. I *think* all RKL machines use a 24 MHz refclk (certainly all machines in our CI do) and so technically never need the adjustment. But let's assume the hardware is exactly the same anyway and simplify th

[PATCH 3/4] drm/i915/gem: Allow EXEC_CAPTURE on recoverable contexts on DG1

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä The intel-media-driver is currently broken on DG1 because it uses EXEC_CAPTURE with recovarable contexts. Relax the check to allow that. I've also submitted a fix for the intel-media-driver: https://github.com/intel/media-driver/pull/1920 Cc: sta...@vger.kernel.org Cc: Matth

[PATCH 1/4] drm/i915: Apply the combo PLL frac w/a on DG1

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä DG1 apparently needs the combo PLL fractional divider w/a with 38.4 MHz refclk as well. This isn't listed in bspec, but looking at the hsd it looks like it was possibly just missed due to no one having a DG1 around at the time. This gives us slightly more accurate clocks on D

[PATCH 0/4] drm/i915: DG1 fixes

2025-04-01 Thread Ville Syrjala
From: Ville Syrjälä Fix a couple of problems on DG1, and remove the long overdue force_probe requirement. Ville Syrjälä (4): drm/i915: Apply the combo PLL frac w/a on DG1 drm/i915: Simplify combo PLL frac w/a drm/i915/gem: Allow EXEC_CAPTURE on recoverable contexts on DG1 drm/i915/pci: R

Re: [PATCH 11/11] fs: Remove aops->writepage

2025-04-01 Thread Matthew Wilcox
On Tue, Mar 18, 2025 at 09:10:38AM +0100, Thomas Hellström wrote: > On Mon, 2025-03-17 at 22:30 +, Matthew Wilcox wrote: > > This patch fixes the compilation problem.  But I don't understand why > > it's messing with the reclaim flag.  Thomas, can you explain? > > Hi, Sorry for not responding

Re: [PATCH v7 01/12] mtd: core: always create master device

2025-04-01 Thread Miquel Raynal
Hello Alexander, On 26/03/2025 at 17:26:12 +02, Alexander Usyskin wrote: > Create master device without partition when > CONFIG_MTD_PARTITIONED_MASTER flag is unset. > > This streamlines device tree and allows to anchor > runtime power management on master device in all cases. > > Signed-off-by

Re: [PATCH 1/2] drm/dp_mst: Fix GUID DPCD write to non-root MST branch devices

2025-04-01 Thread Jani Nikula
On Tue, 01 Apr 2025, Imre Deak wrote: > The return value on success of drm_dp_send_dpcd_write() called for > non-root MST branch devices from drm_dp_check_mstb_guid() is the number > of bytes transferred. Atm this return value (in case of a complete read) > will be regarded incorrectly as an error

Re: [PATCH v2] drm/i915/selftest: allow larger memory allocation

2025-04-01 Thread Mikolaj Wasiak
Hi Andi, On 2025-03-29 at 08:18:33 +0100, Andi Shyti wrote: > On Fri, Mar 21, 2025 at 03:02:49PM +0100, Mikolaj Wasiak wrote: > > Due to changes in allocator, the size of the allocation for > > which change in the allocator? [8569c31545385195bdb0c021124e68336e91c693] drm/i915: Move the size comp

[PATCH v6 8/8] drm/i915/display: Add drm_panic support for 4-tiling with DPT

2025-04-01 Thread Jocelyn Falempe
On Alder Lake and later, it's not possible to disable tiling when DPT is enabled. So this commit implements 4-Tiling support, to still be able to draw the panic screen. Signed-off-by: Jocelyn Falempe --- .../gpu/drm/i915/display/intel_atomic_plane.c | 22 ++- 1 file changed, 21 i

Re: [PATCH v6 5/8] drm/i915/display: Add drm_panic support

2025-04-01 Thread Jani Nikula
On Tue, 01 Apr 2025, Jocelyn Falempe wrote: > This adds drm_panic support for a wide range of Intel GPU. I've > tested it only on 4 laptops, Haswell (with 128MB of eDRAM), > Comet Lake, Raptor Lake, and Lunar Lake. > For hardware using DPT, it's not possible to disable tiling, as you > will need t

Re: [PATCH 06/11] migrate: Remove call to ->writepage

2025-04-01 Thread David Hildenbrand
On 27.03.25 18:22, Zi Yan wrote: On Thu Mar 27, 2025 at 12:52 PM EDT, Matthew Wilcox wrote: On Thu, Mar 27, 2025 at 11:04:57AM -0400, Zi Yan wrote: On Fri Mar 7, 2025 at 8:54 AM EST, Matthew Wilcox (Oracle) wrote: The writepage callback is going away; filesystems must implement migrate_folio o

RE: [PATCH v11 0/5] Expose modifiers/formats supported by async flips

2025-04-01 Thread Kumar, Naveen1
Hi Ville, >-Original Message- >From: Ville Syrjälä >Sent: Monday, March 31, 2025 9:28 PM >To: Murthy, Arun R >Cc: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; intel- >x...@lists.freedesktop.org; Jani Nikula ; Borah, >Chaitanya Kumar ; Syrjala, Ville >; Kumar, Naveen1

[PATCH v6 6/8] drm/i915/display: Flush the front buffer in panic handler

2025-04-01 Thread Jocelyn Falempe
On Lunar Lake, if the panic occurs when fbcon is active, the panic screen is only partially visible on the screen. Adding this intel_frontbuffer_flush() call solves the issue. It's probably not safe to do that in the panic handler, but that's still better than nothing. Signed-off-by: Jocelyn Falem

[PATCH 1/2] drm/dp_mst: Fix GUID DPCD write to non-root MST branch devices

2025-04-01 Thread Imre Deak
The return value on success of drm_dp_send_dpcd_write() called for non-root MST branch devices from drm_dp_check_mstb_guid() is the number of bytes transferred. Atm this return value (in case of a complete read) will be regarded incorrectly as an error by the caller of drm_dp_check_mstb_guid(). Fix

[PATCH v6 7/8] drm/i915/display: Add drm_panic support for Y-tiling with DPT

2025-04-01 Thread Jocelyn Falempe
On Alder Lake and later, it's not possible to disable tiling when DPT is enabled. So this commit implements Y-Tiling support, to still be able to draw the panic screen. Signed-off-by: Jocelyn Falempe --- .../gpu/drm/i915/display/intel_atomic_plane.c | 69 ++- .../drm/i915/display

✗ Fi.CI.BUILD: failure for hdrtest: hide the disgusting turds

2025-04-01 Thread Patchwork
== Series Details == Series: hdrtest: hide the disgusting turds URL : https://patchwork.freedesktop.org/series/147058/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/147058/revisions/1/mbox/ not applied Applying: drm: place header test files in .h

[PATCH v6 5/8] drm/i915/display: Add drm_panic support

2025-04-01 Thread Jocelyn Falempe
This adds drm_panic support for a wide range of Intel GPU. I've tested it only on 4 laptops, Haswell (with 128MB of eDRAM), Comet Lake, Raptor Lake, and Lunar Lake. For hardware using DPT, it's not possible to disable tiling, as you will need to reconfigure the way the GPU is accessing the framebuf

[PATCH v6 4/8] drm/i915/gem: Add i915_gem_object_panic_map()

2025-04-01 Thread Jocelyn Falempe
Prepare the work for drm_panic support. This is used to map the current framebuffer, so the CPU can overwrite it with the panic message. Signed-off-by: Jocelyn Falempe --- v5: * Use iosys_map for intel_bo_panic_map(). drivers/gpu/drm/i915/display/intel_bo.c| 5 drivers/gpu/drm/i915/

[PATCH v6 0/8] drm/i915: Add drm_panic support

2025-04-01 Thread Jocelyn Falempe
This is a draft of drm_panic support for i915. I've tested it on the 4 intel laptops I have at my disposal. * Haswell with 128MB of eDRAM. * Comet Lake i7-10850H * Raptor Lake i7-1370P (with DPT, and Y-tiling). * Lunar Lake Ultra 5 228V (with DPT, and 4-tiling, and using the Xe driver. I tes

[PATCH v6 3/8] drm/i915/display: Add a disable_tiling() for skl planes

2025-04-01 Thread Jocelyn Falempe
drm_panic draws in linear framebuffer, so it's easier to re-use the current framebuffer, and disable tiling in the panic handler, to show the panic screen. Signed-off-by: Jocelyn Falempe --- .../drm/i915/display/skl_universal_plane.c| 20 +++ 1 file changed, 20 insertions(+)

[PATCH v6 2/8] drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes

2025-04-01 Thread Jocelyn Falempe
drm_panic draws in linear framebuffer, so it's easier to re-use the current framebuffer, and disable tiling in the panic handler, to show the panic screen. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++ .../drm/i915/display/intel_displa

[PATCH v6 1/8] drm/i915/fbdev: Add intel_fbdev_get_map()

2025-04-01 Thread Jocelyn Falempe
The vaddr of the fbdev framebuffer is private to the struct intel_fbdev, so this function is needed to access it for drm_panic. Also the struct i915_vma is different between i915 and xe, so it requires a few functions to access fbdev->vma->iomap. Signed-off-by: Jocelyn Falempe --- v2: * Add int

[PATCH 5/5] drm: add config option for extra build-time checks

2025-04-01 Thread Jani Nikula
The DRM subsystem contains additional build-time checks, primarily aimed at DRM developers and CI systems. The checks may be overzealous. They may slow down or fail the build altogether. They may create excessive dependency files in the build tree. They should not be enabled for regular builds, and

✓ i915.CI.BAT: success for series starting with [1/2] drm/dp_mst: Fix GUID DPCD write to non-root MST branch devices

2025-04-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp_mst: Fix GUID DPCD write to non-root MST branch devices URL : https://patchwork.freedesktop.org/series/147054/ State : success == Summary == CI Bug Log - changes from CI_DRM_16355 -> Patchwork_147054v1

[PATCH 4/5] kbuild: hdrtest: place header test files in .hdrtest subdirectories

2025-04-01 Thread Jani Nikula
The header tests track whether headers have been checked using empty *.hdrtest files in the build tree. This pollutes the build directories, as the files live in the same "name space" as the real output files, messing with TAB completion among other things. Hide the disgusting turds by placing the

[PATCH 3/5] drm/i915: place header test files in .hdrtest subdirectories

2025-04-01 Thread Jani Nikula
The header tests track whether headers have been checked using empty *.hdrtest files in the build tree. This pollutes the build directories, as the files live in the same "name space" as the real output files, messing with TAB completion among other things. Hide the disgusting turds by placing the

[PATCH 2/5] drm/xe: place header test files in .hdrtest subdirectories

2025-04-01 Thread Jani Nikula
The header tests track whether headers have been checked using empty *.hdrtest files in the build tree. This pollutes the build directories, as the files live in the same "name space" as the real output files, messing with TAB completion among other things. Hide the disgusting turds by placing the

[PATCH 1/5] drm: place header test files in .hdrtest subdirectories

2025-04-01 Thread Jani Nikula
The header tests track whether headers have been checked using empty *.hdrtest files in the build tree. This pollutes the build directories, as the files live in the same "name space" as the real output files, messing with TAB completion among other things. Hide the disgusting turds by placing the

[PATCH 0/5] hdrtest: hide the disgusting turds

2025-04-01 Thread Jani Nikula
Hide all the disgusting turds in .hdrtest subdirectories in the build tree, and put the extra drm build-time checks behind a kconfig option. BR, Jani. Cc: linux-kbu...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: intel...@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Cc:

Re: [PATCH 03/12] drm/i915/display: Add sharpness strength and winsize

2025-04-01 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: register I think this is part of the subject, need to fix this. The strength value for sharpness is based on user input and the winsize is based on resolution. Set the casf_enable flag if there is a platform support and uapi strength is not zero. O

[PATCH 2/2] drm/dp_mst: Use drm_dp_dpcd_write_data() to write GUID for non-root MST branch devices

2025-04-01 Thread Imre Deak
drm_dp_dpcd_write_data() can be used to write the GUID for a non-root MST branch device, similarly to writing the GUID to a root MST branch device, do so. Cc: Dmitry Baryshkov Cc: Lyude Paul Signed-off-by: Imre Deak --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 17 +++-- 1 fi

Re: [PATCH] drm/i915/gvt: fix unterminated-string-initialization warning

2025-04-01 Thread Jani Nikula
On Sun, 30 Mar 2025, Zhenyu Wang wrote: > On Thu, Mar 27, 2025 at 02:47:39PM +0200, Jani Nikula wrote: >> Initializing const char opregion_signature[16] = OPREGION_SIGNATURE >> (which is "IntelGraphicsMem") drops the NUL termination of the >> string. This is intentional, but the compiler doesn't k

Re: [PATCH] drm/i915/gvt: Add __nonstring annotations for unterminated strings

2025-04-01 Thread Thorsten Leemhuis
On 01.04.25 10:46, Jani Nikula wrote: > On Mon, 31 Mar 2025, Thorsten Leemhuis wrote: >> On 10.03.25 23:23, Kees Cook wrote: >>> When a character array without a terminating NUL character has a static >>> initializer, GCC 15's -Wunterminated-string-initialization will only >>> warn if the array la

Re: [PATCH] drm/i915/psr: Prevent DP Panel Replay as well when CRC is enable

2025-04-01 Thread Jani Nikula
On Mon, 31 Mar 2025, Jouni Högander wrote: > We are seeing timeouts in opening CRC fd when testing on setup where DP > Panel Replay can be enabled. Fix these by checking if CRC is enabled for DP > Panel Replay as well. > > Signed-off-by: Jouni Högander Reviewed-by: Jani Nikula > --- > driver

Re: [RESEND] drm/i915/gvt: use hardcoded reference clocks

2025-04-01 Thread Jani Nikula
On Sun, 30 Mar 2025, Zhenyu Wang wrote: > On Fri, Mar 21, 2025 at 02:51:14PM +0200, Jani Nikula wrote: >> Usually I'd argue hardcoding values is the wrong thing to do, but in >> this case, GVT looking deep into the guts of the DPLL manager for the >> reference clocks is worse. This is done for BDW

Re: [PATCH] drm/i915: reduce intel_wakeref.h dependencies

2025-04-01 Thread Jani Nikula
On Fri, 28 Mar 2025, Rodrigo Vivi wrote: > On Wed, Mar 26, 2025 at 01:54:52PM +0200, Jani Nikula wrote: >> Forward declare struct drm_printer instead of including drm/drm_print.h, >> as we only need the pointer. Turns out quite a few places depend on this >> include implicitly. Make them explicit.

Re: [PATCH] drm/i915/gvt: Add __nonstring annotations for unterminated strings

2025-04-01 Thread Jani Nikula
On Mon, 31 Mar 2025, Thorsten Leemhuis wrote: > On 10.03.25 23:23, Kees Cook wrote: >> When a character array without a terminating NUL character has a static >> initializer, GCC 15's -Wunterminated-string-initialization will only >> warn if the array lacks the "nonstring" attribute[1]. Mark the a

Re: [PATCH v5] drm/i915/selftests: Refactor RC6 power measurement and error handling

2025-04-01 Thread Andi Shyti
Hi Anirban, On Fri, Mar 28, 2025 at 12:49:24AM +0530, Sk Anirban wrote: > Revise the power measurement logic to save and evaluate energy values. How is the logic been revised? Can you be more specific please? > Previously, the test only checked whether the system had entered the RC6 > state, wit