Re: [PATCH] drm/i915/xe2hpd: Identify the memory type for SKUs with GDDR + ECC

2025-03-20 Thread Lucas De Marchi
On Fri, Feb 14, 2025 at 01:59:44PM -0800, Vivek Kasireddy wrote: Some SKUs of Xe2_HPD platforms (such as BMG) have GDDR memory type with ECC enabled. We need to identify this scenario and add a new case in xelpdp_get_dram_info() to handle it. In addition, the derating value needs to be adjusted a

✓ i915.CI.BAT: success for Use VRR timing generator for fixed refresh rate modes (rev16)

2025-03-20 Thread Patchwork
== Series Details == Series: Use VRR timing generator for fixed refresh rate modes (rev16) URL : https://patchwork.freedesktop.org/series/134383/ State : success == Summary == CI Bug Log - changes from CI_DRM_16298 -> Patchwork_134383v16 Su

Re: [PATCH v2 34/59] checkpatch: dont warn about unused macro arg on empty body

2025-03-20 Thread Joe Perches
On Thu, 2025-03-20 at 12:52 -0600, Jim Cromie wrote: > we currently get: > WARNING: Argument 'name' is not used in function-like macro > on: > #define DRM_CLASSMAP_USE(name) /* nothing here */ > > Following this advice is wrong here, and shouldn't be fixed by > ignoring args altogether; the m

✓ i915.CI.BAT: success for drm/i915/display: add display specific runtime PM interface (rev3)

2025-03-20 Thread Patchwork
== Series Details == Series: drm/i915/display: add display specific runtime PM interface (rev3) URL : https://patchwork.freedesktop.org/series/146134/ State : success == Summary == CI Bug Log - changes from CI_DRM_16296 -> Patchwork_146134v3

[PULL] drm-xe-fixes

2025-03-20 Thread Thomas Hellstrom
Hi Dave, Simona! Rodrigo is out this week, but sending a PR for a single fix. Thanks, Thomas drm-xe-fixes-2025-03-20: Driver Changes: - Fix for an error if exporting a dma-buf multiple time (Tomasz) The following changes since commit f5d4e81774c42d9c2ea3980e570f3330ff2ed5d2: drm/xe: remove re

Re: [PATCH v8 01/14] drm: Define histogram structures exposed to user

2025-03-20 Thread Pekka Paalanen
On Wed, 19 Mar 2025 12:08:15 + "Murthy, Arun R" wrote: > > On Mon, 3 Mar 2025 13:23:42 +0530 > > "Murthy, Arun R" wrote: > > > > > On 20-02-2025 21:20, Pekka Paalanen wrote: > > > > On Wed, 19 Feb 2025 09:28:51 +0530 > > > > "Murthy, Arun R" wrote: ... > > > Hi Pekka, > > > Sorry got

[CI 6/6] drm/xe/compat: remove intel_runtime_pm.h

2025-03-20 Thread Jani Nikula
Now that all display code has been converted to display specific runtime PM interfaces, there's no need for the compat header anymore. Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- .../gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 - .../xe/compat-i915-headers/intel_runtime_pm.h | 7

[CI 8/9] drm/i915/irq: convert rest of intel_display_irq.[ch] to struct intel_display

2025-03-20 Thread Jani Nikula
Going forward, struct intel_display is the main display device data pointer. Convert as much as possible of intel_display_irq.[ch] to struct intel_display. Reviewed-by: Uma Shankar Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_display_irq.c | 527 +++

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: conversions to struct intel_display (rev4)

2025-03-20 Thread Patchwork
== Series Details == Series: drm/i915/display: conversions to struct intel_display (rev4) URL : https://patchwork.freedesktop.org/series/144748/ State : warning == Summary == Error: dim checkpatch failed 5690406eba8c drm/i915/color: prefer display->platform. checks 88aebf87aae8 drm/i915/connec

[CI 2/6] drm/i915/display: conversions to with_intel_display_rpm()

2025-03-20 Thread Jani Nikula
Convert all with_intel_runtime_pm() uses to with_intel_display_rpm(). Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_backlight.c | 5 ++--- drivers/gpu/drm/i915/display/intel_bios.c | 6 +++--- drivers/gpu/drm/i915/display/intel_hdcp.c | 5

✗ Fi.CI.SPARSE: warning for drm/i915/display: conversions to struct intel_display (rev4)

2025-03-20 Thread Patchwork
== Series Details == Series: drm/i915/display: conversions to struct intel_display (rev4) URL : https://patchwork.freedesktop.org/series/144748/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[CI 4/6] drm/i915/display: convert to display runtime PM interfaces

2025-03-20 Thread Jani Nikula
Convert i915 runtime PM interfaces to display runtime PM interfaces all over the place in display code. Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/hsw_ips.c | 8 .../drm/i915/display/intel_display_debugfs.c| 17 +++--

[CI 3/6] drm/i915/display: use display runtime PM interfaces for for atomic state

2025-03-20 Thread Jani Nikula
Convert intel_atomic_commit() and intel_atomic_commit_tail() to use display runtime PM interfaces. Also convert the wakeref member type to struct ref_tracker *, which is the same as intel_wakeref_t, but without the typedef. Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/dr

[CI 5/6] drm/i915/power: convert to display runtime PM interfaces

2025-03-20 Thread Jani Nikula
Finish the conversions to display specific runtime PM interfaces in the power code. Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_power.c| 63 --- .../i915/display/intel_display_power_well.c | 4 +- 2 files changed, 30 inserti

[CI 0/6] drm/i915/display: add display specific runtime PM interface

2025-03-20 Thread Jani Nikula
Resend for CI. Jani Nikula (6): drm/i915/display: add display specific runtime PM wrappers drm/i915/display: conversions to with_intel_display_rpm() drm/i915/display: use display runtime PM interfaces for for atomic state drm/i915/display: convert to display runtime PM interfaces drm

[CI 1/6] drm/i915/display: add display specific runtime PM wrappers

2025-03-20 Thread Jani Nikula
Add display specific wrappers around the i915 and xe dedicated runtime PM interfaces. There are no conversions here, just the wrappers. Implement with_intel_display_rpm() without needing to provide a local variable, which neatly narrows the scope and hides the type of the wakeref cookie. Reviewed

[CI 9/9] drm/i915/display: rename I915_HAS_HOTPLUG() to HAS_HOTPLUG

2025-03-20 Thread Jani Nikula
Most of the other display feature check macros are just HAS_. Follow suit with hotplug check. Reviewed-by: Uma Shankar Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c| 6 +++--- drivers/gpu/drm/i915/display/intel_display_device.h |

[CI 7/9] drm/i915/irq: convert intel_display_irq.[ch] interfaces to struct intel_display

2025-03-20 Thread Jani Nikula
Going forward, struct intel_display is the main display device data pointer. Convert the external interfaces of intel_display_irq.[ch] to struct intel_display. Reviewed-by: Uma Shankar Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 24

[CI 6/9] drm/i915/hotplug: convert intel_hotplug_irq.[ch] to struct intel_display

2025-03-20 Thread Jani Nikula
Going forward, struct intel_display is the main display device data pointer. Convert as much as possible of intel_hotplug_irq.[ch] to struct intel_display. Reviewed-by: Uma Shankar Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 4 +-

[CI 4/9] drm/i915/hotplug: convert hotplug debugfs to struct intel_display

2025-03-20 Thread Jani Nikula
Pass struct intel_display as the cookie to debugfs functions. Reviewed-by: Uma Shankar Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/dr

[CI 1/9] drm/i915/color: prefer display->platform. checks

2025-03-20 Thread Jani Nikula
This let's us drop the dependency on i915_drv.h. Reviewed-by: Uma Shankar Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/display/inte

[CI 2/9] drm/i915/connector: convert intel_connector.c to struct intel_display

2025-03-20 Thread Jani Nikula
Going forward, struct intel_display is the main display device data pointer. Convert as much as possible of intel_connector.c to struct intel_display. i915_inject_probe_failure() remains the only call that requires i915 pointer. Reviewed-by: Uma Shankar Reviewed-by: Ville Syrjälä Signed-off-by:

[CI 0/9] drm/i915/display: conversions to struct intel_display

2025-03-20 Thread Jani Nikula
Resend for CI. Jani Nikula (9): drm/i915/color: prefer display->platform. checks drm/i915/connector: convert intel_connector.c to struct intel_display drm/i915/hotplug: convert intel_hotplug.[ch] to struct intel_display drm/i915/hotplug: convert hotplug debugfs to struct intel_display dr

RE: [PATCH 1/3] drm/i915: Fix scanline_offset for LNL+ and BMG+

2025-03-20 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Saturday, February 8, 2025 3:24 AM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; sta...@vger.kernel.org > Subject: [PATCH 1/3] drm/i915: Fix scanline_offset for LNL+ and BMG+ > > Fr

Re: [PATCH] drm/i915/display: add audio dis/enable when connector hotplug

2025-03-20 Thread Jani Nikula
On Tue, 18 Mar 2025, Lu Yao wrote: > Now audio enable/disable depends on an atomic commit, it doesn't make > sence. For wayland, there will trigering an atomic commit, so it > works well. But for Xorg using modesetting, there won't. In this > case, unplug the HDMI/DP and the audio jack event is no

Re: [PATCH v2 2/2] drm/i915/fbc: remove panel_replay dependency from fbc wa checks

2025-03-20 Thread Govindapillai, Vinod
On Thu, 2025-03-20 at 10:12 +, Hogander, Jouni wrote: > On Wed, 2025-03-19 at 15:51 +0200, Vinod Govindapillai wrote: > > Panel replay is supported from display 14 onwards. So no need > > to check the panel replay status in the previous gen workarounds. > > In the newer panel replay, selective

Re: [PATCH v2 2/2] drm/i915/fbc: remove panel_replay dependency from fbc wa checks

2025-03-20 Thread Hogander, Jouni
On Wed, 2025-03-19 at 15:51 +0200, Vinod Govindapillai wrote: > Panel replay is supported from display 14 onwards. So no need > to check the panel replay status in the previous gen workarounds. > In the newer panel replay, selective update is supported and it > is suffice to check selective update

Re: [v3] drm/i915: Disable RPG during live selftest

2025-03-20 Thread Poosa, Karthik
On 19-03-2025 16:42, Anirban, Sk wrote: On 19-03-2025 12:40, Poosa, Karthik wrote: On 10-03-2025 20:58, Sk Anirban wrote: From: Badal Nilawar The Forcewake timeout issue has been observed on Gen 12.0 and above. To address this, disable Render Power-Gating (RPG) during live self-tests f

RE: [PATCH 2/4] drm/i915/gt: Fix SPDX license format

2025-03-20 Thread Gote, Nitin R
HI Andi, > On Tue, Mar 18, 2025 at 10:55:03AM +, Krzysztof Karas wrote: > > > Header files need to declare the SPDX under /* ... */ style > > All files modified in this patch series start with: > > // SPDX-License-Identifier: MIT > > rather than: > > /* SPDX-License-Identifier: MIT */ > > > >

RE: [PATCH 3/4] drm/i915/gt: Remove trailing blank lines

2025-03-20 Thread Gote, Nitin R
Hi Andi, > -Original Message- > From: Intel-gfx On Behalf Of Andi > Shyti > Sent: Friday, March 14, 2025 7:42 AM > To: intel-gfx > Cc: Andi Shyti ; Andi Shyti > > Subject: [PATCH 3/4] drm/i915/gt: Remove trailing blank lines > > Remove useless blank lines before and after the bracket

RE: [PATCH 4/4] drm/i915/gt: Use proper sleeping functions for timeouts shorter than 20ms

2025-03-20 Thread Gote, Nitin R
Hi Andi, > Subject: [PATCH 4/4] drm/i915/gt: Use proper sleeping functions for timeouts > shorter than 20ms > > msleep is very unprecise for timeouts shorter than 20 milliseconds and most > probably will sleep longer. Use > uslee_range() instead. Typo: %s/uslee_range()/usleep_range() With typo