On 2/6/2025 10:19 AM, Mitul Golani wrote:
Compute as sdp when vrr.enable is set, also Skip
infoframe.enable check to avoid full modeset during
as_sdp toggle.
Mitul Golani (2):
drm/i915/display: Skip state checker for AS SDP infoframe enable
Revert "drm/i915/dp: Compute as_sdp based on if
Testing HDCP 1.4 becomes tough since the only way our code comes to
HDCP 1.4 pathway is if the monitor only supports HDCP 1.4 which
becomes tough to find sometimes.
Setting this debug_fs entry will force use to use the HDCP 1.4 path
so that more robust HDCP 1.4 testing can take place.
Signed-off-b
== Series Details ==
Series: Compute as_sdp when vrr is enabled (rev3)
URL : https://patchwork.freedesktop.org/series/144268/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16076_full -> Patchwork_144268v3_full
Summary
-
== Series Details ==
Series: Compute as_sdp when vrr is enabled (rev3)
URL : https://patchwork.freedesktop.org/series/144268/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16076 -> Patchwork_144268v3
Summary
---
**SU
Hello,
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144268v3/fi-cfl-guc/igt@i915_pm_...@module-reload.html
Reported bug is not related to my changes for VSC or Adaptive sync. Please help
to re-report
Regards,
Mitul
From: Patchwork
Sent: 06 February 2025 21:14
To: Golani, Mitulkumar Aji
Hi all,
After merging the drm-misc tree, today's linux-next build (htmldocs)
produced this warning:
/home/sfr/next/next/drivers/gpu/drm/drm_writeback.c:243: warning: expecting
prototype for drm_writeback_connector_init_with_encoder(). Prototype was for
__drm_writeback_connector_init() instead
> From: Vivi, Rodrigo
> [...]
> > On 2/6/2025 1:34 PM, Zhuo, Qiuxu wrote:
> > > Hi,
> > >
> > > I got the compile error as below.
> > > My GCC is: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
> > > kernel: v6.14-rc1
> >
> > Hi Qiuxu,
> >
> > Thanks for the mail.
> >
> > Fix was sent and merged in drm-i
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/display/intel_dp_mst.c
between commit:
66df9debcb29 ("drm/connector: make mode_valid_ctx take a const struct
drm_display_mode")
from the drm-misc tree and commit:
d49b485d1be3 ("drm/i915/dp_m
Hi,
I noticed a few issues in this patch (while fixing the other ones
reported), could you please check and follow up on the comments
below? Thanks.
On Wed, Jan 22, 2025 at 11:25:42AM +0530, Arun R Murthy wrote:
> Mandate a minimum Hblank symbol cycle count between BlankingStart and
> BlankingEnd
== Series Details ==
Series: drm/i915: Fix harmfull driver register/unregister assymetry
URL : https://patchwork.freedesktop.org/series/144436/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/inc
== Series Details ==
Series: drm/i915: intel_display conversions and some debug improvements (rev2)
URL : https://patchwork.freedesktop.org/series/143942/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: intel_display conversions and some debug improvements (rev2)
URL : https://patchwork.freedesktop.org/series/143942/
State : warning
== Summary ==
Error: dim checkpatch failed
5b0f312808c8 drm/i915: Pass intel_display to intel_scanout_needs_vtd_wa()
ebde46
On Thu, Feb 06, 2025 at 09:43:54PM +0530, Nautiyal, Ankit K wrote:
>
> On 2/6/2025 1:34 PM, Zhuo, Qiuxu wrote:
> > Hi,
> >
> > I got the compile error as below.
> > My GCC is: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
> > kernel: v6.14-rc1
>
> Hi Qiuxu,
>
> Thanks for the mail.
>
> Fix was sent
== Series Details ==
Series: drm/i915: Fix harmfull driver register/unregister assymetry
URL : https://patchwork.freedesktop.org/series/144436/
State : warning
== Summary ==
Error: dim checkpatch failed
0b4f8eb34328 drm/i915: Fix PM reference not released if device register fails
-:19: WARNING
== Series Details ==
Series: drm/i915/dp_mst: Fix getting display pointer in
intel_dp_mst_compute_min_hblank() (rev2)
URL : https://patchwork.freedesktop.org/series/144387/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16076_full -> Patchwork_144387v2_full
===
Bandwidth parameters for Xe3_LPD have been updated with respect to
previous display releases. Encode them into xe3lpd_sa_info and use that
new struct.
Since we are touching intel_bw.c, also take the opportunity to make it
use display-specific platform checkers, which is what patches #1 and #2
are
Update intel_bw.c to use a "display" variable to refer to members of the
display struct. While this change does not move that file to completely
use struct intel_display as part of it's internal and public interface,
this should help with a future transition.
Signed-off-by: Gustavo Sousa
---
dri
Add one step further into making intel_bw.c xe/i915 agnostic by using
display-specific platform checks.
Signed-off-by: Gustavo Sousa
---
drivers/gpu/drm/i915/display/intel_bw.c | 77 ++---
1 file changed, 43 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/i915/di
Bandwidth parameters for Xe3_LPD have been updated with respect to
previous display releases. Encode them into xe3lpd_sa_info and use that
new struct.
Bspec: 68859
Signed-off-by: Gustavo Sousa
---
drivers/gpu/drm/i915/display/intel_bw.c | 11 ++-
1 file changed, 10 insertions(+), 1 delet
From: Ville Syrjälä
Convert a bunch of stuff over to struct intel_display, and
finish off with a few debug print improvements.
v2: One new patch to deal with the VT-d fallout, and the rest
has been rebased/slightly updated due to various othert changes
Ville Syrjälä (12):
drm/i915: Pass i
From: Ville Syrjälä
Now that intel_scanout_needs_vtd_wa() is no longer used from
the gem code we can convert it to take struct intel_display.
which will help with converting the low level plane code over
as well.
Cc: Jani Nikula
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/i9
From: Ville Syrjälä
struct intel_display will replace struct drm_i915_private as
the main thing for display code. Convert the skl+ universal plane
code to use it.
Note that we still have two straggles in the form on
HAS_FLAT_CCS() and the pxp stuff.
Reviewed-by: Jani Nikula
Signed-off-by: Vill
From: Ville Syrjälä
intel_sprite.c was partially converted to struct intel_display.
Finish the job now that we can deal with the platform checks
as well.
And while at it we also move the 'display' variable declaration
to be the first thing in most functions, consistency. We can
actually do that
From: Ville Syrjälä
Switch the plane debugs to use DRM_RECT_FMT & co. instead
of drm_rect_debug_print() so that the debugs go on the same line.
Reviewed-by: Jani Nikula
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_atomic_plane.c | 11 +--
1 file changed, 5 inser
From: Ville Syrjälä
Include the standard "[PLANE:%d:s]" stuff in all plane debugs
(or rather all I was able to find), to provide better information
on which plane we're actually talking about.
There are a few spots where we care about the CRTC as well, so
include that where appropriate.
Reviewe
From: Ville Syrjälä
struct intel_display will replace struct drm_i915_private as
the main thing for display code. Convert the fb code to
use it.
Reviewed-by: Jani Nikula
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 2 +-
drivers/gpu/drm/i915/display/intel
From: Ville Syrjälä
struct intel_display will replace struct drm_i915_private as
the main thing for display code. Convert the pre-skl primary plane
code to use it.
Reviewed-by: Jani Nikula
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 240 +++---
From: Ville Syrjälä
struct intel_display will replace struct drm_i915_private as
the main thing for display code. Convert the cursor code to
use it.
Reviewed-by: Jani Nikula
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_crtc.c | 2 +-
drivers/gpu/drm/i915/display/int
From: Ville Syrjälä
Pass intel_display to the display power stuff. These are spread
all over the place so tend to hinder clean conversions of whole
files.
TODO: The gt part/unpark power domain shenanigans need some
kind of more abstract interface...
v2: Deal with cmtg
Reviewed-by: Jani Nikula
From: Ville Syrjälä
struct intel_display will replace struct drm_i915_private as
the main thing for display code. Convert intel_crtc.c code to
use it.
Reviewed-by: Jani Nikula
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/g4x_dp.c | 4 +-
drivers/gpu/drm/i915/display/
From: Ville Syrjälä
Pass the device argument as drm_device to intel_plane_fb_max_stride()
to decouple i915_gem_dumb_create() vs. the display code a bit.
xe currently doesn't even call this, but it probably should...
v2: s/dev/drm/ (Jani)
Reviewed-by: Jani Nikula
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Make the intel_fb_bo.h interfaces operated purely in base
drm_ types so that each driver (i915 and xe) doesn't have to
know about each other, or the display stuff.
v2: s/dev/drm/ (Jani)
Reviewed-by: Jani Nikula
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display
We return immediately from i915_driver_register() if drm_dev_register()
fails, skipping remaining registration steps. However, the _unregister()
counterpart called at device remove knows nothing about that skip and
executes reverts for all those steps. For that to work correctly, those
revert fun
We return immediately from i915_driver_register() if drm_dev_register()
fails, skipping remaining registration steps. However, the _unregister()
counterpart called at device remove knows nothing about that skip and
executes reverts for all those steps. For that to work correctly, those
revert fun
We return immediately from i915_driver_register() if drm_dev_register()
fails, skipping remaining registration steps. However, the _unregister()
counterpart called at device remove knows nothing about that skip and
executes reverts for all those steps. For that to work correctly, those
revert fun
We return immediately from i915_driver_register() if drm_dev_register()
fails, skipping remaining registration steps. However, the _unregister()
counterpart called at device remove knows nothing about that skip and
executes reverts for all those steps. For that to work correctly, those
revert fun
> -Original Message-
> From: Deak, Imre
> Sent: Thursday, February 6, 2025 10:16 PM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: Murthy, Arun R ; Kandpal, Suraj
>
> Subject: [PATCH] drm/i915/dp_mst: Fix disabling the minimum HBlank time
>
> Disable the m
Disable the minimum HBlank time only on LNL+, where this functionality
and corresponding register exists.
Fixes: a5ebe00c2ace ("drm/i915/dp: Guarantee a minimum HBlank time")
Cc: Arun R Murthy
Cc: Suraj Kandpal
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 ++-
1
On Thu, Feb 06, 2025 at 03:06:18PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/dp_mst: Fix getting display pointer in
> intel_dp_mst_compute_min_hblank() (rev2)
> URL : https://patchwork.freedesktop.org/series/144387/
> State : success
Thanks for the report, testing and
On 2/6/2025 1:34 PM, Zhuo, Qiuxu wrote:
Hi,
I got the compile error as below.
My GCC is: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
kernel: v6.14-rc1
Hi Qiuxu,
Thanks for the mail.
Fix was sent and merged in drm-intel-next :
https://cgit.freedesktop.org/drm/drm-intel/commit/?h=drm-intel-next
== Series Details ==
Series: Compute as_sdp when vrr is enabled (rev3)
URL : https://patchwork.freedesktop.org/series/144268/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16076 -> Patchwork_144268v3
Summary
---
**FA
On Thu, Jan 30, 2025 at 11:09 PM Christoph Hellwig wrote:
>
> On Thu, Jan 30, 2025 at 04:18:05PM -0800, Vishal Moola (Oracle) wrote:
> > + rcu_read_lock();
> > + xas_for_each(&xas, folio, last) {
>
> This only maps folios currently in the page cache, which makes it
> usefull for everything
On Thu, Jan 30, 2025 at 4:48 PM Andrew Morton wrote:
>
> On Thu, 30 Jan 2025 16:18:04 -0800 "Vishal Moola (Oracle)"
> wrote:
>
> > Currently, users have to call vmap() or vmap_pfn() to map pages to
> > kernel virtual space. vmap() requires the page references, and
> > vmap_pfn() requires page pf
== Series Details ==
Series: drm/i915/dp_mst: Fix getting display pointer in
intel_dp_mst_compute_min_hblank() (rev2)
URL : https://patchwork.freedesktop.org/series/144387/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16076 -> Patchwork_144387v2
=
== Series Details ==
Series: drm/i915/dp_mst: Fix getting display pointer in
intel_dp_mst_compute_min_hblank()
URL : https://patchwork.freedesktop.org/series/144387/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16076 -> Patchwork_144387v1
== Series Details ==
Series: drm/i915: Fix NULL vs IS_ERR() check in __shmem_writeback()
URL : https://patchwork.freedesktop.org/series/144406/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/144406/revisions/1/mbox/ not
applied
Applying: drm/i915:
== Series Details ==
Series: Enable Aux based Nits brightness control for eDP (rev3)
URL : https://patchwork.freedesktop.org/series/143909/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Acked-by: Maarten Lankhorst
for both
On 2025-02-06 07:45, Kandpal, Suraj wrote:
-Original Message-
From: Murthy, Arun R
Sent: Thursday, February 6, 2025 12:13 PM
To: Kandpal, Suraj ; intel...@lists.freedesktop.org;
intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org
Cc
On Thu, Feb 06, 2025 at 09:11:42AM -0500, Rodrigo Vivi wrote:
> Hi Dave and Sima,
>
> Here goes the first i915 fixes towards 6.14.
>
> It looks that our CI was dead for the last round, but I double
> checked locally in both ADL-P and DG2 and everything is working fine.
> In the last round the onl
Hi Dave and Sima,
Here goes the first i915 fixes towards 6.14.
It looks that our CI was dead for the last round, but I double
checked locally in both ADL-P and DG2 and everything is working fine.
In the last round the only addition was the Jani's DP fix, that
looks correct. So, let's move forward
Hi Dave and Sima,
Here goes our first Xe related fixes towards 6.14.
Thanks,
Rodrigo.
drm-xe-fixes-2025-02-06:
UAPI Changes:
- OA uAPI related fixes (Ashutosh)
Driver Changes:
- Fix SRIOV migration initialization (Michal)
- Restore devcoredump to a sane state (Lucas)
The following changes si
Hi Krzysztof,
On Thu, Jan 30, 2025 at 09:19:31AM +, Krzysztof Karas wrote:
> There is an error path in igt_ppgtt_alloc(), which leads
> to ww object being passed down to i915_gem_ww_ctx_fini() without
> initialization. Correct that by only putting ppgtt->vm and
> returning early.
>
> Fixes: 4
Hi Vinay,
> Add these redundant utils to core lib. Also fix the bug in
I think "Move" would better describe what you do in this patch.
> + slept = igt_measured_usleep(batch_duration_ns / 1000) * NSEC_PER_USEC;
Since you return usec instead of nsec, you had to add
"* NSEC_PER_USEC" in many i
> The filemap_lock_folio() function doesn't return NULL, it returns error
> pointers.
>
> Fixes: 25dd342f0cc8 ("drm/i915/gem: convert __shmem_writeback() to folios")
> Signed-off-by: Dan Carpenter
...
> struct folio *folio;
>
> folio = filemap_lock_folio(mapping, i
On 1/31/2025 12:15 AM, Ville Syrjala wrote:
From: Ville Syrjälä
Since we now do the "wait for safe window" before triggering
the push send, there is a theoretical possibity that we may
have screwed up the vblank evasion and the push has slipped
past the vmax decision boundary. In that case th
On 1/31/2025 12:15 AM, Ville Syrjala wrote:
From: Ville Syrjälä
Currently we trigger the push send first, then follow it with
a "wait for safe window". That approach no longer works on
PTL+ because triggering the push send immediately ends the safe
window. On prior hardware the safe window ex
On 1/31/2025 12:15 AM, Ville Syrjala wrote:
From: Ville Syrjälä
Add a functiuon for emitting a DSB poll instruction. We'll allow
s/functiuon/function
the caller to specify the poll parameters.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_dsb.c | 19
The filemap_lock_folio() function doesn't return NULL, it returns error
pointers.
Fixes: 25dd342f0cc8 ("drm/i915/gem: convert __shmem_writeback() to folios")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Hi,
I got the compile error as below.
My GCC is: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
kernel: v6.14-rc1
--- compile error log ---
CC drivers/gpu/drm/i915/display/intel_dp.o
In file included from :0:0:
In function ‘intel_dp_dsc_compute_pipe_bpp_limits.isra.77’,
inlined from ‘intel_d
59 matches
Mail list logo
