✗ i915.CI.BAT: failure for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev7)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev7) URL : https://patchwork.freedesktop.org/series/142119/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142119v7 ===

✗ Fi.CI.SPARSE: warning for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev7)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev7) URL : https://patchwork.freedesktop.org/series/142119/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked sep

Re: [CI v3 2/6] drm/i915/hdmi: propagate errors from intel_hdmi_init_connector()

2024-12-30 Thread Jani Nikula
On Tue, 31 Dec 2024, "Vodapalli, Ravi Kumar" wrote: > On 12/30/2024 7:44 PM, Jani Nikula wrote: >> Propagate errors from intel_hdmi_init_connector() to be able to handle >> them at callers. This is similar to intel_dp_init_connector(). >> >> Cc: Sergey Senozhatsky >> Cc: Ville Syrjala >> Report

Re: [CI v3 2/6] drm/i915/hdmi: propagate errors from intel_hdmi_init_connector()

2024-12-30 Thread Vodapalli, Ravi Kumar
On 12/30/2024 7:44 PM, Jani Nikula wrote: Propagate errors from intel_hdmi_init_connector() to be able to handle them at callers. This is similar to intel_dp_init_connector(). Cc: Sergey Senozhatsky Cc: Ville Syrjala Reported-and-tested-by: Sergey Senozhatsky Closes: https://lore.kernel.

Re: [PATCH] drm/i915: Remove deadcode

2024-12-30 Thread Vodapalli, Ravi Kumar
On 12/27/2024 5:10 PM, Tvrtko Ursulin wrote: Hi, On 22/12/2024 17:47, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" i915_active_acquire_for_context() was added in 2020 by commit 5d9341370f57 ("drm/i915: Export a preallocate variant of i915_active_acquire()") but has never been

✗ i915.CI.BAT: failure for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev6)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev6) URL : https://patchwork.freedesktop.org/series/142119/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142119v6 ===

✗ Fi.CI.SPARSE: warning for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev6)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev6) URL : https://patchwork.freedesktop.org/series/142119/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked sep

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-30 Thread Jani Nikula
On Mon, 30 Dec 2024, Dmitry Baryshkov wrote: > On Mon, Dec 30, 2024 at 03:18:35PM +0200, Jani Nikula wrote: >> On Thu, 26 Dec 2024, Abel Vesa wrote: >> > On 24-12-11 15:42:27, Johan Hovold wrote: >> >> On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: >> >> >> >> > +/** >> >> > + * drm

Re: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt

2024-12-30 Thread Imre Deak
On Tue, Dec 24, 2024 at 06:01:48PM -0300, Gustavo Sousa wrote: > Quoting Imre Deak (2024-12-18 11:56:46-03:00) > >On Tue, Dec 17, 2024 at 04:34:40PM +0200, Mika Kahola wrote: > >> tbt-alt mode is missing uhbr rates 10G and 20G. This requires > >> requires pll clock rates 312.5 MHz and 625 MHz to be

✗ i915.CI.BAT: failure for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev5)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev5) URL : https://patchwork.freedesktop.org/series/142119/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142119v5 ===

✗ Fi.CI.SPARSE: warning for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev5)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev5) URL : https://patchwork.freedesktop.org/series/142119/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked sep

✗ i915.CI.BAT: failure for drm/i915/gvt: store virtual_dp_monitor_edid in rodata (rev4)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/gvt: store virtual_dp_monitor_edid in rodata (rev4) URL : https://patchwork.freedesktop.org/series/142793/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142793v4 Summ

✗ i915.CI.BAT: failure for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev4)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev4) URL : https://patchwork.freedesktop.org/series/142119/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142119v4 ===

✗ Fi.CI.SPARSE: warning for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev4)

2024-12-30 Thread Patchwork
== Series Details == Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev4) URL : https://patchwork.freedesktop.org/series/142119/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked sep

Re: [PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2024-12-30 Thread Krzysztof Karas
Hi Apoorva, > From: Apoorva Singh > > Initialize rq to NULL to prevent uninitialized pointer reads. > > Signed-off-by: Apoorva Singh > --- > drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_mi

Re: [PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2024-12-30 Thread Krzysztof Karas
Hi Apoorva and Andi, > > Initialize rq to NULL to prevent uninitialized pointer reads. > > where is it happening? > > Andi There are two instances that I see: 1) err = fn(..., &rq); <- this probably will set the rq (at least looking at the functions that are used to set "fn", when calling "clea

Re: [RFC v2 5/6] drm/i915/scaler: Check if vblank is sufficient for scaler

2024-12-30 Thread Jani Nikula
On Tue, 17 Dec 2024, Mitul Golani wrote: > Check if vblank is too short for scaler prefill latency. > > Signed-off-by: Mitul Golani > --- > drivers/gpu/drm/i915/display/skl_watermark.c | 22 > 1 file changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/skl

[CI v3 6/6] drm/i915/ddi: only call shutdown hooks for valid encoders

2024-12-30 Thread Jani Nikula
DDI might be HDMI or DP only, leaving the other encoder uninitialized. Calling the shutdown hook on an uninitialized encoder may lead to a NULL pointer dereference. Check the encoder types (and thus validity via the DP output_reg or HDMI hdmi_reg checks) before calling the hooks. Reported-and-test

[CI v3 5/6] drm/i915/display: add intel_encoder_is_hdmi()

2024-12-30 Thread Jani Nikula
Similar to intel_encoder_is_dp() and friends. Cc: Sergey Senozhatsky Cc: Ville Syrjala Reviewed-by: Suraj Kandpal Tested-by: Sergey Senozhatsky Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h | 13 + 1 file changed, 13 insertions(+) diff --git a

[CI v3 3/6] drm/i915/hdmi: add error handling in g4x_hdmi_init()

2024-12-30 Thread Jani Nikula
Handle encoder and connector init failures in g4x_hdmi_init(). This is similar to g4x_dp_init(). Cc: Sergey Senozhatsky Cc: Ville Syrjala Reported-and-tested-by: Sergey Senozhatsky Closes: https://lore.kernel.org/r/20241031105145.2140590-1-senozhat...@chromium.org Reviewed-by: Sergey Senozhats

[CI v3 4/6] drm/i915/ddi: gracefully handle errors from intel_ddi_init_hdmi_connector()

2024-12-30 Thread Jani Nikula
Errors from intel_ddi_init_hdmi_connector() can just mean "there's no HDMI" while we'll still want to continue with DP only. Handle the errors gracefully, but don't propagate. Clear the hdmi_reg which is used as a proxy to indicate the HDMI is initialized. v2: Gracefully handle but do not propagat

[CI v3 1/6] drm/i915/ddi: change intel_ddi_init_{dp, hdmi}_connector() return type

2024-12-30 Thread Jani Nikula
The caller doesn't actually need the returned struct intel_connector; it's stored in the ->attached_connector of intel_dp and intel_hdmi. Switch to returning an int with 0 for success and negative errors codes to be able to indicate success even when we don't have a connector. Reviewed-by: Suraj K

[CI v3 2/6] drm/i915/hdmi: propagate errors from intel_hdmi_init_connector()

2024-12-30 Thread Jani Nikula
Propagate errors from intel_hdmi_init_connector() to be able to handle them at callers. This is similar to intel_dp_init_connector(). Cc: Sergey Senozhatsky Cc: Ville Syrjala Reported-and-tested-by: Sergey Senozhatsky Closes: https://lore.kernel.org/r/20241031105145.2140590-1-senozhat...@chrom

[CI v3 0/6] drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases

2024-12-30 Thread Jani Nikula
Resend for CI. Jani Nikula (6): drm/i915/ddi: change intel_ddi_init_{dp,hdmi}_connector() return type drm/i915/hdmi: propagate errors from intel_hdmi_init_connector() drm/i915/hdmi: add error handling in g4x_hdmi_init() drm/i915/ddi: gracefully handle errors from intel_ddi_init_hdmi_co

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-30 Thread Dmitry Baryshkov
On Mon, Dec 30, 2024 at 03:18:35PM +0200, Jani Nikula wrote: > On Thu, 26 Dec 2024, Abel Vesa wrote: > > On 24-12-11 15:42:27, Johan Hovold wrote: > >> On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > >> > >> > +/** > >> > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in tran

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-30 Thread Jani Nikula
On Thu, 26 Dec 2024, Abel Vesa wrote: > On 24-12-11 15:42:27, Johan Hovold wrote: >> On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: >> >> > +/** >> > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode >> > + * @aux: DisplayPort AUX channel >> > + * @enable: Ena

Re: [PATCH 6/8] drm/i915/scaler: Pimp scaler debugs

2024-12-30 Thread Jani Nikula
On Tue, 24 Dec 2024, Gustavo Sousa wrote: > Quoting Ville Syrjala (2024-12-19 10:08:25-03:00) >>From: Ville Syrjälä >> >>Include the standard "[CRTC:...]" information in the scaler debugs >>to make life easier. > > Drive-by comment (and going a bit off-topic): > > $ git grep '\[[A-Z]\+:%d:%s]

RE: [PATCH 4/4] drm/i915/dmc_wl: Allow enable_dmc_wl=3 to mean "always locked"

2024-12-30 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Intel-xe On Behalf Of Gustavo > Sousa > Sent: Friday, December 20, 2024 3:44 AM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: [PATCH 4/4] drm/i915/dmc_wl: Allow enable_dmc_wl=3 to mean > "always locked" > > When debugging

RE: [PATCH 3/4] drm/i915/dmc_wl: Allow enable_dmc_wl=2 to mean "match any register"

2024-12-30 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Intel-xe On Behalf Of Gustavo > Sousa > Sent: Friday, December 20, 2024 3:44 AM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: [PATCH 3/4] drm/i915/dmc_wl: Allow enable_dmc_wl=2 to mean > "match any register" > > When debug

RE: [PATCH 2/4] drm/i915/dmc_wl: Show description string for enable_dmc_wl

2024-12-30 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Intel-gfx On Behalf Of Gustavo > Sousa > Sent: Friday, December 20, 2024 3:44 AM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: [PATCH 2/4] drm/i915/dmc_wl: Show description string for > enable_dmc_wl > > We already provide

RE: [PATCH 1/4] drm/i915/dmc_wl: Use enum values for enable_dmc_wl

2024-12-30 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Intel-xe On Behalf Of Gustavo > Sousa > Sent: Friday, December 20, 2024 3:44 AM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: [PATCH 1/4] drm/i915/dmc_wl: Use enum values for enable_dmc_wl > > Currently, after sanitization

Re: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

2024-12-30 Thread Miquel Raynal
On 29/12/2024 at 15:08:56 GMT, "Usyskin, Alexander" wrote: >> >> Hello Alexander, >> >> >> If so, I have to add patch for mtd subsystem to always have device for >> master >> >> initialized regardless of kernel flag. >> >> Only to initialize struct device, not to create full mtd node. >> >> >>