✗ i915.CI.BAT: failure for drm/i915/uc: Include requested frequency in slow firmware load messages (rev2)

2024-12-27 Thread Patchwork
== Series Details == Series: drm/i915/uc: Include requested frequency in slow firmware load messages (rev2) URL : https://patchwork.freedesktop.org/series/142901/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142901v2 ===

✗ i915.CI.BAT: failure for series starting with [1/3] drm/i915: Remove deadcode (rev2)

2024-12-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Remove deadcode (rev2) URL : https://patchwork.freedesktop.org/series/142988/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142988v2 Summa

✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Remove deadcode (rev2)

2024-12-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Remove deadcode (rev2) URL : https://patchwork.freedesktop.org/series/142988/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 3/3] drm/i915: Remove unused intel_ring_cacheline_align

2024-12-27 Thread Andi Shyti
Hi, On Fri, Dec 27, 2024 at 11:37:54AM +, Tvrtko Ursulin wrote: > From: "Dr. David Alan Gilbert" > > The last use of intel_ring_cacheline_align() was removed in 2017 by > commit afa8ce5b3080 ("drm/i915: Nuke legacy flip queueing code") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbe

Re: [PATCH 2/3] drm/i915: Remove unused intel_huc_suspend

2024-12-27 Thread Andi Shyti
Hi, On Fri, Dec 27, 2024 at 11:37:53AM +, Tvrtko Ursulin wrote: > From: "Dr. David Alan Gilbert" > > intel_huc_suspend() was added in 2022 by > commit 27536e03271d ("drm/i915/huc: track delayed HuC load with a > fence") > but hasn't been used. > > Remove it. > > Signed-off-by: Dr. David Al

Re: [PATCH 1/3] drm/i915: Remove deadcode

2024-12-27 Thread Andi Shyti
BTW... On Fri, Dec 27, 2024 at 11:37:52AM +, Tvrtko Ursulin wrote: > From: "Dr. David Alan Gilbert" > > i915_active_acquire_for_context() was added in 2020 by > commit 5d9341370f57 ("drm/i915: Export a preallocate variant of > i915_active_acquire()") but has never been used. > > The last us

Re: [PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2024-12-27 Thread Andi Shyti
Hi Apoorva, On Fri, Dec 27, 2024 at 04:59:20PM +0530, apoorva.si...@intel.com wrote: > From: Apoorva Singh > > Initialize rq to NULL to prevent uninitialized pointer reads. where is it happening? Andi

Re: [PATCH 1/3] drm/i915: Remove deadcode

2024-12-27 Thread Andi Shyti
Hi Tvrtko, I did plan to take care of these patches, anyway, thanks for doing it. Just a couple of notes: please add a cover letter to explain where this comes from and... On Fri, Dec 27, 2024 at 11:37:52AM +, Tvrtko Ursulin wrote: > From: "Dr. David Alan Gilbert" > > i915_active_acquire_fo

✗ i915.CI.BAT: failure for series starting with [1/3] drm/i915: Remove deadcode

2024-12-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Remove deadcode URL : https://patchwork.freedesktop.org/series/142988/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142988v1 Summary

✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Remove deadcode

2024-12-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Remove deadcode URL : https://patchwork.freedesktop.org/series/142988/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ i915.CI.BAT: failure for drm/i915/gt: Prevent uninitialized pointer reads

2024-12-27 Thread Patchwork
== Series Details == Series: drm/i915/gt: Prevent uninitialized pointer reads URL : https://patchwork.freedesktop.org/series/142986/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142986v1 Summary ---

Re: [PATCH] drm/i915: Remove deadcode

2024-12-27 Thread Tvrtko Ursulin
Hi, On 22/12/2024 17:47, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" i915_active_acquire_for_context() was added in 2020 by commit 5d9341370f57 ("drm/i915: Export a preallocate variant of i915_active_acquire()") but has never been used. The last use of __i915_gem_object_is_lmem(

[PATCH 3/3] drm/i915: Remove unused intel_ring_cacheline_align

2024-12-27 Thread Tvrtko Ursulin
From: "Dr. David Alan Gilbert" The last use of intel_ring_cacheline_align() was removed in 2017 by commit afa8ce5b3080 ("drm/i915: Nuke legacy flip queueing code") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/i915/gt/intel_ring.c | 24 drivers/

[PATCH 1/3] drm/i915: Remove deadcode

2024-12-27 Thread Tvrtko Ursulin
From: "Dr. David Alan Gilbert" i915_active_acquire_for_context() was added in 2020 by commit 5d9341370f57 ("drm/i915: Export a preallocate variant of i915_active_acquire()") but has never been used. The last use of __i915_gem_object_is_lmem() was removed in 2021 by commit ff20afc4cee7 ("drm/i915

[PATCH 2/3] drm/i915: Remove unused intel_huc_suspend

2024-12-27 Thread Tvrtko Ursulin
From: "Dr. David Alan Gilbert" intel_huc_suspend() was added in 2022 by commit 27536e03271d ("drm/i915/huc: track delayed HuC load with a fence") but hasn't been used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 13 - drivers/gpu/d

✓ i915.CI.BAT: success for drm/i915/gt: Add GEM_BUG_ON to ensure at least one engine supports migration

2024-12-27 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add GEM_BUG_ON to ensure at least one engine supports migration URL : https://patchwork.freedesktop.org/series/142984/ State : success == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142984v1 =

Re: [PATCH] drm/i915/gt: Add GEM_BUG_ON to ensure at least one engine supports migration

2024-12-27 Thread Tvrtko Ursulin
On 27/12/2024 11:11, apoorva.si...@intel.com wrote: From: Apoorva Singh Ensure GEM_BUG_ON verifies at least one engine supports migration. Additionally, it prevents passing an uninitialized variable to intel_context_create(). Under what circumstances can this happen ie. does it need a Fixes

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Add GEM_BUG_ON to ensure at least one engine supports migration

2024-12-27 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add GEM_BUG_ON to ensure at least one engine supports migration URL : https://patchwork.freedesktop.org/series/142984/ State : warning == Summary == Error: dim checkpatch failed d2a2617f19e9 drm/i915/gt: Add GEM_BUG_ON to ensure at least one engine su

[PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2024-12-27 Thread apoorva . singh
From: Apoorva Singh Initialize rq to NULL to prevent uninitialized pointer reads. Signed-off-by: Apoorva Singh --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu/drm/i915/g

[PATCH] drm/i915/gt: Add GEM_BUG_ON to ensure at least one engine supports migration

2024-12-27 Thread apoorva . singh
From: Apoorva Singh Ensure GEM_BUG_ON verifies at least one engine supports migration. Additionally, it prevents passing an uninitialized variable to intel_context_create(). Cc: Chris Wilson Signed-off-by: Apoorva Singh --- drivers/gpu/drm/i915/gt/intel_migrate.c | 3 +++ 1 file changed, 3 in