Regression on linux-next (next-20241203)

2024-12-05 Thread Borah, Chaitanya Kumar
Hello Tamir, Hope you are doing well. I am Chaitanya from the linux graphics team in Intel. This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository. Since the version next-20241203 [2], we are seeing the following regression

Re: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-05 Thread Martin Uecker
Am Freitag, dem 06.12.2024 um 02:25 + schrieb David Laight: > From: Vincent Mailhol > > Sent: 05 December 2024 15:31 > > > > -CC: Martin Uecker > > +CC: Martin Uecker > > (seems that Martin changed his address) My current one is this: uec...@tugraz.at Martin > > > > On Thu. 5 Dec. 2024 a

Re: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-05 Thread Linus Torvalds
On Thu, 5 Dec 2024 at 18:26, David Laight wrote: > > From: Vincent Mailhol > > ACK. Would adding a suggested--by Linus tag solve your concern? I'm genberally the one person who doesn't need any more credit ;) > I actually suspect the first patches to change __is_constexpr() to > use _Generic wer

RE: [PATCH 01/10] compiler.h: add statically_false()

2024-12-05 Thread David Laight
From: Vincent Mailhol > Sent: 05 December 2024 15:26 > > On Thu. 5 Dec 2024 at 03:30, David Laight wrote: > > From: Vincent Mailhol > > > Sent: 02 December 2024 17:33 > > > > > > From: Vincent Mailhol > > > > > > For completion, add statically_false() which is the equivalent of > > > statically_

RE: [PATCH 02/10] compiler.h: add is_const() as a replacement of __is_constexpr()

2024-12-05 Thread David Laight
From: Vincent Mailhol > Sent: 05 December 2024 15:31 > > -CC: Martin Uecker > +CC: Martin Uecker > (seems that Martin changed his address) > > On Thu. 5 Dec. 2024 at 03:39, David Laight wrote: > > > Sent: 02 December 2024 17:33 > > > > > > From: Vincent Mailhol > > > > > > __is_constexpr(), w

Re: [PATCH 05/10] minmax: simplify __clamp_once() by using is_const_false()

2024-12-05 Thread Vincent Mailhol
On Thu. 5 Dec. 2024 at 03:54, David Laight wrote: > From: Vincent Mailhol > > Sent: 02 December 2024 17:33 > > > > In __clamp_once(), > > > > __builtin_choose_expr(__is_constexpr((lo) > (hi)), (lo) <= (hi), true) > > > > is equivalent to: > > > > !is_const_false((lo) <= (hi)) > > > > Apply is_

Re: [v2 09/25] drm: Add helper to initialize segmented 1D LUT

2024-12-05 Thread Dmitry Baryshkov
On Tue, Dec 03, 2024 at 09:14:58AM +, Shankar, Uma wrote: > > > > -Original Message- > > From: Dmitry Baryshkov > > Sent: Saturday, November 30, 2024 3:17 PM > > To: Shankar, Uma > > Cc: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; intel- > > x...@lists.freedesk

✓ i915.CI.Full: success for drm: fix and enable warnings on unused static inlines (rev2)

2024-12-05 Thread Patchwork
== Series Details == Series: drm: fix and enable warnings on unused static inlines (rev2) URL : https://patchwork.freedesktop.org/series/138460/ State : success == Summary == CI Bug Log - changes from CI_DRM_15796_full -> Patchwork_138460v2_full

RE: [PATCH v2 3/3] drm/i915/xe3: Use hw support for min/interim ddb allocations for async flip

2024-12-05 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Vinod > Govindapillai > Sent: Thursday, November 21, 2024 4:57 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Govindapillai, Vinod ; Nikula, Jani > ; Syrjala, Ville ; Saarinen, > Jani > > Subject: [PAT

RE: [PATCH v2 2/3] drm/i915/display: update to relative data rate handling

2024-12-05 Thread Shankar, Uma
> -Original Message- > From: Intel-xe On Behalf Of Vinod > Govindapillai > Sent: Thursday, November 21, 2024 4:57 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Govindapillai, Vinod ; Nikula, Jani > ; Syrjala, Ville ; Saarinen, > Jani > > Subject: [PATC

RE: [PATCH v2 1/3] drm/i915/display: update to plane_wm register access function

2024-12-05 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Vinod > Govindapillai > Sent: Thursday, November 21, 2024 4:57 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Govindapillai, Vinod ; Nikula, Jani > ; Syrjala, Ville ; Saarinen, > Jani > > Subject: [PAT

Re: [PATCH 3/3] i915/guc: Accumulate active runtime on gt reset

2024-12-05 Thread John Harrison
On 11/27/2024 09:40, Umesh Nerlige Ramappa wrote: On gt reset, if a context is running, then accumulate it's active time into the busyness counter since there will be no chance for the context to switch out and update it's run time. v2: Move comment right above the if (John) Fixes: 77cdd054dd2c

✗ i915.CI.BAT: failure for i915/gt: Reapply workarounds in case the previous attempt failed.

2024-12-05 Thread Patchwork
== Series Details == Series: i915/gt: Reapply workarounds in case the previous attempt failed. URL : https://patchwork.freedesktop.org/series/142188/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15796 -> Patchwork_142188v1

✗ Fi.CI.BUILD: failure for drm/xe/display: Re-use display vmas when possible (rev2)

2024-12-05 Thread Patchwork
== Series Details == Series: drm/xe/display: Re-use display vmas when possible (rev2) URL : https://patchwork.freedesktop.org/series/136034/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/136034/revisions/2/mbox/ not applied Applying: drm/xe/displ

✗ Fi.CI.CHECKPATCH: warning for i915/gt: Reapply workarounds in case the previous attempt failed.

2024-12-05 Thread Patchwork
== Series Details == Series: i915/gt: Reapply workarounds in case the previous attempt failed. URL : https://patchwork.freedesktop.org/series/142188/ State : warning == Summary == Error: dim checkpatch failed 254bcd8fe90b i915/gt: Reapply workarounds in case the previous attempt failed. -:19:

✓ i915.CI.BAT: success for drm: fix and enable warnings on unused static inlines (rev2)

2024-12-05 Thread Patchwork
== Series Details == Series: drm: fix and enable warnings on unused static inlines (rev2) URL : https://patchwork.freedesktop.org/series/138460/ State : success == Summary == CI Bug Log - changes from CI_DRM_15796 -> Patchwork_138460v2 Summ

✗ Fi.CI.SPARSE: warning for drm: fix and enable warnings on unused static inlines (rev2)

2024-12-05 Thread Patchwork
== Series Details == Series: drm: fix and enable warnings on unused static inlines (rev2) URL : https://patchwork.freedesktop.org/series/138460/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm: fix and enable warnings on unused static inlines (rev2)

2024-12-05 Thread Patchwork
== Series Details == Series: drm: fix and enable warnings on unused static inlines (rev2) URL : https://patchwork.freedesktop.org/series/138460/ State : warning == Summary == Error: dim checkpatch failed dc99fb0a4943 drm/bridge: dw-hdmi-i2s: annotate hdmi_read() with __maybe_unused -:7: WARNIN

✓ i915.CI.Full: success for drm/i915/pps: include panel power cycle delay in debugfs

2024-12-05 Thread Patchwork
== Series Details == Series: drm/i915/pps: include panel power cycle delay in debugfs URL : https://patchwork.freedesktop.org/series/142174/ State : success == Summary == CI Bug Log - changes from CI_DRM_15795_full -> Patchwork_142174v1_full

✗ i915.CI.BAT: failure for drm/i915/dsi: add some missing dphy configuration

2024-12-05 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add some missing dphy configuration URL : https://patchwork.freedesktop.org/series/142181/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15796 -> Patchwork_142181v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915/dsi: add some missing dphy configuration

2024-12-05 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add some missing dphy configuration URL : https://patchwork.freedesktop.org/series/142181/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/b

✓ i915.CI.Full: success for series starting with [v1,1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset

2024-12-05 Thread Patchwork
== Series Details == Series: series starting with [v1,1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset URL : https://patchwork.freedesktop.org/series/142170/ State : success == Summary == CI Bug Log - changes from CI_DRM_15795_full -> Patchwork_142170v1_full

✗ i915.CI.BAT: failure for drm/i915/mst: add beginnings of DP MST documentation (rev2)

2024-12-05 Thread Patchwork
== Series Details == Series: drm/i915/mst: add beginnings of DP MST documentation (rev2) URL : https://patchwork.freedesktop.org/series/141756/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15796 -> Patchwork_141756v2 Summa

[PULL] drm-misc-fixes

2024-12-05 Thread Maarten Lankhorst
Hi Dave, Simona, Filled with pepernoten, still had to send a drm-misc-fixes pull request. May contain DP-MST fixes with traces of v3d. :-) Cheers, ~Maarten drm-misc-fixes-2024-12-05: drm-misc-fixes v6.13-rc2: - v3d performance counter fix. - A lot of DP-MST related fixes. The following changes s

✓ i915.CI.BAT: success for drm/i915/pps: include panel power cycle delay in debugfs

2024-12-05 Thread Patchwork
== Series Details == Series: drm/i915/pps: include panel power cycle delay in debugfs URL : https://patchwork.freedesktop.org/series/142174/ State : success == Summary == CI Bug Log - changes from CI_DRM_15795 -> Patchwork_142174v1 Summary

Re: [PATCHv2 01/10] drm/crtc: Add histogram properties

2024-12-05 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 04:29:55PM +, Murthy, Arun R wrote: > > > > -Original Message- > > > > From: Dmitry Baryshkov > > > > Sent: Wednesday, December 4, 2024 5:17 PM > > > > To: Murthy, Arun R > > > > Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; > > > > dri-

[PATCH] drm/xe/display: Re-use display vmas when possible

2024-12-05 Thread Maarten Lankhorst
i915 has this really nice, infrastructure where everything becomes complicated, GGTT needs eviction, etc.. Lets not do that, and make the dumbest possible interface instead. Try to retrieve the VMA from old_plane_state, or intel_fbdev if kernel fb. Signed-off-by: Maarten Lankhorst --- .../gpu/d

Re: [PATCH 06/10] fortify: replace __is_constexpr() by is_const() in strlen()

2024-12-05 Thread Vincent Mailhol
On Thu. 5 Dec. 2024 at 03:58, David Laight wrote: > From: Vincent Mailhol > > Sent: 02 December 2024 17:33 > > > > From: Vincent Mailhol > > > > is_const() is a one to one replacement of __is_constexpr(). Do the > > replacement so that __is_constexpr() can be removed. > > > > Signed-off-by: Vince

✓ i915.CI.Full: success for drm: add drm_printer based hex dumper and use it

2024-12-05 Thread Patchwork
== Series Details == Series: drm: add drm_printer based hex dumper and use it URL : https://patchwork.freedesktop.org/series/142156/ State : success == Summary == CI Bug Log - changes from CI_DRM_15794_full -> Patchwork_142156v1_full Summar

✓ i915.CI.BAT: success for series starting with [v1,1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset

2024-12-05 Thread Patchwork
== Series Details == Series: series starting with [v1,1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset URL : https://patchwork.freedesktop.org/series/142170/ State : success == Summary == CI Bug Log - changes from CI_DRM_15795 -> Patchwork_142170v1 ==

✗ i915.CI.Full: failure for drm/i915/selftest: Log throttle reasons on failure

2024-12-05 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Log throttle reasons on failure URL : https://patchwork.freedesktop.org/series/142148/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15794_full -> Patchwork_142148v1_full Summ

✓ i915.CI.BAT: success for drm: add drm_printer based hex dumper and use it

2024-12-05 Thread Patchwork
== Series Details == Series: drm: add drm_printer based hex dumper and use it URL : https://patchwork.freedesktop.org/series/142156/ State : success == Summary == CI Bug Log - changes from CI_DRM_15794 -> Patchwork_142156v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm: add drm_printer based hex dumper and use it

2024-12-05 Thread Patchwork
== Series Details == Series: drm: add drm_printer based hex dumper and use it URL : https://patchwork.freedesktop.org/series/142156/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: Fi.CI.CHECKPATCH: warning for compiler.h: refactor __is_constexpr() into is_const{, _true, _false}()

2024-12-05 Thread Vincent Mailhol
Hi checkpatch maintainers, On Tue, 03 Dec 2024 at 10:19:34, Patchwork wrote: > == Series Details == > > Series: compiler.h: refactor __is_constexpr() into is_const{,_true,_false}() > URL : https://patchwork.freedesktop.org/series/142040/ > State : warning > > == Summary == > > Error: dim check

✗ i915.CI.BAT: failure for drm/i915/display: clean up DP Adaptive Sync SDP state mismatch logging

2024-12-05 Thread Patchwork
== Series Details == Series: drm/i915/display: clean up DP Adaptive Sync SDP state mismatch logging URL : https://patchwork.freedesktop.org/series/142154/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15794 -> Patchwork_142154v1

Re: [PATCH 04/10] linux/bits.h: simplify GENMASK_INPUT_CHECK() by using is_const_true()

2024-12-05 Thread Vincent Mailhol
On Thu. 5 Dec 2024 at 03:52, David Laight wrote: > From: Vincent Mailhol > > Sent: 02 December 2024 17:33 > > > > __builtin_choose_expr(__is_constexpr((l) > (h)), (l) > (h), 0) > > > > is equivalent to: > > > > is_const_true((l) > (h)) > > Change it to BUILD_BUG_ON_MSG(statically_true((l) < (h

✓ i915.CI.BAT: success for drm/i915/selftest: Log throttle reasons on failure

2024-12-05 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Log throttle reasons on failure URL : https://patchwork.freedesktop.org/series/142148/ State : success == Summary == CI Bug Log - changes from CI_DRM_15794 -> Patchwork_142148v1 Summary --

RE: [PATCHv2 01/10] drm/crtc: Add histogram properties

2024-12-05 Thread Murthy, Arun R
> > > -Original Message- > > > From: Dmitry Baryshkov > > > Sent: Wednesday, December 4, 2024 5:17 PM > > > To: Murthy, Arun R > > > Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; > > > dri- de...@lists.freedesktop.org > > > Subject: Re: [PATCHv2 01/10] drm/crtc: Add

Re: [PATCH v1 1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset

2024-12-05 Thread Andi Shyti
Hi Nitin, On Thu, Dec 05, 2024 at 04:03:38PM +, Gote, Nitin R wrote: > > On Thu, Dec 05, 2024 at 05:27:36PM +0530, Nitin Gote wrote: > > > Issue is seen again where engine resets fails because the engine > > > resumes from an incorrect RING_HEAD. So, increase a time if at first > > > the write

Re: [PATCH v2 2/3] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused

2024-12-05 Thread Laurent Pinchart
On Thu, Dec 05, 2024 at 05:03:00PM +0200, Jani Nikula wrote: > Building with clang and and W=1 leads to warning about unused > rcar_cmm_read(). Fix by annotating it with __maybe_unused. > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > inline functions for W=1 build").

RE: [PATCH v1 1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset

2024-12-05 Thread Gote, Nitin R
Hi Andi, > -Original Message- > From: Andi Shyti > Sent: Thursday, December 5, 2024 6:35 PM > To: Gote, Nitin R > Cc: intel-gfx@lists.freedesktop.org; Wilson, Chris P > > Subject: Re: [PATCH v1 1/1] drm/i915/gt: Increase a time to retry RING_HEAD > reset > > Hi Nitin, > > On Thu, Dec

[PATCH v2 1/3] drm/bridge: dw-hdmi-i2s: annotate hdmi_read() with __maybe_unused

2024-12-05 Thread Jani Nikula
Building with clang and and W=1 leads to warning about unused hdmi_read(). Fix by annotating it with __maybe_unused. See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build"). Signed-off-by: Jani Nikula --- Cc: Andrzej Hajda Cc: Neil Armstrong

[RFC PATCH] i915/gt: Reapply workarounds in case the previous attempt failed.

2024-12-05 Thread Sebastian Brzezinka
`wa_verify`sporadically detects lost workaround on application; this is unusual behavior since wa are applied at `intel_gt_init_hw` and verified right away by `intel_gt_verify_workarounds`, and  `wa_verify` doesn't fail on initialization as one might suspect would happen. One approach that may be

Re: [PATCH 00/10] compiler.h: refactor __is_constexpr() into is_const{,_true,_false}()

2024-12-05 Thread Vincent Mailhol
On Thu. 5 Dec. 2024 at 08:58, Kees Cook wrote: > On December 3, 2024 3:33:22 AM GMT+10:00, Vincent Mailhol via B4 Relay > wrote: > >This series is the spiritual successor of [1] which introduced > >const_true(). In [1], following a comment from David Laight, Linus > >came with a suggestion to si

Re: ✓ i915.CI.Full: success for drm/dp_mst: Fix a few side-band message handling issues (rev3)

2024-12-05 Thread Imre Deak
On Wed, Dec 04, 2024 at 03:30:24PM +, Patchwork wrote: > == Series Details == > > Series: drm/dp_mst: Fix a few side-band message handling issues (rev3) > URL : https://patchwork.freedesktop.org/series/142057/ > State : success Thanks for the review, patchset is pushed to drm-misc-fixes. >

[PATCH v2 2/3] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused

2024-12-05 Thread Jani Nikula
Building with clang and and W=1 leads to warning about unused rcar_cmm_read(). Fix by annotating it with __maybe_unused. See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build"). Signed-off-by: Jani Nikula --- Cc: Laurent Pinchart Cc: Kieran Bi

[PATCH v2 0/3] drm: fix and enable warnings on unused static inlines

2024-12-05 Thread Jani Nikula
v2 of [1]. Dropped the parts that have already been fixed. No other changes. Hoping to get this merged soon. BR, Jani. [1] https://lore.kernel.org/r/cover.1725962479.git.jani.nik...@intel.com Jani Nikula (3): drm/bridge: dw-hdmi-i2s: annotate hdmi_read() with __maybe_unused drm: renesas: rc

[PATCH v2 3/3] drm: enable warnings on unused static inlines

2024-12-05 Thread Jani Nikula
We enable most W=1 warnings by default subsystem wide. Also enable warnings on unused static inlines when building with clang. See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build"). Cc: Nathan Chancellor Tested-by: Nathan Chancellor # build Si

Re: [PATCH] drm/i915/pps: debug log the remaining power cycle delay to wait

2024-12-05 Thread Paul Menzel
Dear Jani, Thank you very much for the patch. Am 04.12.24 um 17:00 schrieb Jani Nikula: While pps_init_delays() debug logs the power cycle delay, also debug log the actual remaining time to wait in wait_panel_power_cycle(). Note that this still isn't the full picture; the power sequencer may

[PATCH 5/5] drm/i915/dsi: set a few DSI_TRANS_FUNC_CONF bits according to VBT

2024-12-05 Thread Jani Nikula
Set the relevant DSI_TRANS_FUNC_CONF bits according to VBT DSI DPHY config. The DSI VBT usage is a nightmare, but that's for another time. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 10 ++ drivers/gpu/drm/i915/display/intel_dsi.h | 2 ++ drivers/g

[PATCH 4/5] drm/i915/vbt: define a few more DSI dphy config bits

2024-12-05 Thread Jani Nikula
We're missing Blanking Packets During BLLP and LP Clock During LPM. Add them. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/i915/display/

[PATCH 0/5] drm/i915/dsi: add some missing dphy configuration

2024-12-05 Thread Jani Nikula
Untested. Jani Nikula (5): drm/i915/dsi: fix PIX_FMT_MASK width drm/i915/dsi: convert DSI_TRANS_FUNC_CONF to REG_BIT() and friends drm/i915/dsi: add LP_CLOCK_DURING_LPM bit for DSI_TRANS_FUNC_CONF drm/i915/vbt: define a few more DSI dphy config bits drm/i915/dsi: set a few DSI_TRANS_FUNC

[PATCH 3/5] drm/i915/dsi: add LP_CLOCK_DURING_LPM bit for DSI_TRANS_FUNC_CONF

2024-12-05 Thread Jani Nikula
We're missing the definition for LP_CLOCK_DURING_LPM. Add it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/icl_dsi_regs.h b/drivers/gpu/drm/i915/display/icl_dsi_regs.h index 88df1da8cc

[PATCH 2/5] drm/i915/dsi: convert DSI_TRANS_FUNC_CONF to REG_BIT() and friends

2024-12-05 Thread Jani Nikula
The register definition is a nightmare to update. Convert to the modern style. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi_regs.h | 74 ++--- 1 file changed, 34 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/i915/display/icl_dsi_regs.h b/dri

[PATCH 1/5] drm/i915/dsi: fix PIX_FMT_MASK width

2024-12-05 Thread Jani Nikula
It's really bits 18:16 not 17:16. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/icl_dsi_regs.h b/drivers/gpu/drm/i915/display/icl_dsi_regs.h index d4845ac65acc..0cb9a5f7

Re: [PATCH v5] drm/i915: ensure segment offset never exceeds allowed max

2024-12-05 Thread Andi Shyti
Hi Krzysztof, On Mon, Nov 18, 2024 at 12:19:22PM +, Krzysztof Karas wrote: > Commit 255fc1703e42 ("drm/i915/gem: Calculate object page offset for > partial memory mapping") introduced a new offset, which accounts for > userspace mapping not starting from the beginning of object's scatterlist.

[PULL] drm-misc-next

2024-12-05 Thread Maxime Ripard
Hi Dave, Sima, Here's this week drm-misc-next PR Maxime drm-misc-next-2024-12-05: drm-misc-next for 6.14: UAPI Changes: Cross-subsystem Changes: Core Changes: - Remove driver date from drm_driver Driver Changes: - amdxdna: New driver! - ivpu: Fix qemu crash when using passthrough - n

Re: [PATCH v5] drm/i915: ensure segment offset never exceeds allowed max

2024-12-05 Thread Andi Shyti
Hi Krzysztof, On Mon, Nov 18, 2024 at 12:19:22PM +, Krzysztof Karas wrote: > Commit 255fc1703e42 ("drm/i915/gem: Calculate object page offset for > partial memory mapping") introduced a new offset, which accounts for > userspace mapping not starting from the beginning of object's scatterlist.

Re: [PATCH 2/3] drm/i915/display: use drm_print_hex_dump() for crtc state dump

2024-12-05 Thread Jani Nikula
On Thu, 05 Dec 2024, Andi Shyti wrote: > Hi Jani, > > On Thu, Dec 05, 2024 at 11:49:34AM +0200, Jani Nikula wrote: >> Use the drm_printer based printer to get the device specific printing of >> the hex dump. >> >> Signed-off-by: Jani Nikula > > ... > >> -static void >> -intel_dump_buffer(const c

Re: [RESEND] drm/i915: add GEM_WARN_ON to remap_io_sg

2024-12-05 Thread Andi Shyti
Hi Krzysztof, On Thu, Nov 21, 2024 at 08:53:39AM +, Krzysztof Karas wrote: > Since we already have that warning inside `remap_sg` we can also catch > this condition inside `remap_io_sg`. didn't we agree that this is redundant? If we hit the first what are the chances to hit the second? Thank

Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure

2024-12-05 Thread Andi Shyti
Hi Raag, On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jadav wrote: > Log throttle reasons on selftest failure which will be useful for > debugging. > > Signed-off-by: Raag Jadav Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH 3/3] drm/i915/display: use drm_print_hex_dump() for buffer mismatch dumps

2024-12-05 Thread Andi Shyti
Hi Jani, On Thu, Dec 05, 2024 at 11:49:35AM +0200, Jani Nikula wrote: > Use the drm_printer based printer to get the device specific printing of > the hex dump, and avoid the manual loglevel hacking. > > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH 2/3] drm/i915/display: use drm_print_hex_dump() for crtc state dump

2024-12-05 Thread Andi Shyti
Hi Jani, On Thu, Dec 05, 2024 at 11:49:34AM +0200, Jani Nikula wrote: > Use the drm_printer based printer to get the device specific printing of > the hex dump. > > Signed-off-by: Jani Nikula ... > -static void > -intel_dump_buffer(const char *prefix, const u8 *buf, size_t len) > -{ > - if

Re: [PATCH 1/3] drm/print: add drm_print_hex_dump()

2024-12-05 Thread Andi Shyti
Hi Jani, On Thu, Dec 05, 2024 at 11:49:33AM +0200, Jani Nikula wrote: > Add a helper to print a hex dump to a struct drm_printer. There's no > fancy formatting stuff, just 16 space-separated bytes per line, with an > optional prefix. > > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyti Than

Re: [PATCH v1 1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset

2024-12-05 Thread Andi Shyti
Hi Nitin, On Thu, Dec 05, 2024 at 05:27:36PM +0530, Nitin Gote wrote: > Issue is seen again where engine resets fails because the engine resumes > from an incorrect RING_HEAD. So, increase a time if at first the > write doesn't succeed and retry again. > > Fixes: 6ef0e3ef2662 ("drm/i915/gt: Retry

[PATCH] drm/i915/pps: include panel power cycle delay in debugfs

2024-12-05 Thread Jani Nikula
The debugfs contains all the other timings except panel power cycle delay. Add it for completeness. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_pps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/displ

Re: [PATCHv2 01/10] drm/crtc: Add histogram properties

2024-12-05 Thread Dmitry Baryshkov
On Thu, 5 Dec 2024 at 09:58, Murthy, Arun R wrote: > > > > > -Original Message- > > From: Dmitry Baryshkov > > Sent: Wednesday, December 4, 2024 5:17 PM > > To: Murthy, Arun R > > Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; dri- > > de...@lists.freedesktop.org >

[PATCH v1 1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset

2024-12-05 Thread Nitin Gote
Issue is seen again where engine resets fails because the engine resumes from an incorrect RING_HEAD. So, increase a time if at first the write doesn't succeed and retry again. Fixes: 6ef0e3ef2662 ("drm/i915/gt: Retry RING_HEAD reset until it get sticks") Closes: https://gitlab.freedesktop.org/drm

Re: [PATCH v2 0/3] drm: remove driver date

2024-12-05 Thread Jani Nikula
On Wed, 04 Dec 2024, Jani Nikula wrote: > Resend, crunched this through more configs enabled to be sure. > > BR, > Jani. > > > > Jani Nikula (3): > drm/xen: remove redundant initialization info print > accel/ivpu: remove DRIVER_DATE conditional drm_driver init > drm: remove driver date from

[PATCH 3/3] drm/i915/display: use drm_print_hex_dump() for buffer mismatch dumps

2024-12-05 Thread Jani Nikula
Use the drm_printer based printer to get the device specific printing of the hex dump, and avoid the manual loglevel hacking. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers

[PATCH 2/3] drm/i915/display: use drm_print_hex_dump() for crtc state dump

2024-12-05 Thread Jani Nikula
Use the drm_printer based printer to get the device specific printing of the hex dump. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_crtc_state_dump.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_crtc_sta

[PATCH 1/3] drm/print: add drm_print_hex_dump()

2024-12-05 Thread Jani Nikula
Add a helper to print a hex dump to a struct drm_printer. There's no fancy formatting stuff, just 16 space-separated bytes per line, with an optional prefix. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 23 +++ include/drm/drm_print.h | 2 ++ 2 files chan

[PATCH 0/3] drm: add drm_printer based hex dumper and use it

2024-12-05 Thread Jani Nikula
Add a hex dumper for drm_printer, and use it to simplify hex dumping in i915. Jani Nikula (3): drm/print: add drm_print_hex_dump() drm/i915/display: use drm_print_hex_dump() for crtc state dump drm/i915/display: use drm_print_hex_dump() for buffer mismatch dumps drivers/gpu/drm/drm_print.c

[PATCH] drm/i915/display: clean up DP Adaptive Sync SDP state mismatch logging

2024-12-05 Thread Jani Nikula
Pass the drm_printer from intel_pipe_config_compare(), and use it for logging, along with pipe_config_mismatch(), to simplify and unify. While at it, differentiate the VSC and AS SDP log texts from each other. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 29

[PATCH v1] drm/i915/selftest: Log throttle reasons on failure

2024-12-05 Thread Raag Jadav
Log throttle reasons on selftest failure which will be useful for debugging. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/selftest_rps.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_