== Series Details ==
Series: cpufreq: intel_pstate: Rearrange locking in
hybrid_init_cpu_capacity_scaling()
URL : https://patchwork.freedesktop.org/series/141196/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15675 -> Patchwork_141196v1
===
== Series Details ==
Series: cpufreq: intel_pstate: Rearrange locking in
hybrid_init_cpu_capacity_scaling()
URL : https://patchwork.freedesktop.org/series/141196/
State : warning
== Summary ==
Error: dim checkpatch failed
cbe2800c4d77 cpufreq: intel_pstate: Rearrange locking in
hybrid_init_c
From: "Rafael J. Wysocki"
Notice that hybrid_init_cpu_capacity_scaling() only needs to hold
hybrid_capacity_lock around __hybrid_init_cpu_capacity_scaling()
calls, so introduce a "locked" wrapper around the latter and call
it from the former. This allows to drop a local variable and a
label that
== Series Details ==
Series: series starting with [1/5] drm/i915/watermark: Initialize latency
variable to appropriate value
URL : https://patchwork.freedesktop.org/series/141193/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15675 -> Patchwork_141193v1
==
Use intel_display for DPKGC code wherever we can. While we are
at it also use intel_de_rmw instead of intel_uncore_rmw as we
really don't need the internal uncore_rmw_function.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/skl_watermark.c | 7 ---
1 file changed, 4 insertions
Refactor the value getting prepped to be written into the PKG_C_LATENCY
register by ORing the REG_FIELD_PREP values instead of having val
getiing operated on twice.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/skl_watermark.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
Increase the latency programmed into PKG_C_LATENCY latency to be
a multiple of line time which is written into WM_LINETIME.
--v2
-Fix commit subject line [Sai Teja]
-Use individual DISPLAY_VER checks instead of range [Sai Teja]
-Initialize max_linetime [Sai Teja]
--v3
-take into account the scena
Initialize max_latency variable to LNL_PKG_C_LATENCY_MASK which helps
to eliminate the else block and make the whole code a lot cleaner.
Signed-off-by: Suraj Kandpal
Reviewed-by: Mitul Golani
---
drivers/gpu/drm/i915/display/skl_watermark.c | 5 +
1 file changed, 1 insertion(+), 4 deletions
Rename the enable_dpkgc variable to make it more clear what it
represents which is that if we are in fixed refresh rate or not.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/skl_watermark.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu
On 11/11/2024 11:18 PM, Garg, Nemesa wrote:
-Original Message-
From: Intel-gfx On Behalf Of Ankit
Nautiyal
Sent: Monday, November 11, 2024 2:42 PM
To: intel-gfx@lists.freedesktop.org
Cc: intel...@lists.freedesktop.org; jani.nik...@linux.intel.com;
ville.syrj...@linux.intel.com; Golan
On 11/11/2024 11:03 PM, Garg, Nemesa wrote:
-Original Message-
From: Intel-gfx On Behalf Of Ankit
Nautiyal
Sent: Monday, November 11, 2024 2:42 PM
To: intel-gfx@lists.freedesktop.org
Cc: intel...@lists.freedesktop.org; jani.nik...@linux.intel.com;
ville.syrj...@linux.intel.com; Golan
On Fri, Nov 08, 2024 at 03:00:21PM +0200, Jani Nikula wrote:
> On Thu, 07 Nov 2024, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Grab the intel_display from 'encoder' rather than 'state'
> > in the encoder hooks to avoid the massive footgun that is
> > intel_sanitize_encoder(), which pass
Hi Alexander,
Please reduce the context when answering, otherwise it's hard to find
all places where you commented.
>> > > > That's the part that I'm not sure if I agree. if I remember from some
>> > > > experiments in the past,
>> > > > when you call to wake up the child, the parent will wakeup
== Series Details ==
Series: series starting with [CI,1/9] drm/i915: Remove vga and gmbus seq out of
i915_restore_display
URL : https://patchwork.freedesktop.org/series/141182/
State : warning
== Summary ==
Error: dim checkpatch failed
72a50a57811a drm/i915: Remove vga and gmbus seq out of i9
== Series Details ==
Series: series starting with [CI,1/9] drm/i915: Remove vga and gmbus seq out of
i915_restore_display
URL : https://patchwork.freedesktop.org/series/141182/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15674 -> Patchwork_141182v1
=
== Series Details ==
Series: series starting with [CI,1/9] drm/i915: Remove vga and gmbus seq out of
i915_restore_display
URL : https://patchwork.freedesktop.org/series/141182/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be c
Hello Alexander,
On 07/11/2024 at 15:13:46 +02, Alexander Usyskin
wrote:
> Add driver for access to Intel discrete graphics card
> internal NVM device.
> Expose device on auxiliary bus by i915 and Xe drivers and
> provide mtd driver to register this device with MTD framework.
>
> This is a rewr
Move dsm register/unregister calls from the drivers to under
intel_display_driver register/unregister.
Reviewed-by: Jonathan Cavitt
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 4
drivers/gpu/drm/i915/i915_driver.c | 5 -
driver
Move intel_power_domains_{suspend,resume} to inside
intel_display_power_{suspend_late, resume_early}.
With this also change the VLV suspend failure to call
the intel_display_power_resume_early. In the end, the only
function executed there for VLV is the intel_power_domains_resume.
Besides make the
Bring some consistency to register/unregister order at the
same time it aligns with i915 sequence order.
Reviewed-by: Jonathan Cavitt
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/display/xe_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/di
Consolidate the intel_power_domains calls under
intel_display_driver.
Reviewed-by: Jonathan Cavitt
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 9 +
drivers/gpu/drm/i915/display/intel_display_driver.h | 1 +
drivers/gpu/drm/i915/i915_driver.c
These save & restore functions inside i915_suspend are old display
functions to save and restore a bunch of display related registers.
Move it under display and rename accordantly. Just don't move it
entirely towards intel_display struct yet because it depends
on drm_i915_private for the IS_MOBILE
The intel_display struct already has a place for save/restore
stuff. Move the i915's regfile there since they are only
related to display.
Reviewed-by: Jonathan Cavitt
Signed-off-by: Rodrigo Vivi
---
.../gpu/drm/i915/display/i9xx_display_sr.c| 40 ++-
.../gpu/drm/i915/displa
Align with i915 and only initialize hotplugs after the display driver
access has been resumed.
Reviewed-by: Jonathan Cavitt
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/xe/display/xe_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/display/xe
Move dp_mst suspend/resume functions from the drivers towards
intel_display_driver to continue with the unification.
Reviewed-by: Jonathan Cavitt
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 6 ++
drivers/gpu/drm/i915/i915_driver.c |
Restrict this function to only save and restore registers
functionality. Then, that can be moved out later to under
display with a proper name.
Cc: Jani Nikula
Reviewed-by: Jonathan Cavitt
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_driver.c | 6 ++
drivers/gpu/drm/i915/i915
On Tue, Oct 08, 2024 at 11:24:42AM -0400, Cavitt, Jonathan wrote:
> -Original Message-
> From: Intel-gfx On Behalf Of
> Rodrigo Vivi
> Sent: Tuesday, September 24, 2024 1:35 PM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: Deak, Imre ; Vivi, Rodrigo
> Subjec
== Series Details ==
Series: drm/i915: intel_display conversions, cleanups
URL : https://patchwork.freedesktop.org/series/141176/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15674 -> Patchwork_141176v1
Summary
---
== Series Details ==
Series: drm/i915: intel_display conversions, cleanups
URL : https://patchwork.freedesktop.org/series/141176/
State : warning
== Summary ==
Error: dim checkpatch failed
8c43f2b99cec drm/i915/overlay: convert to struct intel_display
-:608: CHECK:LINE_SPACING: Please use a bl
== Series Details ==
Series: drm/i915: intel_display conversions, cleanups
URL : https://patchwork.freedesktop.org/series/141176/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Fix potential context UAFs (rev3)
URL : https://patchwork.freedesktop.org/series/112383/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/112383/revisions/3/mbox/ not
applied
Applying: drm/i915: Fix potential c
> -Original Message-
> From: Intel-gfx On Behalf Of Ankit
> Nautiyal
> Sent: Monday, November 11, 2024 2:42 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; jani.nik...@linux.intel.com;
> ville.syrj...@linux.intel.com; Golani, Mitulkumar Ajitkumar
>
> Subj
Move the check for display_irqs_enabled within vlv_display_irq_reset()
and vlv_display_irq_postinstall() to avoid looking at struct
intel_display members within i915 core irq code.
Within display irq code, vlv_display_irq_reset() may need to be called
with !display_irqs_enabled, so add a small wra
Rename display_irqs_enabled to vlv_display_irqs_enabled, to emphasize
it's really only about VLV/CHV. Only access it when running on VLV/CHV.
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_display_core.h | 9 ++-
.../gpu/drm/i915/display/intel_display_irq.c | 26 ++--
struct intel_display replaces struct drm_i915_private as the main
display device pointer. Convert overlay to it, as much as possible.
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_driver.c | 4 +-
drivers/gpu/drm/i915/display/intel_overlay.c | 179 +-
dri
struct intel_display replaces struct drm_i915_private as the main
display device pointer. Convert initial plane setup to it, as much as
possible.
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_driver.c | 2 +-
.../drm/i915/display/intel_plane_initial.c| 56 ++---
Avoid accessing struct intel_display members directly from
i915_getparam_ioctl(). Add intel_overlay_available() function to provide
the information for I915_PARAM_HAS_OVERLAY.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_overlay.c | 5 +
drivers/gpu/drm/i915/display/inte
Some struct intel_display conversions, with the goal to reduce direct
struct intel_display member access from i915 core code. Also some
related cleanups.
BR,
Jani.
Jani Nikula (5):
drm/i915/overlay: convert to struct intel_display
drm/i915/overlay: add intel_overlay_available() and use it
> -Original Message-
> From: Garg, Nemesa
> Sent: Monday, November 11, 2024 11:19 PM
> To: 'Ankit Nautiyal' ;
> intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; jani.nik...@linux.intel.com;
> ville.syrj...@linux.intel.com; Golani, Mitulkumar Ajitkumar
>
> Subject:
On Mon, 11 Nov 2024, Imre Deak wrote:
> On Mon, Nov 11, 2024 at 06:58:32PM +0200, Imre Deak wrote:
>> On Thu, Nov 07, 2024 at 10:32:20PM +0200, Jani Nikula wrote:
>> > The fake encoders pretty much match individual MST streams. The encoders
>> > remain as fake as ever, but change the naming to MST
Make drm-active- optional just like drm-resident- and drm-purgeable-.
Signed-off-by: Yunxiang Li
CC: dri-de...@lists.freedesktop.org
CC: intel-gfx@lists.freedesktop.org
CC: amd-...@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 1 +
drivers/gpu/drm/drm_file.c
When memory stats is generated fresh everytime by going though all the
BOs, their active information is quite easy to get. But if the stats are
tracked alongside BO's state changes this becomes harder since the job
scheduling part doesn't really deal with individual buffers.
Make drm-active- optio
On 10/11/2024 15:41, Yunxiang Li wrote:
Make drm-active- optional just like drm-resident- and drm-purgeable-.
As Jani has already commented the commit message needs some work.
Signed-off-by: Yunxiang Li
CC: dri-de...@lists.freedesktop.org
CC: intel-gfx@lists.freedesktop.org
CC: amd-...@lis
Hello,
On Mon, 4 Nov 2024 at 23:28, Rodrigo Vivi wrote:
>
> On Mon, Nov 04, 2024 at 02:09:46PM +0200, Giedrius Statkevičius wrote:
> > Hello,
> >
> > Kind ping.
>
> There was a pipe underun in CI... I honestly don't believe this patch is
> causing it, but anyway I decided to trigger a retest ther
From: Rob Clark
commit afce71ff6daa9c0f852df0727fe32c6fb107f0fa upstream.
gem_context_register() makes the context visible to userspace, and which
point a separate thread can trigger the I915_GEM_CONTEXT_DESTROY ioctl.
So we need to ensure that nothing uses the ctx ptr after this. And we
need t
> -Original Message-
> From: Jani Nikula
> Sent: Monday, November 11, 2024 2:03 PM
> To: Garg, Nemesa ; intel-gfx@lists.freedesktop.org
> Cc: Garg, Nemesa ; kulka...@freedesktop.org;
> Kulkarni, Vandita
> Subject: Re: [PATCH] drm/i915/display: Add WA_14018221282
>
> On Mon, 11 Nov 202
> -Original Message-
> From: Intel-gfx On Behalf Of Ankit
> Nautiyal
> Sent: Monday, November 11, 2024 2:42 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; jani.nik...@linux.intel.com;
> ville.syrj...@linux.intel.com; Golani, Mitulkumar Ajitkumar
>
> Subj
On Mon, Nov 11, 2024 at 06:58:32PM +0200, Imre Deak wrote:
> On Thu, Nov 07, 2024 at 10:32:20PM +0200, Jani Nikula wrote:
> > The fake encoders pretty much match individual MST streams. The encoders
> > remain as fake as ever, but change the naming to MST stream
> > encoders. Rename all the encoder
On Thu, Nov 07, 2024 at 10:32:20PM +0200, Jani Nikula wrote:
> The fake encoders pretty much match individual MST streams. The encoders
> remain as fake as ever, but change the naming to MST stream
> encoders. Rename all the encoder hooks and related functions called from
> them to mst_stream_* to
On Thu, Nov 07, 2024 at 10:32:21PM +0200, Jani Nikula wrote:
> It would be best to have self-explanatory code, but lacking that, add
> some comments about the way the DDI encoder hooks get called from DP MST
> stream encoders.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Imre Deak
> ---
> driv
On Thu, Nov 07, 2024 at 10:32:19PM +0200, Jani Nikula wrote:
> struct intel_display will replace struct drm_i915_private as the main
> display device data structure. Convert the DP MST code to struct
> intel_display as much as possible.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Imre Deak
> -
On Fri, Nov 08, 2024 at 11:31:29AM +0200, Jani Nikula wrote:
> Making register macros platform or display version aware is not exactly
> something I want to promote widely, but in this case it's the lesser of
> two evils. hsw_chicken_trans_reg() is not pretty, and it doesn't have a
> suitable home.
On Thu, Nov 07, 2024 at 10:32:17PM +0200, Jani Nikula wrote:
> Use a primary_encoder local variable in
> intel_dp_create_fake_mst_encoder() for clarity.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Imre Deak
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +++--
> 1 file changed, 3 ins
On Thu, Nov 07, 2024 at 10:32:16PM +0200, Jani Nikula wrote:
> Add helpers to_primary_encoder() and to_primary_dp() to convert fake MST
> encoder pointers to primary encoder and DP pointers, respectively, and
> use them.
>
> The main point is to highlight the primary encoder and DP usage. Very
> f
On Thu, Nov 07, 2024 at 10:32:15PM +0200, Jani Nikula wrote:
> Switch to the modern style in fake mst encoder creation.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Imre Deak
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 46 ++---
> 1 file changed, 23 insertions(+), 23
On Thu, Nov 07, 2024 at 10:32:14PM +0200, Jani Nikula wrote:
> Pass the primary encoder to the primary encoder hooks. This is
> pedantically correct, but intel_ddi_post_pll_disable() also works with
> the fake encoder by coincidence.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/di
> -Original Message-
> From: Golani, Mitulkumar Ajitkumar
>
> Sent: Monday, November 11, 2024 6:56 PM
> To: Kandpal, Suraj ; intel...@lists.freedesktop.org;
> intel-gfx@lists.freedesktop.org
> Cc: Govindapillai, Vinod ; Kandpal, Suraj
>
> Subject: RE: [PATCH 2/3] drm/i915/watermark: Mo
== Series Details ==
Series: series starting with [1/3] drm/i915/watermark: Initialize latency
variable to appropriate value
URL : https://patchwork.freedesktop.org/series/141160/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15673 -> Patchwork_141160v1
==
> -Original Message-
> From: Intel-gfx On Behalf Of Suraj
> Kandpal
> Sent: 11 November 2024 18:03
> To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> Cc: Govindapillai, Vinod ; Kandpal, Suraj
>
> Subject: [PATCH 1/3] drm/i915/watermark: Initialize latency variable
Hi Chaitanya,
On Mon, Nov 11, 2024 at 6:41 AM Borah, Chaitanya Kumar
wrote:
>
> Hello Rafael,
>
> Hope you are doing well. I am Chaitanya from the linux graphics team in Intel.
>
> This mail is regarding a regression we are seeing in our CI runs[1] on
> linux-next repository.
>
> Since the versi
== Series Details ==
Series: drm/i915/display: convert display feature helpers to struct
intel_display (rev6)
URL : https://patchwork.freedesktop.org/series/140886/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15673 -> Patchwork_140886v6
=
> -Original Message-
> From: Intel-gfx On Behalf Of Suraj
> Kandpal
> Sent: 11 November 2024 18:03
> To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> Cc: Govindapillai, Vinod ; Kandpal, Suraj
>
> Subject: [PATCH 2/3] drm/i915/watermark: Modify latency programmed in
== Series Details ==
Series: drm/i915/display: convert display feature helpers to struct
intel_display (rev6)
URL : https://patchwork.freedesktop.org/series/140886/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separ
== Series Details ==
Series: drm/i915/display: convert display feature helpers to struct
intel_display (rev6)
URL : https://patchwork.freedesktop.org/series/140886/
State : warning
== Summary ==
Error: dim checkpatch failed
963e4875b6cd drm/i915/display: identify discrete graphics
807910abe4f
Hi,
On Tue, 8 Oct 2024, Vinod Govindapillai wrote:
> In intel_dp_audio_compute_config() pipe_config->has_audio decision
> is now based on combination of two condition checks. Split out these
> condition as two separate checks to facilitate handling has_audio
> decision when we introduce audio bw
Hi,
On Tue, 8 Oct 2024, Vinod Govindapillai wrote:
> Limit the audio bw check with DP2 configurations only
[...]
> @@ -3048,7 +3048,8 @@ intel_dp_audio_compute_config(struct intel_encoder
> *encoder,
> {
> pipe_config->has_audio = intel_dp_has_audio(encoder, conn_state);
>
> - pipe_
Hey,
On Tue, 8 Oct 2024, Vinod Govindapillai wrote:
> We would need to check the validity of connector ELD from multiple
> places in the follow up patches. So create a separate function to
> check the validity for ELD.
Reviewed-by: Kai Vehmanen
Br, Kai
Use intel_display for DPKGC code wherever we can. While we are
at it also use intel_de_rmw instead of intel_uncore_rmw as we
really don't need the internal uncore_rmw_function.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/skl_watermark.c | 9 +
1 file changed, 5 insertio
Increase the latency programmed into PKG_C_LATENCY latency to be
a multiple of line time which is written into WM_LINETIME.
--v2
-Fix commit subject line [Sai Teja]
-Use individual DISPLAY_VER checks instead of range [Sai Teja]
-Initialize max_linetime [Sai Teja]
--v3
-take into account the scena
Initialize max_latency variable to LNL_PKG_C_LATENCY_MASK which helps
to eliminate the else block and make the whole code a lot cleaner.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/skl_watermark.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/g
Hey,
On Tue, 8 Oct 2024, Vinod Govindapillai wrote:
> For the complete audio compute config calculations, we would
> need to have the transcoder M/N values as well. So move
> intel_dp_audio_compute_config after the transcoder M/N values
> are calculated in intel_link_compute_m_n().This becomes mo
Hi,
On Tue, 8 Oct 2024, Vinod Govindapillai wrote:
> Calculate the audio bw requirements and check the supported sad
> audio frequencies are feasible with selected pipe configuration.
> If not feasible, prune the audio frequencies from sad list.
a bit of stretch for me to review the display port
> -Original Message-
> From: Usyskin, Alexander
> Sent: Sunday, November 10, 2024 3:17 PM
> To: Vivi, Rodrigo
> Cc: Gupta, Anshuman ; Deak, Imre
> ; Miquel Raynal ;
> Richard Weinberger ; Vignesh Raghavendra
> ; De Marchi, Lucas ; Thomas
> Hellström ; Maarten Lankhorst
> ; Maxime Ripard ;
> -Original Message-
> From: Govindapillai, Vinod
> Sent: Monday, November 11, 2024 4:29 PM
> To: Kandpal, Suraj ; intel...@lists.freedesktop.org;
> intel-gfx@lists.freedesktop.org
> Cc: Pottumuttu, Sai Teja
> Subject: Re: [PATCH] drm/i915/watermark: Modify latency programmed into
> PKG
== Series Details ==
Series: drm/i915/display: convert display feature helpers to struct
intel_display (rev5)
URL : https://patchwork.freedesktop.org/series/140886/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15671 -> Patchwork_140886v5
=
> -Original Message-
> From: Govindapillai, Vinod
> Sent: Monday, November 11, 2024 4:29 PM
> To: Kandpal, Suraj ; intel...@lists.freedesktop.org;
> intel-gfx@lists.freedesktop.org
> Cc: Pottumuttu, Sai Teja
> Subject: Re: [PATCH] drm/i915/watermark: Modify latency programmed into
> PKG
== Series Details ==
Series: drm/i915/display: convert display feature helpers to struct
intel_display (rev5)
URL : https://patchwork.freedesktop.org/series/140886/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separ
== Series Details ==
Series: drm/i915/display: convert display feature helpers to struct
intel_display (rev5)
URL : https://patchwork.freedesktop.org/series/140886/
State : warning
== Summary ==
Error: dim checkpatch failed
895765b7842d drm/i915/display: identify discrete graphics
c2f82f26a75
== Series Details ==
Series: drm/i915/dp: Guarantee a minimum HBlank time (rev4)
URL : https://patchwork.freedesktop.org/series/139267/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15671 -> Patchwork_139267v4
Summary
-
Hi Suraj,
Some comments, please have a look..
On Fri, 2024-11-08 at 14:20 +0530, Suraj Kandpal wrote:
> > Increase the latency programmed into PKG_C_LATENCY latency to be
> > a multiple of line time which is written into WM_LINETIME.
> >
> > --v2
> > -Fix commit subject line [Sai Teja]
> > -Use
== Series Details ==
Series: drm/i915/dp: Guarantee a minimum HBlank time (rev4)
URL : https://patchwork.freedesktop.org/series/139267/
State : warning
== Summary ==
Error: dim checkpatch failed
37aff9d5f323 drm/i915/dp: Guarantee a minimum HBlank time
-:14: WARNING:TYPO_SPELLING: 'accomodate'
Identify mobile platforms separately in display, using the platform
group mechanism. This enables dropping the dependency on i915_drv.h
IS_MOBILE() from display code.
v2: Make snb_display static (kernel test robot)
Reviewed-by: Vinod Govindapillai
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani N
Convert intel_display_device_probe() to accept struct pci_dev * instead
of struct drm_i915_private *. Return struct intel_display * in
preparation of allocating the memory of it later.
Reviewed-by: Vinod Govindapillai
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_dev
Convert intel_display_device.[ch] to struct intel_display, including
callers, but excluding intel_display_device_probe() which will be
handled in follow-up.
v2: fix display->drm = display->drm goof-up
Reviewed-by: Vinod Govindapillai
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/
All the feature check helpers now support (and some require) passing
struct intel_display. Rename the parameter to __display to reflect the
fact.
v2: Rebase
Reviewed-by: Vinod Govindapillai
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_device.h | 116 +-
1
Convert HAS_ULTRAJOINER() to struct intel_display. Do minimal drive-by
conversions to struct intel_display in the callers while at it.
Reviewed-by: Vinod Govindapillai
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 10 ++
Convert HAS_HW_SAGV_WM() to struct intel_display. Do minimal drive-by
conversions to struct intel_display in the callers while at it.
v2: Rebase
Reviewed-by: Vinod Govindapillai # v1
Reviewed-by: Rodrigo Vivi # v1
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cursor.c |
Convert HAS_GMBUS_BURST_READ() to struct intel_display. Do minimal
drive-by conversions to struct intel_display in the callers while at it.
Reviewed-by: Vinod Govindapillai
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_device.h | 2 +-
driv
Convert HAS_SAGV() to struct intel_display. Do minimal drive-by
conversions to struct intel_display in the callers while at it.
Reviewed-by: Vinod Govindapillai
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_device.h | 3 +-
drivers/gpu/drm/i915/
Convert HAS_IPS() to struct intel_display. Do minimal drive-by
conversions to struct intel_display in the callers while at it.
Reviewed-by: Vinod Govindapillai
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/hsw_ips.c | 4 +++-
drivers/gpu/drm
Convert HAS_MBUS_JOINING() to struct intel_display. Do minimal drive-by
conversions to struct intel_display in the callers while at it.
v2: Rebase
Reviewed-by: Vinod Govindapillai # v1
Reviewed-by: Rodrigo Vivi # v1
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_device.h
Convert HAS_DP20() to struct intel_display. Do minimal drive-by
conversions to struct intel_display in the callers while at it.
v2: Rebase
Reviewed-by: Vinod Govindapillai # v1
Reviewed-by: Rodrigo Vivi # v1
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_audio.c| 7 ++-
Convert HAS_DOUBLE_BUFFERED_M_N() to struct intel_display. Do minimal
drive-by conversions to struct intel_display in the callers while at it.
v2: Rebase
Reviewed-by: Vinod Govindapillai
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c
Convert HAS_4TILE() to struct intel_display. Do minimal drive-by
conversions to struct intel_display in the callers while at it.
Reviewed-by: Vinod Govindapillai
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_display_device.h| 2 +-
drivers/gpu/drm
Convert HAS_D12_PLANE_MINIMIZATION() to struct intel_display. Do minimal
drive-by conversions to struct intel_display in the callers while at it.
Reviewed-by: Vinod Govindapillai
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_device.c | 2 +
Identify discrete graphics separately in display, using the platform
group mechanism. This enables dropping the dependency on i915_drv.h
IS_DGFX() from display code.
Start grouping platform groups separately in INTEL_DISPLAY_PLATFORMS()
in anticipation of more groups to come.
Reviewed-by: Rodrigo
Another rebase, v3 of [1].
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1731015333.git.jani.nik...@intel.com
Jani Nikula (15):
drm/i915/display: identify discrete graphics
drm/i915/display: convert HAS_D12_PLANE_MINIMIZATION() to struct
intel_display
drm/i915/display: convert HAS_4TIL
== Series Details ==
Series: Use VRR timing generator for fixed refresh rate modes (rev6)
URL : https://patchwork.freedesktop.org/series/134383/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15668 -> Patchwork_134383v6
Summ
== Series Details ==
Series: Use VRR timing generator for fixed refresh rate modes (rev6)
URL : https://patchwork.freedesktop.org/series/134383/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/in
Mandate a minimum Hblank symbol cycle count between BS and BE in 8b/10b
MST and 12b/132b mode.
Spec: DP2.1a
v2: Affine calculation/updation of min HBlank to dp_mst (Jani)
v3: moved min_hblank from struct intel_dp to intel_crtc_state (Jani)
v4: use max/min functions, change intel_xx *intel_xx to in
1 - 100 of 131 matches
Mail list logo
