linux-next: build warning after merge of the drm-misc tree

2024-10-07 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/panthor.rst:10: WARNING: duplicate label panfrost-usage-stats, other instance in Documentation/gpu/panfrost.rst Introduced by commit 6a797bdfde77 ("drm/panthor: add sysfs kno

✓ Fi.CI.BAT: success for drm/i915/display: Don't allow tile4 framebuffer to do hflip on display20 or greater

2024-10-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't allow tile4 framebuffer to do hflip on display20 or greater URL : https://patchwork.freedesktop.org/series/139664/ State : success == Summary == CI Bug Log - changes from CI_DRM_15489 -> Patchwork_139664v1 ==

✓ Fi.CI.BAT: success for drm/i915/active: Use try_cmpxchg() in active_fence_cb()

2024-10-07 Thread Patchwork
== Series Details == Series: drm/i915/active: Use try_cmpxchg() in active_fence_cb() URL : https://patchwork.freedesktop.org/series/139640/ State : success == Summary == CI Bug Log - changes from CI_DRM_15489 -> Patchwork_139640v1 Summary -

✗ Fi.CI.BUILD: warning for drm/i915/active: Use try_cmpxchg() in active_fence_cb()

2024-10-07 Thread Patchwork
== Series Details == Series: drm/i915/active: Use try_cmpxchg() in active_fence_cb() URL : https://patchwork.freedesktop.org/series/139640/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/139640/revisions/1/mbox/ not found

✓ Fi.CI.BAT: success for series starting with [1/2] drm/xe: Separate the d3cold and non-d3cold runtime PM handling

2024-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/xe: Separate the d3cold and non-d3cold runtime PM handling URL : https://patchwork.freedesktop.org/series/139637/ State : success == Summary == CI Bug Log - changes from CI_DRM_15489 -> Patchwork_139637v1

✗ Fi.CI.BAT: failure for drm/i915/dg2: enable G8 with a workaround

2024-10-07 Thread Patchwork
== Series Details == Series: drm/i915/dg2: enable G8 with a workaround URL : https://patchwork.freedesktop.org/series/139628/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15489 -> Patchwork_139628v1 Summary --- **FA

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: enable G8 with a workaround

2024-10-07 Thread Patchwork
== Series Details == Series: drm/i915/dg2: enable G8 with a workaround URL : https://patchwork.freedesktop.org/series/139628/ State : warning == Summary == Error: dim checkpatch failed 3502ee93c20a drm/i915/dg2: enable G8 with a workaround -:52: ERROR:COMPLEX_MACRO: Macros with complex values

✓ Fi.CI.BAT: success for Revert "platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended"

2024-10-07 Thread Patchwork
== Series Details == Series: Revert "platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended" URL : https://patchwork.freedesktop.org/series/139619/ State : success == Summary == CI Bug Log - changes from CI_DRM_15489 -> Patchwork_139619v1

✗ Fi.CI.BUILD: failure for drm/xe: Reduce flickering when inheriting BIOS fb. (rev2)

2024-10-07 Thread Patchwork
== Series Details == Series: drm/xe: Reduce flickering when inheriting BIOS fb. (rev2) URL : https://patchwork.freedesktop.org/series/139517/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/139517/revisions/2/mbox/ not applied Applying: drm/xe/disp

✗ Fi.CI.BAT: failure for drm/i915/psr: Implement WA to help reach PC10 (rev2)

2024-10-07 Thread Patchwork
== Series Details == Series: drm/i915/psr: Implement WA to help reach PC10 (rev2) URL : https://patchwork.freedesktop.org/series/139513/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15489 -> Patchwork_139513v2 Summary

✗ Fi.CI.BAT: failure for drm/i915/display/dp: Reduce log level for SOURCE OUI write failures

2024-10-07 Thread Patchwork
== Series Details == Series: drm/i915/display/dp: Reduce log level for SOURCE OUI write failures URL : https://patchwork.freedesktop.org/series/139585/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15488 -> Patchwork_139585v1 ===

✓ Fi.CI.BAT: success for drm/i915/display: Fuse bit for power management disable removed

2024-10-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Fuse bit for power management disable removed URL : https://patchwork.freedesktop.org/series/139583/ State : success == Summary == CI Bug Log - changes from CI_DRM_15488 -> Patchwork_139583v1 S

✓ Fi.CI.BAT: success for drm/ci: add new devices for testing

2024-10-07 Thread Patchwork
== Series Details == Series: drm/ci: add new devices for testing URL : https://patchwork.freedesktop.org/series/139562/ State : success == Summary == CI Bug Log - changes from CI_DRM_15488 -> Patchwork_139562v1 Summary --- **SUCCESS*

✗ Fi.CI.CHECKPATCH: warning for drm/ci: add new devices for testing

2024-10-07 Thread Patchwork
== Series Details == Series: drm/ci: add new devices for testing URL : https://patchwork.freedesktop.org/series/139562/ State : warning == Summary == Error: dim checkpatch failed bc332a06dbaa drm/ci: refactor software-driver stage jobs -:7: WARNING:TYPO_SPELLING: 'seperate' may be misspelled -

Re: linux-next: manual merge of the drm-xe tree with the drm-misc-fixes tree

2024-10-07 Thread Stephen Rothwell
Hi all, On Fri, 4 Oct 2024 12:18:00 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the drm-xe tree got a conflict in: > > drivers/gpu/drm/xe/xe_guc_submit.c > > between commit: > > 9286a191abe2 ("drm/xe: Drop GuC submit_wq pool") > > from the drm-misc-fixes tree and commit

RE: [PATCH 20/31] drm/xe/display: Align suspend sequence with i915

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 20/31] drm/xe/display: Align suspend sequence with i915 > > Move a few

RE: [PATCH 19/31] drm/xe/display: Align display resume sequence with i915

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 19/31] drm/xe/display: Align display resume sequence with i915 > > Re

RE: [PATCH 18/31] drm/i915/display: Split resume_noirq calls for now

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 18/31] drm/i915/display: Split resume_noirq calls for now > > Some fun

RE: [PATCH 17/31] drm/{i915, xe}: Move remaining intel_power_domains to intel_display

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 17/31] drm/{i915, xe}: Move remaining intel_power_domains to intel_dis

RE: [PATCH 16/31] drm/{i915, xe}: Move power_domains suspend/resume to display_power

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 16/31] drm/{i915, xe}: Move power_domains suspend/resume to display_p

RE: [PATCH 15/31] drm/xe/display: Delay dsm handler registration

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 15/31] drm/xe/display: Delay dsm handler registration > > Bring some c

RE: [PATCH 14/31] drm/i915/display: Move resume sequences to intel_display_driver

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 14/31] drm/i915/display: Move resume sequences to intel_display_drive

RE: [PATCH 13/31] drm/{i915,xe}: Consolidate display suspend functions

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 13/31] drm/{i915,xe}: Consolidate display suspend functions > > Same

RE: [PATCH 12/31] drm/i915: Remove lingering pci_save_state

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo ; Gupta, Anshuman ; Ville Syrjälä Subject: [PATCH 12/31] drm/i915: Remove lingering

RE: [PATCH 11/31] drm/{i915, xe}: Consolidate display resume functions

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 11/31] drm/{i915,xe}: Consolidate display resume functions > > Same s

RE: [PATCH 10/31] drm/xe/display: Spin-off xe_display runtime/d3cold sequences

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 10/31] drm/xe/display: Spin-off xe_display runtime/d3cold sequences >

Re: [PATCH v3 03/15] drm/i915/display: use a macro to define platform enumerations

2024-10-07 Thread Michal Wajdeczko
On 30.09.2024 14:31, Jani Nikula wrote: > We'll be needing a macro based list of platforms for more things in the > future. Start by defining the platform enumerations with it. > > Signed-off-by: Jani Nikula > --- > .../drm/i915/display/intel_display_device.h | 115 ++ > 1 f

RE: [PATCH 09/31] drm/xe/display: Delay hpd_init resume

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 09/31] drm/xe/display: Delay hpd_init resume > > Align with i915 and o

RE: [PATCH 08/31] drm/i915/display: Move suspend sequences to intel_display_driver

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:35 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 08/31] drm/i915/display: Move suspend sequences to intel_display_driv

Re: [PATCH v3 06/15] drm/i915/display: add display platforms structure with platform members

2024-10-07 Thread Rodrigo Vivi
On Mon, Sep 30, 2024 at 03:31:07PM +0300, Jani Nikula wrote: > Add a structure with a bitfield member for each platform and > subplatform, and initialize them in platform and subplatform descs. > > The structure also contains a bitmap in a union for easier manipulation > of the bits. > > Signed-o

Re: [PATCH v3 05/15] drm/i915/display: convert display platforms to lower case

2024-10-07 Thread Rodrigo Vivi
On Mon, Sep 30, 2024 at 03:31:06PM +0300, Jani Nikula wrote: > This will be helpful for follow-up, where the names here become struct > member names. > > This does impact debug logs as well, making everything lower case. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > .../dr

Re: [PATCH v3 04/15] drm/i915/display: join the platform and subplatform enums

2024-10-07 Thread Rodrigo Vivi
On Mon, Sep 30, 2024 at 03:31:05PM +0300, Jani Nikula wrote: > We'll want to use the subplatforms similar to platforms. Join the > subplatforms next to their corresponding platforms. Update the comment > while at it. > > v2: Put the subplatforms next to the platforms > > Signed-off-by: Jani Nikul

Re: [PATCH v3 03/15] drm/i915/display: use a macro to define platform enumerations

2024-10-07 Thread Rodrigo Vivi
On Mon, Sep 30, 2024 at 03:31:04PM +0300, Jani Nikula wrote: > We'll be needing a macro based list of platforms for more things in the > future. Start by defining the platform enumerations with it. > > Signed-off-by: Jani Nikula > --- > .../drm/i915/display/intel_display_device.h | 115 +++

RE: [PATCH 07/31] drm/{i915, xe}/display: Move DP MST calls to display_driver

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:35 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 07/31] drm/{i915, xe}/display: Move DP MST calls to display_driver >

RE: [PATCH 06/31] drm/xe: Use i915-display shutdown sequence directly

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:35 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 06/31] drm/xe: Use i915-display shutdown sequence directly > > Start t

RE: [PATCH 05/31] drm/xe: At shutdown disable commit helpers instead of flushing

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:35 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo ; Maarten Lankhort Subject: [PATCH 05/31] drm/xe: At shutdown disable commit helpers i

Re: [PATCH v3 02/15] drm/i915/display: use a macro to initialize subplatforms

2024-10-07 Thread Rodrigo Vivi
On Mon, Sep 30, 2024 at 03:31:03PM +0300, Jani Nikula wrote: > Make it easier to change the underlying structures by using a macro > similar to PLATFORM() for initialization. > > The subplatform names in debug logs change slightly as they now reflect > the enum rather than manually entered names.

Re: [PATCH v3 01/15] drm/i915/display: reindent subplatform initialization

2024-10-07 Thread Rodrigo Vivi
On Mon, Sep 30, 2024 at 03:31:02PM +0300, Jani Nikula wrote: > Make the subplatform initialization less cramped, and follow the coding > style more closely. Initialize .pciidlist using designated initializers. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > .../drm/i915/displ

Re: [PATCH][next] drm/i915/display: Fix spelling mistake "Uncomressed" -> "Uncompressed"

2024-10-07 Thread Rodrigo Vivi
On Wed, Oct 02, 2024 at 01:32:29PM +0530, Nautiyal, Ankit K wrote: > > On 10/2/2024 1:19 PM, Colin Ian King wrote: > > There is a spelling mistake in a drm_WARN message. Fix it. > > > > Signed-off-by: Colin Ian King > Reviewed-by: Ankit Nautiyal pushed, thanks > > --- > > drivers/gpu/drm/i9

RE: [PATCH 04/31] drm/i915/display: Move shutdown sequences under display driver

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:35 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 04/31] drm/i915/display: Move shutdown sequences under display driver

RE: [PATCH 03/31] drm/i915/display: Move regfile registers intel_display.restore

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:35 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo Subject: [PATCH 03/31] drm/i915/display: Move regfile registers intel_display.restore

RE: [PATCH 02/31] drm/i915/display: Convert i915_suspend into i9xx_display_sr

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:35 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo ; Jesse Barnes ; Nikula, Jani Subject: [PATCH 02/31] drm/i915/display: Convert i915_su

RE: [PATCH 01/31] drm/i915: Remove vga and gmbus seq out of i915_restore_display

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:35 PM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Deak, Imre ; Vivi, Rodrigo ; Nikula, Jani Subject: [PATCH 01/31] drm/i915: Remove vga and gmbus seq out of i915

Re: [PATCH 2/2] drm/xe: Add missing HPD interrupt enabling during non-d3cold RPM resume

2024-10-07 Thread Rodrigo Vivi
On Mon, Oct 07, 2024 at 09:46:53PM +0300, Imre Deak wrote: > On Mon, Oct 07, 2024 at 09:29:46PM +0300, Cavitt, Jonathan wrote: > > -Original Message- > > From: Intel-xe On Behalf Of Imre > > Deak > > Sent: Monday, October 7, 2024 7:06 AM > > To: intel...@lists.freedesktop.org; intel-gfx@l

Re: [PATCH v3 01/12] drm/xe/display: Handle stolen bar readout in the same way as lmem

2024-10-07 Thread Lucas De Marchi
On Thu, Oct 03, 2024 at 05:44:10PM +0200, Maarten Lankhorst wrote: i915 already does this, we should do the same for Xe. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/xe/display/xe_plane_initial.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH 2/2] drm/xe: Add missing HPD interrupt enabling during non-d3cold RPM resume

2024-10-07 Thread Imre Deak
On Mon, Oct 07, 2024 at 09:29:46PM +0300, Cavitt, Jonathan wrote: > -Original Message- > From: Intel-xe On Behalf Of Imre Deak > Sent: Monday, October 7, 2024 7:06 AM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo > Subject: [PATCH 2/2] drm/xe: A

Re: [PATCH 1/2] drm/xe: Separate the d3cold and non-d3cold runtime PM handling

2024-10-07 Thread Imre Deak
On Mon, Oct 07, 2024 at 09:28:52PM +0300, Cavitt, Jonathan wrote: > -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, October 7, 2024 7:06 AM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo > Subject: [PATCH 1/2] drm/x

Re: [PATCH v3 10/12] drm/xe: Make xe_ggtt_pt_ops private

2024-10-07 Thread Lucas De Marchi
On Thu, Oct 03, 2024 at 05:44:19PM +0200, Maarten Lankhorst wrote: The only user outside xe_ggtt.c is fb pinning, which makes sense as all the operations it performs can be considered part of GGTT. We could move this to xe_ggtt.c, but lets keep it inside display for now. Signed-off-by: Maarten

RE: [PATCH 2/2] drm/xe: Add missing HPD interrupt enabling during non-d3cold RPM resume

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Imre Deak Sent: Monday, October 7, 2024 7:06 AM To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [PATCH 2/2] drm/xe: Add missing HPD interrupt enabling during non-d3cold RPM resume > > Atm the d

RE: [PATCH 1/2] drm/xe: Separate the d3cold and non-d3cold runtime PM handling

2024-10-07 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Imre Deak Sent: Monday, October 7, 2024 7:06 AM To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: [PATCH 1/2] drm/xe: Separate the d3cold and non-d3cold runtime PM handling > > For clarity separ

[PATCH] drm/i915/display: Don't allow tile4 framebuffer to do hflip on display20 or greater

2024-10-07 Thread Juha-Pekka Heikkila
On display ver 20 onwards tile4 is not supported with horizontal flip Bspec: 69853 Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_fb.c| 13 + drivers/gpu/drm/i915/display/intel_fb.h| 1 + drivers/gpu/drm/i915/display/skl_universal_

Re: [PATCH v3 11/12] drm/xe/display: Stop dereferencing ggtt in xe_fb_pin

2024-10-07 Thread Matthew Brost
On Thu, Oct 03, 2024 at 05:44:20PM +0200, Maarten Lankhorst wrote: > This is the only user of the ggtt struct still there, add > some calls to lock/unlock ggtt and remove other dereferencing. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/xe/display/xe

Re: [PATCH] drm/i915/display: Don't allow tile4 framebuffer to do hflip on Xe2

2024-10-07 Thread Juha-Pekka Heikkila
On 12.9.2024 20.14, Lucas De Marchi wrote: On Thu, Sep 12, 2024 at 05:46:06PM GMT, Juha-Pekka Heikkila wrote: On Intel Xe2 hw tile4 is not supported with horizontal flip bspec 69853 Usual spelling is: "Bspec: 69853" and as part of the trailers below. Signed-off-by: Juha-Pekka Heikkila ---

Re: [PATCH v1 1/3] drm/ci: refactor software-driver stage jobs

2024-10-07 Thread Daniel Stone
Hi Vignesh, On Fri, 4 Oct 2024 at 09:31, Vignesh Raman wrote: > +.software-driver: > + stage: software-driver > + extends: > +- .test-gl > +- .test-rules > + timeout: "1h30m" > + tags: > +- kvm > + script: > +- ln -sf $CI_PROJECT_DIR/install /install > +- mv install/bzIma

[PATCH] drm/i915/active: Use try_cmpxchg() in active_fence_cb()

2024-10-07 Thread Uros Bizjak
Replace this pattern in active_fence_cb(): cmpxchg(*ptr, old, new) == old ... with the simpler and faster: try_cmpxchg(*ptr, &old, new) The x86 CMPXCHG instruction returns success in the ZF flag, so this change saves a compare after the CMPXCHG. Signed-off-by: Uros Bizjak Cc: Jani Nik

Re: [PATCH 06/28] drm/hyperv-drm: Use video aperture helpers

2024-10-07 Thread Deepak Rawat
On Mon, Sep 30, 2024 at 6:09 AM Thomas Zimmermann wrote: > > DRM's aperture functions have long been implemented as helpers > under drivers/video/ for use with fbdev. Avoid the DRM wrappers by > calling the video functions directly. > > Signed-off-by: Thomas Zimmermann > Cc: Deepak Rawat > --- >

[PATCH 2/2] drm/xe: Add missing HPD interrupt enabling during non-d3cold RPM resume

2024-10-07 Thread Imre Deak
Atm the display HPD interrupts that got disabled during runtime suspend, are re-enabled only if d3cold is enabled. Fix things by also re-enabling the interrupts if d3cold is disabled. Cc: Rodrigo Vivi Signed-off-by: Imre Deak --- drivers/gpu/drm/xe/display/xe_display.c | 1 + 1 file changed, 1

[PATCH 1/2] drm/xe: Separate the d3cold and non-d3cold runtime PM handling

2024-10-07 Thread Imre Deak
For clarity separate the d3cold and non-d3cold runtime PM handling. The only change in behavior is disabling polling later during runtime resume. This shouldn't make a difference, since the poll disabling is handled from a work, which could run at any point wrt. the runtime resume handler. The work

Re: [PATCH v1] drm/i915/dg2: enable G8 with a workaround

2024-10-07 Thread Nilawar, Badal
On 07-10-2024 18:35, Nilawar, Badal wrote: On 07-10-2024 17:54, Raag Jadav wrote: Usually Wa_ID is included in commit message title for simplified searching. ~/workspace/drmtip/drm-tip$ git log --oneline | grep "Wa_" da9a73b7b25e drm/xe/xe2hpg: Add Wa_15016589081 9db969b36b2f drm/xe/xe2hp

Re: [PATCH v1] drm/i915/dg2: enable G8 with a workaround

2024-10-07 Thread Nilawar, Badal
On 07-10-2024 17:54, Raag Jadav wrote: Host BIOS doesn't enable G8 power mode due to an issue on DG2, so we enable it from kernel with Wa_14022698589. Currently it is enabled for all DG2 devices with the exception of a few, for which, it is enabled only when paired with whitelisted CPU models.

[PATCH v1] drm/i915/dg2: enable G8 with a workaround

2024-10-07 Thread Raag Jadav
Host BIOS doesn't enable G8 power mode due to an issue on DG2, so we enable it from kernel with Wa_14022698589. Currently it is enabled for all DG2 devices with the exception of a few, for which, it is enabled only when paired with whitelisted CPU models. Signed-off-by: Raag Jadav --- drivers/gp

[PATCH v2.1 03/12] drm/i915/display: Use async flip when available for initial plane config

2024-10-07 Thread Maarten Lankhorst
I'm planning to reorder readout in the Xe sequence in such a way that interrupts will not be available, so just use an async flip. Since the new FB points to the same pages, it will not tear. It also has the benefit of perhaps being slightly faster. Signed-off-by: Maarten Lankhorst --- Fix compi

[core-for-CI PATCH] Revert "platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended"

2024-10-07 Thread Luca Coelho
This is causing a regression since 6.12-rc1. We are getting the following error messages when running flip-vs-suspend* tests: [222.857770] = [222.857771] [ BUG: Invalid wait context ] [222.857772] 6.12.0-rc1-xe #1 Not tainted [222.857773] -

Re: [PATCH 8/8] drm/client: s/unsigned int i/int i/

2024-10-07 Thread Thomas Zimmermann
Hi Am 03.10.24 um 13:33 schrieb Ville Syrjala: From: Ville Syrjälä Replace the 'unsigned int i' footguns with plain old signed int. Avoids accidents if/when someone decides they need to iterate backwards. Why are signed types preferable here? Best regards Thomas Signed-off-by: Ville Syrj

Re: [PATCH 4/8] drm/client: Make copies of modes

2024-10-07 Thread Thomas Zimmermann
Hi Am 03.10.24 um 13:33 schrieb Ville Syrjala: From: Ville Syrjälä drm_client_firmware_config() is currently picking up the current mode of the crtc via the legacy crtc->mode, which is not supposed to be used by atomic drivers at all. We can't simply switch over to the proper crtc->state->mode