[PATCH] drm/i915: Rename functions in the docs to match code changes

2024-09-30 Thread Harshit Mogalapalli
make htmldocs is reporting: drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_disable_interrupts' not found drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_enable_interrupts' not found intel_runtime_pm_disable_interrupts() is renamed to intel_irq_suspend(), make docume

Re: [PATCH v7 2/5] drm: Expose wedge recovery methods

2024-09-30 Thread Raag Jadav
On Mon, Sep 30, 2024 at 04:01:38PM +0300, Andy Shevchenko wrote: > On Mon, Sep 30, 2024 at 01:08:42PM +0530, Raag Jadav wrote: > > Now that we have device wedged event in place, add wedge_recovery sysfs > > attribute which will expose recovery methods supported by the DRM device. > > This is useful

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-09-30 Thread Raag Jadav
On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful especially in ca

✓ Fi.CI.BAT: success for i915: Fix HBLANK Expansion Quirk Causing Modeset Failure on Dell WD19TB Dock at 3440x1440@100Hz

2024-09-30 Thread Patchwork
== Series Details == Series: i915: Fix HBLANK Expansion Quirk Causing Modeset Failure on Dell WD19TB Dock at 3440x1440@100Hz URL : https://patchwork.freedesktop.org/series/139318/ State : success == Summary == CI Bug Log - changes from CI_DRM_15462 -> Patchwork_139318v1 ==

✗ Fi.CI.CHECKPATCH: warning for i915: Fix HBLANK Expansion Quirk Causing Modeset Failure on Dell WD19TB Dock at 3440x1440@100Hz

2024-09-30 Thread Patchwork
== Series Details == Series: i915: Fix HBLANK Expansion Quirk Causing Modeset Failure on Dell WD19TB Dock at 3440x1440@100Hz URL : https://patchwork.freedesktop.org/series/139318/ State : warning == Summary == Error: dim checkpatch failed 2be9337017fa i915: Fix HBLANK Expansion Quirk Causing

✗ Fi.CI.BUILD: failure for drm: Add check for encoder in intel_get_crtc_new_encoder() (rev3)

2024-09-30 Thread Patchwork
== Series Details == Series: drm: Add check for encoder in intel_get_crtc_new_encoder() (rev3) URL : https://patchwork.freedesktop.org/series/139314/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/139314/revisions/3/mbox/ not applied Applying: drm

✓ Fi.CI.BAT: success for drm/i915:Remove unused parameter in marco

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915:Remove unused parameter in marco URL : https://patchwork.freedesktop.org/series/139313/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139313v1 Summary --- **SU

linux-next: build warning after merge of the drm-intel tree

2024-09-30 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (htmldocs) produced this warning: drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_disable_interrupts' not found drivers/gpu/drm/i915/i915_irq.c:1: warning: 'intel_runtime_pm_enable_interrupts' not found Introduced

✓ Fi.CI.BAT: success for drm/i915/irq: clean up irq reset/init macro hacks (rev2)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/irq: clean up irq reset/init macro hacks (rev2) URL : https://patchwork.freedesktop.org/series/139168/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139168v2 Summary

✓ Fi.CI.BAT: success for drm: Remove DRM aperture helpers

2024-09-30 Thread Patchwork
== Series Details == Series: drm: Remove DRM aperture helpers URL : https://patchwork.freedesktop.org/series/139307/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139307v1 Summary --- **SUCCESS**

✗ Fi.CI.CHECKPATCH: warning for drm: Remove DRM aperture helpers

2024-09-30 Thread Patchwork
== Series Details == Series: drm: Remove DRM aperture helpers URL : https://patchwork.freedesktop.org/series/139307/ State : warning == Summary == Error: dim checkpatch failed 626bcab951ea drm/amdgpu: Use video aperture helpers af1cd7064fe6 drm/arm/hdlcd: Use video aperture helpers 9a70c232851

✗ Fi.CI.CHECKPATCH: warning for drm/i915/irq: clean up irq reset/init macro hacks (rev2)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/irq: clean up irq reset/init macro hacks (rev2) URL : https://patchwork.freedesktop.org/series/139168/ State : warning == Summary == Error: dim checkpatch failed c73477ce6156 drm/i915/irq: add struct i915_irq_regs triplet ff400a9db6ab drm/i915/irq: remove

✗ Fi.CI.SPARSE: warning for drm/i915/irq: clean up irq reset/init macro hacks (rev2)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/irq: clean up irq reset/init macro hacks (rev2) URL : https://patchwork.freedesktop.org/series/139168/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: remove IS_LP()

2024-09-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: remove IS_LP() URL : https://patchwork.freedesktop.org/series/139304/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139304v1 Summary --

✗ Fi.CI.BUILD: failure for drm/i915: remove all IS__GT() macros

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915: remove all IS__GT() macros URL : https://patchwork.freedesktop.org/series/139306/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/139306/revisions/1/mbox/ not found Build failed, no error log produced

✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915: remove IS_LP()

2024-09-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: remove IS_LP() URL : https://patchwork.freedesktop.org/series/139304/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/139304/revisions/1/mbox/ not found

✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: remove IS_LP()

2024-09-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: remove IS_LP() URL : https://patchwork.freedesktop.org/series/139304/ State : warning == Summary == Error: dim checkpatch failed 0bb70631ccc4 drm/i915: remove IS_LP() -:30: WARNING:LONG_LINE: line length of 109 exceeds 100 co

✗ Fi.CI.SPARSE: warning for drm/i915/display: platform identification with display->platform.

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/display: platform identification with display->platform. URL : https://patchwork.freedesktop.org/series/139302/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915/display: platform identification with display->platform.

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/display: platform identification with display->platform. URL : https://patchwork.freedesktop.org/series/139302/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139302v1

linux-next: build failure after merge of the drm-xe tree

2024-09-30 Thread Stephen Rothwell
Hi all, After merging the drm-xe tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/xe/display/xe_display.c: In function 'xe_display_pm_shutdown': drivers/gpu/drm/xe/display/xe_display.c:382:27: error: passing argument 1 of 'intel_dmc_suspend' from incompatibl

✗ Fi.CI.BAT: failure for drm/i915: Allow fastset for change in HDR infoframe

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915: Allow fastset for change in HDR infoframe URL : https://patchwork.freedesktop.org/series/139293/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139293v1 Summary -

✓ Fi.CI.BAT: success for drm/i915/display: Workaround for odd panning for planar yuv (rev5)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/display: Workaround for odd panning for planar yuv (rev5) URL : https://patchwork.freedesktop.org/series/136416/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_136416v5

✓ Fi.CI.BAT: success for drm/i915/selftests: Implement frequency logging for energy reading validation (rev3)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Implement frequency logging for energy reading validation (rev3) URL : https://patchwork.freedesktop.org/series/139235/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139235v3 =

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Workaround for odd panning for planar yuv (rev5)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/display: Workaround for odd panning for planar yuv (rev5) URL : https://patchwork.freedesktop.org/series/136416/ State : warning == Summary == Error: dim checkpatch failed 88141b5d86a7 drm/i915/display: Workaround for odd panning for planar yuv -:6: WARNIN

Re: [PATCH v3 02/19] crypto: testmgr: Include instead of

2024-09-30 Thread Herbert Xu
On Mon, Sep 30, 2024 at 02:33:13PM +0200, Uros Bizjak wrote: > Substitute the inclusion of header with > to allow the removal of legacy inclusion > of from . > > Signed-off-by: Uros Bizjak > Cc: Herbert Xu > Cc: "David S. Miller" > --- > crypto/testmgr.c | 2 +- > 1 file changed, 1 insertio

✓ Fi.CI.BAT: success for docs/gpu: ci: update flake tests requirements (rev4)

2024-09-30 Thread Patchwork
== Series Details == Series: docs/gpu: ci: update flake tests requirements (rev4) URL : https://patchwork.freedesktop.org/series/139020/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139020v4 Summary

✓ Fi.CI.BAT: success for Introduce DRM device wedged event (rev5)

2024-09-30 Thread Patchwork
== Series Details == Series: Introduce DRM device wedged event (rev5) URL : https://patchwork.freedesktop.org/series/138069/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_138069v5 Summary --- **SUC

✗ Fi.CI.SPARSE: warning for Introduce DRM device wedged event (rev5)

2024-09-30 Thread Patchwork
== Series Details == Series: Introduce DRM device wedged event (rev5) URL : https://patchwork.freedesktop.org/series/138069/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Introduce DRM device wedged event (rev5)

2024-09-30 Thread Patchwork
== Series Details == Series: Introduce DRM device wedged event (rev5) URL : https://patchwork.freedesktop.org/series/138069/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/138069/revisions/5/mbox/ not found

Re: [PATCH 1/6] PCI/PM: Respect pci_dev->skip_bus_pm in the .poweroff() path

2024-09-30 Thread Bjorn Helgaas
On Thu, Sep 26, 2024 at 07:03:16PM +0300, Ville Syrjälä wrote: > On Wed, Sep 25, 2024 at 02:28:42PM -0500, Bjorn Helgaas wrote: > > On Wed, Sep 25, 2024 at 05:45:21PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > On some older laptops i915 needs to leave the GPU in > > > D0 wh

Re: [RFC] Add AS_SDP to fastset

2024-09-30 Thread Ville Syrjälä
On Thu, Aug 08, 2024 at 03:18:49PM +0530, Mitul Golani wrote: > Add full modeset being triggered during VRR enable/disable, specially > when panel has Adaptive sync SDP suypport. > > Signed-off-by: Mitul Golani > --- > drivers/gpu/drm/i915/display/intel_display.c | 3 ++- > 1 file changed, 2 ins

[PATCH v2 03/13] drm/i915/dsb: Generate the DSB buffer in commit_tail()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Once we start using DSB for plane updates we'll need to defer generating the DSB buffer until the clear color has been read out. So we need to move at some of the DSB stuff into commit_tail(). That is perhaps a better place for it anyway as the ioctl thread can move on immedia

[PATCH v2 12/13] drm/i915: Plumb 'dsb' all way to the color commit hooks

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Pass the 'dsb' all the way down to the color commit hooks so that we'll be able to update the double buffered color management registers (eg. CSC) via the DSB. Reviewed-by: Animesh Manna Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c| 180 +

[PATCH v2 13/13] drm/i915/dsb: Use DSB for plane/color management updates

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Push regular plane/color management updates to the DSB, if other constraints allow it. The first part of the sequence will go as follows: - CPU will kick off DSB0 immediately - DSB0 writes double bufferd non-arming registers - DSB0 evades the vblank - DSB0 writes double buffe

[PATCH v2 11/13] drm/i915: Plumb 'dsb' all way to the plane hooks

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä We need to be able to do both MMIO and DSB based pipe/plane programming. To that end plumb the 'dsb' all way from the top into the plane commit hooks. The compiler appears smart enough to combine the branches from all the back-to-back register writes into a single branch. So

[PATCH v2 10/13] drm/i915: Extract intel_crtc_prepare_vblank_event()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Extract the code for staging the vblank event for the flip done interrupt handler. We'll reuse this for DSB stuff later. Reviewed-by: Animesh Manna Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.c | 21 +++-- drivers/gpu/drm/i915/d

[PATCH v2 08/13] drm/i915: Introduce intel_scanlines_to_usecs()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Introduce intel_scanlines_to_usecs() as a counterpart to intel_usecs_to_scanlines(). We'll have some use for this in DSB code as we want to do relative scanline waits to evade the delayed vblank, but unfortunately DSB can't do relative scanline waits (only absolute). So we'll

[PATCH v2 09/13] drm/i915/dsb: Introduce intel_dsb_wait_vblank_delay()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Add intel_dsb_wait_vblank_delay() which instructs the DSB to wait for duration between the undelayed and delayed vblanks. We'll need this as the DSB can only directly wait for the undelayed vblank, but we'll need to wait until the delayed vblank has elapsed as well. Reviewed-

[PATCH v2 07/13] drm/i915/dsb: Introduce intel_dsb_wait_vblanks()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Add a function to emit a DSB wait for vblank instruction. This just waits until the specified number of vblanks. Note that this triggers on the transcoder's undelayed vblank, as opposed to the pipe's delayed vblank. Reviewed-by: Animesh Manna Signed-off-by: Ville Syrjälä -

[PATCH v2 05/13] drm/i915/dsb: Introduce intel_dsb_vblank_evade()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Add a helper for performing vblank evasion on the DSB. DSB based plane updates will need this to guarantee all the double buffered arming registers will get programmed atomically within the same frame. With VRR we more or less have two vblanks to worry about: - vmax vblank st

[PATCH v2 06/13] drm/i915/dsb: Introduce intel_dsb_wait_usec()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Add a function to emit the DSB "wait usecs" instruction. This is just a usleep() for the DSB. As a lower bound it seems pretty accurate, but the upper bound seemed oddly relaxed (ie. sometimes I've seen waits that are quite a bit longer than specified, not sure why). Reviewe

[PATCH v2 04/13] drm/i915/dsb: Enable programmable DSB interrupt

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä The DSB can signal a programmable interrupt in response to a specific DSB command getting executed. Hook that up. For now we'll just use this to signal the completion of the commit via a vblank event. If, in the future, we'll need to do other things in response to DSB interru

[PATCH v2 02/13] drm/i915: Prepare clear color before wait_for_dependencies()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Read out the clear color as soon as fences and the transient data flush have finished. There is no need to wait for all the display specific operations that might still be going on. This could parallelize things a bit more effectively. Reviewed-by: Animesh Manna Signed-off-b

[PATCH v2 01/13] drm/i915/dsb: Avoid reads of the DSB buffer for indexed register writes

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Reading from the DSB command buffer might be somewhat expensive on discrete GPUs because the buffer resides in GPU local memory. Avoid such reads in the indexed register write handling by tracking the previous instruction in intel_dsb. TODO: actually measure this Reviewed-by

[PATCH v2 00/13] drm/i915: Use DSB for plane/color management commits

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Use the DSB to perform simple plane/color management commits. Anything more complicatd (modesets and fastsets) are still punted to the mmio path. Also DSB won't be used when any of these are in use: - scalers (scaler code needs more work) - VRR (need to figure out a race free

RE: [RFC] Add AS_SDP to fastset

2024-09-30 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Jani Nikula > Sent: Thursday, August 8, 2024 3:28 PM > To: Golani, Mitulkumar Ajitkumar ; > intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Nautiyal, Ankit K > > Subject: Re: [RFC] Add AS_SDP to fastset > > On Thu, 08 Aug 2024, Mitul

[RFC v2] drm/i915/vrr: Add AS_SDP to fastset

2024-09-30 Thread Mitul Golani
Enabling and disabling VRR should not trigger full modeset, for this use vrr.flipline instead of vrr.enable while computing Adaptive Sync SDP. This prevents VRR enable/disable to trigger full modeset. --v1: - Explain commit message more clearly [Jani] - Instead of tweaking to fastset use vrr.flipl

[PATCH 13/13] drm/i915/intel_dp: Add support for forcing ultrajoiner

2024-09-30 Thread Ankit Nautiyal
Allow forcing ultrajoiner through debugfs. v2: Minor refactoring of switch case logic. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 10/13] drm/i915/dp: Simplify helper to get slice count with joiner

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy When bigjoiner is used, we need at least 2 dsc slices per pipe. Modify the condition in intel_dp_dsc_get_slice_count() to reflect the same. Signed-off-by: Stanislav Lisovskiy Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i

[PATCH 05/13] drm/i915: Implement hw state readout and checks for ultrajoiner

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Ultrajoiner mode has some new bits and states to be read out from the hw. Lets make changes accordingly. v2: Fix checkpatch warnings. (Ankit) v3: Add separate functions for computing expected secondary_big/ultrajoiner pipes. (Ankit) v4: -Streamline the helpers for ultra

[PATCH 12/13] drm/i915/display: Consider ultrajoiner for computing maxdotclock

2024-09-30 Thread Ankit Nautiyal
Use the check for ultrajoiner while computing maxdotclock. v2: Add Check for HAS_UNCOMPRESSED_JOINER. (Ville) v3: Remove extraneous newline. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 5 +++-- 1 file changed, 3 insertions

[PATCH 11/13] drm/i915: Compute config and mode valid changes for ultrajoiner

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Implement required changes for mode validation and compute config, to support Ultrajoiner. v2: -Drop changes for HDMI. -Separate out DSC changes into another patch. v3: Fix check in can_ultrajoiner. (Ankit) v4: -Unify helper to check joiner requirement. (Ville) -Split p

[PATCH 07/13] drm/i915/dp: Refactor joiner max_bpp calculations into separate functions

2024-09-30 Thread Ankit Nautiyal
Currently compressed max_bpp limitations for small joiner ram, big joiner etc are intermingled. Seprate these limitations into separate functions. v2: Use num_joined_pipes in small joiner ram helper and other minor fixes. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- dri

[PATCH 09/13] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner

2024-09-30 Thread Ankit Nautiyal
Add compressed bpp limitations for ultrajoiner. v2: Fix the case for 1 pipe. (Ankit) v3: Refactor existing helper separately and add only ultrajoiner limitation. (Ville) v4: Separate out function for ultrajoiner_ram_bits. v5: Make the helper function more concise. (Ville) Signed-off-by: Ankit Nau

[PATCH 08/13] drm/i915/dp: Use num_joined_pipes in bigjoiner_bw_max_bpp

2024-09-30 Thread Ankit Nautiyal
Streamline the helper to get max compressed bpp for bigjoiner case, to effectively use num of pipes joined. This will make the addition of ultrajoiner limitations easier and improve redability. Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c

[PATCH 06/13] drm/i915/display/vdsc: Add ultrajoiner support with DSC

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Add changes to DSC which are required for Ultrajoiner. v2: -Use correct helper for setting bits for bigjoiner secondary. (Ankit) -Use primary/secondary instead of master/slave. (Suraj) v3: Add the ultrajoiner helpers and use it for setting ultrajoiner bits (Ankit) v4: U

[PATCH 02/13] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Add sanity checks for primary and secondary bigjoiner/uncompressed bitmasks, should make it easier to spot possible issues. v2: -Streamline the expected masks and add few more drm_WARNs. (Ville) -Use %#x format specifier for printing joiner masks. (Ville) -Use struct in

[PATCH 04/13] drm/i915/display: Refactor enable_joiner_pipes

2024-09-30 Thread Ankit Nautiyal
Pass the current pipe into enabled_joiner_pipes(), and let it figure out the proper bitmasks for us. Since the enabled_joiner_pipes now gets the primary and secondary pipes wrt a given pipe, the helpers to get primary pipe and secondary pipes are no longer required. v2: -Simplify helper get_joiner

[PATCH 03/13] drm/i915/display: Add macro HAS_ULTRAJOINER()

2024-09-30 Thread Ankit Nautiyal
Add macro to check if platform supports Ultrajoiner. v2: -Use check for DISPLAY_VER >= 20, and add bmg as a special case. (Ville) -Add check for HAS_DSC. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_device.h | 3 +++ 1 file cha

[PATCH 00/13] Ultrajoiner basic functionality series

2024-09-30 Thread Ankit Nautiyal
This patch series attempts to implement basic support for Ultrajoiner functionality. Rev6: -Upgrade the debugfs functionality to enable the joining of a specified number of pipes. -Modify the display helpers reliant on the pipe joiner mechanism to use number of pipes joined, instead of joiner flag

[PATCH 01/13] drm/i915: Split current joiner hw state readout

2024-09-30 Thread Ankit Nautiyal
We need to add a new sanity checks and also do some preparations for adding ultrajoiner hw state readout. Lets first split reading of the uncompressed joiner and bigjoiner bit masks into separate functions. v2: Fixed checkpatch warnings (Ankit) v3: Use struct intel_display in the new functions. (A

Re: ✗ Fi.CI.IGT: failure for Ultrajoiner basic functionality series (rev13)

2024-09-30 Thread Nautiyal, Ankit K
On 9/30/2024 7:50 PM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Ultrajoiner basic functionality series (rev13) *URL:* https://patchwork.freedesktop.org/series/133800/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133800v1

Re: [PATCH v3 17/19] netem: Include in sch_netem.c

2024-09-30 Thread Stephen Hemminger
On Mon, 30 Sep 2024 14:33:28 +0200 Uros Bizjak wrote: > Include header to allow the removal of legacy > inclusion of from . > > Signed-off-by: Uros Bizjak > Cc: Stephen Hemminger > Cc: Jamal Hadi Salim > Cc: Cong Wang > Cc: Jiri Pirko > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jak

Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup

2024-09-30 Thread Jani Nikula
On Mon, 30 Sep 2024, Matthew Auld wrote: > On 30/09/2024 14:54, Jani Nikula wrote: >> On Fri, 27 Sep 2024, Jani Nikula wrote: >>> On Thu, 26 Sep 2024, Rodrigo Vivi wrote: On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote: > CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defa

Re: [PATCH 0/4] Enhance debugfs for forcing joiner

2024-09-30 Thread Nautiyal, Ankit K
On 9/26/2024 7:13 PM, Ankit Nautiyal wrote: This patch series introduces enhancements to debugfs for forcing pipe joiner and prepares for the implementation of the ultrajoiner. These patches are derived from the original series [1] focused on the basic functionality of the ultra joiner. The deb

[PATCH 2/2] drm/i915/dp: Write the source OUI for non-eDP sinks as well

2024-09-30 Thread Imre Deak
At least the i-tec USB-C Nano 2x Display Docking Station (containing a Synaptics MST branch device) requires the driver to update the source OUI DPCD registers to expose its DSC capability. Accordingly update the OUI for all sink types (besides eDP where this has been done already). Closes: https:

[PATCH 1/2] drm/i915/dp: Track source OUI validity explicitly

2024-09-30 Thread Imre Deak
While updating the source OUI on the sink the driver should avoid writing the OUI if it's already up-to-date to prevent the sink from resetting itself in response to the update. On eDP - the only output type where the OUI was updated so far - the driver ensured this by comparing the current source

Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup

2024-09-30 Thread Matthew Auld
On 30/09/2024 14:54, Jani Nikula wrote: On Fri, 27 Sep 2024, Jani Nikula wrote: On Thu, 26 Sep 2024, Rodrigo Vivi wrote: On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote: CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When the wakeref is non-zero, it's either

RE: [PATCH 28/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of Thomas > Zimmermann > Sent: Monday, September 30, 2024 9:03 AM > To: javi...@redhat.com; airl...@gmail.com; sim...@ffwll.ch; > maarten.lankho...@linux.intel.com; mrip...@kernel.org > Cc: dri-de...@lists.freedesktop.org; amd-...@li

Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup

2024-09-30 Thread Jani Nikula
On Fri, 27 Sep 2024, Jani Nikula wrote: > On Thu, 26 Sep 2024, Rodrigo Vivi wrote: >> On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote: >>> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When >>> the wakeref is non-zero, it's either -1 or a dynamically allocated >>

[RESEND] drm/i915/gvt: use macros from drm_dp.h instead of duplication

2024-09-30 Thread Jani Nikula
Use the existing macros in drm_dp.h for DPCD and DP AUX instead of duplicating. Remove unused macros, as well as the duplicate definition of DPCD_SIZE. AUX_NATIVE_REPLY_NAK is left unchanged, as it does not match DP_AUX_NATIVE_REPLY_NACK, and I'm not sure what the right thing to do is here. Signe

[PATCH] i915: Fix HBLANK Expansion Quirk Causing Modeset Failure on Dell WD19TB Dock at 3440x1440@100Hz

2024-09-30 Thread Benjamin Hoefs
Hello, I am using a Dell WD19TB dock with a 3440x1440 monitor. Using it at 100Hz used to work but recently I tried it again and discovered it no longer did, specifically the modeset seems to silently fail with no error message in userspace utilities like kscreen-doctor and xrandr and no output in

[PATCH] gpu: drm: i915: display: Avoid null values intel_plane_atomic_check_with_state

2024-09-30 Thread Alessandro Zanni
This fix solves multiple Smatch errors: drivers/gpu/drm/i915/display/intel_atomic_plane.c:660 intel_plane_atomic_check_with_state() error: we previously assumed 'fb' could be null (see line 648) drivers/gpu/drm/i915/display/intel_atomic_plane.c:664 intel_plane_atomic_check_with_state() error: we

[PATCH] drm/i915: Use memdup_user() instead of kmalloc() and copy_from_user()

2024-09-30 Thread Thorsten Blum
Use memdup_user() instead of kmalloc() followed by copy_from_user() to simplify set_context_image(). Fixes the following Coccinelle/coccicheck warning reported by memdup_user.cocci: WARNING opportunity for memdup_user Signed-off-by: Thorsten Blum --- drivers/gpu/drm/i915/gem/i915_gem_context

[PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-30 Thread George Rurikov
If the video card driver could not find the connector assigned to the current video controller, or if the hardware status has changed so that a pre-existing connector is no longer active, none of the state connectors will meet the assignment criteria for the current crtc video controller. In the d

Re: [PATCH v5 42/80] drm/tilcdc: Run DRM default client setup

2024-09-30 Thread jyri . sarha
September 24, 2024 at 10:12 AM, "Thomas Zimmermann" mailto:tzimmerm...@suse.de?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote: > > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the c

[PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-30 Thread George Rurikov
If the video card driver could not find the connector assigned to the current video controller, or if the hardware status has changed so that a pre-existing connector is no longer active, none of the state connectors will meet the assignment criteria for the current crtc video controller. In the d

[RESEND PATCH] drm/i915:Remove unused parameter in marco

2024-09-30 Thread He Lugang
The parameter dev_priv is actually not used in macro PORT_ALPM_CTL and PORT_ALPM_LFPS_CTL,so remove it to simplify the code. Reviewed-by: Jani Nikula Signed-off-by: He Lugang --- drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++-- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- driver

[PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-30 Thread George Rurikov
If the video card driver could not find the connector assigned to the current video controller, or if the hardware status has changed so that a pre-existing connector is no longer active, none of the state connectors will meet the assignment criteria for the current crtc video controller. In the d

Re: [PATCH 00/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > DRM's aperture helpers are merely wrappers around the respective > helpers in drivers/video/. The DRM interface existed first, but was > later generalized for use with fbdev and a few other graphics-related > places in the kernel. It is time to remove th

Re: [PATCH v3 00/19] random: Resolve circular include dependency and include

2024-09-30 Thread Jason A. Donenfeld
Hi Uros, Per your plan, I took this into random.git, and we'll now see if being in next unearths some problems over the next week or two. Jason

[PATCH 00/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture helpers are merely wrappers around the respective helpers in drivers/video/. The DRM interface existed first, but was later generalized for use with fbdev and a few other graphics-related places in the kernel. It is time to remove the DRM wrappers and call the video helpers directly.

[PATCH 20/28] drm/tegra: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Thierry Reding Cc: Mikko Perttunen Cc: Jonathan Hunter --- drivers/gpu/drm/tegra/drm.c |

Re: [PATCH 09/28] drm/meson: Use video aperture helpers

2024-09-30 Thread Neil Armstrong
On 30/09/2024 15:03, Thomas Zimmermann wrote: DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome

[PATCH 26/28] drm/vmwgfx: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Zack Rusin Cc: Broadcom internal kernel review list --- drivers/gpu/drm/vmwgfx/vmwgfx_drv

[PATCH 28/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Thomas Zimmermann
The DRM aperture helpers are wrappers around video helpers from . There are no callers of these functions. Remove them entirely. Signed-off-by: Thomas Zimmermann Cc: Jonathan Corbet --- Documentation/gpu/drm-internals.rst | 12 -- MAINTAINERS | 2 - drivers/gpu/drm/Ma

[PATCH 22/28] drm/cirrus: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Gerd Hoffmann --- drivers/gpu/drm/tiny/cirrus.c | 4 ++-- 1 file changed,

[PATCH 21/28] drm/bochs: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Gerd Hoffmann --- drivers/gpu/drm/tiny/bochs.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH 05/28] drm/hisilicon/hibmc: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Xinliang Liu Cc: Tian Tao Cc: Xinwei Kong Cc: Sumit Semwal Cc: Yongqin Liu Cc: John Stu

[PATCH 27/28] drm/xe: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Lucas De Marchi Cc: "Thomas Hellström" Cc: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_device

[PATCH 25/28] drm/virtgpu: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: David Airlie Cc: Gerd Hoffmann Cc: Gurchetan Singh Cc: Chia-I Wu --- drivers/gpu/drm/vi

[PATCH 24/28] drm/vc4: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Dave Stevenson Cc: Raspberry Pi Kernel Maintenance --- drivers/gpu/drm

[PATCH 15/28] drm/radeon: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan --- drivers/gpu/drm/radeon/radeon_drv.

[PATCH 10/28] drm/mgag200: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 4 ++-- 1 fil

[PATCH 23/28] drm/vboxvideo: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 5 +++-- 1 file changed, 3 insert

[PATCH 17/28] drm/simpledrm: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/simpledrm.c | 8 +--- 1 file changed

[PATCH 14/28] drm/qxl: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.c | 4 ++-- 1 file changed,

[PATCH 16/28] drm/rockchip: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_d

[PATCH 19/28] drm/sun4i: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Jernej Skrabec Cc: Samuel Holland --- drivers/gpu/dr

[PATCH 06/28] drm/hyperv-drm: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Deepak Rawat --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 4 ++-- 1 file changed, 2 inser

  1   2   >