Re: [PATCH] drm/i915/psr: eDP Panel Replay is not supported on pipes other than A and B

2024-09-17 Thread Hogander, Jouni
On Wed, 2024-09-18 at 06:17 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Monday, September 16, 2024 2:27 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Hogander, Jouni > > Subject: [PATCH] drm/i915/psr: eDP

✗ Fi.CI.SPARSE: warning for drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo (rev2) URL : https://patchwork.freedesktop.org/series/138774/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo (rev2) URL : https://patchwork.freedesktop.org/series/138774/ State : warning == Summary == Error: dim checkpatch failed 182f778cfb30 drm/i915/display: start a buffer object abstraction layer -:57: WARNING:FIL

[PATCH 1/2] drm/i915: Add some essential functionality for joiners

2024-09-17 Thread Ankit Nautiyal
From: Stanislav Lisovskiy In most of the cases we now try to avoid mentioning things like "bigjoiner" or "ultrajoiner" trying to unify the API and refer mostly to all this functionality as "joiner". In majority cases that should be way to go. However in some cases we still need to distinguish bet

[PATCH 0/2] Modify iterators to prepare for ultrajoiner

2024-09-17 Thread Ankit Nautiyal
Modify the iterators for enabling/disabling during modeset that works for present and future joiner cases. This patch series is a spin off from original series for ultrajoiner basic functionality [1] and discussion on [2]. Few of the preparatory patches are taken here for review and merge before t

[PATCH 2/2] drm/i915/display: Enhance iterators for modeset en/disable

2024-09-17 Thread Ankit Nautiyal
Joiners have specific enabling and disabling order dependent on primary and secondary pipes. This becomes more complex with ultrajoiner where we have ultrajoiner primary/secondary pipes in addition to bigjoiner primary/secondary pipes. To unify the approach that works for present and future joiner

Re: [PATCH 03/22] drm/i915/fb: convert parts of intel_fb.c to struct drm_gem_object

2024-09-17 Thread Jani Nikula
On Tue, 17 Sep 2024, Maarten Lankhorst wrote: > Den 2024-09-17 kl. 18:13, skrev Jani Nikula: >> diff --git a/drivers/gpu/drm/xe/display/intel_bo.c >> b/drivers/gpu/drm/xe/display/intel_bo.c >> index d564fb7d85e5..f57b684050da 100644 >> --- a/drivers/gpu/drm/xe/display/intel_bo.c >> +++ b/drivers

[PATCH v2] drm/i915/fb: convert parts of intel_fb.c to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Add new intel_bo_* functions as needed. v2: update comment for intel_bo_is_userptr() (Maarten) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bo.c | 10 + drivers/gpu/drm/i

RE: [PATCH] drm/i915/psr: eDP Panel Replay is not supported on pipes other than A and B

2024-09-17 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Monday, September 16, 2024 2:27 PM > To: intel-gfx@lists.freedesktop.org > Cc: Hogander, Jouni > Subject: [PATCH] drm/i915/psr: eDP Panel Replay is not supported on pipes > other than A and B > > Do not allow

Re: [PATCH v3 2/2] drm/i915/display: Prevent DC6 while vblank is enabled for Panel Replay

2024-09-17 Thread Hogander, Jouni
On Tue, 2024-09-17 at 21:15 +0300, Ville Syrjälä wrote: > On Tue, Sep 17, 2024 at 09:36:00AM +0300, Jouni Högander wrote: > > We need to block DC6 entry in case of Panel Replay as enabling VBI > > doesn't > > prevent DC6 in case of Panel Replay. This causes problems if user- > > space is > > pollin

Re: [PATCH v3 1/2] drm/i915/display: Add block_dc6_needed variable into intel_crtc

2024-09-17 Thread Hogander, Jouni
On Tue, 2024-09-17 at 20:58 +0300, Ville Syrjälä wrote: > On Tue, Sep 17, 2024 at 09:35:59AM +0300, Jouni Högander wrote: > > We need to block DC6 entry in case of Panel Replay as enabling VBI > > doesn't > > prevent DC6 in case of Panel Replay. This causes problems if user- > > space is > > pollin

Re: [PATCH 2/2] drm/i915/display: Enhance iterators for modeset en/disable

2024-09-17 Thread Nautiyal, Ankit K
On 9/17/2024 7:01 PM, Ville Syrjälä wrote: On Tue, Sep 17, 2024 at 01:53:58PM +0530, Ankit Nautiyal wrote: Joiners have specific enabling and disabling order dependent on primary and secondary pipes. This becomes more complex with ultrajoiner where we have ultrajoiner primary/secondary pipes i

Re: [PATCH 1/4] Add bits for link_n_exended for DISPLAY >= 14

2024-09-17 Thread Nautiyal, Ankit K
On 9/17/2024 11:16 PM, Jani Nikula wrote: On Tue, 17 Sep 2024, Ankit Nautiyal wrote: LINK_N register has bits 31:24 for extended link N value used for HDMI2.1 and for an alternate mode of operation of DP TG DDA (Bspec:50488). Add support for these extra bits. v2: Drop extra link_n_ext membe

Re: [PATCH v3] Avoid memory barrier in read_seqcount() through load acquire

2024-09-17 Thread Vivi, Rodrigo
On Tue, 2024-09-17 at 13:50 +0200, Thomas Gleixner wrote: > Cc+ i915 people > > On Tue, Sep 17 2024 at 08:37, Will Deacon wrote: > > On Mon, Sep 16, 2024 at 10:52:18AM -0700, Christoph Lameter > > (Ampere) wrote: > > > On Fri, 13 Sep 2024, kernel test robot wrote: > > > > > > > > > drivers/gpu/dr

Re: [PATCH 1/2] drm/xe: Fix DSB buffer coherency

2024-09-17 Thread Ville Syrjälä
On Fri, Sep 13, 2024 at 01:47:53PM +0200, Maarten Lankhorst wrote: > Add the scanout flag to force WC caching, and add the memory barrier > where needed. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/xe/display/xe_dsb_buffer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deleti

Re: [PATCH 22/22] drm/xe: eradicate -Ddrm_i915_gem_object=xe_bo

2024-09-17 Thread Maarten Lankhorst
For the whole series, with the comment addressed: Reviewed-by: Maarten Lankhorst Den 2024-09-17 kl. 18:14, skrev Jani Nikula: > We've now completely stopped using drm_i915_gem_object in display code > that gets built for xe. Kill off the -Ddrm_i915_gem_object=xe_bo > hack. Good riddance. > > Sig

✓ Fi.CI.BAT: success for drm/xe: avoid the async_flip update in the initial plane config (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: drm/xe: avoid the async_flip update in the initial plane config (rev2) URL : https://patchwork.freedesktop.org/series/132649/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_132649v2

Re: [PATCH v3] drm/i915/cx0: Set power state to ready only on owned PHY lanes

2024-09-17 Thread Gustavo Sousa
Quoting Vamsi Krishna Brahmajosyula (2024-09-17 09:44:49-03:00) >In DP alt mode, when pin assignment is D, only one PHY lane is owned >by the display. intel_cx0pll_enable currently performs a power state >ready on both the lanes in all cases. > >Address the todo to perfom power state ready on owned

✓ Fi.CI.BAT: success for drm: revert some framebuffer API tests

2024-09-17 Thread Patchwork
== Series Details == Series: drm: revert some framebuffer API tests URL : https://patchwork.freedesktop.org/series/138782/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138782v1 Summary --- **SUCCE

✗ Fi.CI.SPARSE: warning for drm: revert some framebuffer API tests

2024-09-17 Thread Patchwork
== Series Details == Series: drm: revert some framebuffer API tests URL : https://patchwork.freedesktop.org/series/138782/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116

✗ Fi.CI.BAT: failure for Implement Wa_14021768792 to bypass m_n ratio limit (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: Implement Wa_14021768792 to bypass m_n ratio limit (rev2) URL : https://patchwork.freedesktop.org/series/138257/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138257v2 Summary

Re: [PATCH v3 1/2] drm/i915/display: Add block_dc6_needed variable into intel_crtc

2024-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2024 at 08:58:07PM +0300, Ville Syrjälä wrote: > On Tue, Sep 17, 2024 at 09:35:59AM +0300, Jouni Högander wrote: > > We need to block DC6 entry in case of Panel Replay as enabling VBI doesn't > > prevent DC6 in case of Panel Replay. This causes problems if user-space is > > polling

✗ Fi.CI.SPARSE: warning for Implement Wa_14021768792 to bypass m_n ratio limit (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: Implement Wa_14021768792 to bypass m_n ratio limit (rev2) URL : https://patchwork.freedesktop.org/series/138257/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/inclu

Re: [PATCH 03/22] drm/i915/fb: convert parts of intel_fb.c to struct drm_gem_object

2024-09-17 Thread Maarten Lankhorst
Den 2024-09-17 kl. 18:13, skrev Jani Nikula: > Prefer the driver agnostic struct drm_gem_object over i915 specific > struct drm_i915_gem_object. Add new intel_bo_* functions as needed. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_bo.c | 10 + > drivers/gpu

Re: [PATCH v3 2/2] drm/i915/display: Prevent DC6 while vblank is enabled for Panel Replay

2024-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2024 at 09:36:00AM +0300, Jouni Högander wrote: > We need to block DC6 entry in case of Panel Replay as enabling VBI doesn't > prevent DC6 in case of Panel Replay. This causes problems if user-space is > polling for vblank events. > > Fix this by setting target DC state as DC_STATE

Re: [PATCH v3 1/2] drm/i915/display: Add block_dc6_needed variable into intel_crtc

2024-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2024 at 09:35:59AM +0300, Jouni Högander wrote: > We need to block DC6 entry in case of Panel Replay as enabling VBI doesn't > prevent DC6 in case of Panel Replay. This causes problems if user-space is > polling for vblank events. For this purpose add new block_dc6_needed > variable

Re: [PATCH 1/4] Add bits for link_n_exended for DISPLAY >= 14

2024-09-17 Thread Jani Nikula
On Tue, 17 Sep 2024, Ankit Nautiyal wrote: > LINK_N register has bits 31:24 for extended link N value used for > HDMI2.1 and for an alternate mode of operation of DP TG DDA > (Bspec:50488). > > Add support for these extra bits. > > v2: Drop extra link_n_ext member. (Jani) > > Signed-off-by: Ankit

[PATCH 2/2] Revert "drm/tests: Add test for drm_framebuffer_init()"

2024-09-17 Thread Jani Nikula
This reverts commit 2735d5e4060960c7bd06698b0a1990c7d42c762e. This test hits a WARN_ON_ONCE(), because fb.format isn't set. Fixes: 2735d5e40609 ("drm/tests: Add test for drm_framebuffer_init()") Cc: Carlos Eduardo Gallo Filho Cc: Maxime Ripard Cc: Maarten Lankhorst Cc: Thomas Zimmermann Cc: J

[PATCH 1/2] Revert "drm/tests: Add test for drm_framebuffer_free()"

2024-09-17 Thread Jani Nikula
This reverts commit d2194256049910d286cd6c308c2689df521d8842. Intel CI consistently hits a WARN in drm_framebuffer_free() with this test, because the fb->filp_head list is uninitialized. Link: https://lore.kernel.org/r/87plp7ex27@intel.com Fixes: d21942560499 ("drm/tests: Add test for drm_fra

[PATCH 0/2] drm: revert some framebuffer API tests

2024-09-17 Thread Jani Nikula
The tests consistently trigger WARNs in drm_framebuffer code. I'm not sure what the point is with type of belts and suspenders tests. The warnings *are* the way to flag erroneous API usage. Warnings in turn trigger failures in CI. Filtering the warnings are error prone, and, crucially, would also

[PATCH 4/4] drm/i915/display: Implement Wa_14021768792 for BMG DP for link_m/n ratio > 10

2024-09-17 Thread Ankit Nautiyal
Handle the bypass logic for the M/N ratio limit for DP. Calculate the M/N ratio, check if it can bypass the limit, and set the appropriate flags for the workaround. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 1 - drivers/gpu/drm/i915/display/intel_display.h

[PATCH 3/4] drm/i915/display: Add bits for Wa_14021768792 for linkm/n ratio > 10

2024-09-17 Thread Ankit Nautiyal
To support Link M/N ratio between 10.0 and 15.0, for some BMG ultrajoiner cases we need Wa_14021768792. To bypass the hardware limitation within the Timing Generator DDA (TGDDA), we need to program the LINKM and LINKN registers as defined in the WA. Along with this we also need relvant bits in HDM

[PATCH 2/4] drm/i915/display: Limit m/n ratio to 10 for display > 12

2024-09-17 Thread Ankit Nautiyal
As per Bspec:49266 for DISPLAY > 12 which support higher link rates have a limitation: If the CEILING( Link M / Link N ) ratio is greater than 10.0, then hardware cannot support the given resolution / refresh rate at the given configuration. Modify the helper to compute m_n, to check for the max l

[PATCH 1/4] Add bits for link_n_exended for DISPLAY >= 14

2024-09-17 Thread Ankit Nautiyal
LINK_N register has bits 31:24 for extended link N value used for HDMI2.1 and for an alternate mode of operation of DP TG DDA (Bspec:50488). Add support for these extra bits. v2: Drop extra link_n_ext member. (Jani) Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c

[PATCH 0/4] Implement Wa_14021768792 to bypass m_n ratio limit

2024-09-17 Thread Ankit Nautiyal
For Platforms that support higher link rates, there is a limitation on Link M /Link N ratio. If the CEILING( Link M / Link N ) ratio is greater than 10.0, then hardware cannot support the given resolution / refresh rate at the given configuration. For BMG Wa_14021768792 helps to bypass this limitat

✓ Fi.CI.BAT: success for Introduce drm sharpness property (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: Introduce drm sharpness property (rev2) URL : https://patchwork.freedesktop.org/series/138754/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138754v2 Summary --- **SUCC

✗ Fi.CI.SPARSE: warning for Introduce drm sharpness property (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: Introduce drm sharpness property (rev2) URL : https://patchwork.freedesktop.org/series/138754/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Introduce drm sharpness property (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: Introduce drm sharpness property (rev2) URL : https://patchwork.freedesktop.org/series/138754/ State : warning == Summary == Error: dim checkpatch failed 916b12ed3724 drm: Introduce sharpness strength property f0b0e2321ed3 drm/i915/display: Compute the scaler filte

Re: [PATCH] drm/i915/irq: Uninstall should be called just once

2024-09-17 Thread Jani Nikula
On Mon, 16 Sep 2024, Rodrigo Vivi wrote: > There shouldn't be any path where the irq uninstall is called > twice nowadays. So, remove the FIXME commend and change > the check to a WARN. > > Suggested-by: Jani Nikula > Signed-off-by: Rodrigo Vivi Please double check the CI results, I didn't spot

✓ Fi.CI.BAT: success for drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo URL : https://patchwork.freedesktop.org/series/138774/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138774v1 Summary -

✗ Fi.CI.CHECKPATCH: warning for drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo URL : https://patchwork.freedesktop.org/series/138774/ State : warning == Summary == Error: dim checkpatch failed 63c8a90376b6 drm/i915/display: start a buffer object abstraction layer -:57: WARNING:FILE_PATH_

✗ Fi.CI.SPARSE: warning for drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo URL : https://patchwork.freedesktop.org/series/138774/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH 20/22] drm/xe/compat: remove a bunch of compat gem headers

2024-09-17 Thread Jani Nikula
Now that we've switched to struct drm_gem_object and the intel_bo_* interfaces, we no longer need most of the compat gem headers. Remove. Signed-off-by: Jani Nikula --- .../compat-i915-headers/gem/i915_gem_lmem.h | 1 - .../compat-i915-headers/gem/i915_gem_mman.h | 17 -- .../compat

[PATCH 22/22] drm/xe: eradicate -Ddrm_i915_gem_object=xe_bo

2024-09-17 Thread Jani Nikula
We've now completely stopped using drm_i915_gem_object in display code that gets built for xe. Kill off the -Ddrm_i915_gem_object=xe_bo hack. Good riddance. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/xe/Makefile b

[PATCH 19/22] drm/i915/display: clean up some gem/ includes

2024-09-17 Thread Jani Nikula
Drop some unnecessary gem/ includes. We seem to include xe_device.h through some compat gem headers, so we need to include it directly in compat i915_drv.h to get xe_device_has_flat_ccs(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cursor.c | 2 -- drivers/gpu/drm/i

[PATCH 21/22] drm/xe: remove a number of superfluous compat macros

2024-09-17 Thread Jani Nikula
Some compat macros have inadvertently been sprinkled in xe core headers. Remove the final users and the macros. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 4 ++-- drivers/gpu/drm/xe/xe_bo.h | 2 -- drivers/gpu/drm/xe/xe_bo_types.h| 3

[PATCH 18/22] drm/i915/fb: remove intel_fb_obj()

2024-09-17 Thread Jani Nikula
Convert remaining users of the struct drm_i915_gem_object based intel_fb_obj() to the struct drm_gem_object based intel_fb_bo(), and remove intel_fb_obj(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dpt.c| 2 +- drivers/gpu/drm/i915/display/intel_fb.c | 5 -

[PATCH 14/22] drm/i915/display: add intel_bo_get/set_frontbuffer() and use them

2024-09-17 Thread Jani Nikula
Add the struct drm_gem_object based interfaces. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bo.c | 12 drivers/gpu/drm/i915/display/intel_bo.h | 4 drivers/gpu/drm/i915/display/intel_frontbuffer.c | 7 --- drivers/gpu/drm/xe/display

[PATCH 13/22] drm/i915/display: add intel_bo_read_from_page() and use it

2024-09-17 Thread Jani Nikula
Add an interface based on struct drm_gem_object, and use it. Move the xe implementation to the intel_bo abstraction layer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bo.c | 5 drivers/gpu/drm/i915/display/intel_bo.h | 1 + drivers/gpu/drm/i915/display/in

[PATCH 17/22] drm/i915/display: add intel_bo_describe() and use it

2024-09-17 Thread Jani Nikula
Add an interface based on struct drm_gem_object, and use it. This lets us delete the compat i915_debugfs.h header. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bo.c| 6 ++ drivers/gpu/drm/i915/display/intel_bo.h| 3 +++ .../gpu/drm/i915/display

[PATCH 11/22] drm/i915/fb: convert intel_framebuffer_create() to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Move the declaration to the right place while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.h | 4 drivers/gpu/drm/i915/display/intel_fb.c | 6 +++--- d

[PATCH 15/22] drm/i915/frontbuffer: convert intel_frontbuffer_get() to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- drivers/gpu/drm/i915/display/intel_frontbuffer.c | 12 ++-- drivers/gpu/drm/i915/display/intel_frontbuf

[PATCH 16/22] drm/i915/frontbuffer: convert frontbuffer->obj to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Do some opportunistic struct intel_display conversions while at it, because it's more convenient to deal with. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_frontbuffer.c | 56 ++

[PATCH 12/22] drm/xe/display: stop using intel_fb_obj() in xe_fb_pin.c

2024-09-17 Thread Jani Nikula
intel_fb_obj() returns struct drm_i915_gem_object, which is not right for xe, and only works because xe defines -Ddrm_i915_gem_object=xe_bo. Switch to intel_fb_bo() and convert to struct xe_bo from there. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/display/xe_fb_pin.c | 12 1

[PATCH 05/22] drm/i915/display: convert skl_universal_plane.c to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Add new intel_bo_* functions as needed. Convert intel_pxp_key_check() to struct drm_gem_object. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bo.c| 5 + driver

[PATCH 10/22] drm/xe/display: use correct bo type in intel_fbdev_fb_alloc()

2024-09-17 Thread Jani Nikula
It's really struct xe_bo, and struct drm_i915_gem_object only works because of -Ddrm_i915_gem_object=xe_bo in xe Makefile. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/display/int

[PATCH 09/22] drm/i915/fb: convert intel_fb_bo_framebuffer_fini() to struct drm_i915_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. The xe specific intel_fb_bo.h becomes redundant. Remove it, and rely on the common header in i915 display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fb.c| 4 ++-- drivers

[PATCH 08/22] drm/i915/fb: convert intel_fb_bo_framebuffer_init() to struct drm_i915_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Add new intel_bo_* functions as needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fb.c| 2 +- drivers/gpu/drm/i915/display/intel_fb_bo.c | 3 ++- drivers/gpu/drm/i915/displ

[PATCH 03/22] drm/i915/fb: convert parts of intel_fb.c to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Add new intel_bo_* functions as needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bo.c | 10 + drivers/gpu/drm/i915/display/intel_bo.h | 2 ++ drivers/gpu/drm/i915/dis

[PATCH 06/22] drm/i915/fb: convert intel_framebuffer_init() to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fb.c| 14 +++--- drivers/gpu/drm/i915/display/intel_fb.h| 2 +- drivers/gpu/drm/i915/display/intel_pl

[PATCH 07/22] drm/i915/fb: convert intel_fb_bo_lookup_valid_bo() to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fb.c| 6 +++--- drivers/gpu/drm/i915/display/intel_fb_bo.c | 4 ++-- drivers/gpu/drm/i915/display/intel_fb_bo.h | 5 +++-- driv

[PATCH 01/22] drm/i915/display: start a buffer object abstraction layer

2024-09-17 Thread Jani Nikula
The display code needs to deal with gem objects, and mostly uses struct drm_i915_gem_object. That's not great, because for xe we need to redefine it struct xe_bo during build. Start a common interface using struct drm_gem_object, with separate implementations for i915 and xe. For starters, convert

[PATCH 02/22] drm/i915/display: convert intel_atomic_plane.c to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ato

[PATCH 04/22] drm/i915/fbdev: convert intel_fbdev.c to struct drm_gem_object

2024-09-17 Thread Jani Nikula
Prefer the driver agnostic struct drm_gem_object over i915 specific struct drm_i915_gem_object. Add new intel_bo_* functions as needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bo.c | 11 drivers/gpu/drm/i915/display/intel_bo.h | 3 ++ drivers/gpu/d

[PATCH 00/22] drm/i915 & drm/xe: kill off -Ddrm_i915_gem_object=xe_bo

2024-09-17 Thread Jani Nikula
The xe Makefile defines -Ddrm_i915_gem_object=xe_bo to build i915 display for xe. This lengthy series removes that hack. This is based on two ideas: 1) Always use struct drm_gem_object instead of struct drm_i915_gem_object or xe_bo in code that gets built for both i915 and xe. 2) Add intel

RE: [PATCH 3/5] Add crtc properties for global histogram

2024-09-17 Thread Murthy, Arun R
> > > > +static int intel_crtc_set_property(struct drm_crtc *crtc, > > > > + struct drm_crtc_state *state, > > > > + struct drm_property *property, > > > > + u64 val) > > > > +{ > > > > + struct

RE: [PATCH 3/5] Add crtc properties for global histogram

2024-09-17 Thread Murthy, Arun R
> > > +static int intel_crtc_get_property(struct drm_crtc *crtc, > > > +const struct drm_crtc_state *state, > > > +struct drm_property *property, > > > +uint64_t *val) > > > +{ > > > + struct drm_i915_private *i915

✓ Fi.CI.BAT: success for drm/i915/psr: Fix PSR sink enable sequence (rev3)

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915/psr: Fix PSR sink enable sequence (rev3) URL : https://patchwork.freedesktop.org/series/138530/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138530v3 Summary ---

Re: [PATCH 1/2] drm/i915/display: remove small micro-optimizations in irq handling

2024-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2024 at 10:02:19AM -0400, Rodrigo Vivi wrote: > On Tue, Sep 17, 2024 at 01:58:19PM +0300, Jani Nikula wrote: > > On Thu, 18 Apr 2024, Tvrtko Ursulin wrote: > > > On 18/04/2024 10:49, Jani Nikula wrote: > > >> On Wed, 17 Apr 2024, Lucas De Marchi wrote: > > >>> On Mon, Apr 08, 2024

✓ Fi.CI.BAT: success for drm/i915/gvt: use macros from drm_dp.h instead of duplication

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915/gvt: use macros from drm_dp.h instead of duplication URL : https://patchwork.freedesktop.org/series/138760/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138760v1 Sum

RE: [PATCH] drm/i915/selftests: Implement Frequency Check for Energy Reading Validation

2024-09-17 Thread Gupta, Anshuman
> -Original Message- > From: Anirban, Sk > Sent: Tuesday, September 17, 2024 2:50 PM > To: intel-gfx@lists.freedesktop.org > Cc: Gupta, Anshuman ; Anirban, Sk > > Subject: [PATCH] drm/i915/selftests: Implement Frequency Check for Energy > Reading Validation > > This commit introduces

✓ Fi.CI.BAT: success for drm/i915/selftests: Implement Frequency Check for Energy Reading Validation (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Implement Frequency Check for Energy Reading Validation (rev2) URL : https://patchwork.freedesktop.org/series/138753/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138753v2 ===

Re: [PATCH 1/2] drm/i915/display: remove small micro-optimizations in irq handling

2024-09-17 Thread Rodrigo Vivi
On Tue, Sep 17, 2024 at 01:58:19PM +0300, Jani Nikula wrote: > On Thu, 18 Apr 2024, Tvrtko Ursulin wrote: > > On 18/04/2024 10:49, Jani Nikula wrote: > >> On Wed, 17 Apr 2024, Lucas De Marchi wrote: > >>> On Mon, Apr 08, 2024 at 03:54:44PM GMT, Jani Nikula wrote: > The raw register reads/wri

✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Implement Frequency Check for Energy Reading Validation (rev2)

2024-09-17 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Implement Frequency Check for Energy Reading Validation (rev2) URL : https://patchwork.freedesktop.org/series/138753/ State : warning == Summary == Error: dim checkpatch failed 05183c9170dc drm/i915/selftests: Implement frequency check for ener

✗ Fi.CI.BAT: failure for Introduce drm sharpness property

2024-09-17 Thread Patchwork
== Series Details == Series: Introduce drm sharpness property URL : https://patchwork.freedesktop.org/series/138754/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138754v1 Summary --- **FAILURE**

Re: [PATCH 2/2] drm/i915/display: Enhance iterators for modeset en/disable

2024-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2024 at 01:53:58PM +0530, Ankit Nautiyal wrote: > Joiners have specific enabling and disabling order dependent on primary > and secondary pipes. This becomes more complex with ultrajoiner where we > have ultrajoiner primary/secondary pipes in addition to bigjoiner > primary/secondar

✗ Fi.CI.SPARSE: warning for Introduce drm sharpness property

2024-09-17 Thread Patchwork
== Series Details == Series: Introduce drm sharpness property URL : https://patchwork.freedesktop.org/series/138754/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Introduce drm sharpness property

2024-09-17 Thread Patchwork
== Series Details == Series: Introduce drm sharpness property URL : https://patchwork.freedesktop.org/series/138754/ State : warning == Summary == Error: dim checkpatch failed adc86d1a29f8 drm: Introduce sharpness strength property 025abcd09462 drm/i915/display: Compute the scaler filter coeff

✓ Fi.CI.BAT: success for Modify iterators to prepare for ultrajoiner

2024-09-17 Thread Patchwork
== Series Details == Series: Modify iterators to prepare for ultrajoiner URL : https://patchwork.freedesktop.org/series/138751/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138751v1 Summary --- **

✗ Fi.CI.CHECKPATCH: warning for Modify iterators to prepare for ultrajoiner

2024-09-17 Thread Patchwork
== Series Details == Series: Modify iterators to prepare for ultrajoiner URL : https://patchwork.freedesktop.org/series/138751/ State : warning == Summary == Error: dim checkpatch failed 0725cfc71687 drm/i915: Add some essential functionality for joiners 488bdd3f086f drm/i915/display: Enhance

Re: [PATCH 1/2] drm/i915: Add some essential functionality for joiners

2024-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2024 at 01:53:57PM +0530, Ankit Nautiyal wrote: > From: Stanislav Lisovskiy > > In most of the cases we now try to avoid mentioning things like > "bigjoiner" or "ultrajoiner" trying to unify the API and refer > mostly to all this functionality as "joiner". > In majority cases that

Re: [PATCH 16/19] drm/i915: Add new abstraction layer to handle pipe order for different joiners

2024-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2024 at 02:52:10PM +0530, Nautiyal, Ankit K wrote: > > On 9/16/2024 8:36 PM, Ville Syrjälä wrote: > > On Mon, Sep 16, 2024 at 05:54:12PM +0300, Ville Syrjälä wrote: > >> On Mon, Sep 16, 2024 at 01:09:42PM +0530, Nautiyal, Ankit K wrote: > >>> On 9/12/2024 4:08 AM, Ville Syrjälä wro

✓ Fi.CI.BAT: success for Block DC6 on Vblank enable for Panel Replay (rev3)

2024-09-17 Thread Patchwork
== Series Details == Series: Block DC6 on Vblank enable for Panel Replay (rev3) URL : https://patchwork.freedesktop.org/series/138630/ State : success == Summary == CI Bug Log - changes from CI_DRM_15429 -> Patchwork_138630v3 Summary --

Re: [PATCH v3] Avoid memory barrier in read_seqcount() through load acquire

2024-09-17 Thread Thomas Gleixner
Cc+ i915 people On Tue, Sep 17 2024 at 08:37, Will Deacon wrote: > On Mon, Sep 16, 2024 at 10:52:18AM -0700, Christoph Lameter (Ampere) wrote: >> On Fri, 13 Sep 2024, kernel test robot wrote: >> >> > >> drivers/gpu/drm/i915/gt/intel_tlb.h:21:47: error: macro >> > >> "seqprop_sequence" requires 2

✗ Fi.CI.SPARSE: warning for Block DC6 on Vblank enable for Panel Replay (rev3)

2024-09-17 Thread Patchwork
== Series Details == Series: Block DC6 on Vblank enable for Panel Replay (rev3) URL : https://patchwork.freedesktop.org/series/138630/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

RE: [PATCHv2 2/5] drm/i915/display: histogram interrupt handling

2024-09-17 Thread Murthy, Arun R
> > diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c > > b/drivers/gpu/drm/i915/display/intel_histogram.c > > index 45e968e00af6..83ba826a7a89 100644 > > --- a/drivers/gpu/drm/i915/display/intel_histogram.c > > +++ b/drivers/gpu/drm/i915/display/intel_histogram.c > > @@ -19,12 +19,83 @@

Re: [PATCH 1/2] drm/i915/display: remove small micro-optimizations in irq handling

2024-09-17 Thread Jani Nikula
On Thu, 18 Apr 2024, Tvrtko Ursulin wrote: > On 18/04/2024 10:49, Jani Nikula wrote: >> On Wed, 17 Apr 2024, Lucas De Marchi wrote: >>> On Mon, Apr 08, 2024 at 03:54:44PM GMT, Jani Nikula wrote: The raw register reads/writes are there as micro-optimizations to avoid multiple pointer ind

[PATCH] drm/i915/gvt: use macros from drm_dp.h instead of duplication

2024-09-17 Thread Jani Nikula
Use the existing macros in drm_dp.h for DPCD and DP AUX instead of duplicating. Remove unused macros, as well as the duplicate definition of DPCD_SIZE. AUX_NATIVE_REPLY_NAK is left unchanged, as it does not match DP_AUX_NATIVE_REPLY_NACK, and I'm not sure what the right thing to do is here. Signe

[v2] drm/i915/selftests: Implement frequency check for energy reading validation

2024-09-17 Thread Sk Anirban
This commit introduces a frequency check mechanism aimed at ensuring the accuracy of energy readings. v2 : Improved commit message Signed-off-by: Anirban Sk --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.

[PATCH 5/5] drm/i915/display: Load the lut values and enable sharpness

2024-09-17 Thread Nemesa Garg
Load the lut values during pipe enable. v2: Add the display version check Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_crtc.c| 3 +++ drivers/gpu/drm/i915/display/intel_display.c | 6 ++ drivers/gpu/drm/i915/display/skl_scaler.c| 13 - 3 files chan

[PATCH v2 4/5] drm/i915/display: Add registers and compute the strength

2024-09-17 Thread Nemesa Garg
Add new registers and related bits. Compute the strength value and tap value based on display mode. v2: Replace i915/dev_priv with display[Jani] Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_display.c | 7 +- .../drm/i915/display/intel_sharpness_filter.c | 112 +++

[PATCH v3 3/5] drm/i915/display: Enable the second scaler for sharpness

2024-09-17 Thread Nemesa Garg
As only second scaler can be used for sharpness check if it is available and also check if panel fitting is also not enabled, then set the sharpness. Panel fitting will have the preference over sharpness property. v2: Add the panel fitting check before enabling sharpness v3: Reframe commit message

[PATCH v3 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-09-17 Thread Nemesa Garg
The sharpness property requires the use of one of the scaler so need to set the sharpness scaler coefficient values. These values are based on experiments and vary for different tap value/win size. These values are normalized by taking the sum of all values and then dividing each value with a sum.

[PATCH v2 1/5] drm: Introduce sharpness strength property

2024-09-17 Thread Nemesa Garg
Introduces the new crtc property "SHARPNESS_STRENGTH" that allows the user to set the intensity so as to get the sharpness effect. The value of this property can be set from 0-255. It is useful in scenario when the output is blurry and user want to sharpen the pixels. User can increase/decrease the

[PATCH 0/5] Introduce drm sharpness property

2024-09-17 Thread Nemesa Garg
Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural details. In

[PATCH] drm/i915/selftests: Implement Frequency Check for Energy Reading Validation

2024-09-17 Thread Sk Anirban
This commit introduces a frequency check mechanism aimed at ensuring the accuracy of energy readings. Signed-off-by: Sk Anirban --- drivers/gpu/drm/i915/gt/selftest_rc6.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers/gpu/drm/i915/gt/s

Re: [PATCH 16/19] drm/i915: Add new abstraction layer to handle pipe order for different joiners

2024-09-17 Thread Nautiyal, Ankit K
On 9/16/2024 8:36 PM, Ville Syrjälä wrote: On Mon, Sep 16, 2024 at 05:54:12PM +0300, Ville Syrjälä wrote: On Mon, Sep 16, 2024 at 01:09:42PM +0530, Nautiyal, Ankit K wrote: On 9/12/2024 4:08 AM, Ville Syrjälä wrote: On Wed, Sep 11, 2024 at 06:43:46PM +0530, Ankit Nautiyal wrote: From: Stani

✓ Fi.CI.BAT: success for Reduce SHPD_FILTER_CNT value

2024-09-17 Thread Patchwork
== Series Details == Series: Reduce SHPD_FILTER_CNT value URL : https://patchwork.freedesktop.org/series/138743/ State : success == Summary == CI Bug Log - changes from CI_DRM_15428 -> Patchwork_138743v1 Summary --- **SUCCESS** No

Re: [PATCH 2/2] drm/i915/display: move enum i9xx_plane_id to intel_display_limits.h

2024-09-17 Thread Jani Nikula
On Mon, 16 Sep 2024, Rodrigo Vivi wrote: > On Sat, Sep 14, 2024 at 12:32:13AM +0300, Jani Nikula wrote: >> On Fri, 13 Sep 2024, Rodrigo Vivi wrote: >> > On Fri, Sep 13, 2024 at 04:54:39PM +0300, Jani Nikula wrote: >> >> Move enum i9xx_plane_id from intel_display.h to intel_display_limits.h >> >>

[PATCH 1/2] drm/i915: Add some essential functionality for joiners

2024-09-17 Thread Ankit Nautiyal
From: Stanislav Lisovskiy In most of the cases we now try to avoid mentioning things like "bigjoiner" or "ultrajoiner" trying to unify the API and refer mostly to all this functionality as "joiner". In majority cases that should be way to go. However in some cases we still need to distinguish bet

  1   2   >