✗ Fi.CI.BUILD: failure for linux-next: build failure after merge of the drm-intel tree (rev5)

2024-08-28 Thread Patchwork
== Series Details == Series: linux-next: build failure after merge of the drm-intel tree (rev5) URL : https://patchwork.freedesktop.org/series/42839/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers MODPOST Modu

linux-next: build failure after merge of the drm-intel tree

2024-08-28 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/display/intel_dp_mst.c:2118:6: error: redefinition of 'intel_dp_mst_verify_dpcd_state' 2118 | bool intel_dp_mst_verify_dpcd_state(struct intel_dp *intel_dp) |

linux-next: manual merge of the drm-misc tree with the pmdomain tree

2024-08-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/tegra/gr3d.c between commit: 606cb5b75827 ("drm/tegra: gr3d: Convert into devm_pm_domain_attach_list()") from the pmdomain tree and commit: f790b5c09665 ("drm/tegra: gr3d: Convert into dev_pm_domai

linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2024-08-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got conflicts in: drivers/gpu/drm/i915/display/intel_dp_mst.c drivers/gpu/drm/i915/display/intel_dp_mst.h between commit: a2ccc33b88e2 ("drm/i915/dp_mst: Fix MST state after a sink reset") from the drm-intel-fixes tree and commit: e44bc

✓ Fi.CI.BAT: success for drm/i915/bios: Update new entries in VBT BDB block definitions (rev3)

2024-08-28 Thread Patchwork
== Series Details == Series: drm/i915/bios: Update new entries in VBT BDB block definitions (rev3) URL : https://patchwork.freedesktop.org/series/137312/ State : success == Summary == CI Bug Log - changes from CI_DRM_15317 -> Patchwork_137312v3 =

Re: [PATCH v2 9/9] drm/i915/bios: use display->is.PLATFORM instead of IS_PLATFORM()

2024-08-28 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 09:44:36PM +0300, Jani Nikula wrote: > Switch to using the new display->is.PLATFORM members. > > There are still cases like IS_G4X() which is trivial with macros, but > not so with platform members. Ditto for IS_IRONLAKE_M() and IS_IVB_GT1() > etc. although not used in this

Re: [PATCH v2 8/9] drm/i915/display: keep subplatforms next to their platforms

2024-08-28 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 09:44:35PM +0300, Jani Nikula wrote: > There's no reason to keep subplatforms separated in the members. Update > the comment while at it. > > Signed-off-by: Jani Nikula > --- > .../drm/i915/display/intel_display_device.h | 51 ++- > 1 file changed, 27 in

Re: [PATCH v2 7/9] drm/i915/display: consider HSW/BDW ULX to also be ULT

2024-08-28 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 09:44:34PM +0300, Jani Nikula wrote: > Follow i915 core and IS_HASWELL_ULT()/IS_BROADWELL_ULT() conventions, > i.e. "is ULT" also matches ULX platforms. > > Using multiple SUBPLATFORM() macros, we initialize both ULT and ULX > subplatforms, and take the subplatform name fro

Re: [PATCH v2 6/9] drm/i915/display: remove the display platform enum as unnecessary

2024-08-28 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 09:44:33PM +0300, Jani Nikula wrote: > The display platform enums are not really needed for > anything. Remove. > > Without the enum, PLATFORM_UNINITIALIZED is also no longer needed for > keeping the first enum 0. oh great! no need to rename that then! :) Reviewed-by: Ro

Re: [PATCH v3] drm/i915/display: add platforms "is" member to struct intel_display

2024-08-28 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 09:48:40PM +0300, Jani Nikula wrote: > Facilitate using display->is.HASWELL and display->is.HASWELL_ULT > etc. for identifying platforms and subplatforms. Merge platform and > subplatform members together. > > v3: > - Fix sanity check on display->is after merging subplatfor

Re: [PATCH v2 5/9] drm/i915/display: add platforms "is" member to struct intel_display

2024-08-28 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 09:44:32PM +0300, Jani Nikula wrote: 11;rgb://> Facilitate using display->is.HASWELL and display->is.HASWELL_ULT > etc. for identifying platforms and subplatforms. Merge platform and > subplatform members together. > > v2: > - Use bitmap ops > - Add some sanity

Re: [PATCH v2 4/9] drm/i915/display: add display platforms structure with platform members

2024-08-28 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 09:44:31PM +0300, Jani Nikula wrote: > Add a structure with a bitfield member for each platform and > subplatform, and initialize them in platform and subplatform descs. > > The structure also contains a bitmap in a union for easier manipulation > of the bits. > > Signed-o

Re: [PATCH v2 0/9] drm/i915/display: platform identification with display->is.

2024-08-28 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 09:44:27PM +0300, Jani Nikula wrote: > v2 of [1]. Please read the cover letter there. > > This addresses review comments and adds a few more commits on top, in > particular > the last one showcasing the approach. > > The main question remains, is this what we want? I don

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-28 Thread Rodrigo Vivi
On Tue, Aug 27, 2024 at 07:05:05PM +0200, Daniel Vetter wrote: > On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > > The i915 driver generates sysfs entries for each engine of the > > GPU in /sys/class/drm/cardX/engines/. > > > > The process is straightforward: we loop over the UABI en

[PULL] drm-xe-next

2024-08-28 Thread Lucas De Marchi
Hi Dave and Sima, Second drm-xe-next pull request for the 6.12 cycle. This includes the pull request from last week since it was not applied due to the ttm patch. That patch is now reverted and replacement on the back burner. The only UAPI change is actually a fix for building with gcc 5. Aside

Re: [PATCH v3 00/15] CCS static load balance

2024-08-28 Thread Andi Shyti
Hi Sima, On Wed, Aug 28, 2024 at 03:47:21PM +0200, Daniel Vetter wrote: > On Wed, Aug 28, 2024 at 10:20:15AM +0200, Andi Shyti wrote: > > Hi Sima, > > > > first of all, thanks for looking into this series. > > > > On Tue, Aug 27, 2024 at 07:31:21PM +0200, Daniel Vetter wrote: > > > On Fri, Aug 2

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Hamza Mahfooz
On 8/28/24 10:06, Jani Nikula wrote: On Wed, 28 Aug 2024, Hamza Mahfooz wrote: On 8/12/24 08:23, Jani Nikula wrote: Instead of just smashing jiffies into a GUID, use guid_gen() to generate RFC 4122 compliant GUIDs. Signed-off-by: Jani Nikula --- Acked-by: Hamza Mahfooz I would prefer to

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Jani Nikula
On Wed, 28 Aug 2024, Jani Nikula wrote: > On Wed, 28 Aug 2024, Hamza Mahfooz wrote: >> On 8/12/24 08:23, Jani Nikula wrote: >>> Instead of just smashing jiffies into a GUID, use guid_gen() to generate >>> RFC 4122 compliant GUIDs. >>> >>> Signed-off-by: Jani Nikula >>> >>> --- >> >> Acked-by:

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Harry Wentland
On 2024-08-28 09:58, Alex Deucher wrote: > On Wed, Aug 28, 2024 at 9:53 AM Jani Nikula wrote: >> >> On Wed, 28 Aug 2024, Daniel Vetter wrote: >>> On Mon, Aug 12, 2024 at 03:23:12PM +0300, Jani Nikula wrote: Instead of just smashing jiffies into a GUID, use guid_gen() to generate RFC

✓ Fi.CI.BAT: success for drm/i915: nomodeset and i915.modeset cleanups (rev2)

2024-08-28 Thread Patchwork
== Series Details == Series: drm/i915: nomodeset and i915.modeset cleanups (rev2) URL : https://patchwork.freedesktop.org/series/137909/ State : success == Summary == CI Bug Log - changes from CI_DRM_15308 -> Patchwork_137909v2 Summary

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Jani Nikula
On Wed, 28 Aug 2024, Hamza Mahfooz wrote: > On 8/12/24 08:23, Jani Nikula wrote: >> Instead of just smashing jiffies into a GUID, use guid_gen() to generate >> RFC 4122 compliant GUIDs. >> >> Signed-off-by: Jani Nikula >> >> --- > > Acked-by: Hamza Mahfooz > > I would prefer to take this serie

Re: [PATCH v1] drm/i915/hwmon: expose package temperature

2024-08-28 Thread Andy Shevchenko
On Wed, Aug 28, 2024 at 10:15:12AM +0530, Raag Jadav wrote: > Add hwmon support for temp1_input attribute, which will expose package > temperature in millidegree Celsius. With this in place we can monitor > package temperature using lm-sensors tool. > > $ sensors > i915-pci-0300 > Adapter: PCI ada

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Alex Deucher
On Wed, Aug 28, 2024 at 9:53 AM Jani Nikula wrote: > > On Wed, 28 Aug 2024, Daniel Vetter wrote: > > On Mon, Aug 12, 2024 at 03:23:12PM +0300, Jani Nikula wrote: > >> Instead of just smashing jiffies into a GUID, use guid_gen() to generate > >> RFC 4122 compliant GUIDs. > >> > >> Signed-off-by: J

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Hamza Mahfooz
On 8/12/24 08:23, Jani Nikula wrote: Instead of just smashing jiffies into a GUID, use guid_gen() to generate RFC 4122 compliant GUIDs. Signed-off-by: Jani Nikula --- Acked-by: Hamza Mahfooz I would prefer to take this series through the amdgpu tree though, assuming nobody minds. Side n

Re: [PATCH v3 00/15] CCS static load balance

2024-08-28 Thread Daniel Vetter
On Wed, Aug 28, 2024 at 10:20:15AM +0200, Andi Shyti wrote: > Hi Sima, > > first of all, thanks for looking into this series. > > On Tue, Aug 27, 2024 at 07:31:21PM +0200, Daniel Vetter wrote: > > On Fri, Aug 23, 2024 at 03:08:40PM +0200, Andi Shyti wrote: > > > Hi, > > > > > > This patch series

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Jani Nikula
On Wed, 28 Aug 2024, Daniel Vetter wrote: > On Mon, Aug 12, 2024 at 03:23:12PM +0300, Jani Nikula wrote: >> Instead of just smashing jiffies into a GUID, use guid_gen() to generate >> RFC 4122 compliant GUIDs. >> >> Signed-off-by: Jani Nikula >> >> --- >> >> Side note, it baffles me why amdgpu

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Daniel Vetter
On Mon, Aug 12, 2024 at 03:23:12PM +0300, Jani Nikula wrote: > Instead of just smashing jiffies into a GUID, use guid_gen() to generate > RFC 4122 compliant GUIDs. > > Signed-off-by: Jani Nikula > > --- > > Side note, it baffles me why amdgpu has a copy of this instead of > plumbing it into drm

Re: [RESEND 2/3] drm/mst: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Daniel Vetter
On Mon, Aug 12, 2024 at 03:23:11PM +0300, Jani Nikula wrote: > Instead of just smashing jiffies into a GUID, use guid_gen() to generate > RFC 4122 compliant GUIDs. > > Signed-off-by: Jani Nikula Read a bit the RFC, definitely sounds better than stuffing jiffies into the guid ... Reviewed-by: Da

Re: [PATCH] drm/i915/dmc: Hardcode path to MTL DMC v2.23

2024-08-28 Thread Gustavo Sousa
Quoting Jani Nikula (2024-08-28 05:42:01-03:00) >On Tue, 27 Aug 2024, Dnyaneshwar Bhadane wrote: >> NOT TO BE REVIEWED/MERGED >> Hardcode path to DMC firmware for CI purposes only. > >This is why we have trybot, no? This patch is not an "experimentation" type of thing, it is part of our regular p

Re: [RESEND 1/3] drm/mst: switch to guid_t type for GUID

2024-08-28 Thread Daniel Vetter
On Mon, Aug 12, 2024 at 03:23:10PM +0300, Jani Nikula wrote: > The kernel has a guid_t type for GUIDs. Switch to using it, but avoid > any functional changes here. > > Signed-off-by: Jani Nikula I didn't cross-check everything, I'll trust the compiler on this. But functionally lgtm Reviewed-by:

Re: [PATCH 0/2] drm/i915: nomodeset and i915.modeset cleanups

2024-08-28 Thread Daniel Vetter
On Wed, Aug 28, 2024 at 02:19:07PM +0300, Jani Nikula wrote: > Is it time? It is. Concurred. On the series: Reviewed-by: Daniel Vetter Cheers, Sima > > Jani Nikula (2): > drm/i915: fail module probe on nomodeset and i915.modeset=0 > drm/i915: deprecate the i915.modeset module parameter >

✓ Fi.CI.BAT: success for drm/i915/dsb: Use chained DSBs for LUT programming (rev3)

2024-08-28 Thread Patchwork
== Series Details == Series: drm/i915/dsb: Use chained DSBs for LUT programming (rev3) URL : https://patchwork.freedesktop.org/series/135316/ State : success == Summary == CI Bug Log - changes from CI_DRM_15307 -> Patchwork_135316v3 Summary

✗ Fi.CI.SPARSE: warning for drm/i915/dsb: Use chained DSBs for LUT programming (rev3)

2024-08-28 Thread Patchwork
== Series Details == Series: drm/i915/dsb: Use chained DSBs for LUT programming (rev3) URL : https://patchwork.freedesktop.org/series/135316/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/inclu

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsb: Use chained DSBs for LUT programming (rev3)

2024-08-28 Thread Patchwork
== Series Details == Series: drm/i915/dsb: Use chained DSBs for LUT programming (rev3) URL : https://patchwork.freedesktop.org/series/135316/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/135316/revisions/3/mbox/ not applied Applying: drm/i915: C

✗ Fi.CI.BUILD: warning for drm/i915/dsb: Use chained DSBs for LUT programming (rev3)

2024-08-28 Thread Patchwork
== Series Details == Series: drm/i915/dsb: Use chained DSBs for LUT programming (rev3) URL : https://patchwork.freedesktop.org/series/135316/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/135316/revisions/3/mbox/ not applied Applying: drm/i915: C

✗ Fi.CI.BAT: failure for drm/i915: nomodeset and i915.modeset cleanups

2024-08-28 Thread Patchwork
== Series Details == Series: drm/i915: nomodeset and i915.modeset cleanups URL : https://patchwork.freedesktop.org/series/137909/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15307 -> Patchwork_137909v1 Summary ---

Re: [PATCHv2] drm/i915/display: BMG supports UHBR13.5

2024-08-28 Thread Jani Nikula
On Wed, 28 Aug 2024, "Govindapillai, Vinod" wrote: > Hi, > > Do we need this? There is this patch already > https://patchwork.freedesktop.org/patch/592161/ mtl_rates doesn't have 135. BR, Jani. > > Looks like we are supposed to iterate source_rates using > "intel_dp->num_source_rates" >

[PATCH 2/2] drm/i915: deprecate the i915.modeset module parameter

2024-08-28 Thread Jani Nikula
The i915.modeset parameter doesn't really provide any useful benefit over the nomodeset kernel parameter. Anything that i915.modeset does can be achieved via nomodeset or not probing i915 at all. Unfortunately, the i915.modeset parameter is widely referenced on various forums, and removing it is n

[PATCH 1/2] drm/i915: fail module probe on nomodeset and i915.modeset=0

2024-08-28 Thread Jani Nikula
Since commit b30324adaf8d ("drm/i915: Deprecated UMS support") we've silently failed the probe, without propagating errors, on nomodeset and i915.modeset=0. This has been to not upset userspace. See the above commit for details. Since then, we've removed both the UMS and KMS kconfig options in com

[PATCH 0/2] drm/i915: nomodeset and i915.modeset cleanups

2024-08-28 Thread Jani Nikula
Is it time? It is. Jani Nikula (2): drm/i915: fail module probe on nomodeset and i915.modeset=0 drm/i915: deprecate the i915.modeset module parameter drivers/gpu/drm/i915/i915_module.c | 9 +++-- drivers/gpu/drm/i915/i915_params.c | 3 +-- 2 files changed, 8 insertions(+), 4 deletions(-)

✓ Fi.CI.BAT: success for drm/i915/mtl: Update PLL c20 phy value for DP uhbr20 (rev2)

2024-08-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update PLL c20 phy value for DP uhbr20 (rev2) URL : https://patchwork.freedesktop.org/series/137844/ State : success == Summary == CI Bug Log - changes from CI_DRM_15307 -> Patchwork_137844v2 Summa

Re: [PATCHv2] drm/i915/display: BMG supports UHBR13.5

2024-08-28 Thread Govindapillai, Vinod
Hi, Do we need this? There is this patch already https://patchwork.freedesktop.org/patch/592161/ Looks like we are supposed to iterate source_rates using "intel_dp->num_source_rates" If you are keeping this, then may be we need a separate max_rate call for bmg for better clarity? Now there is

Re: [PATCH] drm/i915/dmc: Hardcode path to MTL DMC v2.23

2024-08-28 Thread Jani Nikula
On Tue, 27 Aug 2024, Dnyaneshwar Bhadane wrote: > NOT TO BE REVIEWED/MERGED > Hardcode path to DMC firmware for CI purposes only. This is why we have trybot, no? BR, Jani. > > Signed-off-by: Dnyaneshwar Bhadane > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- > 1 file changed, 1 inser

Re: [PATCH v3 00/15] CCS static load balance

2024-08-28 Thread Andi Shyti
Hi Sima, first of all, thanks for looking into this series. On Tue, Aug 27, 2024 at 07:31:21PM +0200, Daniel Vetter wrote: > On Fri, Aug 23, 2024 at 03:08:40PM +0200, Andi Shyti wrote: > > Hi, > > > > This patch series introduces static load balancing for GPUs with > > multiple compute engines.