✗ Fi.CI.BAT: failure for CCS static load balance (rev2)

2024-08-17 Thread Patchwork
== Series Details == Series: CCS static load balance (rev2) URL : https://patchwork.freedesktop.org/series/136381/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15252 -> Patchwork_136381v2 Summary --- **FAILURE**

✗ Fi.CI.SPARSE: warning for CCS static load balance (rev2)

2024-08-17 Thread Patchwork
== Series Details == Series: CCS static load balance (rev2) URL : https://patchwork.freedesktop.org/series/136381/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for CCS static load balance (rev2)

2024-08-17 Thread Patchwork
== Series Details == Series: CCS static load balance (rev2) URL : https://patchwork.freedesktop.org/series/136381/ State : warning == Summary == Error: dim checkpatch failed 84e876cb3a32 drm/i915/gt: Move the CCS mode variable to a global position -:113: CHECK:UNCOMMENTED_DEFINITION: struct mu

Re: [PATCH 22/86] drm/ingenic: Run DRM default client setup

2024-08-17 Thread Paul Cercueil
Hi Thomas, Le vendredi 16 août 2024 à 14:22 +0200, Thomas Zimmermann a écrit : > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The ingenic driver specifies a prefe

[RFC PATCH v2 11/11] drm/i915/gt: Allow the user to change the CCS mode through sysfs

2024-08-17 Thread Andi Shyti
Create the 'ccs_mode' file under /sys/class/drm/cardX/gt/gt0/ccs_mode This file allows the user to read and set the current CCS mode. - Reading: The user can read the current CCS mode, which can be 1, 2, or 4. This value is derived from the current engine mask. - Writing: The user can s

[RFC PATCH v2 10/11] drm/i915/gt: Implement creation and removal routines for CCS engines

2024-08-17 Thread Andi Shyti
In preparation for upcoming patches, we need routines to dynamically create and destroy CCS engines based on the CCS mode that the user wants to set. The process begins by calculating the engine mask for the engines that need to be added or removed. We then update the UABI list of exposed engines

[RFC PATCH v2 09/11] drm/i915/gt: Isolate single sysfs engine file creation

2024-08-17 Thread Andi Shyti
In preparation for upcoming patches, we need the ability to create and remove individual sysfs files. To facilitate this, extract from the intel_engines_add_sysfs() function the creation of individual files. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/sysfs_engines.c | 75 +

[RFC PATCH v2 08/11] drm/i915/gt: Store active CCS mask

2024-08-17 Thread Andi Shyti
To support upcoming patches, we need to store the current mask for active CCS engines. Active engines refer to those exposed to userspace via the UABI engine list. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c | 20 drivers/gpu/drm/i915/gt/intel_

[RFC PATCH v2 07/11] drm/i915/gt: Store engine-related sysfs kobjects

2024-08-17 Thread Andi Shyti
Upcoming commits will need to access engine-related kobjects to enable the creation and destruction of sysfs interfaces at runtime. For this, store the "engine" directory (i915->sysfs_engine), the engine files (gt->kobj), and the default data (gt->kobj_defaults). Signed-off-by: Andi Shyti --- d

[RFC PATCH v2 06/11] drm/i915/gt: Expose the number of total CCS slices

2024-08-17 Thread Andi Shyti
Implement a sysfs interface to show the number of available CCS slices. The displayed number does not take into account the CCS balancing mode. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c | 24 + drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.h | 1 +

[RFC PATCH v2 05/11] drm/i915/gt: Remove cslices mask value from the CCS structure

2024-08-17 Thread Andi Shyti
Following the decision to manage CCS engine creation within UABI engines, the "cslices" variable in the "ccs" structure in the "gt" is no longer needed. Remove it is now redundant. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt_

[RFC PATCH v2 04/11] drm/i915/gt: Manage CCS engine creation within UABI exposure

2024-08-17 Thread Andi Shyti
In commit ea315f98e5d6 ("drm/i915/gt: Do not generate the command streamer for all the CCS"), we restricted the creation of physical CCS engines to only one stream. This allowed the user to submit a single compute workload, with all CCS slices sharing the workload from that stream. This patch remo

[RFC PATCH v2 03/11] drm/i915/gt: Refactor uabi engine class/instance list creation

2024-08-17 Thread Andi Shyti
For the upcoming changes we need a cleaner way to build the list of uabi engines. Suggested-by: Tvrtko Ursulin Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_engine_user.c | 29 - 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i9

[RFC PATCH v2 02/11] drm/i915/gt: Allow the creation of multi-mode CCS masks

2024-08-17 Thread Andi Shyti
Until now, we have only set CCS mode balancing to 1, which means that only one compute engine is exposed to the user. The stream of compute commands submitted to that engine is then shared among all the dedicated execution units. This is done by calling the 'intel_gt_apply_ccs_mode(); function. W

[RFC PATCH v2 01/11] drm/i915/gt: Move the CCS mode variable to a global position

2024-08-17 Thread Andi Shyti
Store the CCS mode value in the intel_gt->ccs structure to make it available for future instances that may need to change its value. Name it mode_reg_val because it holds the value that will be written into the CCS_MODE register, determining the CCS balancing and, consequently, the number of engin

[RFC PATCH v2 00/11] CCS static load balance

2024-08-17 Thread Andi Shyti
Hi, This patch series introduces static load balancing for GPUs with multiple compute engines. It's a lengthy series, and some challenging aspects still need to be resolved. I have tried to split the work as much as possible to facilitate the review process. To summarize, in patches 1 to 10, no

Re: [PATCH 83/86] drm/{i915,xe}: Run DRM default client setup

2024-08-17 Thread kernel test robot
: 70d6d55dea574b7b78ccf714699cc5d8d62fcc2c patch link: https://lore.kernel.org/r/20240816125408.310253-84-tzimmermann%40suse.de patch subject: [PATCH 83/86] drm/{i915,xe}: Run DRM default client setup config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20240817/202408171913

Re: [PATCH 69/86] drm/nouveau: Run DRM default client setup

2024-08-17 Thread Danilo Krummrich
On 8/16/24 2:23 PM, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The nouveau driver specifies a preferred color mode depending on the available

Re: [PATCH v2 2/2] drm: use mem_is_zero() instead of !memchr_inv(s, 0, n)

2024-08-17 Thread Kees Cook
On Wed, Aug 14, 2024 at 01:00:35PM +0300, Jani Nikula wrote: > Use the mem_is_zero() helper where possible. > > Conversion done using cocci: > > | @@ > | expression PTR; > | expression SIZE; > | @@ > | > | <... > | ( > | - memchr_inv(PTR, 0, SIZE) == NULL > | + mem_is_zero(PTR, SIZE) > | | > |

Re: [PATCH v2 1/2] string: add mem_is_zero() helper to check if memory area is all zeros

2024-08-17 Thread Kees Cook
On Wed, Aug 14, 2024 at 01:00:34PM +0300, Jani Nikula wrote: > Almost two thirds of the memchr_inv() usages check if the memory area is > all zeros, with no interest in where in the buffer the first non-zero > byte is located. Checking for !memchr_inv(s, 0, n) is also not very > intuitive or discov

Re: [PATCH 55/86] drm/hyperv_drm: Run DRM default client setup

2024-08-17 Thread Deepak Rawat
Reviewed-by: Deepak Rawat On Fri, Aug 16, 2024 at 5:54 AM Thomas Zimmermann wrote: > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmerm

Re: [PATCH 83/86] drm/{i915,xe}: Run DRM default client setup

2024-08-17 Thread kernel test robot
: 70d6d55dea574b7b78ccf714699cc5d8d62fcc2c patch link: https://lore.kernel.org/r/20240816125408.310253-84-tzimmermann%40suse.de patch subject: [PATCH 83/86] drm/{i915,xe}: Run DRM default client setup config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20240817/202408171746

Re: [PATCH] drm/i915/gt: remove stray declaration of intel_gt_release_all()

2024-08-17 Thread Andi Shyti
Hi Luca, On Tue, Aug 13, 2024 at 05:06:18PM +0300, Luca Coelho wrote: > When intel_gt_release_all() was removed from the code in commit > e89950553385 ("drm/i915: do not clean GT table on error path"), its > declaration in the header file remained. Remove it. > > Signed-off-by: Luca Coelho mer

Re: [PATCH] drm/i915/gt: remove stray declaration of intel_gt_release_all()

2024-08-17 Thread Andi Shyti
Hi Luca, On Tue, Aug 13, 2024 at 05:06:18PM +0300, Luca Coelho wrote: > When intel_gt_release_all() was removed from the code in commit > e89950553385 ("drm/i915: do not clean GT table on error path"), its > declaration in the header file remained. Remove it. > > Signed-off-by: Luca Coelho Rev