RE: [PATCH] drm/i915/guc: Change GEM_WARN_ON to guc_err to prevent taints in CI

2024-08-09 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Jesus Narvaez Sent: Thursday, August 8, 2024 1:50 PM To: intel-gfx@lists.freedesktop.org Cc: Narvaez, Jesus Subject: [PATCH] drm/i915/guc: Change GEM_WARN_ON to guc_err to prevent taints in CI > > This warning was supposed to catch a harm

Re: [PATCH v2 00/10] drm/xe & drm/i915: drvdata usage changes

2024-08-09 Thread Lucas De Marchi
On Fri, Aug 09, 2024 at 10:58:24AM GMT, Lucas De Marchi wrote: On Fri, Aug 09, 2024 at 04:23:47PM GMT, Jani Nikula wrote: On Fri, 09 Aug 2024, Jani Nikula wrote: On Thu, 08 Aug 2024, Lucas De Marchi wrote: On Thu, Aug 08, 2024 at 06:15:45PM GMT, Jani Nikula wrote: v2 of https://patchwork.fr

Re: [PATCH v2 00/10] drm/xe & drm/i915: drvdata usage changes

2024-08-09 Thread Lucas De Marchi
On Fri, Aug 09, 2024 at 04:23:47PM GMT, Jani Nikula wrote: On Fri, 09 Aug 2024, Jani Nikula wrote: On Thu, 08 Aug 2024, Lucas De Marchi wrote: On Thu, Aug 08, 2024 at 06:15:45PM GMT, Jani Nikula wrote: v2 of https://patchwork.freedesktop.org/series/136621/ Removed "drm/xe/tests: fix drvdata

✓ Fi.CI.BAT: success for video/aperture: match the pci device when calling sysfb_disable()

2024-08-09 Thread Patchwork
== Series Details == Series: video/aperture: match the pci device when calling sysfb_disable() URL : https://patchwork.freedesktop.org/series/137088/ State : success == Summary == CI Bug Log - changes from CI_DRM_15204 -> Patchwork_137088v1

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-09 Thread Jann Horn
On Fri, Aug 9, 2024 at 4:48 PM Jann Horn wrote: > On Tue, Aug 6, 2024 at 2:08 PM Joonas Lahtinen > wrote: > > Quoting Andi Shyti (2024-08-06 12:46:07) > > > Hi Greg, > > > > > > same question without the stable mailing list not to trigger the > > > automatic reply. > > > > > > > Andi Shyti (2): >

✗ Fi.CI.CHECKPATCH: warning for video/aperture: match the pci device when calling sysfb_disable()

2024-08-09 Thread Patchwork
== Series Details == Series: video/aperture: match the pci device when calling sysfb_disable() URL : https://patchwork.freedesktop.org/series/137088/ State : warning == Summary == Error: dim checkpatch failed 8ad209af2ad1 video/aperture: match the pci device when calling sysfb_disable() -:12:

[PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-09 Thread Alex Deucher
In aperture_remove_conflicting_pci_devices(), match the pci device determine whether or not to call sysfb_disable(). This fixes cases where the pimary device is not VGA compatible which leads to the following problem: 1. A PCI device with a non-VGA class is the the boot display 2. That device is

✓ Fi.CI.BAT: success for drm/i915: struct intel_display conversions (rev2)

2024-08-09 Thread Patchwork
== Series Details == Series: drm/i915: struct intel_display conversions (rev2) URL : https://patchwork.freedesktop.org/series/136758/ State : success == Summary == CI Bug Log - changes from CI_DRM_15204 -> Patchwork_136758v2 Summary ---

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

✗ Fi.CI.SPARSE: warning for drm/i915: struct intel_display conversions (rev2)

2024-08-09 Thread Patchwork
== Series Details == Series: drm/i915: struct intel_display conversions (rev2) URL : https://patchwork.freedesktop.org/series/136758/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-09 Thread Jann Horn
On Tue, Aug 6, 2024 at 2:08 PM Joonas Lahtinen wrote: > Quoting Andi Shyti (2024-08-06 12:46:07) > > Hi Greg, > > > > same question without the stable mailing list not to trigger the > > automatic reply. > > > > > Andi Shyti (2): > > > drm/i915/gem: Adjust vma offset for framebuffer mmap offset

[PATCH v2 4/4] drm/i915/bios: convert to struct intel_display

2024-08-09 Thread Jani Nikula
Going forward, struct intel_display shall replace struct drm_i915_private as the main display device data pointer type. Convert intel_bios.[ch] to struct intel_display. Do one drive-by conversion of unnecessary hex usage to decimal. Reviewed-by: Imre Deak Signed-off-by: Jani Nikula --- drivers

[PATCH v2 1/4] drm/i915/acpi: convert to struct intel_display

2024-08-09 Thread Jani Nikula
Going forward, struct intel_display shall replace struct drm_i915_private as the main display device data pointer type. Convert intel_acpi.[ch] to struct intel_display. Reviewed-by: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_acpi.c | 17 - d

[PATCH v2 3/4] drm/i915/opregion: convert to struct intel_display

2024-08-09 Thread Jani Nikula
Going forward, struct intel_display shall replace struct drm_i915_private as the main display device data pointer type. Convert intel_opregion.[ch] to struct intel_display. v2: - Fix declarations for !CONFIG_ACPI (Imre, kernel test robot) - Pass encoder/connector directly to intel_display() (Imre)

[PATCH v2 2/4] drm/i915/opregion: unify intel_encoder/intel_connector naming

2024-08-09 Thread Jani Nikula
Prefer the short encoder/connector names for struct intel_encoder/intel_connector variables and parameters. Reviewed-by: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_opregion.c | 23 +-- drivers/gpu/drm/i915/display/intel_opregion.h | 4 ++-- 2 fi

[PATCH v2 0/4] drm/i915: struct intel_display conversions

2024-08-09 Thread Jani Nikula
v2 of https://lore.kernel.org/r/cover.1722444150.git.jani.nik...@intel.com Cc: Imre Deak Jani Nikula (4): drm/i915/acpi: convert to struct intel_display drm/i915/opregion: unify intel_encoder/intel_connector naming drm/i915/opregion: convert to struct intel_display drm/i915/bios: convert

Re: [PATCH v2 00/10] drm/xe & drm/i915: drvdata usage changes

2024-08-09 Thread Jani Nikula
On Fri, 09 Aug 2024, Jani Nikula wrote: > On Thu, 08 Aug 2024, Lucas De Marchi wrote: >> On Thu, Aug 08, 2024 at 06:15:45PM GMT, Jani Nikula wrote: >>>v2 of https://patchwork.freedesktop.org/series/136621/ >>> >>>Removed "drm/xe/tests: fix drvdata usage" from v1 in favour of >>>"drm/xe/tests: rem

Re: [PATCH v2 09/10] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging

2024-08-09 Thread Gustavo Sousa
Quoting Jani Nikula (2024-08-08 12:15:54-03:00) >Use to_intel_display() instead of kdev_to_i915() in the HDCP component >API hooks. Avoid further drive-by changes at this point, and just >convert the display pointer to i915, and leave the struct intel_display >conversion for later. > >The NULL erro

Re: [PATCH v2 06/10] drm/i915: support struct device and pci_dev in to_intel_display()

2024-08-09 Thread Gustavo Sousa
Quoting Jani Nikula (2024-08-08 12:15:51-03:00) >Now that both xe and i915 store struct drm_device in drvdata, we can >trivially support struct device and struct pci_dev in >to_intel_display(). > >We do need to check for NULL drvdata before converting it into struct >intel_device pointer, though. D

Re: [PATCH v2 04/10] drm/i915: use pdev_to_i915() instead of pci_get_drvdata() directly

2024-08-09 Thread Gustavo Sousa
Quoting Jani Nikula (2024-08-08 12:15:49-03:00) >We have a helper for converting pci device to i915 device, use it. > >v2: Also convert i915_pci_probe() (Gustavo) > >Cc: Gustavo Sousa >Signed-off-by: Jani Nikula Reviewed-by: Gustavo Sousa >--- > drivers/gpu/drm/i915/i915_pci.c | 6 +++--- > 1 f

Re: [PATCH v2 01/10] drm/xe/tests: remove unused leftover xe_call_for_each_device()

2024-08-09 Thread Gustavo Sousa
Quoting Jani Nikula (2024-08-08 12:15:46-03:00) >xe_call_for_each_device() has been unused since commit 57ecead343e7 >("drm/xe/tests: Convert xe_mocs live tests"). Remove it and the related >dev_to_xe_device_fn() and struct kunit_test_data. > >Cc: Gustavo Sousa >Cc: Lucas De Marchi >Signed-off-by

✓ Fi.CI.BAT: success for drm/i915/hdcp: Use correct cp_irq_count (rev2)

2024-08-09 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Use correct cp_irq_count (rev2) URL : https://patchwork.freedesktop.org/series/137072/ State : success == Summary == CI Bug Log - changes from CI_DRM_15204 -> Patchwork_137072v2 Summary ---

Re: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-09 Thread Andi Shyti
Hi, On Wed, Aug 07, 2024 at 10:10:14AM +0100, Andi Shyti wrote: > From: Chris Wilson > > After we detect that mmio is returning all 0xff, we believe that the GPU > has dropped off the pci bus and is dead. Mark the device as wedged such > that we can propagate the failure back to userspace and wa

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andi Shyti
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andy Shevchenko
On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > Add hwmon support for fan1_input attribute, which will expose fan speed > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > $ sensors > i915-pci-0300 > Adapter: PCI adapter > in0: 653.00 mV > fan1:

[PATCH] drm/i915/hdcp: Use correct cp_irq_count

2024-08-09 Thread Suraj Kandpal
We are checking cp_irq_count from the wrong hdcp structure which ends up giving timed out errors. We only increment the cp_irq_count of the primary connector's hdcp structure but here in case of multidisplay setup we end up checking the secondary connector's hdcp structure, which will not have its

RE: [PATCH] drm/i915/hdcp: Use correct cp_irq_count

2024-08-09 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Friday, August 9, 2024 1:51 PM > To: Kandpal, Suraj ; intel- > g...@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Kandpal, Suraj > > Subject: Re: [PATCH] drm/i915/hdcp: Use correct cp_irq_count > > On Fri, 09 Aug 2024, Suraj Kandpal

Re: ✗ Fi.CI.IGT: failure for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev5)

2024-08-09 Thread Andi Shyti
Hi, > Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev5) > URL: https://patchwork.freedesktop.org/series/136975/ > State: failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136975v5/index.html ... > Possible new issues > > Here are the unknown c

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Krzysztof Kozlowski
On 09/08/2024 10:35, Joonas Lahtinen wrote: > Quoting Krzysztof Kozlowski (2024-08-08 21:44:39) >> On 08/08/2024 20:35, Krzysztof Kozlowski wrote: >>> On 08/08/2024 10:45, Tvrtko Ursulin wrote: Hi Dave, Sima, A small bunch of fixes for the weekly cycle: >>> >>> ... >>>

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-09 Thread Andi Shyti
Hi Sima, On Fri, Aug 09, 2024 at 10:53:38AM +0200, Daniel Vetter wrote: > On Wed, Aug 07, 2024 at 11:05:19AM +0100, Andi Shyti wrote: > > This patch series concludes on the memory mapping fixes and > > improvements by allowing partial memory mapping for the cpu > > memory as well. > > > > The par

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andi Shyti
Hi Badal, > > +static int > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > +{ > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + struct hwm_fan_info *fi = &ddat->fi; > > + u32 reg_val, pulses, time, time_now; > > + intel_wakeref_t wakeref; > > + long rotations; > > +

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 03:03:20PM +0530, Nilawar, Badal wrote: > > > On 09-08-2024 11:45, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensors > > i915-pci-0

Re: [PATCH] drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL

2024-08-09 Thread Andi Shyti
Hi Johna, On Thu, Aug 08, 2024 at 05:06:46PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > The previous update to enable the workaround on ARL only changed two > out of three places where the w/a needs to be enabled. That meant the > GuC side was operational but not the KMD s

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Nilawar, Badal
On 09-08-2024 11:45, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

Re: [PATCH] drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL

2024-08-09 Thread Nirmoy Das
On 8/9/2024 2:06 AM, john.c.harri...@intel.com wrote: From: John Harrison The previous update to enable the workaround on ARL only changed two out of three places where the w/a needs to be enabled. That meant the GuC side was operational but not the KMD side. And as the KMD side is the trigger,

Re: [PATCH v2 00/10] drm/xe & drm/i915: drvdata usage changes

2024-08-09 Thread Jani Nikula
On Thu, 08 Aug 2024, Lucas De Marchi wrote: > On Thu, Aug 08, 2024 at 06:15:45PM GMT, Jani Nikula wrote: >>v2 of https://patchwork.freedesktop.org/series/136621/ >> >>Removed "drm/xe/tests: fix drvdata usage" from v1 in favour of >>"drm/xe/tests: remove unused leftover xe_call_for_each_device()" h

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-09 Thread Daniel Vetter
On Wed, Aug 07, 2024 at 11:05:19AM +0100, Andi Shyti wrote: > Hi, > > This patch series concludes on the memory mapping fixes and > improvements by allowing partial memory mapping for the cpu > memory as well. > > The partial memory mapping by adding an object offset was > implicitely included in

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Joonas Lahtinen
Quoting Krzysztof Kozlowski (2024-08-08 21:44:39) > On 08/08/2024 20:35, Krzysztof Kozlowski wrote: > > On 08/08/2024 10:45, Tvrtko Ursulin wrote: > >> > >> Hi Dave, Sima, > >> > >> A small bunch of fixes for the weekly cycle: > > > > ... > > > >> > >>

Re: [PATCH] drm/i915/hdcp: Use correct cp_irq_count

2024-08-09 Thread Jani Nikula
On Fri, 09 Aug 2024, Suraj Kandpal wrote: > We are checking cp_irq_count from the wrong hdcp structure which > ends up giving timed out errors. Extract it from the correct > intel_hdcp structure. The change in the referenced commit seems natural. Please explain *why* it's the wrong hdcp structure

Re: [PATCHv2] drm/xe/display: Change HPD to polling on runtime suspend

2024-08-09 Thread Jani Nikula
On Thu, 08 Aug 2024, Arun R Murthy wrote: > HPD is interrupt based and on runtime suspend change it to polling as > HPD is not a wakeup event. A worker thread is scheduled for doing this > polling and it keeps polling for HPD live status on an internval of 10s. > On runtime resume disable polling

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Krzysztof Kozlowski
On 09/08/2024 09:13, Dave Airlie wrote: > Hi Krzysztof, > > You might want to familiarise yourself with the drm tree development > procedures before weighing in, > and snarky comments like the final one are not appreciated on this > list or in this community. > > The drm next trees are never reba

✗ Fi.CI.IGT: failure for drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL

2024-08-09 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL URL : https://patchwork.freedesktop.org/series/137067/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15202_full -> Patchwork_137067v1_full ===

✗ Fi.CI.IGT: failure for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev5)

2024-08-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev5) URL : https://patchwork.freedesktop.org/series/136975/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15202_full -> Patchwork_136975v5_full =

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Dave Airlie
Hi Krzysztof, You might want to familiarise yourself with the drm tree development procedures before weighing in, and snarky comments like the final one are not appreciated on this list or in this community. The drm next trees are never rebased (only in super rare emergencies), we never rebase ne

[PULL] drm-misc-next

2024-08-09 Thread Thomas Zimmermann
Hi Dave, Sima, here's a fairly small PR for drm-misc-next for this this week. The controversial Power Saving Policy has been removed. Mgag200 finally has good support for the BMC output. CI added some more drivers. Best regards Thomas drm-misc-next-2024-08-09: drm-misc-next for v6.12: UAPI Chan