[core-for-CI PATCH] usb: typec: ucsi: Fix a potential deadlock in ucsi_send_command_common()

2024-08-06 Thread Chaitanya Kumar Borah
From: Heikki Krogerus The function returns with the ppm_lock held if there's an error or the PPM reports BUSY condition. This is a core-for-ci patch for [1] [1] https://lore.kernel.org/linux-usb/20240806112029.2984319-1-heikki.kroge...@linux.intel.com/ Reported-by: Luciano Coelho Fixes: 5e9c

✗ Fi.CI.IGT: failure for drm/i915: remove __i915_printk()

2024-08-06 Thread Patchwork
== Series Details == Series: drm/i915: remove __i915_printk() URL : https://patchwork.freedesktop.org/series/136927/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15187_full -> Patchwork_136927v1_full Summary --- **F

✓ Fi.CI.BAT: success for drm/i915/bmg: Read display register timeout (rev2)

2024-08-06 Thread Patchwork
== Series Details == Series: drm/i915/bmg: Read display register timeout (rev2) URL : https://patchwork.freedesktop.org/series/136497/ State : success == Summary == CI Bug Log - changes from CI_DRM_15191 -> Patchwork_136497v2 Summary --

RE: [PATCH] drm/i915/bmg: Read display register timeout

2024-08-06 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Kandpal, Suraj > Sent: Monday, July 29, 2024 2:39 PM > To: Golani, Mitulkumar Ajitkumar ; > intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org > Subject: RE: [PATCH] drm/i915/bmg: Read display register timeout > > > > > -Original Mes

[PATCH v2] drm/i915/bmg: Read display register timeout

2024-08-06 Thread Mitul Golani
Log the address of the register that caused the timeout interrupt by reading RMTIMEOUTREG_CAPTURE Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display_irq.c | 7 ++- drivers/gpu/drm/i915/i915_reg.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-)

✗ Fi.CI.BUILD: failure for cdc4ad36a8: kernel_BUG_at_include/linux/page-flags.h

2024-08-06 Thread Patchwork
== Series Details == Series: cdc4ad36a8: kernel_BUG_at_include/linux/page-flags.h URL : https://patchwork.freedesktop.org/series/136961/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/136961/revisions/1/mbox/ not applied Applying: cdc4ad36a8: kern

Re: [linux-next:master] [fs] cdc4ad36a8: kernel_BUG_at_include/linux/page-flags.h

2024-08-06 Thread Matthew Wilcox
On Tue, Aug 06, 2024 at 10:26:17PM +0800, kernel test robot wrote: > kernel test robot noticed "kernel_BUG_at_include/linux/page-flags.h" on: > > commit: cdc4ad36a871b7ac43fcc6b2891058d332ce60ce ("fs: Convert > aops->write_begin to take a folio") > https://git.kernel.org/cgit/linux/kernel/git/nex

Re: [PATCH 4/5] drm/i915/pll_algorithm: Compute C10 HDMI PLLs with algorithm

2024-08-06 Thread Nautiyal, Ankit K
On 8/6/2024 7:29 PM, Jani Nikula wrote: On Tue, 06 Aug 2024, Ankit Nautiyal wrote: diff --git a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h index 9f60bd9bacbe..288289ec593f 100644 --- a/drivers/gpu/drm/i915/display/intel_snps_hdmi_p

[PATCH 02/10] tools/include: Sync uapi/drm/i915_drm.h with the kernel sources

2024-08-06 Thread Namhyung Kim
To pick up changes from: 0f1bb41bf396 drm/i915: Support replaying GPU hangs with captured context image This should be used to beautify DRM syscall arguments and it addresses these tools/perf build warnings: Warning: Kernel ABI header differences: diff -u tools/include/uapi/drm/i915_drm.

RE: [PATCH 3/3] drm/i915: remove __i915_printk()

2024-08-06 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Jani Nikula Sent: Tuesday, August 6, 2024 6:39 AM To: intel-gfx@lists.freedesktop.org Cc: Nikula, Jani Subject: [PATCH 3/3] drm/i915: remove __i915_printk() > > With the previous cleanups, the last remaining user of __i915_printk() > is i9

RE: [PATCH 2/3] drm/i915: remove i915_report_error()

2024-08-06 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Jani Nikula Sent: Tuesday, August 6, 2024 6:39 AM To: intel-gfx@lists.freedesktop.org Cc: Nikula, Jani Subject: [PATCH 2/3] drm/i915: remove i915_report_error() > > i915_report_error() has only two users, both in driver probe. I doubt > th

RE: [PATCH 1/3] drm/i915: remove a few __i915_printk() uses

2024-08-06 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Jani Nikula Sent: Tuesday, August 6, 2024 6:39 AM To: intel-gfx@lists.freedesktop.org Cc: Nikula, Jani Subject: [PATCH 1/3] drm/i915: remove a few __i915_printk() uses > > __i915_printk() does nothing for notice/info levels. Just use the >

Re: [PATCH] drm/xe/pm: Change HPD to polling on runtime suspend

2024-08-06 Thread Imre Deak
On Tue, Aug 06, 2024 at 02:25:13PM +0530, Arun R Murthy wrote: > HPD is interrupt based and on runtime suspend change it to polling as > HPD is not a wakeup event. A worker thread is scheduled for doing this > polling and it keeps polling for HPD live status on an internval of 10s. > On runtime res

Re: [PATCH] drm/xe/pm: Change HPD to polling on runtime suspend

2024-08-06 Thread kernel test robot
Hi Arun, kernel test robot noticed the following build errors: [auto build test ERROR on drm-xe/drm-xe-next] [also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.11-rc2 next-20240806] [If your patch is applied to the wrong git tree

Re: [PATCH 0/2] drm/i915: Fix ttm small BAR placement handling

2024-08-06 Thread Andi Shyti
Hi David, thanks for the patches and thanks Justin for debugging the issue. I reviewed and merged it into drm-intel-gt-next. Thanks, Andi On Sun, Aug 04, 2024 at 05:18:46PM +0800, David Gow wrote: > From: David Gow > > As described in [1], there have been a couple of regressions in the TTM >

✗ Fi.CI.SPARSE: warning for drm/i915: remove __i915_printk()

2024-08-06 Thread Patchwork
== Series Details == Series: drm/i915: remove __i915_printk() URL : https://patchwork.freedesktop.org/series/136927/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: remove __i915_printk()

2024-08-06 Thread Patchwork
== Series Details == Series: drm/i915: remove __i915_printk() URL : https://patchwork.freedesktop.org/series/136927/ State : warning == Summary == Error: dim checkpatch failed 35cd2f6098a9 drm/i915: remove a few __i915_printk() uses e4981bdebe5c drm/i915: remove i915_report_error() 545c1e43b47

✓ Fi.CI.BAT: success for drm/i915: remove __i915_printk()

2024-08-06 Thread Patchwork
== Series Details == Series: drm/i915: remove __i915_printk() URL : https://patchwork.freedesktop.org/series/136927/ State : success == Summary == CI Bug Log - changes from CI_DRM_15187 -> Patchwork_136927v1 Summary --- **SUCCESS**

Re: [PATCH 4/4] drm/i915/bios: convert to struct intel_display

2024-08-06 Thread Imre Deak
On Wed, Jul 31, 2024 at 07:44:36PM +0300, Jani Nikula wrote: > [...] > diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c > b/drivers/gpu/drm/i915/display/g4x_dp.c > index a8e746a0f670..c2128b46bdbd 100644 > --- a/drivers/gpu/drm/i915/display/g4x_dp.c > +++ b/drivers/gpu/drm/i915/display/g4x_dp.c

Re: [PATCH 3/4] drm/i915/opregion: convert to struct intel_display

2024-08-06 Thread Imre Deak
On Wed, Jul 31, 2024 at 07:44:35PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_opregion.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i

✓ Fi.CI.BAT: success for Add HDMI PLL Algorithm for SNPS/C10PHY (rev2)

2024-08-06 Thread Patchwork
== Series Details == Series: Add HDMI PLL Algorithm for SNPS/C10PHY (rev2) URL : https://patchwork.freedesktop.org/series/135397/ State : success == Summary == CI Bug Log - changes from CI_DRM_15186 -> Patchwork_135397v2 Summary ---

✗ Fi.CI.SPARSE: warning for Add HDMI PLL Algorithm for SNPS/C10PHY (rev2)

2024-08-06 Thread Patchwork
== Series Details == Series: Add HDMI PLL Algorithm for SNPS/C10PHY (rev2) URL : https://patchwork.freedesktop.org/series/135397/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitop

✗ Fi.CI.CHECKPATCH: warning for Add HDMI PLL Algorithm for SNPS/C10PHY (rev2)

2024-08-06 Thread Patchwork
== Series Details == Series: Add HDMI PLL Algorithm for SNPS/C10PHY (rev2) URL : https://patchwork.freedesktop.org/series/135397/ State : warning == Summary == Error: dim checkpatch failed 8a9b0f71f831 drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2 -:39: WARNING:FILE_PA

[linux-next:master] [fs] cdc4ad36a8: kernel_BUG_at_include/linux/page-flags.h

2024-08-06 Thread kernel test robot
b: 5e pop%rsi c: c3 ret d: 90 nop e: 89 54 24 0c mov%edx,0xc(%rsp) 12: 89 4c 24 08 mov%ecx,0x8(%rsp) The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/a

Re: [PATCH 09/10] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging

2024-08-06 Thread Jani Nikula
On Tue, 06 Aug 2024, Jani Nikula wrote: > On Thu, 01 Aug 2024, Gustavo Sousa wrote: >> Quoting Jani Nikula (2024-07-29 11:30:10-03:00) >>>Use to_intel_display() instead of kdev_to_i915() in the HDCP component >>>API hooks. Avoid further drive-by changes at this point, and just >>>convert the disp

Re: [PATCH 09/10] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging

2024-08-06 Thread Jani Nikula
On Thu, 01 Aug 2024, Gustavo Sousa wrote: > Quoting Jani Nikula (2024-07-29 11:30:10-03:00) >>Use to_intel_display() instead of kdev_to_i915() in the HDCP component >>API hooks. Avoid further drive-by changes at this point, and just >>convert the display pointer to i915, and leave the struct intel

Re: [PATCH 4/5] drm/i915/pll_algorithm: Compute C10 HDMI PLLs with algorithm

2024-08-06 Thread Jani Nikula
On Tue, 06 Aug 2024, Ankit Nautiyal wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h > b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h > index 9f60bd9bacbe..288289ec593f 100644 > --- a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h > +++ b/drivers/gpu/drm/i915/dis

Re: [PATCH 2/4] drm/i915/opregion: unify intel_encoder/intel_connector naming

2024-08-06 Thread Imre Deak
On Wed, Jul 31, 2024 at 07:44:34PM +0300, Jani Nikula wrote: > Prefer the short encoder/connector names for struct > intel_encoder/intel_connector variables and parameters. > > Signed-off-by: Jani Nikula Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_opregion.c | 23 +++

Re: [PATCH 1/4] drm/i915/acpi: convert to struct intel_display

2024-08-06 Thread Imre Deak
On Wed, Jul 31, 2024 at 07:44:33PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_acpi.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Imre Deak > --

[PATCH 3/3] drm/i915: remove __i915_printk()

2024-08-06 Thread Jani Nikula
With the previous cleanups, the last remaining user of __i915_printk() is i915_probe_error(). Switch that to use drm_dbg() and drm_err() instead, dropping the request to report bugs in the few remaining specific cases. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_utils.c | 41 ---

[PATCH 2/3] drm/i915: remove i915_report_error()

2024-08-06 Thread Jani Nikula
i915_report_error() has only two users, both in driver probe. I doubt these cases are worth having a dedicated wrapper to also print bug reporting info. Just switch them to regular drm_err() and remove the wrapper. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_driver.c | 8 d

[PATCH 1/3] drm/i915: remove a few __i915_printk() uses

2024-08-06 Thread Jani Nikula
__i915_printk() does nothing for notice/info levels. Just use the regular drm_notice() and drm_info() calls. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_utils.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_utils.c b/driver

[PATCH 0/3] drm/i915: remove __i915_printk()

2024-08-06 Thread Jani Nikula
I don't think we need the bug reporting request in the few specific places that lead to __i915_printk(). With them gone, there's really no need for __i915_printk(). Just switch to regular drm logging. Jani Nikula (3): drm/i915: remove a few __i915_printk() uses drm/i915: remove i915_report_err

[PATCH 3/5] drm/i915/cx0_phy_regs: Add C10 registers bits

2024-08-06 Thread Ankit Nautiyal
Add C10 register bits to be used for computing HDMI PLLs with algorithm. Signed-off-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_cx0_phy_regs.h | 24 +++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h b/drivers/gpu/drm/i

[PATCH 5/5] drm/i915/cx0_phy: Use HDMI PLL algorithm for C10 PHY

2024-08-06 Thread Ankit Nautiyal
Try HDMI PLL alogorithm for C10 PHY, if there are no pre-computed tables. Also get rid of the helpers to get rate for HDMI for C10/20 PHY, as we no longer depend only on pre-computed tables. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 49 +---

[PATCH 4/5] drm/i915/pll_algorithm: Compute C10 HDMI PLLs with algorithm

2024-08-06 Thread Ankit Nautiyal
Add support for computing C10 HDMI PLLS using the HDMI PLL algorithm. v2: -Fixed styling issues. (Jani) Signed-off-by: Ankit Nautiyal --- .../drm/i915/display/intel_snps_hdmi_pll.c| 76 +++ .../drm/i915/display/intel_snps_hdmi_pll.h| 2 + 2 files changed, 78 insertions(

[PATCH 2/5] drm/i915/snps_phy: Use HDMI PLL algorithm for DG2

2024-08-06 Thread Ankit Nautiyal
Try SNPS_PHY HDMI alogorithm, if there are no pre-computed tables. Also get rid of the helper to get rate for HDMI snps phy, as we no longer depend only on pre-computed tables. v2: -Prefer pre-computed tables over computed values from algorithm. (Jani) Signed-off-by: Ankit Nautiyal --- drivers/

[PATCH 1/5] drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2

2024-08-06 Thread Ankit Nautiyal
Add helper _intel_phy_compute_hdmi_tmds_pll to calculate the necessary parameters for configuring the HDMI PLL for SNPS MPLLB and C10 PHY. The pll parameters are computed for desired pixel clock, curve data and other inputs used for interpolation and finally stored in the pll_state. Bspec:54032 C

[PATCH 0/5] Add HDMI PLL Algorithm for SNPS/C10PHY

2024-08-06 Thread Ankit Nautiyal
The HDMI PLL programming involves pre-calculated values for specific frequencies and an algorithm to compute values for other frequencies. While the algorithm itself wasn't part of the driver, tables were added based on it for known modes. Some HDMI modes were pruned due to lack of support (for ex

Re: [PATCH 03/10] drm/xe/tests: fix drvdata usage

2024-08-06 Thread Jani Nikula
On Tue, 06 Aug 2024, Jani Nikula wrote: > On Thu, 01 Aug 2024, Gustavo Sousa wrote: >> Quoting Jani Nikula (2024-07-29 11:30:04-03:00) >>>The test code seems to assume struct drm_device * is stored in >>>drvdata. This is (currently) not the case. Use the proper helper to get >>>at the xe device.

Re: [PATCH 03/10] drm/xe/tests: fix drvdata usage

2024-08-06 Thread Jani Nikula
On Thu, 01 Aug 2024, Gustavo Sousa wrote: > Quoting Jani Nikula (2024-07-29 11:30:04-03:00) >>The test code seems to assume struct drm_device * is stored in >>drvdata. This is (currently) not the case. Use the proper helper to get >>at the xe device. >> >>This has not been an issue, because struct

Re: [PATCH 02/10] drm/xe: add kdev_to_xe_device() helper and use it

2024-08-06 Thread Jani Nikula
On Thu, 01 Aug 2024, Gustavo Sousa wrote: > Quoting Jani Nikula (2024-07-29 11:30:03-03:00) >>There are enough users for kernel device to xe device conversion, add a >>helper for it. >> >>Signed-off-by: Jani Nikula >>--- >> drivers/gpu/drm/xe/xe_device.h| 5 + >> drivers/gpu/drm/xe/xe_gsc_

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-06 Thread Joonas Lahtinen
Quoting Andi Shyti (2024-08-06 12:46:07) > Hi Greg, > > same question without the stable mailing list not to trigger the > automatic reply. > > > Andi Shyti (2): > > drm/i915/gem: Adjust vma offset for framebuffer mmap offset > > drm/i915/gem: Fix Virtual Memory mapping boundaries calculation

Re: ✗ Fi.CI.IGT: failure for drm/i915: Dump DSC HW state

2024-08-06 Thread Imre Deak
On Tue, Aug 06, 2024 at 12:43:09AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Dump DSC HW state > URL : https://patchwork.freedesktop.org/series/136890/ > State : failure The patchset is pushed to drm-intel-next, thanks for the acks. The failures are unrelated, see bel

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-06 Thread Andi Shyti
Hi Greg, same question without the stable mailing list not to trigger the automatic reply. > Andi Shyti (2): > drm/i915/gem: Adjust vma offset for framebuffer mmap offset > drm/i915/gem: Fix Virtual Memory mapping boundaries calculation I have forgotten to actually Cc the stable mailing list

✓ Fi.CI.BAT: success for drm/xe/pm: Change HPD to polling on runtime suspend

2024-08-06 Thread Patchwork
== Series Details == Series: drm/xe/pm: Change HPD to polling on runtime suspend URL : https://patchwork.freedesktop.org/series/136917/ State : success == Summary == CI Bug Log - changes from CI_DRM_15183 -> Patchwork_136917v1 Summary -

[PATCH] drm/xe/pm: Change HPD to polling on runtime suspend

2024-08-06 Thread Arun R Murthy
HPD is interrupt based and on runtime suspend change it to polling as HPD is not a wakeup event. A worker thread is scheduled for doing this polling and it keeps polling for HPD live status on an internval of 10s. On runtime resume disable polling and fallback to interrupt mechanism. Signed-off-by

Re: [PATCH v2] drm/i915/hwmon: expose fan speed

2024-08-06 Thread Riana Tauro
Hi Raag On 7/30/2024 11:35 AM, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-06 Thread Thomas Zimmermann
Hi Am 05.08.24 um 21:00 schrieb Deucher, Alexander: [Public] -Original Message- From: Thomas Zimmermann Sent: Wednesday, July 31, 2024 8:17 AM To: maarten.lankho...@linux.intel.com; mrip...@kernel.org; airl...@gmail.com; dan...@ffwll.ch Cc: amd-...@lists.freedesktop.org; dri-de...@lis