[PULL] drm-xe-next

2024-06-26 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our likely last pull-request towards 6.11. If some last minute thing shows up a small one might come next Tuesday. Thanks, Rodrigo. drm-xe-next-2024-06-26: UAPI Changes: - New uapi adding OA functionality to Xe (Ashutosh) Cross-subsystem Changes: - devcoredump: Add

Re: [PATCH] drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace

2024-06-26 Thread Nirmoy Das
Hi Rodrigo, On 6/26/2024 5:50 PM, Rodrigo Vivi wrote: On Wed, Jun 26, 2024 at 05:36:43PM +0200, Nirmoy Das wrote: Hi Rodrigo, On 6/26/2024 5:24 PM, Rodrigo Vivi wrote:

Re: [PATCH 1/5] drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2

2024-06-26 Thread kernel test robot
hm-for-DG2/20240626-131209 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/20240626050056.3996349-2-ankit.k.nautiyal%40intel.com patch subject: [PATCH 1/5] drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2 config: i386-

Re: [PATCH] drm/i915: Skip programming FIA link enable bits for MTL+

2024-06-26 Thread Imre Deak
On Wed, Jun 26, 2024 at 02:31:49PM -0300, Gustavo Sousa wrote: > Quoting Imre Deak (2024-06-26 13:24:24-03:00) > >On Tue, Jun 25, 2024 at 05:26:52PM -0300, Gustavo Sousa wrote: > >> Starting with Xe_LPDP, support for Type-C connections is provided by > >> PICA and programming PORT_TX_DFLEXDPMLE1(*)

Re: [PATCH 1/5] drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2

2024-06-26 Thread kernel test robot
hm-for-DG2/20240626-131209 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/20240626050056.3996349-2-ankit.k.nautiyal%40intel.com patch subject: [PATCH 1/5] drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2 config: i386

Re: [PATCH] drm/i915: Skip programming FIA link enable bits for MTL+

2024-06-26 Thread Gustavo Sousa
Quoting Matt Roper (2024-06-26 14:57:58-03:00) >On Tue, Jun 25, 2024 at 05:26:52PM -0300, Gustavo Sousa wrote: >> Starting with Xe_LPDP, support for Type-C connections is provided by > >Drive-by nitpick: In human-readable text like comments and commit >messages, the official name of the IP is "Xe_

✓ Fi.CI.BAT: success for drm/i915/mtl: Skip PLL state verification in TBT mode

2024-06-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Skip PLL state verification in TBT mode URL : https://patchwork.freedesktop.org/series/135441/ State : success == Summary == CI Bug Log - changes from CI_DRM_15007 -> Patchwork_135441v1 Summary ---

Re: [PATCH] drm/i915: Skip programming FIA link enable bits for MTL+

2024-06-26 Thread Matt Roper
On Tue, Jun 25, 2024 at 05:26:52PM -0300, Gustavo Sousa wrote: > Starting with Xe_LPDP, support for Type-C connections is provided by Drive-by nitpick: In human-readable text like comments and commit messages, the official name of the IP is "Xe_LPD+." We only need to replace the "+" with a "P" i

✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Skip PLL state verification in TBT mode

2024-06-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Skip PLL state verification in TBT mode URL : https://patchwork.freedesktop.org/series/135441/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-26 Thread Matt Roper
On Wed, Jun 26, 2024 at 01:26:00PM -0400, Rodrigo Vivi wrote: > On Wed, Jun 26, 2024 at 05:17:41PM +0100, Matthew Auld wrote: > > On 26/06/2024 16:53, Rodrigo Vivi wrote: > > > On Wed, Jun 19, 2024 at 03:31:27PM +0100, Matthew Auld wrote: > > > > On BMG-G21 we need to disable fbc due to complicatio

Re: [PATCH] drm/i915: Skip programming FIA link enable bits for MTL+

2024-06-26 Thread Gustavo Sousa
Quoting Imre Deak (2024-06-26 13:24:24-03:00) >On Tue, Jun 25, 2024 at 05:26:52PM -0300, Gustavo Sousa wrote: >> Starting with Xe_LPDP, support for Type-C connections is provided by >> PICA and programming PORT_TX_DFLEXDPMLE1(*) registers is not applicable >> anymore. Those registers don't even exi

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-26 Thread Rodrigo Vivi
On Wed, Jun 26, 2024 at 05:17:41PM +0100, Matthew Auld wrote: > On 26/06/2024 16:53, Rodrigo Vivi wrote: > > On Wed, Jun 19, 2024 at 03:31:27PM +0100, Matthew Auld wrote: > > > On BMG-G21 we need to disable fbc due to complications around the WA. > > > > > > Signed-off-by: Matthew Auld > > > Cc:

[PATCH] drm/i915/mtl: Skip PLL state verification in TBT mode

2024-06-26 Thread Imre Deak
In TBT-alt mode the driver doesn't program the PHY's PLL, which is handled instead by Thunderbolt driver/FW components, hence the PLL's HW vs. SW state verification should be skipped. During HW readout set a flag in the PLL state if the port was at the moment in TBT-alt mode and skip the verificati

✓ Fi.CI.BAT: success for drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace

2024-06-26 Thread Patchwork
== Series Details == Series: drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace URL : https://patchwork.freedesktop.org/series/135436/ State : success == Summary == CI Bug Log - changes from CI_DRM_15006 -> Patchwork_135436v1 ===

Re: [PATCH] drm/i915: Skip programming FIA link enable bits for MTL+

2024-06-26 Thread Imre Deak
On Tue, Jun 25, 2024 at 05:26:52PM -0300, Gustavo Sousa wrote: > Starting with Xe_LPDP, support for Type-C connections is provided by > PICA and programming PORT_TX_DFLEXDPMLE1(*) registers is not applicable > anymore. Those registers don't even exist in recent display IPs. As > such, skip programm

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-26 Thread Matthew Auld
On 26/06/2024 16:55, Rodrigo Vivi wrote: On Wed, Jun 26, 2024 at 04:14:02PM +0100, Matthew Auld wrote: On 25/06/2024 09:09, Matthew Auld wrote: On 19/06/2024 15:31, Matthew Auld wrote: On BMG-G21 we need to disable fbc due to complications around the WA. Signed-off-by: Matthew Auld Cc: Jonat

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-26 Thread Matthew Auld
On 26/06/2024 16:53, Rodrigo Vivi wrote: On Wed, Jun 19, 2024 at 03:31:27PM +0100, Matthew Auld wrote: On BMG-G21 we need to disable fbc due to complications around the WA. Signed-off-by: Matthew Auld Cc: Jonathan Cavitt Cc: Matt Roper Cc: Lucas De Marchi Cc: Vinod Govindapillai Cc: intel-

Re: [PATCH v5] drm/display: split DSC helpers from DP helpers

2024-06-26 Thread Thomas Zimmermann
Hi Am 23.06.24 um 00:44 schrieb Dmitry Baryshkov: Currently the DRM DSC functions are selected by the DRM_DISPLAY_DP_HELPER Kconfig symbol. This is not optimal, since the DSI code (both panel and host drivers) end up selecting the seemingly irrelevant DP helpers. Split the DSC code to be guarded

Re: [PATCH v5] drm/display: split DSC helpers from DP helpers

2024-06-26 Thread Rodrigo Vivi
On Sun, Jun 23, 2024 at 01:44:19AM +0300, Dmitry Baryshkov wrote: > Currently the DRM DSC functions are selected by the > DRM_DISPLAY_DP_HELPER Kconfig symbol. This is not optimal, since the DSI > code (both panel and host drivers) end up selecting the seemingly > irrelevant DP helpers. Split the D

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-26 Thread Rodrigo Vivi
On Wed, Jun 26, 2024 at 04:14:02PM +0100, Matthew Auld wrote: > On 25/06/2024 09:09, Matthew Auld wrote: > > On 19/06/2024 15:31, Matthew Auld wrote: > > > On BMG-G21 we need to disable fbc due to complications around the WA. > > > > > > Signed-off-by: Matthew Auld > > > Cc: Jonathan Cavitt > >

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-26 Thread Rodrigo Vivi
On Wed, Jun 19, 2024 at 03:31:27PM +0100, Matthew Auld wrote: > On BMG-G21 we need to disable fbc due to complications around the WA. > > Signed-off-by: Matthew Auld > Cc: Jonathan Cavitt > Cc: Matt Roper > Cc: Lucas De Marchi > Cc: Vinod Govindapillai > Cc: intel-gfx@lists.freedesktop.org >

Re: [PATCH] drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace

2024-06-26 Thread Rodrigo Vivi
On Wed, Jun 26, 2024 at 05:36:43PM +0200, Nirmoy Das wrote: >Hi Rodrigo, > > > >On 6/26/2024 5:24 PM, Rodrigo Vivi wrote:

Re: [PATCH] drm/i915/dp: Wait more before rearming FIFO underrun during retrain

2024-06-26 Thread Imre Deak
Atm the link on DP-SST is retrained without a full modeset, which probably causes an underrun. This was originally done for simplicity, the underrun not causing further known issues. The plan is to retrain the link with a full modeset instead on DP-SST as well, similarly to how this is done on DP-M

Re: [PATCH] drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace

2024-06-26 Thread Nirmoy Das
Hi Rodrigo, On 6/26/2024 5:24 PM, Rodrigo Vivi wrote: On Wed, Jun 26, 2024 at 04:33:18PM +0200, Nirmoy Das wrote: We report object allocation failures to userspace with ENOMEM so add __GFP_NOWARN to remove superfluous oom warnings. Closes:https://gitlab.freedesktop.org/drm/i915/kernel/-/issues

[PULL] drm-misc-fixes

2024-06-26 Thread Maarten Lankhorst
Hi Dave, Sima, Was out last week, didn't happen much anyway with only 2 patches, so have a double sized -fixes this week. Cheers, ~Maarten drm-misc-fixes-2024-06-26: drm-misc-fixes for v6.10-rc6: - nouveau tv mode fixes. - Add KOE TX26D202VM0BWA timings. - Fix fb_info when vmalloc is used, re

Re: [PATCH] drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace

2024-06-26 Thread Rodrigo Vivi
On Wed, Jun 26, 2024 at 04:33:18PM +0200, Nirmoy Das wrote: > We report object allocation failures to userspace with ENOMEM > so add __GFP_NOWARN to remove superfluous oom warnings. > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4936 > Cc: Andi Shyti > Signed-off-by: Nirmoy D

RE: [PATCH] drm/i915/dp: Wait more before rearming FIFO underrun during retrain

2024-06-26 Thread Runyan, Arthur J
There is no underrun expected (that I know of) when coming out of training on recent product generations. You should undo this masking and debug. -Original Message- From: Vivi, Rodrigo Sent: Wednesday, June 26, 2024 8:13 AM To: Nautiyal, Ankit K ; Runyan, Arthur J Cc: intel-gfx@lists

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-26 Thread Matthew Auld
On 25/06/2024 09:09, Matthew Auld wrote: On 19/06/2024 15:31, Matthew Auld wrote: On BMG-G21 we need to disable fbc due to complications around the WA. Signed-off-by: Matthew Auld Cc: Jonathan Cavitt Cc: Matt Roper Cc: Lucas De Marchi Cc: Vinod Govindapillai Cc: intel-gfx@lists.freedesktop

Re: [PATCH] drm/i915/dp: Wait more before rearming FIFO underrun during retrain

2024-06-26 Thread Rodrigo Vivi
On Wed, Jun 26, 2024 at 02:06:24PM +0530, Ankit Nautiyal wrote: > During Link re-training reporting underrun is disabled and then > renabled after re-training is completed. For BMG its seen that we get > FIFO underrun just after the retraining is completed and the underrun > reporting is re-enabled

[PATCH] drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace

2024-06-26 Thread Nirmoy Das
We report object allocation failures to userspace with ENOMEM so add __GFP_NOWARN to remove superfluous oom warnings. Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4936 Cc: Andi Shyti Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_scatterlist.c | 8 1 file ch

RE: [PATCH] drm/i915/display: For MTL+ platforms skip mg dp programming

2024-06-26 Thread Kahola, Mika
Merged and marked as stable i.e with added line in commit message Cc: sta...@vger.kernel.org Thanks for the review! -Mika- > -Original Message- > From: Sousa, Gustavo > Sent: Tuesday, June 25, 2024 10:32 PM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Cc: Deak, Imre ; Kahola,

Re: [PATCH 1/4] drm/i915: Add some essential functionality for joiners

2024-06-26 Thread Jani Nikula
On Wed, 26 Jun 2024, Stanislav Lisovskiy wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_display.h > b/drivers/gpu/drm/i915/display/intel_display.h > index b0cf6ca70952..bac81b7ab764 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.h > +++ b/drivers/gpu/drm/i915/display/intel_di

Re: [PATCH 5/5] drm/xe: Add intel_pll_algorithm in Makefile

2024-06-26 Thread Jani Nikula
On Wed, 26 Jun 2024, Ankit Nautiyal wrote: > Include the intel_pll_algorithm for xe driver. Not how this works. Please build every commit before submitting and you'll see the build is broken at patch 2. git rebase -i $tip -x make BR, Jani. > > Signed-off-by: Ankit Nautiyal > --- > drivers/g

Re: [PATCH 4/5] drm/i915/pll_algorithm: Compute C10 HDMI PLLs with algorithm

2024-06-26 Thread Jani Nikula
On Wed, 26 Jun 2024, Ankit Nautiyal wrote: > Add support for computing C10 HDMI PLLS using the HDMI PLL algorithm. > Try C10 HDMI tables computed with the algorithm, before using the > consolidated tables. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_cx0_phy.c |

Re: [PATCH 2/5] drm/i915/snps_phy: Use HDMI PLL algorithm for DG2

2024-06-26 Thread Jani Nikula
On Wed, 26 Jun 2024, Ankit Nautiyal wrote: > Try SNPS_PHY HDMI tables computed using the algorithm, before using > consolidated tables. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_snps_phy.c | 20 --- > 1 file changed, 8 insertions(+), 12 deletion

Re: [PATCH 1/5] drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2

2024-06-26 Thread Jani Nikula
On Wed, 26 Jun 2024, Ankit Nautiyal wrote: > Add helper _intel_phy_compute_hdmi_tmds_pll to calculate the necessary > parameters for configuring the HDMI PLL for SNPS MPLLB and C10 PHY. > > The pll parameters are computed for desired pixel clock, curve data > and other inputs used for interpolatio

✓ Fi.CI.BAT: success for drm/i915/dp: Wait more before rearming FIFO underrun during retrain

2024-06-26 Thread Patchwork
== Series Details == Series: drm/i915/dp: Wait more before rearming FIFO underrun during retrain URL : https://patchwork.freedesktop.org/series/135415/ State : success == Summary == CI Bug Log - changes from CI_DRM_15002 -> Patchwork_135415v1 ===

✗ Fi.CI.BAT: failure for Ultrajoiner basic functionality series (rev4)

2024-06-26 Thread Patchwork
== Series Details == Series: Ultrajoiner basic functionality series (rev4) URL : https://patchwork.freedesktop.org/series/133800/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15002 -> Patchwork_133800v4 Summary ---

✗ Fi.CI.CHECKPATCH: warning for Ultrajoiner basic functionality series (rev4)

2024-06-26 Thread Patchwork
== Series Details == Series: Ultrajoiner basic functionality series (rev4) URL : https://patchwork.freedesktop.org/series/133800/ State : warning == Summary == Error: dim checkpatch failed 89c7a081cd07 drm/i915: Add some essential functionality for joiners -:61: ERROR:OPEN_BRACE: that open bra

[PATCH] drm/i915/dp: Wait more before rearming FIFO underrun during retrain

2024-06-26 Thread Ankit Nautiyal
During Link re-training reporting underrun is disabled and then renabled after re-training is completed. For BMG its seen that we get FIFO underrun just after the retraining is completed and the underrun reporting is re-enabled. Add one more intel_crtc_wait_for_next_vblank before re-arming the unde

[PATCH 4/4] drm/i915: Add new abstraction layer to handle pipe order for different joiners

2024-06-26 Thread Stanislav Lisovskiy
Ultrajoiner case requires special treatment where both reverse and staight order iteration doesn't work(for instance disabling case requires order to be: primary master, slaves, secondary master). Lets unify our approach by using not only pipe masks for iterating required pipes based on joiner typ

[PATCH 2/4] drm/i915: Implement hw state readout for ultrajoiner

2024-06-26 Thread Stanislav Lisovskiy
Ultrajoiner mode has some new bits and states to be read out from the hw. Lets make changes accordingly. v2: - Split enabled_joiner_pipes readout procedure into 3 parts, each of them taking care of uncompressed joiner, bigjoiner and ultrajoiner respectively and then do some sanit

[PATCH 3/4] drm/i915: Compute config and mode valid changes for ultrajoiner

2024-06-26 Thread Stanislav Lisovskiy
Implement required changes for mode validation and compute config, to support Ultrajoiner. This also includes required DSC changes and checks. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 5 +- drivers/gpu/drm/i915/display/intel_display.h | 3 +- driv

[PATCH 1/4] drm/i915: Add some essential functionality for joiners

2024-06-26 Thread Stanislav Lisovskiy
In most of the cases we now try to avoid mentioning things like "bigjoiner" or "ultrajoiner" trying to unify the API and refer mostly to all this functionality as "joiner". In majority cases that should be way to go. However in some cases we still need to distinguish between bigjoiner primaries and

[PATCH 0/4] Ultrajoiner basic functionality series

2024-06-26 Thread Stanislav Lisovskiy
This patch series attempts to implement basic support for Ultrajoiner functionality. Stanislav Lisovskiy (4): drm/i915: Add some essential functionality for joiners drm/i915: Implement hw state readout for ultrajoiner drm/i915: Compute config and mode valid changes for ultrajoiner drm/i915