On 5/30/2024 11:34 AM, Mitul Golani wrote:
Add register definitions for Transcoder Fixed Average
Vtotal mode/CMRR function, with the necessary bitfields.
Compute these registers when CMRR is enabled, extending
Adaptive refresh rate capabilities.
--v2:
- Use intel_de_read64_2x32 in intel_vrr_ge
On 5/30/2024 11:34 AM, Mitul Golani wrote:
Compute vrr vsync params in case of FAVT as well instead of
only to AVT mode of operation.
--v2:
- Remove redundant computation for vrr_vsync_start
and vrr_vsync_end(Ankit).
Signed-off-by: Mitul Golani
---
drivers/gpu/drm/i915/display/intel_vrr.c
> -Original Message-
> From: Manna, Animesh
> Sent: Thursday, May 30, 2024 1:38 AM
> To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org
> Cc: Manna, Animesh
> Subject: [PATCH v7 0/6] Link off between frames for edp
>
> Link Off Between Active Frames (LOBF) allows an e
On 5/30/2024 11:34 AM, Mitul Golani wrote:
Compute params for Adaptive Sync SDP when Fixed Average Vtotal
mode is enabled.
--v2:
Since vrr.enable is set in case of cmrr also, handle accordingly(Ankit).
Signed-off-by: Mitul Golani
---
drivers/gpu/drm/i915/display/intel_dp.c | 17 +++
On 5/30/2024 11:34 AM, Mitul Golani wrote:
Add support of pack and unpack for target_rr_divider.
--v2:
- Set Target Refresh Rate Divider bit when related
AS SDP bit is set (Ankit).
--v3:
- target_rr_divider is bools so set accordingly (Ankit).
Signed-off-by: Mitul Golani
LGTM.
Reviewed-by
On 5/30/2024 11:34 AM, Mitul Golani wrote:
Compute Fixed Average Vtotal/CMRR with resepect to
userspace VRR enablement. Also calculate required
parameters in case of CMRR is enabled. During
intel_vrr_compute_config, CMRR is getting enabled
based on userspace has enabled Variable refresh mode
w
On 5/30/2024 11:34 AM, Mitul Golani wrote:
Add/update trans_vrr_ctl flag when crtc_state->cmrr.enable
is set, With this commit setting the stage for subsequent
CMRR enablement.
--v2:
- Check pipe active state in cmrr enabling. [Jani]
- Remove usage of bitwise OR on booleans. [Jani]
- Revert un
Hi Dave, Sima,
this is the PR for drm-misc-fixes or this week. FYI I had to run dim
pull-request with the -f option, so that it ignored the following error
dim: 779aa4d74785 ("drm/nouveau/nvif: Avoid build error due to potential
integer overflows"): Fixes: SHA1 in not pointing at an ancestor:
di
On Wed, May 29, 2024 at 02:49:01PM +0300, Imre Deak wrote:
> From: Dan Williams
>
> The new lockdep annotation for cfg_access_lock naively registered a new
> key per device. This is overkill and leads to warnings on hash
> collisions at dynamic registration time:
>
> WARNING: CPU: 0 PID: 1 at k
[+cc Alison, Imre, et al. IIUC this patch didn't help the similar
issue reported by Imre at
https://lore.kernel.org/r/zlxp5otnsapid...@ideak-desk.fi.intel.com,
but just FYI]
On Tue, May 28, 2024 at 04:22:59PM -0700, Dan Williams wrote:
> The new lockdep annotation for cfg_access_lock naively regi
On Thu, 30 May 2024 15:43:52 +0300
Jani Nikula wrote:
> drm_edid_block_valid() is no longer used outside of drm_edid.c. Make
> it static.
>
> Signed-off-by: Jani Nikula
>
> ---
>
> Cc: Zhenyu Wang
> Cc: Zhi Wang
> Cc: intel-gvt-...@lists.freedesktop.org
> Cc: intel-gfx@lists.freedesktop.org
On Thu, 30 May 2024 15:43:51 +0300
Jani Nikula wrote:
> We'll want to stop drm_edid_block_valid() usage. KVMGT is the last
> user. Replace with drm_edid_valid(), which unfortunately requires an
> allocated drm_edid. However, on the plus side, this would be required
> to handle the TODO comment ab
[+cc linux-pci, this is a follow-up to 7e89efc6e9e4, which appeared in
v6.10-rc1 via the PCI tree]
On Wed, May 29, 2024 at 02:49:01PM +0300, Imre Deak wrote:
> From: Dan Williams
>
> The new lockdep annotation for cfg_access_lock naively registered a new
> key per device. This is overkill and le
Hi Dave, Sima
The drm-xe-fixes for -rc2
Only three fixes so far. I'm holding back one additional
fix to be able to sort out whether it's correct or need more work.
drm-xe-fixes-2024-05-30:
Driver Changes:
- One pcode polling timeout change
- One fix for deadlocks for faulting VMs
- One error-pat
== Series Details ==
Series: drm: move Intel drm headers to a subdirectory (rev4)
URL : https://patchwork.freedesktop.org/series/132264/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14852 -> Patchwork_132264v4
Summary
== Series Details ==
Series: drm: move Intel drm headers to a subdirectory (rev4)
URL : https://patchwork.freedesktop.org/series/132264/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+./arch/x86/include/
== Series Details ==
Series: drm: move Intel drm headers to a subdirectory (rev4)
URL : https://patchwork.freedesktop.org/series/132264/
State : warning
== Summary ==
Error: dim checkpatch failed
db129675ce86 drm: move intel-gtt.h under include/drm/intel
-:84: WARNING:FILE_PATH_CHANGES: added,
On Wed, 22 May 2024, Maarten Lankhorst
wrote:
> Hopefully last attempt.
> Small bug in drm_vblank_work_flush_all left, fixed now hopefully.
Acked-by: Jani Nikula
for merging via drm-misc, but drm-intel is also fine by me. No big deal
this time of the cycle when we can get the backmerge fairly
On Thu, 30 May 2024, Mitul Golani wrote:
> Move VRR related register definitions to a separate file called
> intel_vrr_regs.h.
But this is not just movement... there's a bunch of other (mostly
unwanted?) changes there too.
'git show --color-moved' is a powerful tool for reviewing code
movement.
== Series Details ==
Series: series starting with [1/2] drm/i915/gvt: stop using
drm_edid_block_valid()
URL : https://patchwork.freedesktop.org/series/134249/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14850 -> Patchwork_134249v1
===
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Tomas Winkler
Acked-by: Lucas De Marchi
Acked-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/di
With all the Intel specific drm files under include/drm/intel, update
the i915, xe, and the shared display entries. Do not discriminate based
on file name pattern, just add the entire directory for all three
entries.
Cc: Joonas Lahtinen
Cc: Lucas De Marchi
Cc: Oded Gabbay
Cc: Rodrigo Vivi
Cc:
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Acked-by: Lucas De Marchi
Acked-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/xe/xe_pci.c | 2 +-
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Bjorn Helgaas
Acked-by: Lucas De Marchi
Acked-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-q
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Tomas Winkler
Acked-by: Lucas De Marchi
Acked-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/px
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
v2: Also fix comment in intel_pci_config.h (Ilpo)
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Bjorn Helgaas
Cc: Hans de Goede
Cc: Ilpo Järvinen
Acked-by: Lucas De
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
v2: Also change Documentation/gpu/i915.rst (Andi)
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Tomas Winkler
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Acked-by: Lucas D
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Reviewed-by: Andi Shyti
Acked-by: Lucas De Marchi
Acked-by: Rodrigo Vivi
Signed-off-
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Tomas Winkler
Reviewed-by: Andi Shyti
Acked-by: Lucas De Marchi
Acked-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Reviewed-by: Andi Shyti
Acked-by: Lucas De Marchi
Acked-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/char/agp/
We've accumulated enough Intel specific header files under include/drm
that they warrant a subdirectory of their own. Clean up the top drm
header directory by moving the Intel files under include/drm/intel.
Since i915 is most impacted, I suggest merging the lot via
drm-intel-next. Please ack if th
On Tue, 28 May 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> skl_ddb_add_affected_planes() needs the full atomic state. Instead
> of digging that out from dubious sources plumb it in explicitly.
>
> The wm counterpart (skl_wm_add_affected_planes()) already does
> things in the proper way.
On Tue, 28 May 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> icl_check_nv12_planes() needs the full atomic state. Instead of
> digging that out from dubious sources plumb it in explicitly.
>
> Signed-off-by: Ville Syrjälä
Are most to_intel_atomic_state() uses suspect...?
Reviewed-by: Ja
== Series Details ==
Series: drm/i915: Fix assert on pending async-put power domain work when it
requeues itself
URL : https://patchwork.freedesktop.org/series/134246/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14850 -> Patchwork_134246v1
==
On Tue, 28 May 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Various parts of the cdclk code need access the full atomic
> state. Currently it's being dug out via the cdclk_state->base.state
> pointer, which is not great as that pointer isn't always valid.
> Instead plumb the full atomic s
== Series Details ==
Series: Fix cursor FB unpinning. (rev3)
URL : https://patchwork.freedesktop.org/series/133896/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/133896/revisions/3/mbox/ not
applied
Applying: drm: Add drm_vblank_work_flush_all().
== Series Details ==
Series: drm/i915: Fix assert on pending async-put power domain work when it
requeues itself
URL : https://patchwork.freedesktop.org/series/134246/
State : warning
== Summary ==
Error: dim checkpatch failed
ab24310eafdd drm/i915: Fix assert on pending async-put power domai
We'll want to stop drm_edid_block_valid() usage. KVMGT is the last
user. Replace with drm_edid_valid(), which unfortunately requires an
allocated drm_edid. However, on the plus side, this would be required to
handle the TODO comment about EDID extension block support.
Signed-off-by: Jani Nikula
drm_edid_block_valid() is no longer used outside of drm_edid.c. Make it
static.
Signed-off-by: Jani Nikula
---
Cc: Zhenyu Wang
Cc: Zhi Wang
Cc: intel-gvt-...@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_edid.c | 17
== Series Details ==
Series: series starting with [1/2] drm/i915: drop unnecessary i915_reg.h
includes
URL : https://patchwork.freedesktop.org/series/134244/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14850 -> Patchwork_134244v1
== Series Details ==
Series: series starting with [1/2] drm/i915: drop unnecessary i915_reg.h
includes
URL : https://patchwork.freedesktop.org/series/134244/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: identify all platforms in display probe (rev2)
URL : https://patchwork.freedesktop.org/series/133932/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14849 -> Patchwork_133932v2
Summary
== Series Details ==
Series: drm/i915: identify all platforms in display probe (rev2)
URL : https://patchwork.freedesktop.org/series/133932/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: identify all platforms in display probe (rev2)
URL : https://patchwork.freedesktop.org/series/133932/
State : warning
== Summary ==
Error: dim checkpatch failed
4a12935c03fe drm/i915/display: move params copy at probe earlier
9e54c7084bb1 drm/i915/display
== Series Details ==
Series: PCI: Fix missing lockdep annotation for pci_cfg_access_trylock()
URL : https://patchwork.freedesktop.org/series/134183/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14846_full -> Patchwork_134183v1_full
Commit dd839aa857eb ("drm/i915: Fix incorrect assert about pending power domain
async-put work")
fixed the assert about a pending work dropping a display power reference
asynchronously, leading to the
drm_WARN_ON(!queue_delayed_work(&power_domains->async_put_work));
warn next time around a powe
> -Original Message-
> From: Intel-gfx On Behalf Of Luca
> Coelho
> Sent: Tuesday, May 28, 2024 4:59 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Syrjala, Ville
> Subject: [PATCH 0/2] drm/i915: prevent some static analyzer warnings
>
> Hi,
>
> Here's a couple of patches to prevent
Hi,
Here's the first drm-misc-next PR for 6.11
Maxime
drm-misc-next-2024-05-30:
drm-misc-next for 6.11:
UAPI Changes:
- Deprecate DRM date and return a 0 date in DRM_IOCTL_VERSION
Core Changes:
- connector: Create a set of helpers to help with HDMI support
- fbdev: Create memory manager
With the refactoring in the file, some excessive includes were left
behind and are now unnecessary. Remove.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_clock_gating.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_clock_gating.c
b/drivers/gpu/drm
With the register header refactoring, some of the includes of i915_reg.h
have become unnecessary. Remove.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/dvo_ns2501.c | 1 -
drivers/gpu/drm/i915/display/intel_atomic.c | 1 -
drivers/gpu/drm/i915/display/intel_atomic_pla
On 27.05.24 15:50, Jani Nikula wrote:
>
> Hi all, the Intel graphics CI hits a lockdep issue with commit
> 86167183a17e ("igc: fix a log entry using uninitialized netdev") in
> v6.10-rc1.
FWIW, there is a earlier regression report bisected to that commit id:
https://lore.kernel.org/lkml/cabxgcsok
Hi Dave & Sima -
drm-intel-fixes-2024-05-30:
drm/i915 fixes for v6.10-rc2:
- Fix a race in audio component by registering it later
- Make DPT object unshrinkable to avoid shrinking when framebuffer has
not shrunk
- Fix CCS id calculation to fix a perf regression
- Fix selftest caching mode
- F
On Wed, 29 May 2024, Matt Roper wrote:
> On Tue, May 28, 2024 at 05:24:56PM +0300, Jani Nikula wrote:
>> Initialize fsb frequency for more platforms to be able to use it for GT
>> clock and rawclk frequency initialization.
>>
>> Note: There's a discrepancy between existing pnv_fsb_freq() and
>> i
On Wed, 29 May 2024, Matt Roper wrote:
> On Tue, May 28, 2024 at 05:24:55PM +0300, Jani Nikula wrote:
>> We'll want to use fsb frequency for deriving GT clock and rawclk
>> frequencies in the future. Increase the accuracy by converting to
>> kHz. Do the same for mem freq to be aligned.
>>
>> Roun
54 matches
Mail list logo
