== Series Details ==
Series: Documentation/i915: remove kernel-doc for DMC wakelocks
URL : https://patchwork.freedesktop.org/series/133435/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14746_full -> Patchwork_133435v1_full
On Tuesday, May 7, 2024 3:56:57 PM PDT Matt Roper wrote:
> On Mon, May 06, 2024 at 09:52:35PM +0300, Juha-Pekka Heikkila wrote:
> > These patches introduce I915_FORMAT_MOD_4_TILED_XE2_CCS modifier, which,
> > from the kernel's perspective, behaves similarly to
`I915_FORMAT_MOD_4_TILED`.
> > This n
Reviewed-by: Lyude Paul
On Fri, 2024-05-10 at 18:08 +0300, Jani Nikula wrote:
> Prefer the parsed results for is_hdmi and has_audio in display info
> over
> calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(),
> respectively.
>
> Conveniently, this also removes the need to use edid_
On Mon, May 06, 2024 at 03:57:09PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> A bit of cleanup/refactoring around plane fb stuff.
> This is mainly prep work for a slightly bigger rework
> of alignment handling.
>
> Ville Syrjälä (9):
> drm/i915: Split gen2 vs. gen3 .max_stride()
>
== Series Details ==
Series: drm/i915: skl+ plane register stuff
URL : https://patchwork.freedesktop.org/series/133458/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14747 -> Patchwork_133458v1
Summary
---
**SUCCESS*
== Series Details ==
Series: drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups
URL : https://patchwork.freedesktop.org/series/133455/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14747 -> Patchwork_133455v1
Summary
--
== Series Details ==
Series: drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups
URL : https://patchwork.freedesktop.org/series/133455/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote:
>
> I've sent this some moths ago, let's try again...
>
> BR,
> Jani.
>
> Jani Nikula (6):
> drm/nouveau: convert to using is_hdmi and has_audio from display info
> drm/radeon: convert to using is_hdmi and has_audio from display info
> drm/
From: Ville Syrjälä
Having the plane WM/DDB regitster write functions in skl_watermarks.c
is rather annoying when trying to implement DSB based plane updates.
Move them into the respective files that handle all other plane
register writes. Less places where I need to worry about the DSB
vs. MMIO
From: Ville Syrjälä
Get rid of skl_ddb_entry_write() and skl_write_wm_level() and
just call intel_de_write_fw() directly.
This is prep work towards DSB based plane updates where these
wrappers are more of a hinderance.
Done with cocci mostly:
@@
expression D, R, L;
@@
- skl_write_wm_level(D, R,
From: Ville Syrjälä
Extract helpers to calculate the final wm/ddb register
values for skl+. Will allow me to more cleanly remove the
register write wrappers for these registers.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/skl_watermark.c | 29 +---
1 file chan
From: Ville Syrjälä
Currentluy every skl+ plane register defines some intermediate
macros to calculate the final register offset. Pull all of that
into common macros, simplifying the final register offset stuff
into just five defines:
- raw register offsets for the planes 1 and 2 on pipes A and B
From: Ville Syrjälä
A few extra tabs have snuck into the skl+ plane register bit
definitions. Remove them.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/dis
From: Ville Syrjälä
A couple of PLANE_WM bits were still using the hand
rolled (1<
---
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h
b/drivers/gpu/drm/i915/d
From: Ville Syrjälä
Rearrange the plane skl+ universal plane register definitions:
- keep everything related to the same register in one place
- sort based on register offset
- unify the whitespace/etc a bit
Signed-off-by: Ville Syrjälä
---
.../i915/display/skl_universal_plane_regs.h | 502 +
From: Ville Syrjälä
We only need register defines for the first two planes
on the first two pipes. Nuke everything else.
Signed-off-by: Ville Syrjälä
---
.../gpu/drm/i915/display/skl_universal_plane_regs.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/d
From: Ville Syrjälä
Stop hand rolling PLANE_CTL and PLANE_SURF for the third plane
and just use the real thing.
Cc: Zhenyu Wang
CC: Zhi Wang
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff -
From: Ville Syrjälä
Stop hand rolling PLANE_KEY*() register defines and just
use the real thing.
Cc: Zhenyu Wang
CC: Zhi Wang
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/dr
From: Ville Syrjälä
Stop hand rolling PLANE_AUX_OFFSET() and just use the real thing.
Cc: Zhenyu Wang
CC: Zhi Wang
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/gvt/handlers.c | 24 ++---
drivers/gpu/drm/i915/gvt/reg.h | 2 --
drivers/gpu/drm/i91
From: Ville Syrjälä
Stop hand rolling PLANE_AUX_DIST() and just use the real thing.
Cc: Zhenyu Wang
CC: Zhi Wang
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/gvt/handlers.c | 24 ++---
drivers/gpu/drm/i915/gvt/reg.h | 1 -
drivers/gpu/drm/i915/i
From: Ville Syrjälä
On SKL+ the watermark/DDB registers are proper per-plane
registers. Move the definitons to their respective files.
Cc: Zhenyu Wang
CC: Zhi Wang
Signed-off-by: Ville Syrjälä
---
.../gpu/drm/i915/display/intel_cursor_regs.h | 20 +
.../i915/display/skl_universal_plane_
From: Ville Syrjälä
Move most cursor register definitions into their own file.
Declutters i915_reg.h a bit more.
Cc: Zhenyu Wang
CC: Zhi Wang
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_cursor.c | 1 +
.../gpu/drm/i915/display/intel_cursor_regs.h | 78
From: Ville Syrjälä
Move most of the SKL+ universal plane register definitions
into their own file. Declutters i915_reg.h a bit more.
Cc: Zhenyu Wang
CC: Zhi Wang
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 1 +
.../gpu/drm/i915/display/intel_dpt_common
From: Ville Syrjälä
_MMIO_PLANE_GAMC() is some leftover macro that is never used.
Get rid of it.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_reg.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 256d73c
From: Ville Syrjälä
Bunch of refactoring around skl+ plane registers.
Ville Syrjälä (16):
drm/i915: Nuke _MMIO_PLANE_GAMC()
drm/i915: Extract skl_universal_plane_regs.h
drm/i915: Extract intel_cursor_regs.h
drm/i915: Move skl+ wm/ddb registers to proper headers
drm/i915/gvt: Use the pr
Accessing the EDID via edid_blob_ptr causes chicken-and-egg
problems. Keep edid_blob_ptr as the userspace interface that should be
accessed via dedicated functions.
Signed-off-by: Jani Nikula
---
include/drm/drm_connector.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a
Add a helper to get the EDID property for sysfs property show. This
hides all the edid_blob_ptr usage within drm_edid.c.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 2 ++
drivers/gpu/drm/drm_edid.c | 33 +
drivers/gpu/drm/drm_sysfs.c
amdgpu_connector_edid() copies the EDID from edid_blob_ptr as a side
effect if amdgpu_connector->edid isn't initialized. However, everywhere
that the returned EDID is used, the EDID should have been set
beforehands.
Only the drm EDID code should look at the EDID property, anyway, so stop
using it.
radeon_connector_edid() copies the EDID from edid_blob_ptr as a side
effect if radeon_connector->edid isn't initialized. However, everywhere
that the returned EDID is used, the EDID should have been set
beforehands.
Only the drm EDID code should look at the EDID property, anyway, so stop
using it.
Prefer the parsed results for is_hdmi and has_audio in display info over
calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(),
respectively.
Cc: Alex Deucher
Cc: Christian König
Cc: Pan, Xinhui
Cc: amd-...@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/radeon
Prefer the parsed results for is_hdmi and has_audio in display info over
calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(),
respectively.
Conveniently, this also removes the need to use edid_blob_ptr.
v2: Reverse a backwards if condition (Ilia)
Cc: Karol Herbst
Cc: Lyude Paul
Cc
I've sent this some moths ago, let's try again...
BR,
Jani.
Jani Nikula (6):
drm/nouveau: convert to using is_hdmi and has_audio from display info
drm/radeon: convert to using is_hdmi and has_audio from display info
drm/radeon: remove radeon_connector_edid() and stop using
edid_blob_ptr
Merged and pushed out.
https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/210
josh
On Thu, May 9, 2024 at 1:47 PM Gustavo Sousa wrote:
>
> The following changes since commit 93f329774542b9b7d57abb18ea8b6542f2d8feac:
>
> Merge branch 'robot/pr-0-1709214990' into 'main' (2024-02
== Series Details ==
Series: drm/i915/bmg: Load DMC
URL : https://patchwork.freedesktop.org/series/133452/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14747 -> Patchwork_133452v1
Summary
---
**SUCCESS**
No regre
Load Battlemage's DMC. We re-use XELPDP_DMC_MAX_FW_SIZE since BMG's
display is a derivative of Xe_LPD+ and has the same MMIO offset limits.
Signed-off-by: Gustavo Sousa
---
drivers/gpu/drm/i915/display/intel_dmc.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/dis
On Fri, 10 May 2024, Jani Nikula wrote:
> This is a spin-off from [1], including just the PCI ID macro cleanups,
> as well as adding a bunch more cleanups.
>
> BR,
> Jani.
>
> [1] https://lore.kernel.org/all/cover.1715086509.git.jani.nik...@intel.com/
>
>
> Jani Nikula (8):
> drm/i915/pciids: ad
On Fri, May 10, 2024 at 02:22:20PM +0300, Jani Nikula wrote:
> Most other PCI ID macros do not encode the gen in the name. Follow suit
> for TGL.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
> arch/x86/kernel/early-quirks.
On Fri, May 10, 2024 at 02:22:19PM +0300, Jani Nikula wrote:
> Most other PCI ID macros do not encode the gen in the name. Follow suit
> for ICL.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
> arch/x86/kernel/early-quirks.
On Fri, May 10, 2024 at 02:22:18PM +0300, Jani Nikula wrote:
> It's confusing for INTEL_CFL_IDS() to include all WHL and CML PCI
> IDs. Even if we treat them the same in a lot of places, CML is a
> platform of its own, and the lists of PCI IDs should not conflate them.
>
> Largely go by the idea t
On Fri, May 10, 2024 at 02:22:17PM +0300, Jani Nikula wrote:
> Add INTEL_IVB_IDS() to identify all IVBs except IVB Q transcode.
>
Reviewed-by: Rodrigo Vivi
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
> arch/x86/kernel/early-quirks.c
On Fri, May 10, 2024 at 02:22:16PM +0300, Jani Nikula wrote:
> Add INTEL_SNB_IDS() to identify all SNBs.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
> arch/x86/kernel/early-quirks.c | 3 +--
> drivers
On Fri, May 10, 2024 at 02:22:15PM +0300, Jani Nikula wrote:
> Most other PCI ID macros use platform acronyms. Follow suit for ILK. Add
> INTEL_ILK_IDS() to identify all ILKs.
Reviewed-by: Rodrigo Vivi
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
> ---
>
On Fri, May 10, 2024 at 02:22:14PM +0300, Jani Nikula wrote:
> Most other PCI ID macros use platform acronyms. Follow suit for PNV. Add
> INTEL_PNV_IDS() to identify all PNVs.
>
> Cc: Bjorn Helgaas
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
>
== Series Details ==
Series: drm/i915/pciids: PCI ID macro cleanups
URL : https://patchwork.freedesktop.org/series/133444/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14747 -> Patchwork_133444v1
Summary
---
**SUCCE
== Series Details ==
Series: drm/i915/pciids: PCI ID macro cleanups
URL : https://patchwork.freedesktop.org/series/133444/
State : warning
== Summary ==
Error: dim checkpatch failed
74c4a4b08b9b drm/i915/pciids: add INTEL_PNV_IDS(), use acronym
-:72: ERROR:COMPLEX_MACRO: Macros with complex va
On Thu, 09 May 2024, Arun R Murthy wrote:
> uhbr13.5 is not supported on dg2/mtl. This patch removes the pll state
> table for synps and c20 PHY.
>
> Signed-off-by: Arun R Murthy
> ---
> drivers/gpu/drm/i915/display/intel_cx0_phy.c | 26 --
> drivers/gpu/drm/i915/display/intel_dp.c
== Series Details ==
Series: drm/i915: Plane fb refactoring (rev3)
URL : https://patchwork.freedesktop.org/series/133231/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14747 -> Patchwork_133231v3
Summary
---
**SUCCES
== Series Details ==
Series: series starting with [1/2] drm/xe/display: remove unused
xe->enabled_irq_mask
URL : https://patchwork.freedesktop.org/series/133441/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14747 -> Patchwork_133441v1
== Series Details ==
Series: Panel replay selective update support (rev11)
URL : https://patchwork.freedesktop.org/series/128193/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14747 -> Patchwork_128193v11
Summary
---
== Series Details ==
Series: Panel replay selective update support (rev11)
URL : https://patchwork.freedesktop.org/series/128193/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Panel replay selective update support (rev11)
URL : https://patchwork.freedesktop.org/series/128193/
State : warning
== Summary ==
Error: dim checkpatch failed
4ce3205a70e0 drm/i915/psr: Rename has_psr2 as has_sel_update
2d9a71ec0767 drm/i915/display: Do not print
On Mon, 06 May 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Rename the fb pinning functions such that their name directly
> informs us what gets pinned into which address space.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_dpt.c
On Fri, 10 May 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We use a mix of 'intel_fb' vs. 'ifbdev->fb' in the same function.
> Both should be pointing at the same thing. Make things less
> confusing by just getting existing fb from 'ifbdev->fb' at the
> start and then sticking with the l
On Fri, 10 May 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Change intel_fbdev_fb_alloc() to return struct intel_fb instead
> of struct drm_framebuffer. Let's us eliminate some annoying
> aliasing variables in the fbdev setup code.
>
> v2: Assing the results to the correct variable (Jani)
On 10-05-2024 15:13, Jani Nikula wrote:
The xe->enabled_irq_mask member has never been used for anything.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/xe/display/xe_display.c | 1 -
drivers/gpu/drm/xe/xe_device_types.h| 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/gpu
On 10-05-2024 15:13, Jani Nikula wrote:
Nothing in xe needs xe->sb_lock. None of the i915 display code using
->sb_lock gets built with xe, and in any case that would be wrong as xe
uses gt->pcode.lock for this.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/xe/display/xe_display.c | 2 --
dr
On Fri, 10 May 2024, Ville Syrjälä wrote:
> On Fri, May 10, 2024 at 01:24:12PM +0300, Jani Nikula wrote:
>> On Wed, 08 May 2024, Ville Syrjälä wrote:
>> > On Wed, May 08, 2024 at 02:45:10PM +0300, Jani Nikula wrote:
>> >> On Wed, 08 May 2024, Ville Syrjälä wrote:
>> >> > On Tue, May 07, 2024 at
It's confusing for INTEL_RPLP_IDS() to include INTEL_RPLU_IDS(). Even if
we treat them the same elsewhere, the lists of PCI IDs should not.
Cc: Bjorn Helgaas
Cc: linux-...@vger.kernel.org
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c
Most other PCI ID macros do not encode the gen in the name. Follow suit
for TGL.
Cc: Bjorn Helgaas
Cc: linux-...@vger.kernel.org
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c | 2 +-
drivers/gpu/drm/i915/display/intel_display_device.c | 2 +-
drivers/gpu/d
Most other PCI ID macros do not encode the gen in the name. Follow suit
for ICL.
Cc: Bjorn Helgaas
Cc: linux-...@vger.kernel.org
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c | 2 +-
drivers/gpu/drm/i915/display/intel_display_device.c | 2 +-
drivers/gpu/drm
It's confusing for INTEL_CFL_IDS() to include all WHL and CML PCI
IDs. Even if we treat them the same in a lot of places, CML is a
platform of its own, and the lists of PCI IDs should not conflate them.
Largely go by the idea that if a platform has a name, group its PCI IDs
together.
That said, A
Add INTEL_SNB_IDS() to identify all SNBs.
Cc: Bjorn Helgaas
Cc: linux-...@vger.kernel.org
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c | 3 +--
drivers/gpu/drm/i915/display/intel_display_device.c | 3 +--
include/drm/i915_pciids.h
Add INTEL_IVB_IDS() to identify all IVBs except IVB Q transcode.
Cc: Bjorn Helgaas
Cc: linux-...@vger.kernel.org
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c | 3 +--
drivers/gpu/drm/i915/display/intel_display_device.c | 3 +--
include/drm/i915_pciids.h
Most other PCI ID macros use platform acronyms. Follow suit for ILK. Add
INTEL_ILK_IDS() to identify all ILKs.
Cc: Bjorn Helgaas
Cc: linux-...@vger.kernel.org
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c | 3 +--
drivers/gpu/drm/i915/display/intel_display_d
Most other PCI ID macros use platform acronyms. Follow suit for PNV. Add
INTEL_PNV_IDS() to identify all PNVs.
Cc: Bjorn Helgaas
Cc: linux-...@vger.kernel.org
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c | 3 +--
drivers/gpu/drm/i915/display/intel_display_d
This is a spin-off from [1], including just the PCI ID macro cleanups,
as well as adding a bunch more cleanups.
BR,
Jani.
[1] https://lore.kernel.org/all/cover.1715086509.git.jani.nik...@intel.com/
Jani Nikula (8):
drm/i915/pciids: add INTEL_PNV_IDS(), use acronym
drm/i915/pciids: add INTEL
> -Original Message-
> From: Hogander, Jouni
> Sent: Friday, May 10, 2024 3:08 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Hogander, Jouni
>
> Subject: [PATCH v10 08/12] drm/i915/psr: Panel replay uses SRD_STATUS to
> track it's status
>
> DP Panel replay uses SRD_S
== Series Details ==
Series: Documentation/i915: remove kernel-doc for DMC wakelocks
URL : https://patchwork.freedesktop.org/series/133435/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14746 -> Patchwork_133435v1
Summary
-
On Fri, May 10, 2024 at 01:24:12PM +0300, Jani Nikula wrote:
> On Wed, 08 May 2024, Ville Syrjälä wrote:
> > On Wed, May 08, 2024 at 02:45:10PM +0300, Jani Nikula wrote:
> >> On Wed, 08 May 2024, Ville Syrjälä wrote:
> >> > On Tue, May 07, 2024 at 09:47:16AM -0400, Rodrigo Vivi wrote:
> >> >> On
On Fri, 2024-05-10 at 12:45 +0300, Jani Nikula wrote:
> On Fri, 10 May 2024, Jouni Högander wrote:
> > Add definitions for panel replay selective update
> >
> > v2: Remove unnecessary Cc from commit message
> >
> > Signed-off-by: Jouni Högander
> > Reviewed-by: Animesh Manna
>
> Needs to be C
On Wed, 08 May 2024, Ville Syrjälä wrote:
> On Wed, May 08, 2024 at 02:45:10PM +0300, Jani Nikula wrote:
>> On Wed, 08 May 2024, Ville Syrjälä wrote:
>> > On Tue, May 07, 2024 at 09:47:16AM -0400, Rodrigo Vivi wrote:
>> >> On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote:
>> >> > It's
From: Ville Syrjälä
We use a mix of 'intel_fb' vs. 'ifbdev->fb' in the same function.
Both should be pointing at the same thing. Make things less
confusing by just getting existing fb from 'ifbdev->fb' at the
start and then sticking with the local 'fb' (renamed from the
'intel_fb') until the very
From: Ville Syrjälä
Change intel_fbdev_fb_alloc() to return struct intel_fb instead
of struct drm_framebuffer. Let's us eliminate some annoying
aliasing variables in the fbdev setup code.
v2: Assing the results to the correct variable (Jani)
Fix xe's copy
Signed-off-by: Ville Syrjälä
---
On Fri, 10 May 2024, Jouni Högander wrote:
> Add definitions for panel replay selective update
>
> v2: Remove unnecessary Cc from commit message
>
> Signed-off-by: Jouni Högander
> Reviewed-by: Animesh Manna
Needs to be Cc: dri-devel.
> ---
> include/drm/display/drm_dp.h | 6 ++
> 1 file
Nothing in xe needs xe->sb_lock. None of the i915 display code using
->sb_lock gets built with xe, and in any case that would be wrong as xe
uses gt->pcode.lock for this.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/xe/display/xe_display.c | 2 --
drivers/gpu/drm/xe/xe_device_types.h| 3 --
The xe->enabled_irq_mask member has never been used for anything.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/xe/display/xe_display.c | 1 -
drivers/gpu/drm/xe/xe_device_types.h| 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/display/xe_display.c
b/drivers/gpu/drm
Part of intel_psr2_config_valid is valid for panel replay. rename it as
intel_sel_update_config_valid. Split psr2 specific part and name it as
intel_psr2_config_valid.
v3:
- move early transport check to psr2 specific check
- check intel_psr2_config_valid only for non-Panel Replay case
v2:
-
Add panel replay selective update support to debugfs status interface. In
case of sink supporting panel replay we will print out:
Sink support: PSR = no, Panel Replay = yes, Panel Replay Selective Update = yes
and PSR mode will look like this if printing out enabled panel replay
selective update:
We are re-using PSR module parameters for panel replay. Update module
parameter descriptions with panel replay information:
enable_psr:
-1 (default) == follow what is in VBT
0 == disable PSR/PR
1 == Allow PSR1 and PR full frame update
2 == allow PSR1/PSR2 and PR Selective Update
enable_psr2_sel_
There are some workarounds that are not applicable for panel replay. Do not
apply these if panel replay is used.
Bspec: 66624, 50422
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_fbc.c | 5 +++--
drivers/gpu/drm/i915/display/intel_hdmi.c | 3
DP Panel replay uses SRD_STATUS to track it's status despite selective
update mode.
Bspec: 53370, 68920
v4:
- use PSR2_STATUS for eDP Panel Replay
- handle intel_psr_wait_exit_locked as well
v3:
- do not use PSR2_STATUS for PSR1
v2:
- use intel_dp_is_edp to differentiate
- modify debugf
Currently intel_dp_get_su_granularity doesn't support panel replay.
This fix modifies it to support panel replay as well.
v4:
- use drm_dp_dpcd_readb instead of drm_dp_dpcd_read
- ensure return value is 0 if drm_dp_dpcd_readb fails
v3: use correct offset for DP_PANEL_PANEL_REPLAY_CAPABILITY
v2
Add new boolean to store panel replay selective update support of sink into
intel_psr struct. Detect panel replay selective update support and store
it into this new boolean.
v3: Clear sink_panel_replay_su_support in intel_dp_detect
v2: Merge adding new boolean into this patch
Signed-off-by: Jou
After setting has_psr for panel replay as well crtc state dump is
improperly printing "psr: enabled" for Panel Replay as well. Fix this by
checking also has_panel_replay.
Fixes: 5afa6e496098 ("drm/i915/psr: Set intel_crtc_state->has_psr on panel
replay as well")
Signed-off-by: Jouni Högander
Rev
Add definitions for panel replay selective update
v2: Remove unnecessary Cc from commit message
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
include/drm/display/drm_dp.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/drm/display/drm_dp.h b/include/drm/display
We are about to enable Panel Replay Selective update mode. Vsc revision 0x6
for Panel Replay no matter if it is selective update or full frame update
mode. Take this into account when preparing VSC SDP package.
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
drivers/gpu/drm/i915/di
We are going to reuse has_psr2 for panel_replay as well. Rename it
as has_sel_update to avoid confusion.
v3: do not add has_psr check into psr2 case in intel_dp_compute_vsc_sdp
v2: Rebase
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_crtc_state
We are about to reuse psr2_enabled for panel replay as well. Rename
it as sel_update_enabled to avoid confusion.
v3: Rebase
v2: Rebase
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
.../drm/i915/display/intel_display_types.h| 2 +-
drivers/gpu/drm/i915/display/intel_psr.c
This patch set is implementing panel replay selective update support
for Intel hardware.
v10:
- use always PSR2_STATUS for eDP Panel Replay
- handle SRD_STATUS vs. PSR2_STATUS in intel_psr_wait_exit_locked as well
v9:
- do not add has_psr check into psr2 case in intel_dp_compute_vsc_sdp
-
On Wed, 08 May 2024, Ville Syrjälä wrote:
> On Tue, May 07, 2024 at 11:53:40AM +0300, Jani Nikula wrote:
>> On Mon, 06 May 2024, Ville Syrjala wrote:
>> > From: Ville Syrjälä
>> >
>> > For some reason xe and i915 each have an identical (fortunately)
>> > copy of intel_fbdev_fb.h. The xe copy act
On Fri, 10 May 2024, "Lin, Wayne" wrote:
> [Public]
>
>> -Original Message-
>> From: Limonciello, Mario
>> Sent: Friday, May 10, 2024 3:18 AM
>> To: Linux regressions mailing list ; Wentland,
>> Harry
>> ; Lin, Wayne
>> Cc: ly...@redhat.com; imre.d...@intel.com; Leon Weiß > bochum.de>;
On Fri, 2024-05-10 at 12:21 +0300, Jani Nikula wrote:
> On Fri, 10 May 2024, Luca Coelho wrote:
> > The function descriptions are optional and have not yet been added to
> > the DMC wakelock code, so we shouldn't try to use it. Since this is a
> > regression, remove the kernel-doc entry for DMC w
On Fri, 10 May 2024, Luca Coelho wrote:
> The function descriptions are optional and have not yet been added to
> the DMC wakelock code, so we shouldn't try to use it. Since this is a
> regression, remove the kernel-doc entry for DMC wakelocks for now.
> The proper documentation will be added in
The function descriptions are optional and have not yet been added to
the DMC wakelock code, so we shouldn't try to use it. Since this is a
regression, remove the kernel-doc entry for DMC wakelocks for now.
The proper documentation will be added in a future patch.
Fixes: 765425f598c2 ("drm/i915/d
On Thu, 09 May 2024, Rodrigo Vivi wrote:
> On Wed, May 08, 2024 at 06:47:50PM +0300, Jani Nikula wrote:
>> Avoid the implicit dev_priv local variable use, and pass dev_priv
>> explicitly to the TRANS_VRR_VMAXSHIFT register macro.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/i
Hi Dave, Sima,
this is the weekly drm-misc-fixes PR. Sorry for being late.
Best regards
Thomas
drm-misc-fixes-2024-05-10:
Short summary of fixes pull:
core:
- fix connector debugging output
meson:
- dw-hdmi: power-up fixes
- dw-hdmi: add badngap setting for g12
The following changes since comm
96 matches
Mail list logo
