✓ Fi.CI.IGT: success for drm/edid: Parse topology block for all DispID structure v1.x (rev2)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/edid: Parse topology block for all DispID structure v1.x (rev2) URL : https://patchwork.freedesktop.org/series/132292/ State : success == Summary == CI Bug Log - changes from CI_DRM_14617_full -> Patchwork_132292v2_full =

✓ Fi.CI.BAT: success for drm/edid: Parse topology block for all DispID structure v1.x (rev2)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/edid: Parse topology block for all DispID structure v1.x (rev2) URL : https://patchwork.freedesktop.org/series/132292/ State : success == Summary == CI Bug Log - changes from CI_DRM_14617 -> Patchwork_132292v2 ===

✗ Fi.CI.BAT: failure for drm/i915/gem: Downgrade stolen lmem setup warning

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915/gem: Downgrade stolen lmem setup warning URL : https://patchwork.freedesktop.org/series/132663/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14616 -> Patchwork_132663v1 Summary ---

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Downgrade stolen lmem setup warning

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915/gem: Downgrade stolen lmem setup warning URL : https://patchwork.freedesktop.org/series/132663/ State : warning == Summary == Error: dim checkpatch failed dc5960ccb539 drm/i915/gem: Downgrade stolen lmem setup warning -:12: WARNING:COMMIT_LOG_LONG_LINE: Pr

[PATCH] drm/i915/gem: Downgrade stolen lmem setup warning

2024-04-19 Thread Jonathan Cavitt
In the case where lmem_size < dsm_base, hardware is reporting that stolen lmem is unusable. In this case, instead of throwing a warning, we can continue execution as normal by disabling stolen LMEM support. For example, this change will allow the following error report from ATS-M to no longer appl

[linux-next:master] BUILD REGRESSION a35e92ef04c07bd473404b9b73d489aea19a60a8

2024-04-19 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a35e92ef04c07bd473404b9b73d489aea19a60a8 Add linux-next specific files for 20240419 Error/Warning: (recently discovered and may have been fixed) WARNING: modpost: vmlinux: section mismatch in

✓ Fi.CI.BAT: success for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev4)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev4) URL : https://patchwork.freedesktop.org/series/132390/ State : success == Summary == CI Bug Log - changes from CI_DRM_14616 -> Patchwork_132390v4 Summ

✗ Fi.CI.SPARSE: warning for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev4)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev4) URL : https://patchwork.freedesktop.org/series/132390/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/in

✗ Fi.CI.CHECKPATCH: warning for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev4)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev4) URL : https://patchwork.freedesktop.org/series/132390/ State : warning == Summary == Error: dim checkpatch failed 9d4d94ee42bd drm/i915/dpio: Clean up bxt/glk PHY registers c9e16261ad26 drm/i915/dpio: Add

✓ Fi.CI.BAT: success for drm/xe: avoid the async_flip update in the initial plane config

2024-04-19 Thread Patchwork
== Series Details == Series: drm/xe: avoid the async_flip update in the initial plane config URL : https://patchwork.freedesktop.org/series/132649/ State : success == Summary == CI Bug Log - changes from CI_DRM_14616 -> Patchwork_132649v1 S

Re: [PATCH v10 6/6] drm/i915/display: force qgv check after the hw state readout

2024-04-19 Thread Ville Syrjälä
On Fri, Apr 05, 2024 at 02:35:33PM +0300, Vinod Govindapillai wrote: > The current intel_bw_atomic_check do not check the possbility > of a sagv configuration change after the hw state readout. > Hence cannot update the sagv configuration until some other > relevant changes like data rates, number

Re: [PATCH v10 1/6] drm/i915/display: Add meaningful traces for QGV point info error handling

2024-04-19 Thread Ville Syrjälä
On Fri, Apr 05, 2024 at 02:35:28PM +0300, Vinod Govindapillai wrote: > From: Stanislav Lisovskiy > > For debug purposes we need those - error path won't flood the log, > however there has been already numerous cases, when due to lack > of debugs, we couldn't immediately tell what was the problem

Re: ✓ Fi.CI.BAT: success for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)

2024-04-19 Thread Ville Syrjälä
On Fri, Apr 19, 2024 at 11:31:29AM +0300, Jani Nikula wrote: > > Got the results in the middle of the night; Ville, please merge. :) Unfortunately GLK was AWOL at the time, so we didn't actually test anything :( I've hit the retest button for good measure. > > BR, > Jani. > > On Fri, 19 Apr 20

Re: [PATCH 4/6] drm/i915: Eliminate extra frame from skl-glk sync->async flip change

2024-04-19 Thread Ville Syrjälä
On Fri, Apr 19, 2024 at 06:39:48AM +, Murthy, Arun R wrote: > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Wednesday, March 20, 2024 9:34 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH 4/6] drm/i915: Eliminate extra frame from skl

Re: [PATCH 2/6] drm/i915: Reject async flips if we need to change DDB/watermarks

2024-04-19 Thread Ville Syrjälä
On Fri, Apr 19, 2024 at 04:27:53AM +, Murthy, Arun R wrote: > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Wednesday, March 20, 2024 9:34 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH 2/6] drm/i915: Reject async flips if we need

Re: [PATCH v2 0/5] drm/i915/dmc: firmware path handling changes

2024-04-19 Thread Lucas De Marchi
On Fri, Apr 19, 2024 at 12:41:53PM GMT, Jani Nikula wrote: v2 of https://lore.kernel.org/r/cover.1713450693.git.jani.nik...@intel.com Jani Nikula (5): drm/i915/dmc: handle request_firmware() errors separately drm/i915/dmc: improve firmware parse failure propagation drm/i915/dmc: split out per

Re: [PATCH 1/6] drm/i915: Align PLANE_SURF to 16k on ADL for async flips

2024-04-19 Thread Ville Syrjälä
On Fri, Apr 19, 2024 at 04:20:40AM +, Murthy, Arun R wrote: > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Wednesday, March 20, 2024 9:34 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH 1/6] drm/i915: Align PLANE_SURF to 16k on ADL

Re: ✗ Fi.CI.IGT: failure for drm/i915/dp: Few MTL/DSC and a UHBR monitor fix (rev4)

2024-04-19 Thread Imre Deak
On Thu, Apr 18, 2024 at 12:22:53PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Few MTL/DSC and a UHBR monitor fix (rev4) > URL : https://patchwork.freedesktop.org/series/131386/ > State : failure I pushed the patchset to drm-intel-next, amending the code comment in p

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-04-19 Thread Maxime Ripard
On Fri, Apr 19, 2024 at 05:09:29PM +0300, Jani Nikula wrote: > On Fri, 19 Apr 2024, Maxime Ripard wrote: > > On Fri, Apr 19, 2024 at 03:35:55PM +0300, Jani Nikula wrote: > >> On Thu, 04 Apr 2024, "Nautiyal, Ankit K" > >> wrote: > >> > On 3/19/2024 3:16 PM, Maxime Ripard wrote: > >> >> On Mon, Ma

[PATCH v1] drm/xe: avoid the async_flip update in the initial plane config

2024-04-19 Thread Vinod Govindapillai
Async flip call is not needed. The updated fb mapping is updated as part of the fixup_initial_plane_config() call. Otherwise we end up updating the PLAN_SURF register twice with the same info. v2: avoid async_flip instead of removing fixup call (Ville) Signed-off-by: Vinod Govindapillai --- dri

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-04-19 Thread Jani Nikula
On Fri, 19 Apr 2024, Maxime Ripard wrote: > On Fri, Apr 19, 2024 at 03:35:55PM +0300, Jani Nikula wrote: >> On Thu, 04 Apr 2024, "Nautiyal, Ankit K" wrote: >> > On 3/19/2024 3:16 PM, Maxime Ripard wrote: >> >> On Mon, Mar 18, 2024 at 04:37:58PM +0200, Jani Nikula wrote: >> >>> On Mon, 11 Mar 2024

Re: [PATCH] drm/dp: Fix documentation of DP tunnel functions

2024-04-19 Thread Imre Deak
On Fri, Apr 19, 2024 at 03:40:39PM +0300, Jani Nikula wrote: > On Wed, 28 Feb 2024, Imre Deak wrote: > > Fix the documentation issues below, also reported by 'make htmldocs': > > > > drivers/gpu/drm/display/drm_dp_tunnel.c:447: warning: Function parameter or > > struct member 'tunnel' not describ

Re: [PATCH v10 0/6] QGV/SAGV related fixes

2024-04-19 Thread Govindapillai, Vinod
On Fri, 2024-04-19 at 08:42 +, Hogander, Jouni wrote: > On Fri, 2024-04-05 at 14:35 +0300, Vinod Govindapillai wrote: > > We have couple of customer issues, related to SAGV/QGV point > > calculation. Those patches contain fixes plus some additional > > debugs for those issues. > > For the whol

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-04-19 Thread Maxime Ripard
On Fri, Apr 19, 2024 at 03:35:55PM +0300, Jani Nikula wrote: > On Thu, 04 Apr 2024, "Nautiyal, Ankit K" wrote: > > On 3/19/2024 3:16 PM, Maxime Ripard wrote: > >> On Mon, Mar 18, 2024 at 04:37:58PM +0200, Jani Nikula wrote: > >>> On Mon, 11 Mar 2024, Mitul Golani > >>> wrote: > An Adaptiv

✗ Fi.CI.BAT: failure for Panel replay selective update support (rev7)

2024-04-19 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev7) URL : https://patchwork.freedesktop.org/series/128193/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14612 -> Patchwork_128193v7 Summary --- *

Re: [PATCH] drm/dp: Fix documentation of DP tunnel functions

2024-04-19 Thread Jani Nikula
On Wed, 28 Feb 2024, Imre Deak wrote: > Fix the documentation issues below, also reported by 'make htmldocs': > > drivers/gpu/drm/display/drm_dp_tunnel.c:447: warning: Function parameter or > struct member 'tunnel' not described in 'drm_dp_tunnel_put' > drivers/gpu/drm/display/drm_dp_tunnel.c:447

✗ Fi.CI.SPARSE: warning for Panel replay selective update support (rev7)

2024-04-19 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev7) URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev7)

2024-04-19 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev7) URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim checkpatch failed 3122e5718521 drm/i915/psr: Rename has_psr2 as has_sel_update -:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-04-19 Thread Jani Nikula
On Thu, 04 Apr 2024, "Nautiyal, Ankit K" wrote: > On 3/19/2024 3:16 PM, Maxime Ripard wrote: >> On Mon, Mar 18, 2024 at 04:37:58PM +0200, Jani Nikula wrote: >>> On Mon, 11 Mar 2024, Mitul Golani >>> wrote: An Adaptive-Sync-capable DP protocol converter indicates its support by settin

Re: [PATCH v2 4/5] drm/i915/dmc: change how to disable DMC firmware using module param

2024-04-19 Thread Gustavo Sousa
Quoting Jani Nikula (2024-04-19 06:41:57-03:00) >The distinction between the dmc_firmware_path module param being NULL >and the empty string "" is problematic. It's not possible to set the >parameter back to NULL via sysfs or debugfs. Remove the distinction, and >consider NULL and the empty string

Re: [PULL] drm-intel-next

2024-04-19 Thread Maxime Ripard
Hi, On Wed, Apr 17, 2024 at 09:38:55AM -0400, Rodrigo Vivi wrote: > Another thing that it is important to highlight is that we have 3 drm level > patches in this pull request where I didn't see any explicit recorded > ack from you (drm maintainers) nor from drm-misc maintainers. > The patches look

[PATCH v7 09/11] drm/i915/psr: Update PSR module parameter descriptions

2024-04-19 Thread Jouni Högander
We are re-using PSR module parameters for panel replay. Update module parameter descriptions with panel replay information: enable_psr: -1 (default) == follow what is in VBT 0 == disable PSR/PR 1 == Allow PSR1 and PR full frame update 2 == allow PSR1/PSR2 and PR Selective Update enable_psr2_sel_

[PATCH v7 11/11] drm/i915/psr: Add panel replay sel update support to debugfs interface

2024-04-19 Thread Jouni Högander
Add panel replay selective update support to debugfs status interface. In case of sink supporting panel replay we will print out: Sink support: PSR = no, Panel Replay = yes, Panel Replay Selective Update = yes and PSR mode will look like this if printing out enabled panel replay selective update:

[PATCH v7 10/11] drm/i915/psr: Split intel_psr2_config_valid for panel replay

2024-04-19 Thread Jouni Högander
Part of intel_psr2_config_valid is valid for panel replay. rename it as intel_sel_update_config_valid. Split psr2 specific part and name it as intel_psr2_config_valid. v3: - move early transport check to psr2 specific check - check intel_psr2_config_valid only for non-Panel Replay case v2: -

[PATCH v7 08/11] drm/i915/psr: Do not apply workarounds in case of panel replay

2024-04-19 Thread Jouni Högander
There are some workarounds that are not applicable for panel replay. Do not apply these if panel replay is used. Bspec: 66624, 50422 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fbc.c | 5 +++-- drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++- drivers/gpu/drm/i915/d

[PATCH v7 07/11] drm/i915/psr: Panel replay uses SRD_STATUS to track it's status

2024-04-19 Thread Jouni Högander
DP Panel replay uses SRD_STATUS to track it's status despite selective update mode. Bspec: 53370, 68920 v3: - do not use PSR2_STATUS for PSR1 v2: - use intel_dp_is_edp to differentiate - modify debugfs status as well Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_ps

[PATCH v7 06/11] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay

2024-04-19 Thread Jouni Högander
Currently intel_dp_get_su_granularity doesn't support panel replay. This fix modifies it to support panel replay as well. v2: rely on PSR definitions on common bits Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_psr.c | 62 +-

[PATCH v7 02/11] drm/i915/dp: Use always vsc revision 0x6 for Panel Replay

2024-04-19 Thread Jouni Högander
We are about to enable Panel Replay Selective update mode. Vsc revision 0x6 for Panel Replay no matter if it is selective update or full frame update mode. Take this into account when preparing VSC SDP package. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_dp.c | 16 ++

[PATCH v7 03/11] drm/i915/psr: Rename psr2_enabled as sel_update_enabled

2024-04-19 Thread Jouni Högander
We are about to reuse psr2_enabled for panel replay as well. Rename it as sel_update_enabled to avoid confusion. v3: Rebase v2: Rebase Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna --- .../drm/i915/display/intel_display_types.h| 2 +- drivers/gpu/drm/i915/display/intel_psr.c

[PATCH v7 05/11] drm/i915/psr: Detect panel replay selective update support

2024-04-19 Thread Jouni Högander
Add new boolean to store panel replay selective update support of sink into intel_psr struct. Detect panel replay selective update support and store it into this new boolean. v3: Clear sink_panel_replay_su_support in intel_dp_detect v2: Merge adding new boolean into this patch Signed-off-by: Jou

[PATCH v7 04/11] drm/panelreplay: dpcd register definition for panelreplay SU

2024-04-19 Thread Jouni Högander
Add definitions for panel replay selective update v2: Remove unnecessary Cc from commit message Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna --- include/drm/display/drm_dp.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display

[PATCH v7 01/11] drm/i915/psr: Rename has_psr2 as has_sel_update

2024-04-19 Thread Jouni Högander
We are going to reuse has_psr2 for panel_replay as well. Rename it as has_sel_update to avoid confusion. v2: Rebase Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 10 +- drivers/gpu/drm/i915/display/intel_display.c

[PATCH v7 00/11] Panel replay selective update support

2024-04-19 Thread Jouni Högander
This patch set is implementing panel replay selective update support for Intel hardware. v7: - use always vsc revision 0x6 for Panel Replay v6: - fixes split to separate patch set v5: - do not use PSR2_STATUS for PSR1 v4: - do not rename intel_psr_enabled - do not add sel_update_et_enabl

Re: ✗ Fi.CI.BAT: failure for drm/i915/dsi: stop relying on implicit dev_priv variable (rev2)

2024-04-19 Thread Jani Nikula
On Fri, 19 Apr 2024, Patchwork wrote: > == Series Details == > > Series: drm/i915/dsi: stop relying on implicit dev_priv variable (rev2) > URL : https://patchwork.freedesktop.org/series/132285/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14611 -> Patchwork_132285v2 >

[PULL] drm-misc-next

2024-04-19 Thread Maarten Lankhorst
Hi Dave, Sima, Bit late, but with slightly more content. Cheers, ~Maarten drm-misc-next-2024-04-19: drm-misc-next for v6.10-rc1: UAPI Changes: - Add SIZE_HINTS property for cursor planes. Cross-subsystem Changes: Core Changes: - Document the requirements and expectations of adding new driv

✗ Fi.CI.BUILD: failure for drm/i915/dp: Use always vsc revision 0x6 for Panel Replay

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915/dp: Use always vsc revision 0x6 for Panel Replay URL : https://patchwork.freedesktop.org/series/132639/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/132639/revisions/1/mbox/ not applied Applying: drm/i915/dp

[PATCH] drm/i915/dp: Use always vsc revision 0x6 for Panel Replay

2024-04-19 Thread Jouni Högander
We want to use vsc revision 0x6 for Panel Replay no matter if it is selective update or full frame update mode. Fixes: 5afa6e496098 ("drm/i915/psr: Set intel_crtc_state->has_psr on panel replay as well") Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_dp.c | 16

✗ Fi.CI.BAT: failure for drm/i915/dsi: stop relying on implicit dev_priv variable (rev2)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915/dsi: stop relying on implicit dev_priv variable (rev2) URL : https://patchwork.freedesktop.org/series/132285/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14611 -> Patchwork_132285v2 S

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: stop relying on implicit dev_priv variable (rev2)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915/dsi: stop relying on implicit dev_priv variable (rev2) URL : https://patchwork.freedesktop.org/series/132285/ State : warning == Summary == Error: dim checkpatch failed aa3c68d4f30e drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition 0ba6f1a20ef

✗ Fi.CI.BAT: failure for drm/i915/dmc: firmware path handling changes (rev2)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915/dmc: firmware path handling changes (rev2) URL : https://patchwork.freedesktop.org/series/132609/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14611 -> Patchwork_132609v2 Summary -

✗ Fi.CI.SPARSE: warning for drm/i915/dmc: firmware path handling changes (rev2)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915/dmc: firmware path handling changes (rev2) URL : https://patchwork.freedesktop.org/series/132609/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: firmware path handling changes (rev2)

2024-04-19 Thread Patchwork
== Series Details == Series: drm/i915/dmc: firmware path handling changes (rev2) URL : https://patchwork.freedesktop.org/series/132609/ State : warning == Summary == Error: dim checkpatch failed 3d1c3762fcfb drm/i915/dmc: handle request_firmware() errors separately 73f10c70a834 drm/i915/dmc: i

[PATCH v2 4/4] drm/i915/dsi: pass display to register macros instead of implicit variable

2024-04-19 Thread Jani Nikula
Stop relying on the dev_priv local variable in the DSI register macros. Pass struct intel_display pointer to the macros. Move the MIPI DSI MMIO base selection to a different level, passing it to _MMIO_MIPI() and doing the addition there. Start using the local display variable for all intel_de_* us

[PATCH v2 3/4] drm/i915/dsi: unify connector/encoder type and name usage

2024-04-19 Thread Jani Nikula
Stop using struct drm_* local variables and parameters where possible. Drop the intel_ prefix from struct intel_encoder and intel_connector local variable and parameter names. Drop useless intermediate variables. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/vlv_dsi.c | 134 +++

[PATCH v2 2/4] drm/i915/dsi: add VLV_ prefix to VLV only register macros

2024-04-19 Thread Jani Nikula
All the BXT specific macros have BXT_ prefix, do the same for VLV for consistency. This is helpful because the platform specific macros can use the static MIPI MMIO base rather than dynamic. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/vlv_dsi.c | 6 +++--- drivers/gpu/drm/i9

[PATCH v2 1/4] drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition

2024-04-19 Thread Jani Nikula
There are other unused registers, but this is also unusable and inadequate. Remove. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/vlv_dsi_regs.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_regs.h b/drivers/gpu/drm/i915/display/vlv_dsi

[PATCH v2 0/4] drm/i915/dsi: stop relying on implicit dev_priv variable

2024-04-19 Thread Jani Nikula
v2 of [1], using struct intel_display * rather than struct drm_i915_private *. BR, Jani. [1] https://lore.kernel.org/r/cover.1712766927.git.jani.nik...@intel.com Jani Nikula (4): drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition drm/i915/dsi: add VLV_ prefix to VLV only register

Re: [PATCH 3/3] drm/i915: Fix gt reset with GuC submission disabled

2024-04-19 Thread Nirmoy Das
Hi John, On 4/19/2024 1:38 AM, John Harrison wrote: On 4/18/2024 10:10, Nirmoy Das wrote: Currently intel_gt_reset() happens as follows: reset_prepare() ---> Sends GDRST to GuC, GuC is in GS_MIA_IN_RESET do_reset()    intel_gt_reset_all_engines() *_engine_reset_prepare() -->RESET_CTL expe

[PATCH v2 5/5] drm/i915/display: move dmc_firmware_path to display params

2024-04-19 Thread Jani Nikula
The dmc_firmware_path parameter is clearly a display parameter. Move it there so it's available to both i915 and xe modules. This also cleans up the ugly member in struct xe_device. v2: - New try with the NULL/"" param value issue resolved Reviewed-by: Gustavo Sousa Signed-off-by: Jani Nikula -

[PATCH v2 3/5] drm/i915/dmc: split out per-platform firmware path selection

2024-04-19 Thread Jani Nikula
The big if ladder clutters intel_dmc_init(). Split it out to a separate function. Reviewed-by: Gustavo Sousa Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 96 +--- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i91

[PATCH v2 4/5] drm/i915/dmc: change how to disable DMC firmware using module param

2024-04-19 Thread Jani Nikula
The distinction between the dmc_firmware_path module param being NULL and the empty string "" is problematic. It's not possible to set the parameter back to NULL via sysfs or debugfs. Remove the distinction, and consider NULL and the empty string to be the same thing, and use the platform default f

[PATCH v2 2/5] drm/i915/dmc: improve firmware parse failure propagation

2024-04-19 Thread Jani Nikula
Return failures from parse_dmc_fw() instead of relying on intel_dmc_has_payload(). Handle and error report them slightly better, including a new error message for when the firmware does not contain the main program. v2: Print specific error message for payload not found (Gustavo) Reviewed-by: Gus

[PATCH v2 1/5] drm/i915/dmc: handle request_firmware() errors separately

2024-04-19 Thread Jani Nikula
Clarify request_firmware() error handling. Don't proceed to trying to parse non-existent firmware or check for payload when request_firmware() failed to begin with. There's no reason to release_firmware() either when request_firmware() failed. Also move the message about DMC firmware homepage here

[PATCH v2 0/5] drm/i915/dmc: firmware path handling changes

2024-04-19 Thread Jani Nikula
v2 of https://lore.kernel.org/r/cover.1713450693.git.jani.nik...@intel.com Jani Nikula (5): drm/i915/dmc: handle request_firmware() errors separately drm/i915/dmc: improve firmware parse failure propagation drm/i915/dmc: split out per-platform firmware path selection drm/i915/dmc: change h

Re: [PATCH] drm/i915: Convert intel_runtime_pm_get_noresume towards raw wakeref

2024-04-19 Thread Jani Nikula
On Fri, 19 Apr 2024, Imre Deak wrote: > On Thu, Apr 18, 2024 at 06:37:56PM -0400, Rodrigo Vivi wrote: >> In the past, the noresume function was used by the GEM code to ensure >> wakelocks were held and bump its usage. This is no longer the case >> and this function was totally unused until it star

Re: [PATCH 2/3] drm/i915 Rename intel_engine_reset to intel_gt_engine_recover

2024-04-19 Thread Nirmoy Das
Hi John, On 4/19/2024 1:27 AM, John Harrison wrote: On 4/18/2024 10:10, Nirmoy Das wrote: intel_engine_reset() not only reset a engine but also tries to recover it so give it a proper name without any functional changes. Not seeing what the difference is. If this was a super low level function

Re: [PATCH 1/3] drm/i915: Refactor confusing __intel_gt_reset()

2024-04-19 Thread Nirmoy Das
Hi John. On 4/19/2024 1:27 AM, John Harrison wrote: On 4/18/2024 10:10, Nirmoy Das wrote: __intel_gt_reset() is really for resetting engines though the name might suggest something else. So add two helper functions to remove confusions with no functional changes. Technically you only added one

Re: [PATCH v10 0/6] QGV/SAGV related fixes

2024-04-19 Thread Hogander, Jouni
On Fri, 2024-04-05 at 14:35 +0300, Vinod Govindapillai wrote: > We have couple of customer issues, related to SAGV/QGV point > calculation. Those patches contain fixes plus some additional > debugs for those issues. For the whole set (with assumption you take care of that one naming change suggest

RE: ✓ Fi.CI.BAT: success for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)

2024-04-19 Thread Jani Nikula
Got the results in the middle of the night; Ville, please merge. :) BR, Jani. On Fri, 19 Apr 2024, "Musial, Ewelina" wrote: > + @Grabski, Mateusz please check it > > Thanks, > Ewelina > > -Original Message- > From: Jani Nikula > Sent: Thursday, April 18, 2024 6:41 PM > To: Patchwork