✓ Fi.CI.BAT: success for drm/i915/hwmon: Get rid of devm (rev4)

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Get rid of devm (rev4) URL : https://patchwork.freedesktop.org/series/132400/ State : success == Summary == CI Bug Log - changes from CI_DRM_14583 -> Patchwork_132400v4 Summary --- **SUCCE

✓ Fi.CI.BAT: success for drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI URL : https://patchwork.freedesktop.org/series/132479/ State : success == Summary == CI Bug Log - changes from CI_DRM_14583 -> Patchwork_132479v1 Sum

Re: [PATCH v2] drm/i915/hwmon: Get rid of devm

2024-04-15 Thread Dixit, Ashutosh
On Mon, 15 Apr 2024 16:35:02 -0700, Armin Wolf wrote: > Hi Armin, > Am 16.04.24 um 00:36 schrieb Ashutosh Dixit: > > @@ -818,10 +818,10 @@ void i915_hwmon_register(struct drm_i915_private > > *i915) > > hwm_get_preregistration_info(i915); > > > > /* hwmon_dev points to device hwmon */ >

[PATCH v3] drm/i915/hwmon: Get rid of devm

2024-04-15 Thread Ashutosh Dixit
When both hwmon and hwmon drvdata (on which hwmon depends) are device managed resources, the expectation, on device unbind, is that hwmon will be released before drvdata. However, in i915 there are two separate code paths, which both release either drvdata or hwmon and either can be released before

[PATCH] drm/i915/hwmon: Get rid of devm

2024-04-15 Thread Ashutosh Dixit
When both hwmon and hwmon drvdata (on which hwmon depends) are device managed resources, the expectation, on device unbind, is that hwmon will be released before drvdata. However, in i915 there are two separate code paths, which both release either drvdata or hwmon and either can be released before

[PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-04-15 Thread Suraj Kandpal
Disable HDCP Line Rekeying when HDCP ver > 1.4 and when we are on HDMI TMDS operation for DISPLAY_VEY >= 14. WA: 16022217614 Bspec: 49273 Bspec: 69964 Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 16 drivers/gpu/drm/i915/i915_reg.h | 1

Re: [PATCH 3/8] drm/i915/dpio: Extract bxt_dpio_phy_regs.h

2024-04-15 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.9-rc4 next-20240415] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-15 Thread Rodrigo Vivi
On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote: > We defer actually closing, unbinding and destroying a VMA until next idle > point, or until the object is freed in the meantime. By postponing the > unbind, we allow for the VMA to be reopened by the client, avoiding the > work

Re: ✗ Fi.CI.IGT: failure for drm/edid & drm/i915: vendor and product id logging improvements (rev3)

2024-04-15 Thread Rodrigo Vivi
On Fri, Apr 12, 2024 at 11:06:09AM +0300, Jani Nikula wrote: > On Thu, 11 Apr 2024, Patchwork wrote: > > == Series Details == > > > > Series: drm/edid & drm/i915: vendor and product id logging improvements > > (rev3) > > URL : https://patchwork.freedesktop.org/series/131414/ > > State : failure

✓ Fi.CI.BAT: success for LNL GSC FW support

2024-04-15 Thread Patchwork
== Series Details == Series: LNL GSC FW support URL : https://patchwork.freedesktop.org/series/132474/ State : success == Summary == CI Bug Log - changes from CI_DRM_14582 -> Patchwork_132474v1 Summary --- **SUCCESS** No regressio

✗ Fi.CI.CHECKPATCH: warning for LNL GSC FW support

2024-04-15 Thread Patchwork
== Series Details == Series: LNL GSC FW support URL : https://patchwork.freedesktop.org/series/132474/ State : warning == Summary == Error: dim checkpatch failed 1acbf8036fe6 drm/xe/gsc: define GSCCS for LNL 9113c2e5907a drm/xe/gsc: Skip GSC proxy init 4b15e0c96fd0 drm/xe/gsc: define GSC FW fo

✓ Fi.CI.BAT: success for drm/i915/hwmon: Get rid of devm (rev2)

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Get rid of devm (rev2) URL : https://patchwork.freedesktop.org/series/132400/ State : success == Summary == CI Bug Log - changes from CI_DRM_14582 -> Patchwork_132400v2 Summary --- **SUCCE

Re: [PATCH 2/8] drm/i915/dpio: Add per-lane PHY TX register definitons for bxt/glk

2024-04-15 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ville-Syrjala/drm-i915-dpio-Clean-up-bxt-glk-PHY-registers/20240415-095059 base: git://anongit.freedeskt

✓ Fi.CI.BAT: success for drm/i915/vma: Fix UAF on reopen vs destroy race (rev3)

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix UAF on reopen vs destroy race (rev3) URL : https://patchwork.freedesktop.org/series/132360/ State : success == Summary == CI Bug Log - changes from CI_DRM_14582 -> Patchwork_132360v3 Summary --

✗ Fi.CI.CHECKPATCH: warning for drm/i915/vma: Fix UAF on reopen vs destroy race (rev3)

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix UAF on reopen vs destroy race (rev3) URL : https://patchwork.freedesktop.org/series/132360/ State : warning == Summary == Error: dim checkpatch failed afd551900ccd drm/i915/vma: Fix UAF on reopen vs destroy race -:18: WARNING:COMMIT_LOG_LONG_LINE:

✗ Fi.CI.BAT: failure for drm/i915: Don't reset GuC before engine reset on full GT reset

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: Don't reset GuC before engine reset on full GT reset URL : https://patchwork.freedesktop.org/series/132457/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14582 -> Patchwork_132457v1 Su

✗ Fi.CI.SPARSE: warning for drm/i915: Don't reset GuC before engine reset on full GT reset

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: Don't reset GuC before engine reset on full GT reset URL : https://patchwork.freedesktop.org/series/132457/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Don't reset GuC before engine reset on full GT reset

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: Don't reset GuC before engine reset on full GT reset URL : https://patchwork.freedesktop.org/series/132457/ State : warning == Summary == Error: dim checkpatch failed de0c87c308af drm/i915: Don't reset GuC before engine reset on full GT reset -:112: CHECK

Re: [PATCH] drm/i915/hwmon: Get rid of devm

2024-04-15 Thread Dixit, Ashutosh
On Sat, 13 Apr 2024 07:43:50 -0700, Armin Wolf wrote: > Hi Armin, > Am 13.04.24 um 02:10 schrieb Ashutosh Dixit: > > > When both hwmon and hwmon drvdata (on which hwmon depends) are device > > managed resources, the expectation, on device unbind, is that hwmon will be > > released before the drvd

✓ Fi.CI.BAT: success for Add support for partial mapping (rev6)

2024-04-15 Thread Patchwork
== Series Details == Series: Add support for partial mapping (rev6) URL : https://patchwork.freedesktop.org/series/131817/ State : success == Summary == CI Bug Log - changes from CI_DRM_14582 -> Patchwork_131817v6 Summary --- **SUCCE

Re: [PATCH 0/3] LNL GSC FW support

2024-04-15 Thread Daniele Ceraolo Spurio
Ooops, wrong mailing list, please ignore. I'll re-send it to intel-xe. Daniele On 4/15/2024 4:17 PM, Daniele Ceraolo Spurio wrote: The flow is the same as MTL, so the only things we need to add are the GSCCS and FW definitions. Due to the FW not being in its final state yet, we can't push it to

[PATCH 0/3] LNL GSC FW support

2024-04-15 Thread Daniele Ceraolo Spurio
The flow is the same as MTL, so the only things we need to add are the GSCCS and FW definitions. Due to the FW not being in its final state yet, we can't push it to linux-firmware yet so it needs to be in the xe-for-ci branch. Also, due to lack of mei support, a second patch for xe-for-ci has been

[xe-for-ci 2/3] drm/xe/gsc: Skip GSC proxy init

2024-04-15 Thread Daniele Ceraolo Spurio
The mei support for LNL hasn't landed yet, so we can't use the GSC proxy component. Note that the lack of the GSC proxy means that the content protection features (PXP, HDCP) won't work. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/xe/xe_gsc_proxy.c | 9 + 1 file changed, 9

[xe-for-ci 3/3] drm/xe/gsc: define GSC FW for LNL

2024-04-15 Thread Daniele Ceraolo Spurio
Interface and compatibility versions are the same as MTL. Note that the FW is still in development and the current release is for CI only. Theefore, we'll need to keep this patch in the xe-for-ci branch until we get the finalized FW release. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu

[PATCH 1/3] drm/xe/gsc: define GSCCS for LNL

2024-04-15 Thread Daniele Ceraolo Spurio
LNL has 1 GSCCS, same as MTL. Note that the GSCCS will be disabled until we have a GSC FW defined, but having it in the list of engine is a requirement to add such definition. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/xe/xe_pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [PATCH 2/8] drm/i915/dpio: Add per-lane PHY TX register definitons for bxt/glk

2024-04-15 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.9-rc4 next-20240415] [If your patch is applied to the wrong git tree, kindly drop us a

✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping (rev6)

2024-04-15 Thread Patchwork
== Series Details == Series: Add support for partial mapping (rev6) URL : https://patchwork.freedesktop.org/series/131817/ State : warning == Summary == Error: dim checkpatch failed 86569ef9a41f drm/i915/gem: Increment vma offset when mapping fb objects 3a66d43f1d97 drm/i915/gem: Do not look f

✗ Fi.CI.BAT: failure for drm/i915/guc: Fix UB due to signed int overflow

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix UB due to signed int overflow URL : https://patchwork.freedesktop.org/series/132446/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14582 -> Patchwork_132446v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915/guc: Fix UB due to signed int overflow

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix UB due to signed int overflow URL : https://patchwork.freedesktop.org/series/132446/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v2] drm/i915/hwmon: Get rid of devm

2024-04-15 Thread Ashutosh Dixit
When both hwmon and hwmon drvdata (on which hwmon depends) are device managed resources, the expectation, on device unbind, is that hwmon will be released before drvdata. However, in i915 there are two separate code paths, which both release either drvdata or hwmon and either can be released before

✓ Fi.CI.BAT: success for drm/i915: remove redundant assignement to variable err

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: remove redundant assignement to variable err URL : https://patchwork.freedesktop.org/series/132437/ State : success == Summary == CI Bug Log - changes from CI_DRM_14582 -> Patchwork_132437v1 Summary --

✓ Fi.CI.BAT: success for Enable display support for Battlemage

2024-04-15 Thread Patchwork
== Series Details == Series: Enable display support for Battlemage URL : https://patchwork.freedesktop.org/series/132429/ State : success == Summary == CI Bug Log - changes from CI_DRM_14581 -> Patchwork_132429v1 Summary --- **SUCCES

✗ Fi.CI.SPARSE: warning for Enable display support for Battlemage

2024-04-15 Thread Patchwork
== Series Details == Series: Enable display support for Battlemage URL : https://patchwork.freedesktop.org/series/132429/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable display support for Battlemage

2024-04-15 Thread Patchwork
== Series Details == Series: Enable display support for Battlemage URL : https://patchwork.freedesktop.org/series/132429/ State : warning == Summary == Error: dim checkpatch failed 7b481503a16a drm/xe/display: Lane reversal requires writes to both context lanes 9846f194e976 drm/i915/display: E

Re: [PATCH v3 20/21] drm/i915/display: perform transient flush

2024-04-15 Thread Nirmoy Das
Hi Matt, On 4/15/2024 7:07 PM, Matt Roper wrote: On Mon, Apr 15, 2024 at 01:44:22PM +0530, Balasubramani Vivekanandan wrote: From: Matthew Auld Perform manual transient cache flush prior to flip and at the end of frontbuffer_flush. This is needed to ensure display engine doesn't see garbage i

✓ Fi.CI.BAT: success for drm/i915/hwmon: Get rid of devm

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Get rid of devm URL : https://patchwork.freedesktop.org/series/132400/ State : success == Summary == CI Bug Log - changes from CI_DRM_14581 -> Patchwork_132400v1 Summary --- **SUCCESS**

✗ Fi.CI.BUILD: failure for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 (rev2)

2024-04-15 Thread Patchwork
== Series Details == Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 (rev2) URL : https://patchwork.freedesktop.org/series/130851/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/130851/revisions/2/mbox/ not applied Applyi

✓ Fi.CI.BAT: success for drm/xe: no need to call fixup_initial_plane_config in XE

2024-04-15 Thread Patchwork
== Series Details == Series: drm/xe: no need to call fixup_initial_plane_config in XE URL : https://patchwork.freedesktop.org/series/132395/ State : success == Summary == CI Bug Log - changes from CI_DRM_14581 -> Patchwork_132395v1 Summary

[PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-15 Thread Janusz Krzysztofik
We defer actually closing, unbinding and destroying a VMA until next idle point, or until the object is freed in the meantime. By postponing the unbind, we allow for the VMA to be reopened by the client, avoiding the work required to rebind the VMA. It was assumed that as long as a GT is held idl

RE: [PATCH v3 13/21] drm/i915/xe2hpd: Add max memory bandwidth algorithm

2024-04-15 Thread Sripada, Radhakrishna
LGTM, Reviewed-by: Radhakrishna Sripada > -Original Message- > From: Intel-xe On Behalf Of > Balasubramani Vivekanandan > Sent: Monday, April 15, 2024 1:14 AM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: De Marchi, Lucas ; Roper, Matthew D > ; Jani Nikula ;

[linux-next:master] BUILD REGRESSION 6bd343537461b57f3efe5dfc5fc193a232dfef1e

2024-04-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6bd343537461b57f3efe5dfc5fc193a232dfef1e Add linux-next specific files for 20240415 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404151720.ha4kzy01-...@intel.com https

Re: [PATCH v3 20/21] drm/i915/display: perform transient flush

2024-04-15 Thread Matt Roper
On Mon, Apr 15, 2024 at 10:07:32AM -0700, Matt Roper wrote: > On Mon, Apr 15, 2024 at 01:44:22PM +0530, Balasubramani Vivekanandan wrote: > > From: Matthew Auld > > > > Perform manual transient cache flush prior to flip and at the end of > > frontbuffer_flush. This is needed to ensure display eng

[PATCH v2] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-15 Thread Janusz Krzysztofik
We defer actually closing, unbinding and destroying a VMA until next idle point, or until the object is freed in the meantime. By postponing the unbind, we allow for the VMA to be reopened by the client, avoiding the work required to rebind the VMA. It was assumed that as long as a GT is held idl

[PATCH i-g-t v3] lib/kunit: Read results from debugfs

2024-04-15 Thread Janusz Krzysztofik
KUnit can provide KTAP reports from test modules via debugfs files, one per test suite. Using that source of test results instead of extracting them from dmesg, where they may be interleaved with other kernel messages, seems more easy to handle and less error prone. Switch to it. If KUnit debugf

Re: [PATCH v3 20/21] drm/i915/display: perform transient flush

2024-04-15 Thread Matt Roper
On Mon, Apr 15, 2024 at 01:44:22PM +0530, Balasubramani Vivekanandan wrote: > From: Matthew Auld > > Perform manual transient cache flush prior to flip and at the end of > frontbuffer_flush. This is needed to ensure display engine doesn't see > garbage if the surface is L3:XD dirty. > > Testcase

Re: [PATCH v3 19/21] drm/xe/device: implement transient flush

2024-04-15 Thread Matt Roper
On Mon, Apr 15, 2024 at 01:44:21PM +0530, Balasubramani Vivekanandan wrote: > From: Nirmoy Das > > Display surfaces can be tagged as transient by mapping it using one of > the various L3:XD PAT index modes on Xe2. The expectation is that KMD > needs to request transient data flush at the start of

[RFC PATCH] drm/i915: Don't reset GuC before engine reset on full GT reset

2024-04-15 Thread Nirmoy Das
Currently intel_gt_reset() happens as follows: reset_prepare() ---> Sends GDRST to GuC, GuC is in GS_MIA_IN_RESET do_reset() __intel_gt_reset() *_engine_reset_prepare() -->RESET_CTL expects running GuC *_reset_engines() intel_gt_init_hw() -->

Re: [PATCH v3 14/21] drm/i915/xe2hpd: Do not program MBUS_DBOX BW credits

2024-04-15 Thread Matt Roper
On Mon, Apr 15, 2024 at 01:44:16PM +0530, Balasubramani Vivekanandan wrote: > From: José Roberto de Souza > > No display IP beyond Xe_LPD+ has "BW credits" bits in MBUS_DBOX_CTL > register. Restrict the programming only to Xe_LPD+. > > BSpec: 49213 > CC: Matt Roper > Signed-off-by: José Roberto

Re: [PATCH v3 11/21] drm/i915/xe2hpd: Add display info

2024-04-15 Thread Matt Roper
On Mon, Apr 15, 2024 at 01:44:13PM +0530, Balasubramani Vivekanandan wrote: > From: Lucas De Marchi > > Add initial display info for xe2hpd. It is similar to xelpdp, but with no > PORT_B. > > v2: Inherit from XE_LPDP_FEATURES instead of XE_LPD_FEATURES > > Bspec: 67066 > CC: Matt Roper > Signe

Re: [PATCH v3 04/21] drm/i915/xe2hpd: Skip CCS modifiers

2024-04-15 Thread Matt Roper
On Mon, Apr 15, 2024 at 01:44:06PM +0530, Balasubramani Vivekanandan wrote: > Framebuffer format modifiers are used to indicate the existence of > auxillary surface in the plane, containing the CCS data. But on s/auxillary/auxiliary/ in a few places in this commit message. Although I don't think

Re: [PATCH v3 02/21] drm/i915/display: Enable RM timeout detection

2024-04-15 Thread Matt Roper
On Mon, Apr 15, 2024 at 01:44:04PM +0530, Balasubramani Vivekanandan wrote: > From: Mitul Golani > > Enable RM timeout interrupt to detect any hang during display engine > register access. > Current default timeout is 2ms. > > v2: > * Modified the IP version check to apply on all versions starti

Re: [PATCH v3 08/21] drm/i915/xe2hpd: Add new C20 PHY SRAM address

2024-04-15 Thread Jani Nikula
On Mon, 15 Apr 2024, Balasubramani Vivekanandan wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h > b/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h > index bdd0c8c4ef97..23a79e911972 100644 > --- a/drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h > +++ b/drivers/gpu/dr

Re: [PATCH v3 01/21] drm/xe/display: Lane reversal requires writes to both context lanes

2024-04-15 Thread Matt Roper
On Mon, Apr 15, 2024 at 01:44:03PM +0530, Balasubramani Vivekanandan wrote: > From: Clint Taylor > > Write both CX0 Lanes for Context Toggle for all except TC pin assignment D. > > Bspec: 64539 > CC: Jani Nikula > Signed-off-by: Clint Taylor > Signed-off-by: Balasubramani Vivekanandan > Rev

✓ Fi.CI.BAT: success for drm/i915: PLL refactoring

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: PLL refactoring URL : https://patchwork.freedesktop.org/series/132392/ State : success == Summary == CI Bug Log - changes from CI_DRM_14574 -> Patchwork_132392v1 Summary --- **SUCCESS** No re

✗ Fi.CI.SPARSE: warning for drm/i915: PLL refactoring

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: PLL refactoring URL : https://patchwork.freedesktop.org/series/132392/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: PLL refactoring

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: PLL refactoring URL : https://patchwork.freedesktop.org/series/132392/ State : warning == Summary == Error: dim checkpatch failed 14bdc0367571 drm/i915: Replace hand rolled PLL state dump with intel_dpll_dump_hw_state() c07ae2c34376 drm/i915: Use printer

Re: [PATCH 1/3] drm/i915: Define and compute Transcoder CMRR registers

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Mitul Golani wrote: > Add register definitions for Transcoder Fixed Average > Vtotal mode/CMRR function, with the necessary bitfields. > Compute these registers when CMRR is enabled, extending > Adaptive refresh rate capabilities. > > --v2: > - Use intel_de_read64_2x32 in inte

✗ Fi.CI.BUILD: failure for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup URL : https://patchwork.freedesktop.org/series/132390/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drivers/gpu/drm/

Re: [PATCH 00/18] drm/i915: PLL refactoring

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > A bunch of refactoring around PLLs. Main feature is > the unionization of dpll_hw_state. The eventual goal > is to unify the approach for PLLs across all platforms > instead of the current "shared PLLs are somehow > different th

Re: [PATCH 18/18] drm/i915: Suck snps/cx0 PLL states into dpll_hw_state

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Ville Syrjala wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h > b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h > index d0ec6196d398..f09e513ce05b 100644 > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h > +++ b/drivers/gpu/drm/i915/display/intel_dpll_

Re: Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-15 Thread Maxime Ripard
On Mon, 15 Apr 2024 16:09:22 +0300, Jani Nikula wrote: > On Wed, 10 Apr 2024, Jani Nikula wrote: > > Surprisingly many places depend on debugfs.h to be included via > > drm_print.h. Fix them. > > While all of this is trivial, merely adding some includes, please > > [ ... ] Acked-by: Maxime Ripa

Re: [PATCH 10/18] drm/i915: Extract {i9xx,i8xx,ilk}_dpll()

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > The *_compute_dpll() functions generally contain > two things: > - huge pile of inline code to calculate the DPLL > register value > - a few calls to helpers to calculate the > DPLL_MD and FP register values > > Pull the DPLL

2024 X.Org Foundation Election Results

2024-04-15 Thread Ricardo Garcia
The Board of Directors election concluded on 08 April 2024. There were 81 Members of the X.Org Foundation eligible to vote, and 61 Members cast votes. This is a 75.3% turn out. In the election of the Directors to the Board of the X.Org Foundation, the results were that Erik Faye-Lund, Simon Ser, M

✗ Fi.CI.BUILD: failure for Implement CMRR Support (rev7)

2024-04-15 Thread Patchwork
== Series Details == Series: Implement CMRR Support (rev7) URL : https://patchwork.freedesktop.org/series/126443/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drivers/gpu/drm/i915/display/intel_displ

Re: [PATCH v2 0/7] drm: debug logging improvements

2024-04-15 Thread Jani Nikula
On Mon, 08 Apr 2024, Jani Nikula wrote: > v2 of [1], dropping drm_mode_print() stuff altogether, and switching to > DRM_MODE_FMT/DRM_MODE_ARG() in a separate patch. Also add a few more drm > device based logging conversion patches, so the last patch makes more sense. Thanks for the reviews, pushe

Re: [PATCH 00/10] drm: move Intel drm headers to a subdirectory

2024-04-15 Thread Jani Nikula
On Wed, 10 Apr 2024, Jani Nikula wrote: > We've accumulated enough Intel specific header files under include/drm > that they warrant a subdirectory of their own. Clean up the top drm > header directory by moving the Intel files under include/drm/intel. > > Since i915 is most impacted, I suggest me

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-15 Thread Jani Nikula
On Wed, 10 Apr 2024, Jani Nikula wrote: > Surprisingly many places depend on debugfs.h to be included via > drm_print.h. Fix them. While all of this is trivial, merely adding some includes, please consider acking the changes to your corner of the kernel. Thanks, Jani. > > Signed-off-by: Jani Ni

✗ Fi.CI.BAT: failure for Link off between frames for edp (rev2)

2024-04-15 Thread Patchwork
== Series Details == Series: Link off between frames for edp (rev2) URL : https://patchwork.freedesktop.org/series/130650/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14572 -> Patchwork_130650v2 Summary --- **FAILU

Re: [PATCH] drm/i915/hwmon: Get rid of devm

2024-04-15 Thread Armin Wolf
Am 13.04.24 um 02:10 schrieb Ashutosh Dixit: When both hwmon and hwmon drvdata (on which hwmon depends) are device managed resources, the expectation, on device unbind, is that hwmon will be released before the drvdata. However, it appears devres does not do this consistently, so that we occasio

[PATCH] drm/i915/guc: Fix UB due to signed int overflow

2024-04-15 Thread Dmitrii Bundin
Fix compile errors of the form "FIELD_PREP: mask is not constant" caused by signed integer constant overflow. Files affected: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Reproducible with gcc 7.5 Signed-off-by: Dmitrii Bundin --- drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 2 +- 1 fi

✗ Fi.CI.SPARSE: warning for Link off between frames for edp (rev2)

2024-04-15 Thread Patchwork
== Series Details == Series: Link off between frames for edp (rev2) URL : https://patchwork.freedesktop.org/series/130650/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Link off between frames for edp (rev2)

2024-04-15 Thread Patchwork
== Series Details == Series: Link off between frames for edp (rev2) URL : https://patchwork.freedesktop.org/series/130650/ State : warning == Summary == Error: dim checkpatch failed 3237e68ff67b drm/i915/alpm: Move alpm parameters from intel_psr aaf1cb340d64 drm/i915/alpm: Move alpm related co

Re: [PATCH v2 3/4] drm/i915/bios: switch to struct drm_edid and struct drm_edid_product_id

2024-04-15 Thread Jani Nikula
On Tue, 09 Apr 2024, Ville Syrjälä wrote: > On Tue, Apr 09, 2024 at 12:46:11PM +0300, Jani Nikula wrote: >> To avoid accessing and parsing the raw EDID with drm_edid_raw(), switch >> to the struct drm_edid based function to extract product id, and use the >> drm printer function to debug log it. >

Re: [PATCH 6/8] drm/i915/dpio: s/ddi/dpio/ for bxt/glk PHY stuff

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Since all of this lives in intel_dpio_phy.c let's rename the > bxt/glk functions to have bxt_dpio_phy_ namespace. Seems like intel_dpio_phy.c could be split to vlv_dpio_phy.c and bxt_dpio_phy.c after this. At a glance, there isn

✓ Fi.CI.BAT: success for drm/i915: i915_reg.h cleanups

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: i915_reg.h cleanups URL : https://patchwork.freedesktop.org/series/132381/ State : success == Summary == CI Bug Log - changes from CI_DRM_14572 -> Patchwork_132381v1 Summary --- **SUCCESS** N

Re: [PATCH 4/8] drm/i915/dpio: Introdude bxt_ddi_phy_rmw_grp()

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a helper to do the "read from one per-lane register > and write to the group register" rmw cycle. This doesn't turn out to be such a useful helper after going per lane, but there'll still be two users. It's fine. -- Jani

Re: [PATCH 2/8] drm/i915/dpio: Add per-lane PHY TX register definitons for bxt/glk

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Add consistent definitions for the per-lane PHY TX registers > on bxt/glk. The current situation is a slight mess with some > registers having a LN0 define, while others have a parametrized > per-lane definition. *definitions in

Re: [PATCH 0/8] drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Start off with a bit of cleanup around the BXT/GLK DPIO > PHY registers, and finish off with per-lane vswing > programming. The series is Reviewed-by: Jani Nikula but I'll add some notes inline. > > Ville Syrjälä (8): > dr

✗ Fi.CI.CHECKPATCH: warning for drm/i915: i915_reg.h cleanups

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915: i915_reg.h cleanups URL : https://patchwork.freedesktop.org/series/132381/ State : warning == Summary == Error: dim checkpatch failed 19e68395cec8 drm/i915/audio: move LPE audio regs to intel_audio_regs.h dfbe99d107b3 drm/i915/color: move palette register

✓ Fi.CI.BAT: success for series starting with [CI-only,1/8] drm: Add drm_vblank_work_flush_all().

2024-04-15 Thread Patchwork
== Series Details == Series: series starting with [CI-only,1/8] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/132374/ State : success == Summary == CI Bug Log - changes from CI_DRM_14572 -> Patchwork_132374v1 ==

Re: [PATCH v2 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 47 +++ > drivers/gpu/drm/i915/display/intel_alpm.h | 2 + > .../drm/i915/display/intel_display_d

✗ Fi.CI.SPARSE: warning for series starting with [CI-only,1/8] drm: Add drm_vblank_work_flush_all().

2024-04-15 Thread Patchwork
== Series Details == Series: series starting with [CI-only,1/8] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/132374/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +.

Re: [PATCH v2 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Animesh Manna wrote: > Set the Link Off Between Frames Enable bit in ALPM_CTL register. > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 5 + > drivers/gpu/drm/i915/display/intel_display_types.h | 1 + > 2 files changed, 6 ins

Re: [PATCH v2 4/6] drm/i915/alpm: Add compute config for lobf

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Animesh Manna wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h > b/drivers/gpu/drm/i915/display/intel_alpm.h > index c45d078e5a6b..c341d2c2b7f7 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > @@ -10,9

Re: [PATCH v2 2/6] drm/i915/alpm: Move alpm related code to a new file

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Animesh Manna wrote: > Move ALPM feature related code as it will be used for > non-psr panel also thorugh LOBF feature. > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/display/intel_alpm.c | 292 +

✗ Fi.CI.BAT: failure for treewide: Fix common grammar mistake "the the"

2024-04-15 Thread Patchwork
== Series Details == Series: treewide: Fix common grammar mistake "the the" URL : https://patchwork.freedesktop.org/series/132369/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14572 -> Patchwork_132369v1 Summary ---

✗ Fi.CI.SPARSE: warning for treewide: Fix common grammar mistake "the the"

2024-04-15 Thread Patchwork
== Series Details == Series: treewide: Fix common grammar mistake "the the" URL : https://patchwork.freedesktop.org/series/132369/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH][next] drm/i915: remove redundant assignement to variable err

2024-04-15 Thread Andi Shyti
Hi Colin, On Mon, Apr 15, 2024 at 10:56:59AM +0100, Colin Ian King wrote: > The variable err is being assigned a value 0 that is never read, the > break statement escapes a do-while loop and then the code returns > without referencing err. The assignment is redundant and can be > removed. > > Cle

✗ Fi.CI.BAT: failure for drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix UAF on reopen vs destroy race URL : https://patchwork.freedesktop.org/series/132360/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14572 -> Patchwork_132360v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix UAF on reopen vs destroy race URL : https://patchwork.freedesktop.org/series/132360/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix UAF on reopen vs destroy race URL : https://patchwork.freedesktop.org/series/132360/ State : warning == Summary == Error: dim checkpatch failed 3c06e0966968 drm/i915/vma: Fix UAF on reopen vs destroy race -:18: WARNING:COMMIT_LOG_LONG_LINE: Prefer

✓ Fi.CI.BAT: success for drm/i915/display: DMC wakelock implementation (rev5)

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/display: DMC wakelock implementation (rev5) URL : https://patchwork.freedesktop.org/series/131124/ State : success == Summary == CI Bug Log - changes from CI_DRM_14572 -> Patchwork_131124v5 Summary

✗ Fi.CI.SPARSE: warning for drm/i915/display: DMC wakelock implementation (rev5)

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/display: DMC wakelock implementation (rev5) URL : https://patchwork.freedesktop.org/series/131124/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: DMC wakelock implementation (rev5)

2024-04-15 Thread Patchwork
== Series Details == Series: drm/i915/display: DMC wakelock implementation (rev5) URL : https://patchwork.freedesktop.org/series/131124/ State : warning == Summary == Error: dim checkpatch failed bcac7916827c drm/i915/display: add support for DMC wakelocks Traceback (most recent call last):

Re: [PATCH v2 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > Signed-off-by: Animesh Manna > --- >  drivers/gpu/drm/i915/display/intel_alpm.c | 47 > +++ >  drivers/gpu/drm/i915/display/intel_alpm.h |  2 + >  .../drm/i915/display

Re: [PATCH v2 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > Set the Link Off Between Frames Enable bit in ALPM_CTL register. > > Signed-off-by: Animesh Manna > --- >  drivers/gpu/drm/i915/display/intel_alpm.c  | 5 + >  drivers/gpu/drm/i915/display/intel_display_types.h | 1 + >  2 files

Re: [PATCH v2 4/6] drm/i915/alpm: Add compute config for lobf

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC

[PATCH][next] drm/i915: remove redundant assignement to variable err

2024-04-15 Thread Colin Ian King
The variable err is being assigned a value 0 that is never read, the break statement escapes a do-while loop and then the code returns without referencing err. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:107

✓ Fi.CI.BAT: success for Add support for partial mapping (rev5)

2024-04-15 Thread Patchwork
== Series Details == Series: Add support for partial mapping (rev5) URL : https://patchwork.freedesktop.org/series/131817/ State : success == Summary == CI Bug Log - changes from CI_DRM_14571 -> Patchwork_131817v5 Summary --- **SUCCE

✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping (rev5)

2024-04-15 Thread Patchwork
== Series Details == Series: Add support for partial mapping (rev5) URL : https://patchwork.freedesktop.org/series/131817/ State : warning == Summary == Error: dim checkpatch failed d62ad73d2c22 drm/i915/gem: Increment vma offset when mapping fb objects 2f4dc2b29d03 drm/i915/gem: Do not look f

  1   2   >