== Series Details ==
Series: Enable Adaptive Sync SDP Support for DP (rev31)
URL : https://patchwork.freedesktop.org/series/126829/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14465 -> Patchwork_126829v31
Summary
---
On Thu, Mar 21, 2024 at 06:20:57PM +0200, Jani Nikula wrote:
On Thu, 21 Mar 2024, Jani Nikula wrote:
The dmc_firmware_path parameter is clearly a display parameter. Move it
there. This also cleans up the ugly member in struct xe_device.
Hmm, does this actually fix the parameter on xe?!
not
== Series Details ==
Series: Enable Adaptive Sync SDP Support for DP (rev31)
URL : https://patchwork.freedesktop.org/series/126829/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Enable Adaptive Sync SDP Support for DP (rev31)
URL : https://patchwork.freedesktop.org/series/126829/
State : warning
== Summary ==
Error: dim checkpatch failed
218f7e3c8c89 drm/dp: Add support to indicate if sink supports AS SDP
-:14: WARNING:BAD_SIGN_OFF: Duplic
== Series Details ==
Series: drm/i915/gt: Report full vm address range (rev4)
URL : https://patchwork.freedesktop.org/series/131095/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14465 -> Patchwork_131095v4
Summary
---
Add read/write calls for Adaptive Sync SDP.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
b/driv
Compute vrr_vsync_start/end, which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit)
- Updated bit fields of VRR_VSYNC_START/END. (Ankit)
--v3:
- Add PIPE_CONF_CHECK_I(vrr.
Add necessary function definitions to compute AS SDP data.
The new intel_dp_compute_as_sdp function computes AS SDP
values based on the display configuration, ensuring proper
handling of Variable Refresh Rate (VRR).
--v2:
- Added DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx(). [Ankit]
- Separated
Enable infoframe and add state checker for Adaptive Sync
SDP enablement.
--v1:
- crtc_state->infoframes.enable, to add on correct place holder.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_display.c | 46
1 file changed, 46
Add a wrapper function to check if both the source and
sink support Adaptive Sync SDP.
--v1:
Just use drm/i915/dp in subject line.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 8
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
2
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
- Remove unrelated comments and changes. [Jani]
-
Add crtc state dump for Adaptive Sync SDP to know which
crtc specifically caused the failure.
--v1:
- Rebase Patches to latest.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 3 +++
drivers/gpu/drm/i915/display/intel_display_t
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP).
Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate
debugging.
--v2:
- Update logging. [Jani, Ankit]
- Use 'as_sdp' instead of 'async' [Ankit]
- Correct define placeholders to where they are actually used. [J
Add an API that indicates support for Adaptive Sync SDP in
the sink, which can be utilized by the rest of the DP programming.
--v1:
- Format commit message properly.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
Signed-off-by: Mitul Golani
---
drivers/gpu/drm/display/drm_dp_helper.c
An Adaptive-Sync-capable DP protocol converter indicates its
support by setting the related bit in the DPCD register. This
is valid for DP and edp as well.
Computes AS SDP values based on the display configuration,
ensuring proper handling of Variable Refresh Rate (VRR)
in the context of Adaptive
== Series Details ==
Series: drm/i915/display: move dmc_firmware_path to display params
URL : https://patchwork.freedesktop.org/series/131443/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14464 -> Patchwork_131443v1
Summar
== Series Details ==
Series: drm/i915/display: move dmc_firmware_path to display params
URL : https://patchwork.freedesktop.org/series/131443/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/display: move dmc_firmware_path to display params
URL : https://patchwork.freedesktop.org/series/131443/
State : warning
== Summary ==
Error: dim checkpatch failed
dc34fc4bd4c3 drm/i915/display: move dmc_firmware_path to display params
-:20: CHECK:PARENTHE
== Series Details ==
Series: drm/i915/bios: Pimp some VBT definitions
URL : https://patchwork.freedesktop.org/series/131441/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14464 -> Patchwork_131441v1
Summary
---
**SUC
Hi Andi,
On 3/21/2024 4:17 PM, Andi Shyti wrote:
Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per
vm") has reserved an object for kernel space usage.
Userspace, though, needs to know the full address range.
In the former patch the reserved space was substructed from the
total amou
== Series Details ==
Series: Enable Adaptive Sync SDP Support for DP (rev30)
URL : https://patchwork.freedesktop.org/series/126829/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC [M] drivers/gpu/drm/i915/d
== Series Details ==
Series: drm/i915/gt: Report full vm address range (rev3)
URL : https://patchwork.freedesktop.org/series/131095/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14464 -> Patchwork_131095v3
Summary
---
On Thu, 21 Mar 2024, Jani Nikula wrote:
> The dmc_firmware_path parameter is clearly a display parameter. Move it
> there. This also cleans up the ugly member in struct xe_device.
Hmm, does this actually fix the parameter on xe?!
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/disp
Hi Dave, Sima,
here's the drm-misc-next-fixes PR for this week.
Best regards
Thomas
drm-misc-next-fixes-2024-03-21:
Short summary of fixes pull:
core:
- fix rounding in drm_fixp2int_round()
bridge:
- fix documentation for DRM_BRIDGE_OP_EDID
nouveau:
- don't check devinit disable on GSP
sun4i
The dmc_firmware_path parameter is clearly a display parameter. Move it
there. This also cleans up the ugly member in struct xe_device.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++
drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
drivers/g
From: Ville Syrjälä
Add the missing BDB version number information for some of
the backlight fields in VBT.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_
From: Ville Syrjälä
According to some VBIOS sources the LFP power block used to
have a single bit for DPST support. In version 159 that bit
got moved into the driver features block, and then in version
228 back into the LFP power block (but this time as a
per-panel thing). We have definitions for
From: Ville Syrjälä
The VBT backlight entries include various fields for i2c
controlled backlights. These have been obsoleted at some
unknown point in time, but let's define them anyway so that
we have a full picture of what has been in there.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i
From: Ville Syrjälä
While the spec does claim that most of the driver feature flags
start from BDB version 165, reality and some VBIOS code disagrees.
The VBIOS code says it sart from version 159, and my ILK
with version 162 definitely has these things already in its
VBT. Update the version numbe
From: Ville Syrjälä
We've misspelled the VBT DFPS (dynamic frames per second) field
as DPFS. Fix it.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
From: Ville Syrjälä
Update a bunch of our VBT defintions based on real world data
and an archaeological dig through some VBIOS ruins.
Ville Syrjälä (5):
drm/i915/bios: s/dpfs/dfps/
drm/i915/bios: Update VBT driver feature block version numbers
drm/i915/bios: Add the old DPST field into VBT
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
- Remove unrelated comments and changes. [Jani]
-
Add necessary function definitions to compute AS SDP data.
The new intel_dp_compute_as_sdp function computes AS SDP
values based on the display configuration, ensuring proper
handling of Variable Refresh Rate (VRR).
--v2:
- Added DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx(). [Ankit]
- Separated
Enable infoframe and add state checker for Adaptive Sync
SDP enablement.
--v1:
- crtc_state->infoframes.enable, to add on correct place holder.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_display.c | 46
1 file changed, 46
Add a wrapper function to check if both the source and
sink support Adaptive Sync SDP.
--v1:
Just use drm/i915/dp in subject line.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 8
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
2
Add read/write calls for Adaptive Sync SDP.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
b/driv
Compute vrr_vsync_start/end, which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit)
- Updated bit fields of VRR_VSYNC_START/END. (Ankit)
--v3:
- Add PIPE_CONF_CHECK_I(vrr.
Add an API that indicates support for Adaptive Sync SDP in
the sink, which can be utilized by the rest of the DP programming.
--v1:
- Format commit message properly.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/display/drm_dp_helper.c | 25 +++
Add crtc state dump for Adaptive Sync SDP to know which
crtc specifically caused the failure.
--v1:
- Rebase Patches to latest.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 3 +++
drivers/gpu/drm/i915/display/intel_display_t
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP).
Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate
debugging.
--v2:
- Update logging. [Jani, Ankit]
- Use 'as_sdp' instead of 'async' [Ankit]
- Correct define placeholders to where they are actually used. [J
An Adaptive-Sync-capable DP protocol converter indicates its
support by setting the related bit in the DPCD register. This
is valid for DP and edp as well.
Computes AS SDP values based on the display configuration,
ensuring proper handling of Variable Refresh Rate (VRR)
in the context of Adaptive
Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per
vm") has reserved an object for kernel space usage.
Userspace, though, needs to know the full address range.
In the former patch the reserved space was substructed from the
total amount of the VM space. Add it back when the user reques
On Thu, 2024-03-21 at 14:38 +0200, Jani Nikula wrote:
> On Wed, 20 Mar 2024, José Roberto de Souza wrote:
> > It is misleading, if the intention was to also print something
> > in case it succeed it should have a different string.
> >
> > Cc: Alan Previn
> > Signed-off-by: José Roberto de Souza
drm-misc-next-2024-03-21-1:
drm-misc-next for v6.10:
UAPI Changes:
- Move some nouveau magic constants to uapi.
Cross-subsystem Changes:
- Move drm-misc to gitlab and freedesktop hosting.
- Add entries for panfrost.
Core Changes:
- Improve placement for TTM bo's in idle/busy handling.
- Improve
On Wed, 20 Mar 2024, José Roberto de Souza wrote:
> It is misleading, if the intention was to also print something
> in case it succeed it should have a different string.
>
> Cc: Alan Previn
> Signed-off-by: José Roberto de Souza
Fixes: 698e19da2914 ("drm/i915: Skip pxp init if gt is wedged")
C
On Wed, 20 Mar 2024, Jani Nikula wrote:
> v1 after the reviewed RFC [1].
And pushed to drm-intel-next, thanks for the review.
Fixed patch 1 subject prefix to "drm/i915/hdmi" while applying.
BR,
Jani.
>
> BR,
> Jani.
>
>
> [1] https://lore.kernel.org/r/cover.1710253533.git.jani.nik...@intel.com
== Series Details ==
Series: drm/edid & drm/i915: vendor and product id logging improvements
URL : https://patchwork.freedesktop.org/series/131414/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14461 -> Patchwork_131414v1
S
== Series Details ==
Series: drm/edid & drm/i915: vendor and product id logging improvements
URL : https://patchwork.freedesktop.org/series/131414/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86
== Series Details ==
Series: drm/edid & drm/display header spring cleaning
URL : https://patchwork.freedesktop.org/series/131412/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14461 -> Patchwork_131412v1
Summary
---
== Series Details ==
Series: drm/edid & drm/display header spring cleaning
URL : https://patchwork.freedesktop.org/series/131412/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitop
== Series Details ==
Series: drm/edid & drm/display header spring cleaning
URL : https://patchwork.freedesktop.org/series/131412/
State : warning
== Summary ==
Error: dim checkpatch failed
4933bb2fa206 drm/displayid: move drm_displayid.h to drm_displayd_internal.h
-:31: WARNING:FILE_PATH_CHANG
Use a more suitable type to avoid the cast.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
b/drivers/gpu/drm/i915/display/intel_bios.c
index 5e111a8cce
To avoid accessing and parsing the raw EDID with drm_edid_raw(), switch
to the struct drm_edid based function to extract product id, and use the
drm printer function to debug log it.
The underlying assumption is that struct drm_edid_product_id and struct
lvds_pnp_id describe identical data, albeit
Add a function to print a decoded EDID vendor and product id to a drm
printer, optinally with the raw data.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 35 +++
include/drm/drm_edid.h | 3 +++
2 files changed, 38 insertions(+)
diff --git a/dri
Jani Nikula (4):
drm/edid: add drm_edid_get_product_id()
drm/edid: add drm_edid_print_product_id()
drm/i915/bios: switch to struct drm_edid and struct
drm_edid_product_id
drm/i915/bios: return drm_edid_product_id from get_lvds_pnp_id()
drivers/gpu/drm/drm_edid.c| 50
Add a struct drm_edid based function to get the vendor and product ID
from an EDID. Add a separate struct for defining this part of the EDID,
with defined byte order for product code and serial number.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 15 +++
include/drm/dr
On Thu, 21 Mar 2024, Julia Lawall wrote:
> On Wed, 20 Mar 2024, Jani Nikula wrote:
>
>> On Wed, 20 Mar 2024, Julia Lawall wrote:
>> > On Wed, 20 Mar 2024, Jani Nikula wrote:
>> >> Okay, I have another one wrt macros. :)
>> >>
>> >> I'm trying to add a completely new variadic macro, but it fails a
Keep the declarations for struct drm_edid based functions together.
Signed-off-by: Jani Nikula
---
include/drm/drm_edid.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index 6eadc4f12c07..19814bb1103c 100644
--- a/incl
The declarations for internal EDID functions are a bit scattered. Put
them all in drm_crtc_internal.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 6 ++
drivers/gpu/drm/drm_displayid.c | 1 +
drivers/gpu/drm/drm_eld.c | 4 +++-
drivers/gpu/drm/drm_inter
There are no exported symbols for displayid, and it's all internal
interfaces. Move the header to drivers/gpu/drm/drm_displayd_internal.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_displayid.c | 3 ++-
.../gpu/drm/drm_displayid_internal.h
Jani Nikula (3):
drm/displayid: move drm_displayid.h to drm_displayd_internal.h
drm/edid: move all internal declarations to drm_crtc_internal.h
drm/edid: group struct drm_edid based declarations together
drivers/gpu/drm/drm_crtc_internal.h | 6 ++
drivers/gpu/drm/drm_
On Thu, 21 Mar 2024, Arun R Murthy wrote:
> Check return value for drmm_mutex_init as it can fail and return on
> failure.
>
> Signed-off-by: Arun R Murthy
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/driv
== Series Details ==
Series: Weirdness in parsing cpp macros
URL : https://patchwork.freedesktop.org/series/131409/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/131409/revisions/1/mbox/ not
applied
Applying: Weirdness in parsing cpp macros
error
> -Original Message-
> From: Coelho, Luciano
> Sent: Monday, March 18, 2024 7:08 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; Shankar, Uma ;
> ville.syrj...@linux.intel.com; Nikula, Jani
> Subject: [PATCH v3 4/4] drm/i915/display: tie DMC wakelock to D
On Wed, 20 Mar 2024, Jani Nikula wrote:
> On Wed, 20 Mar 2024, Julia Lawall wrote:
> > On Wed, 20 Mar 2024, Jani Nikula wrote:
> >> Okay, I have another one wrt macros. :)
> >>
> >> I'm trying to add a completely new variadic macro, but it fails at
> >> "...". I've tried all sorts of things, b
> -Original Message-
> From: Coelho, Luciano
> Sent: Monday, March 18, 2024 7:08 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; Shankar, Uma ;
> ville.syrj...@linux.intel.com; Nikula, Jani
> Subject: [PATCH v3 3/4] drm/i915/display: add module parameter
> -Original Message-
> From: Coelho, Luciano
> Sent: Monday, March 18, 2024 7:08 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; Shankar, Uma ;
> ville.syrj...@linux.intel.com; Nikula, Jani
> Subject: [PATCH v3 2/4] drm/i915/display: don't allow DMC wakel
== Series Details ==
Series: drm/xe/display: check for error on drmm_mutex_init (rev2)
URL : https://patchwork.freedesktop.org/series/131301/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14459 -> Patchwork_131301v2
Summary
> -Original Message-
> From: Coelho, Luciano
> Sent: Monday, March 18, 2024 7:08 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; Shankar, Uma ;
> ville.syrj...@linux.intel.com; Nikula, Jani
> Subject: [PATCH v3 1/4] drm/i915/display: add support for DMC w
On Tue, 19 Mar 2024, Jani Nikula wrote:
> Resend because I forgot to Cc: dri-devel on the original submission.
Pushed to drm-intel-next, thanks for the reviews and acks.
BR,
Jani.
>
> Jani Nikula (6):
> drm/mst: read sideband messaging cap
> drm/i915/mst: improve debug logging of DP MST mod
70 matches
Mail list logo