Re: [PATCH v14 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-29 Thread Nautiyal, Ankit K
On 2/29/2024 10:09 PM, Mitul Golani wrote: Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] -

[RFC] drm/i915/dp: Log message when limiting SST link rate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit

2024-02-29 Thread Charlton Lin
Driver currently limits link rate up to HBR3 in SST mode. Log a message with monitor vendor, product id, and MSTM_CAP to help understand what monitors are being downgraded by this limit. Cc: Ville Syrjälä Cc: Khaled Almahallawy Cc: Sean Paul Signed-off-by: Charlton Lin --- drivers/gpu/drm/i91

[PATCH v6 2/3] drm/i915: Remove extra multi-gt pm-references

2024-02-29 Thread Janusz Krzysztofik
There was an attempt to fix an issue of illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle, reported by CI on 2-GT Meteor Lake. As a solution, an extra wakeref for a Primary GT was acquired from i915_gem_do_execbuffer() -- see commit f56fe3e91787 ("drm/i9

[PATCH v6 3/3] Revert "drm/i915: Wait for active retire before i915_active_fini()"

2024-02-29 Thread Janusz Krzysztofik
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted by "drm/i915/vma: Fix UAF on destroy against retire race". Signed-off-by: Janusz Krzysztofik Cc: Nirmoy Das --- drivers/gpu/drm/i915/i915_vma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_

[PATCH v6 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-02-29 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915] [161.360082

[PATCH v6 0/3] drm/i915: Fix VMA UAF on destroy against deactivate race

2024-02-29 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915] [161.360082

✗ Fi.CI.BUILD: failure for Fixed-type GENMASK/BIT (rev3)

2024-02-29 Thread Patchwork
== Series Details == Series: Fixed-type GENMASK/BIT (rev3) URL : https://patchwork.freedesktop.org/series/129116/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/129116/revisions/3/mbox/ not applied Applying: bits: introduce fixed-type genmasks err

Re: linux-next: build failure after merge of the kunit-next tree

2024-02-29 Thread David Gow
On Thu, 29 Feb 2024 at 23:07, Shuah Khan wrote: > > Hi Stephen, > > On 2/28/24 21:26, Stephen Rothwell wrote: > > Hi all, > > > > After merging the kunit-next tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from drivers/gpu/drm/tests/drm_buddy_te

✓ Fi.CI.BAT: success for VBT read cleanup (rev2)

2024-02-29 Thread Patchwork
== Series Details == Series: VBT read cleanup (rev2) URL : https://patchwork.freedesktop.org/series/130528/ State : success == Summary == CI Bug Log - changes from CI_DRM_14370 -> Patchwork_130528v2 Summary --- **SUCCESS** No regr

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-29 Thread Lucas De Marchi
On Thu, Feb 29, 2024 at 08:27:30PM +0200, Andy Shevchenko wrote: On Thu, Feb 29, 2024 at 12:21:34PM -0600, Lucas De Marchi wrote: On Thu, Feb 29, 2024 at 12:49:57PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2024 at 05:39:21PM -0600, Lucas De Marchi wrote: > > On Thu, Feb 22, 2024 at 06:49:

✗ Fi.CI.SPARSE: warning for VBT read cleanup (rev2)

2024-02-29 Thread Patchwork
== Series Details == Series: VBT read cleanup (rev2) URL : https://patchwork.freedesktop.org/series/130528/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v4] drm/i915: Show bios vbt when read from firmware/spi/oprom

2024-02-29 Thread Radhakrishna Sripada
Make debugfs vbt only shows valid vbt when read from ACPI opregion. Make it work when read from firmware/spi/pci oprom cases. v2: Extract getting vbt from different sources to its own function. Protect sysfs write with vbt check(Jani) v3: Fix CI error by probing bios vbt with runtime_pm wakere

✓ Fi.CI.BAT: success for drm/i915: Add missing doc for drm_i915_reset_stats (rev2)

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915: Add missing doc for drm_i915_reset_stats (rev2) URL : https://patchwork.freedesktop.org/series/130562/ State : success == Summary == CI Bug Log - changes from CI_DRM_14370 -> Patchwork_130562v2 Summary

✗ Fi.CI.SPARSE: warning for drm/i915: Add missing doc for drm_i915_reset_stats (rev2)

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915: Add missing doc for drm_i915_reset_stats (rev2) URL : https://patchwork.freedesktop.org/series/130562/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for Disable automatic load CCS load balancing (rev4)

2024-02-29 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev4) URL : https://patchwork.freedesktop.org/series/129951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14370 -> Patchwork_129951v4 Summary ---

✗ Fi.CI.CHECKPATCH: warning for Disable automatic load CCS load balancing (rev4)

2024-02-29 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev4) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim checkpatch failed 9d59a3a23381 drm/i915/gt: Refactor uabi engine class/instance list creation -:54: WARNING:AVOID_BUG: D

✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Rename ICL_AUX_ANAOVRD1 to ICL_PORT_TX_DW6_AUX

2024-02-29 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Rename ICL_AUX_ANAOVRD1 to ICL_PORT_TX_DW6_AUX URL : https://patchwork.freedesktop.org/series/130581/ State : success == Summary == CI Bug Log - changes from CI_DRM_14370 -> Patchwork_130581v1 ==

Re: [PATCH] drm/i915/selftest_hangcheck: Check sanity with more patience

2024-02-29 Thread Andi Shyti
Hi Janusz, On Wed, Feb 28, 2024 at 04:24:41PM +0100, Janusz Krzysztofik wrote: > While trying to reproduce some other issues reported by CI for i915 > hangcheck live selftest, I found them hidden behind timeout failures > reported by igt_hang_sanitycheck -- the very first hangcheck test case > exe

Re: [PATCH] drm/i915/selftests: Fix dependency of some timeouts on HZ

2024-02-29 Thread Andi Shyti
Hi Janusz, On Thu, Feb 22, 2024 at 12:32:40PM +0100, Janusz Krzysztofik wrote: > Third argument of i915_request_wait() accepts a timeout value in jiffies. > Most users pass either a simple HZ based expression, or a result of > msecs_to_jiffies(), or MAX_SCHEDULE_TIMEOUT, or a very small number not

✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Rename ICL_AUX_ANAOVRD1 to ICL_PORT_TX_DW6_AUX

2024-02-29 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Rename ICL_AUX_ANAOVRD1 to ICL_PORT_TX_DW6_AUX URL : https://patchwork.freedesktop.org/series/130581/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked se

[PATCH v3 4/4] drm/i915/gt: Enable only one CCS for compute workload

2024-02-29 Thread Andi Shyti
Enable only one CCS engine by default with all the compute sices allocated to it. While generating the list of UABI engines to be exposed to the user, exclude any additional CCS engines beyond the first instance. This change can be tested with igt i915_query. Fixes: d2eae8e98d59 ("drm/i915/dg2:

[PATCH v3 3/4] drm/i915/gt: Disable HW load balancing for CCS

2024-02-29 Thread Andi Shyti
The hardware should not dynamically balance the load between CCS engines. Wa_14019159160 recommends disabling it across all platforms. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matt Roper Cc: # v6.2+ -

[PATCH v3 2/4] drm/i915/gt: Do not exposed fused off engines.

2024-02-29 Thread Andi Shyti
Some of the CCS engines are disabled. They should not be listed in the uabi_engine list, that is the list of engines that the user can see. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") Requires: 4e4f77d74878 ("drm/i915/gt: Refactor uabi engine class/instance list creation")

[PATCH v3 1/4] drm/i915/gt: Refactor uabi engine class/instance list creation

2024-02-29 Thread Andi Shyti
For the upcoming changes we need a cleaner way to build the list of uabi engines. Suggested-by: Tvrtko Ursulin Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_engine_user.c | 29 - 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i9

[PATCH v3 0/4] Disable automatic load CCS load balancing

2024-02-29 Thread Andi Shyti
Hi, this series does basically two things: 1. Disables automatic load balancing as adviced by the hardware workaround. 2. Assigns all the CCS slices to one single user engine. The user will then be able to query only one CCS engine I'm using here the "Requires: " tag, but I'm not sure the

✗ Fi.CI.BAT: failure for drm/i915: Use drm_printer more (rev4)

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev4) URL : https://patchwork.freedesktop.org/series/129956/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14370 -> Patchwork_129956v4 Summary --- **FAILUR

✗ Fi.CI.SPARSE: warning for drm/i915: Use drm_printer more (rev4)

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev4) URL : https://patchwork.freedesktop.org/series/129956/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use drm_printer more (rev4)

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev4) URL : https://patchwork.freedesktop.org/series/129956/ State : warning == Summary == Error: dim checkpatch failed 1b6df16a7ddc drm/i915: Indicate which pipe failed the fastset check overall a2e117546ece drm/i915: Include CRTC i

✓ Fi.CI.IGT: success for drm/dp: Fix documentation of DP tunnel functions

2024-02-29 Thread Patchwork
== Series Details == Series: drm/dp: Fix documentation of DP tunnel functions URL : https://patchwork.freedesktop.org/series/130517/ State : success == Summary == CI Bug Log - changes from CI_DRM_14362_full -> Patchwork_130517v1_full Summar

Re: [PATCH] drm/i915: fix applying placement flag

2024-02-29 Thread Stephen Rothwell
Hi Christian, On Thu, 29 Feb 2024 14:01:05 +0100 Christian König wrote: > > Gentle ping. Can I get an rb for that? If it is me you are waiting for, I am not really able to review it (or test its functionality), but I did apply it to the merge of the drm tree yesterday and it did fix the build p

✗ Fi.CI.BAT: failure for Enable Adaptive Sync SDP Support for DP (rev14)

2024-02-29 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev14) URL : https://patchwork.freedesktop.org/series/126829/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14370 -> Patchwork_126829v14 Summary ---

✗ Fi.CI.SPARSE: warning for Enable Adaptive Sync SDP Support for DP (rev14)

2024-02-29 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev14) URL : https://patchwork.freedesktop.org/series/126829/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable Adaptive Sync SDP Support for DP (rev14)

2024-02-29 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev14) URL : https://patchwork.freedesktop.org/series/126829/ State : warning == Summary == Error: dim checkpatch failed 5de8093d121a drm/dp: Add support to indicate if sink supports AS SDP bf8049b39bb1 drm: Add Adaptive Syn

[PATCH 4/4] drm/i915: Streamline eDP handling in icl_combo_phy_aux_power_well_enable()

2024-02-29 Thread Ville Syrjala
From: Ville Syrjälä Drop the pointless phy/port detour from the eDP handling in icl_combo_phy_aux_power_well_enable(). We can just directly consult the dig_port and determine whether it's eDP or not. This also removes the assumption that port==phy, although that is always trued on ICL, so it was

[PATCH 3/4] drm/i915: Use pw_idx to derive PHY for ICL_LANE_ENABLE_AUX override

2024-02-29 Thread Ville Syrjala
From: Ville Syrjälä We don't actually know whether we should be picking the PHY simply based on the AUX_CH/power well, or based on the VBT defined AUX_CH->DDI->PHY relationship. At the moment we are doing the former for the ANAOVRD workaround, and the latter for the ICL_LANE_ENABLE_AUX override.

[PATCH 2/4] drm/i915: Use REG_BIT() & co. in intel_combo_phy_regs.h

2024-02-29 Thread Ville Syrjala
From: Ville Syrjälä Modernize the ICL+ combo PHY register refinitions by using REG_BIT() & co. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_combo_phy_regs.h | 114 +- 1 file changed, 55 insertions(+), 59 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i

[PATCH 1/4] drm/i915: Rename ICL_AUX_ANAOVRD1 to ICL_PORT_TX_DW6_AUX

2024-02-29 Thread Ville Syrjala
From: Ville Syrjälä ICL_AUX_ANAOVRD1 is actually ICL_PORT_TX_DW6_AUX. Give it its proper name, and relocate to the correct file (intel_combo_phy_regs.h). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_combo_phy_regs.h | 6 ++ drivers/gpu/drm/i915/display/intel_disp

RE: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Golani, Mitulkumar Ajitkumar
> On Thu, 29 Feb 2024, "Golani, Mitulkumar Ajitkumar" > wrote: > > Thought behind this was to use the function where it was defined. But > > no worries, I have split it with new patch series floated. > > Please do not rush to send so many new versions! Let the review come to a > conclusion first.

Re: [PATCH v2 06/12] drm/i915: Convert intel_dpll_dump_hw_state() to drm_printer

2024-02-29 Thread Jani Nikula
On Thu, 29 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Utilize drm_printer in pipe_config_pll_mismatch() to avoid > a bit of code duplication. > > To achieve this we need to plumb the printer all way to the > dpll_mgr .dump_hw_state() functions. Those are also used by > intel_crtc_st

RE: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Jani Nikula
On Thu, 29 Feb 2024, "Golani, Mitulkumar Ajitkumar" wrote: > Thought behind this was to use the function where it was defined. But > no worries, I have split it with new patch series floated. Please do not rush to send so many new versions! Let the review come to a conclusion first. BR, Jani.

✗ Fi.CI.BAT: failure for drm/i915: Add missing doc for drm_i915_reset_stats

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915: Add missing doc for drm_i915_reset_stats URL : https://patchwork.freedesktop.org/series/130562/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14368 -> Patchwork_130562v1 Summary --

✗ Fi.CI.SPARSE: warning for drm/i915: Add missing doc for drm_i915_reset_stats

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915: Add missing doc for drm_i915_reset_stats URL : https://patchwork.freedesktop.org/series/130562/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v2 12/12] drm/i915: Create the printer only once in intel_pipe_config_compare()

2024-02-29 Thread Ville Syrjala
From: Ville Syrjälä Create the drm_printer at the start of intel_pipe_config_compare() and pass it on to all the mismatch() functions. v2: Rebase Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 101 +-- 1 file changed,

[PATCH v2 11/12] drm/i915: Reuse pipe_config_mismatch() more

2024-02-29 Thread Ville Syrjala
From: Ville Syrjälä Just call pipe_config_mismatch() from all the more specialized mismatch() functions instead of hand rolling the same printfs all over. v2: Eliminate the dpll drm_debug_enabled() in an earlier patch (Jani) Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/g

[PATCH v2 06/12] drm/i915: Convert intel_dpll_dump_hw_state() to drm_printer

2024-02-29 Thread Ville Syrjala
From: Ville Syrjälä Utilize drm_printer in pipe_config_pll_mismatch() to avoid a bit of code duplication. To achieve this we need to plumb the printer all way to the dpll_mgr .dump_hw_state() functions. Those are also used by intel_crtc_state_dump() which needs to be adjusted as well. v2: Conve

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-29 Thread Andy Shevchenko
On Thu, Feb 29, 2024 at 12:21:34PM -0600, Lucas De Marchi wrote: > On Thu, Feb 29, 2024 at 12:49:57PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 28, 2024 at 05:39:21PM -0600, Lucas De Marchi wrote: > > > On Thu, Feb 22, 2024 at 06:49:59AM -0800, Yury Norov wrote: ... > > > I build-tested this

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-29 Thread Lucas De Marchi
On Thu, Feb 29, 2024 at 12:49:57PM +0200, Andy Shevchenko wrote: On Wed, Feb 28, 2024 at 05:39:21PM -0600, Lucas De Marchi wrote: On Thu, Feb 22, 2024 at 06:49:59AM -0800, Yury Norov wrote: > On Wed, Feb 21, 2024 at 03:59:06PM -0600, Lucas De Marchi wrote: > > On Wed, Feb 21, 2024 at 11:04:22PM

✗ Fi.CI.BAT: failure for series starting with [1/2] drm/ttm: improve idle/busy handling v5

2024-02-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/ttm: improve idle/busy handling v5 URL : https://patchwork.freedesktop.org/series/130561/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14368 -> Patchwork_130561v1

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/ttm: improve idle/busy handling v5

2024-02-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/ttm: improve idle/busy handling v5 URL : https://patchwork.freedesktop.org/series/130561/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/ttm: improve idle/busy handling v5

2024-02-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/ttm: improve idle/busy handling v5 URL : https://patchwork.freedesktop.org/series/130561/ State : warning == Summary == Error: dim checkpatch failed e4e8442e7666 drm/ttm: improve idle/busy handling v5 -:27: WARNING:BAD_SIGN_OFF: Unexp

Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-02-29 Thread Souza, Jose
On Thu, 2024-02-29 at 16:44 +, Souza, Jose wrote: > On Wed, 2024-02-28 at 06:04 -0800, José Roberto de Souza wrote: > > On Wed, 2024-02-28 at 16:02 +0200, Juha-Pekka Heikkila wrote: > > > AuxCCS framebuffers don't work on Xe driver hence disable them > > > from plane capabilities until they are

✓ Fi.CI.BAT: success for drm/i915/dp: Fix connector DSC HW state readout (rev2)

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915/dp: Fix connector DSC HW state readout (rev2) URL : https://patchwork.freedesktop.org/series/129540/ State : success == Summary == CI Bug Log - changes from CI_DRM_14368 -> Patchwork_129540v2 Summary --

✗ Fi.CI.IGT: failure for Enable Adaptive Sync SDP Support for DP (rev12)

2024-02-29 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev12) URL : https://patchwork.freedesktop.org/series/126829/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14361_full -> Patchwork_126829v12_full Summar

✓ Fi.CI.BAT: success for drm/i915/mtl: Update workaround 14018575942 (rev2)

2024-02-29 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update workaround 14018575942 (rev2) URL : https://patchwork.freedesktop.org/series/130490/ State : success == Summary == CI Bug Log - changes from CI_DRM_14368 -> Patchwork_130490v2 Summary --

[PATCH v14 9/9] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-29 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --g

[PATCH v14 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --git a/

[PATCH v14 6/9] drm/i915/display: Compute AS SDP parameters

2024-02-29 Thread Mitul Golani
Add necessary function definitions to compute AS SDP data. The new intel_dp_compute_as_sdp function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Added DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx(). [Ankit] - Separated

[PATCH v14 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-02-29 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 9 insertions(+

[PATCH v14 8/9] drm/i915/display: Compute vrr_vsync params

2024-02-29 Thread Mitul Golani
Compute vrr_vsync_start/end, which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit) - Updated bit fields of VRR_VSYNC_START/END. (Ankit) --v3: - Add PIPE_CONF_CHECK_I(vrr.

[PATCH v14 2/9] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Mitul Golani
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - Use 'as_sdp' instead of 'async' [Ankit] - Correct define placeholders to where they are actually used. [J

[PATCH v14 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - Remove unrelated comments and changes. [Jani] -

[PATCH v14 3/9] drm: Add crtc state dump for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files changed, 14 insertions(+) dif

[PATCH v14 0/9] Enable Adaptive Sync SDP Support for DP

2024-02-29 Thread Mitul Golani
An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. Computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR) in the context of Adaptive Sync. --v2: - Update logging to Patch

[PATCH v14 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-02-29 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display/drm_d

Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-02-29 Thread Souza, Jose
On Wed, 2024-02-28 at 06:04 -0800, José Roberto de Souza wrote: > On Wed, 2024-02-28 at 16:02 +0200, Juha-Pekka Heikkila wrote: > > AuxCCS framebuffers don't work on Xe driver hence disable them > > from plane capabilities until they are fixed. FlatCCS framebuffers > > work and they are left enable

RE: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nikula, Jani > Sent: Thursday, February 29, 2024 4:08 PM > To: Golani, Mitulkumar Ajitkumar ; > intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Nautiyal, Ankit K > ; Golani, Mitulkumar Ajitkumar > > Subject: Re: [PATCH v12 2/8] drm: A

[PATCH v13 8/8] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-29 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --g

[PATCH v13 6/8] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --git a/

[PATCH v13 7/8] drm/i915/display: Compute vrr_vsync params

2024-02-29 Thread Mitul Golani
Compute vrr_vsync_start/end, which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit) - Updated bit fields of VRR_VSYNC_START/END. (Ankit) --v3: - Add PIPE_CONF_CHECK_I(vrr.

[PATCH v13 3/8] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - Remove unrelated comments and changes. [Jani] -

[PATCH v13 4/8] drm/i915/dp: Add wrapper function to check AS SDP

2024-02-29 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 9 insertions(+

[PATCH v13 5/8] drm/i915/display: Compute AS SDP parameters

2024-02-29 Thread Mitul Golani
Add necessary function definitions to compute AS SDP data. The new intel_dp_compute_as_sdp function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Added DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx(). [Ankit] - Separated

[PATCH v13 2/8] drm: Add crtc state dump for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. --v2: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. Signed-off-by: Mitul Golani --- .../gpu/drm/i915/display/intel_crtc_

[PATCH v13 1/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Mitul Golani
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - Use 'as_sdp' instead of 'async' [Ankit] - Correct define placeholders to where they are actually used. [J

[PATCH v13 0/8] Enable Adaptive Sync SDP Support for DP

2024-02-29 Thread Mitul Golani
An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. Computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR) in the context of Adaptive Sync. --v2: - Update logging to Patch

Re: [PATCH 12/12] drm/i915: Create the printer only once in intel_pipe_config_compare()

2024-02-29 Thread Jani Nikula
On Thu, 15 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Create the drm_printer at the start of intel_pipe_config_compare() > and pass it on to all the mismatch() functions. Nice! Reviewed-by: Jani Nikula > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/inte

Re: [PATCH] drm/i915: Add missing doc for drm_i915_reset_stats

2024-02-29 Thread Andi Shyti
Hi Nirmoy, On Thu, Feb 29, 2024 at 02:29:18PM +0100, Nirmoy Das wrote: > Add missing doc for struct drm_i915_reset_stats. > > Cc: Andi Shyti > Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH 11/12] drm/i915: Reuse pipe_config_mismatch() more

2024-02-29 Thread Jani Nikula
On Thu, 15 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Just call pipe_config_mismatch() from all the more specialized > mismatch() functions instead of hand rolling the same printfs > all over. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c |

Re: [PATCH 10/12] drm/i915: Relocate pipe_config_mismatch()

2024-02-29 Thread Jani Nikula
On Thu, 15 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Hoist pipe_config_mismatch() upwards a bit so that it can get > reused by the other mismatch() functions. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 46 ++

Re: [PATCH 09/12] drm/i915: Skip intel_crtc_state_dump() if debugs aren't enabled

2024-02-29 Thread Jani Nikula
On Thu, 29 Feb 2024, Jani Nikula wrote: > On Thu, 15 Feb 2024, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> intel_crtc_state_dump() does a whole boatload of string formatting >> which is all wasted energy if the debugs aren't even enabled. Skip >> the whole thing in that case. > > I wonder

Re: [PATCH 09/12] drm/i915: Skip intel_crtc_state_dump() if debugs aren't enabled

2024-02-29 Thread Jani Nikula
On Thu, 15 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_crtc_state_dump() does a whole boatload of string formatting > which is all wasted energy if the debugs aren't even enabled. Skip > the whole thing in that case. I wonder how something like this would work to skip it in a

Re: [PATCH v3 0/6] VBT read cleanup

2024-02-29 Thread Jani Nikula
On Wed, 28 Feb 2024, Radhakrishna Sripada wrote: > This series is originally based out of [1], and built on top of [2]. > > The primary departure from [1] was that vbt is no longer cached. During vbt > show, based on the source of vbt, it would simply be re-read reducing the > read/cleanup comple

Re: [PATCH] drm/i915/lnl: Modeset sequence change for DP on LNL

2024-02-29 Thread Jani Nikula
On Thu, 29 Feb 2024, Shekhar Chauhan wrote: > Currently, the driver is only waiting for 1ms for > idle patterns. But starting from LNL and beyond, > the MST wants the driver to wait for 1640us before > timing out (which we round up to 2ms). > > BSpec: 68849 > Signed-off-by: Shekhar Chauhan Repli

Re: [PATCH] drm/i915/display: Save a few bytes of memory in intel_backlight_device_register()

2024-02-29 Thread Jani Nikula
On Fri, 23 Feb 2024, Christophe JAILLET wrote: > 'name' may still be "intel_backlight" when backlight_device_register() is > called. > In such a case, using kstrdup_const() saves a memory duplication when > dev_set_name() is called in backlight_device_register(). > > Use kfree_const() accordingly.

Re: [PATCH] MAINTAINERS: Update email address for Tvrtko Ursulin

2024-02-29 Thread Rodrigo Vivi
On Wed, Feb 28, 2024 at 02:22:40PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I will lose access to my @.*intel.com e-mail addresses soon so let me > adjust the maintainers entry and update the mailmap too. > > While at it consolidate a few other of my old emails to point to the > m

Re: [PATCH v2 3/3] drm/i915/bios: abstract child device expected size

2024-02-29 Thread Jani Nikula
On Thu, 29 Feb 2024, Ville Syrjälä wrote: > On Mon, Feb 26, 2024 at 07:58:54PM +0200, Jani Nikula wrote: >> Add a function to return the expected child device size. Flip the if >> ladder around and use the same versions as in documentation to make it >> easier to verify. Return an error for unknow

Re: [PULL] drm-misc-fixes

2024-02-29 Thread Matthew Auld
On 29/02/2024 13:37, Maxime Ripard wrote: Hi, Here's this week drm-misc fixes PR. There's two commits for files unders drivers/soc/qcom that don't have a maintainer Acked-by. Bjorn's Acked-by was provided on IRC, and Konrad provided it by mail after the facts so we're covered. Maxime drm-misc

[PATCH] drm/i915: Add missing doc for drm_i915_reset_stats

2024-02-29 Thread Nirmoy Das
Add missing doc for struct drm_i915_reset_stats. Cc: Andi Shyti Signed-off-by: Nirmoy Das --- include/uapi/drm/i915_drm.h | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index 2ee338860b7e..1279a6b2b

[PATCH 2/2] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2024-02-29 Thread Christian König
Try to fill up VRAM as well by setting the busy flag on GTT allocations. This fixes the issue that when VRAM was evacuated for suspend it's never filled up again unless the application is restarted. Signed-off-by: Christian König Reviewed-by: Zack Rusin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ob

[PATCH 1/2] drm/ttm: improve idle/busy handling v5

2024-02-29 Thread Christian König
Previously we would never try to move a BO into the preferred placements when it ever landed in a busy placement since those were considered compatible. Rework the whole handling and finally unify the idle and busy handling. ttm_bo_validate() is now responsible to try idle placement first and then

[PULL] drm-misc-fixes

2024-02-29 Thread Maxime Ripard
Hi, Here's this week drm-misc fixes PR. There's two commits for files unders drivers/soc/qcom that don't have a maintainer Acked-by. Bjorn's Acked-by was provided on IRC, and Konrad provided it by mail after the facts so we're covered. Maxime drm-misc-fixes-2024-02-29: A reset fix for host1x, a

[PULL] drm-xe-fixes

2024-02-29 Thread Thomas Hellstrom
Dave, Sima The xe fixes for -rc7. It's mostly uapi sanitizing and future-proofing, and a couple of driver fixes. drm-xe-fixes-2024-02-29: UAPI Changes: - A couple of tracepoint updates from Priyanka and Lucas. - Make sure BINDs are completed before accepting UNBINDs on LR vms. - Don't arbitrarily

Re: [PATCH] drm/i915: fix applying placement flag

2024-02-29 Thread Christian König
Gentle ping. Can I get an rb for that? Thanks, Christian. Am 26.02.24 um 15:27 schrieb Christian König: Switching from a separate list to flags introduced a bug here. We were accidentially ORing the flag before initailizing the placement and not after. So this code didn't do nothing except pro

Re: [PATCH] drm/i915: Remove unneeded double drm_rect_visible call in check_overlay_dst

2024-02-29 Thread Ville Syrjälä
On Wed, Feb 28, 2024 at 09:32:47PM +0300, Nikita Kiryushin wrote: > > check_overlay_dst for clipped is called 2 times: in drm_rect_intersect > and than directly. Change second call for check of drm_rect_intersect > result to save some time (in locked code section). > > Found by Linux Verificati

Re: [PATCH v2 3/3] drm/i915/bios: abstract child device expected size

2024-02-29 Thread Ville Syrjälä
On Mon, Feb 26, 2024 at 07:58:54PM +0200, Jani Nikula wrote: > Add a function to return the expected child device size. Flip the if > ladder around and use the same versions as in documentation to make it > easier to verify. Return an error for unknown versions. No functional > changes. > > v2: Mo

Re: [PATCH] MAINTAINERS: Update email address for Tvrtko Ursulin

2024-02-29 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2024-02-28 16:22:40) > From: Tvrtko Ursulin > > I will lose access to my @.*intel.com e-mail addresses soon so let me > adjust the maintainers entry and update the mailmap too. > > While at it consolidate a few other of my old emails to point to the > main one. > > Signe

Re: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Nautiyal, Ankit K
On 2/29/2024 4:53 PM, Jani Nikula wrote: On Thu, 29 Feb 2024, "Nautiyal, Ankit K" wrote: On 2/28/2024 8:08 PM, Mitul Golani wrote: +enum operation_mode { + DP_AS_SDP_AVT_DYNAMIC_VTOTAL = 0x00, + DP_AS_SDP_AVT_FIXED_VTOTAL = 0x01, + DP_AS_SDP_FAVT_TRR_NOT_REACHED = 0x02, +

Re: [PATCH 00/12] drm/i915: Use drm_printer more

2024-02-29 Thread Jani Nikula
On Thu, 15 Feb 2024, Ville Syrjala wrote: > Convert the entire state dumper and state checker to > use drm_printer. I've backmerged drm-next to drm-intel-next to get the required drm_printer stuff, so it's actually possible to merge this. BR, Jani. -- Jani Nikula, Intel

Re: [PATCH v12 6/8] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-29 Thread Nautiyal, Ankit K
On 2/28/2024 8:08 PM, Mitul Golani wrote: Enable infoframe and add state checker for Adaptive Sync SDP enablement. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 drivers/gpu/drm/i915/display/intel_dp.c | 2 + 2 files changed,

Re: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Jani Nikula
On Thu, 29 Feb 2024, "Nautiyal, Ankit K" wrote: > On 2/28/2024 8:08 PM, Mitul Golani wrote: >> +enum operation_mode { >> +DP_AS_SDP_AVT_DYNAMIC_VTOTAL = 0x00, >> +DP_AS_SDP_AVT_FIXED_VTOTAL = 0x01, >> +DP_AS_SDP_FAVT_TRR_NOT_REACHED = 0x02, >> +DP_AS_SDP_FAVT_TRR_REACHED = 0x03 >>

  1   2   >