Re: [PATCH v2 8/9] drm/i915: Perform vblank evasion around legacy cursor updates

2024-01-17 Thread Hogander, Jouni

Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2024-01-17 Thread Sharma, Swati2
On 17-Jan-24 11:31 PM, Jani Nikula wrote: On Wed, 17 Jan 2024, "Sharma, Swati2" wrote: Hi Ville, On 25-Oct-23 6:29 PM, Ville Syrjälä wrote: On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote: diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/displa

✓ Fi.CI.BAT: success for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev7)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev7) URL : https://patchwork.freedesktop.org/series/123813/ State : success == Summary == CI Bug Log - changes from CI_DRM_14135 -> Patchwork_123813v7 Summary -

✗ Fi.CI.SPARSE: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev7)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev7) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev7)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev7) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim checkpatch failed 9d7e1cd4555f drm/i915: Enable Wa_16019325821 13d2fbbcd57b drm/i915/guc: Add support for w/a KLV

✗ Fi.CI.BAT: failure for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev6)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev6) URL : https://patchwork.freedesktop.org/series/123813/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14134 -> Patchwork_123813v6 Summary -

✗ Fi.CI.SPARSE: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev6)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev6) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev6)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev6) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim checkpatch failed 75a9987b2382 drm/i915: Enable Wa_16019325821 c54ac284eef0 drm/i915/guc: Add support for w/a KLV

Re: [PATCH] drm/i915: move interrupt save/restore into vblank section helpers

2024-01-17 Thread kernel test robot
Hi Luca, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip linus/master next-20240117] [cannot apply to drm-intel/for-linux-next-fixes v6.7] [If your patch is applied to the wrong git tree, kindly

✗ Fi.CI.BAT: failure for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5) URL : https://patchwork.freedesktop.org/series/123813/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14133 -> Patchwork_123813v5 Summary -

✗ Fi.CI.SPARSE: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5)

2024-01-17 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim checkpatch failed 1290ab959552 drm/i915: Enable Wa_16019325821 972bfeee9fdc drm/i915/guc: Add support for w/a KLV

Re: [i-g-t 1/1] drm/i915/display: Dump display parameters to i915_display_capabilities

2024-01-17 Thread Jani Nikula
On Wed, 17 Jan 2024, Bhanuprakash Modem wrote: > Include Display parameters in i915_display_capabilities debugfs. Maybe remove them from i915_capabilities? What's the point in having them in two places? (Or three, if you count the actual debugfs interface to the params!) > > Cc: Jouni Högander

Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2024-01-17 Thread Jani Nikula
On Wed, 17 Jan 2024, "Sharma, Swati2" wrote: > Hi Ville, > > On 25-Oct-23 6:29 PM, Ville Syrjälä wrote: >> On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote: >>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c >>> b/drivers/gpu/drm/i915/display/intel_dp.c >>> index 4f6835a7

Re: [PATCH v3 05/16] drm/i915: Disable the "binder"

2024-01-17 Thread Nirmoy Das
On 1/17/2024 3:13 PM, Michał Winiarski wrote: On Tue, Jan 16, 2024 at 09:56:25AM +0200, Ville Syrjala wrote: From: Ville Syrjälä Now that the GGTT PTE updates go straight to GSMBASE (bypassing GTTMMADR) there should be no more risk of system hangs? So the "binder" (ie. update the PTEs via MI

Re: [PATCH] drm/i915: move interrupt save/restore into vblank section helpers

2024-01-17 Thread kernel test robot
Hi Luca, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip linus/master next-20240117] [cannot apply to drm-intel/for-linux-next-fixes v6.7] [If your patch is applied to the wrong git tree, kindly

✗ Fi.CI.BAT: failure for QGV/SAGV related fixes (rev4)

2024-01-17 Thread Patchwork
== Series Details == Series: QGV/SAGV related fixes (rev4) URL : https://patchwork.freedesktop.org/series/126962/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14132 -> Patchwork_126962v4 Summary --- **FAILURE** S

[i-g-t 1/1] drm/i915/display: Dump display parameters to i915_display_capabilities

2024-01-17 Thread Bhanuprakash Modem
Include Display parameters in i915_display_capabilities debugfs. Cc: Jouni Högander Signed-off-by: Bhanuprakash Modem --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/

✗ Fi.CI.SPARSE: warning for QGV/SAGV related fixes (rev4)

2024-01-17 Thread Patchwork
== Series Details == Series: QGV/SAGV related fixes (rev4) URL : https://patchwork.freedesktop.org/series/126962/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warni

✗ Fi.CI.CHECKPATCH: warning for QGV/SAGV related fixes (rev4)

2024-01-17 Thread Patchwork
== Series Details == Series: QGV/SAGV related fixes (rev4) URL : https://patchwork.freedesktop.org/series/126962/ State : warning == Summary == Error: dim checkpatch failed 9d8849950f20 drm/i915: Add meaningful traces for QGV point info error handling 27f440447eae drm/i915: Extract code requir

Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2024-01-17 Thread Sharma, Swati2
Hi Ville, On 25-Oct-23 6:29 PM, Ville Syrjälä wrote: On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote: For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs.

✗ Fi.CI.BAT: failure for drm/i915: (stolen) memory region related fixes (rev7)

2024-01-17 Thread Patchwork
== Series Details == Series: drm/i915: (stolen) memory region related fixes (rev7) URL : https://patchwork.freedesktop.org/series/127721/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14132 -> Patchwork_127721v7 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915: (stolen) memory region related fixes (rev7)

2024-01-17 Thread Patchwork
== Series Details == Series: drm/i915: (stolen) memory region related fixes (rev7) URL : https://patchwork.freedesktop.org/series/127721/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: (stolen) memory region related fixes (rev7)

2024-01-17 Thread Patchwork
== Series Details == Series: drm/i915: (stolen) memory region related fixes (rev7) URL : https://patchwork.freedesktop.org/series/127721/ State : warning == Summary == Error: dim checkpatch failed 420bd052296b drm/i915: Use struct resource for memory region IO as well -:388: WARNING:LONG_LINE:

[PATCH 2/3] drm/i915: Extract code required to calculate max qgv/psf gv point

2024-01-17 Thread Stanislav Lisovskiy
We need that in order to force disable SAGV in next patch. Also it is beneficial to separate that code, as in majority cases, when SAGV is enabled, we don't even need those calculations. Also we probably need to determine max PSF GV point as well, however currently we don't do that when we disable

[PATCH 3/3] drm/i915: Disable SAGV on bw init, to force QGV point recalculation

2024-01-17 Thread Stanislav Lisovskiy
Problem is that on some platforms, we do get QGV point mask in wrong state on boot. However driver assumes it is set to 0 (i.e all points allowed), however in reality we might get them all restricted, causing issues. Lets disable SAGV initially to force proper QGV point state. If more QGV points ar

[PATCH 1/3] drm/i915: Add meaningful traces for QGV point info error handling

2024-01-17 Thread Stanislav Lisovskiy
For debug purposes we need those - error path won't flood the log, however there has been already numerous cases, when due to lack of debugs, we couldn't immediately tell what was the problem on customer machine, which slowed down the investigation, requiring to get access to target device and addi

[PATCH 0/3] QGV/SAGV related fixes

2024-01-17 Thread Stanislav Lisovskiy
We have couple of customer issues, related to SAGV/QGV point calculation. Those patches contain fixes plus some additional debugs for those issues. Stanislav Lisovskiy (3): drm/i915: Add meaningful traces for QGV point info error handling drm/i915: Extract code required to calculate max qgv/ps

Re: [PATCH v3 05/16] drm/i915: Disable the "binder"

2024-01-17 Thread Michał Winiarski
On Tue, Jan 16, 2024 at 09:56:25AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that the GGTT PTE updates go straight to GSMBASE (bypassing > GTTMMADR) there should be no more risk of system hangs? So the > "binder" (ie. update the PTEs via MI_UPDATE_GTT) is no longer > necessary, di

✓ Fi.CI.BAT: success for drm/i915/opregion: remove unused lid_state

2024-01-17 Thread Patchwork
== Series Details == Series: drm/i915/opregion: remove unused lid_state URL : https://patchwork.freedesktop.org/series/128878/ State : success == Summary == CI Bug Log - changes from CI_DRM_14132 -> Patchwork_128878v1 Summary --- **S

✗ Fi.CI.BUILD: failure for drm/i915: move interrupt save/restore into vblank section helpers

2024-01-17 Thread Patchwork
== Series Details == Series: drm/i915: move interrupt save/restore into vblank section helpers URL : https://patchwork.freedesktop.org/series/128869/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] driv

Re: [PATCH v2 8/9] drm/i915: Perform vblank evasion around legacy cursor updates

2024-01-17 Thread Hogander, Jouni

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-17 Thread Andri Yngvason
mið., 17. jan. 2024 kl. 09:21 skrifaði Pekka Paalanen : > > On Tue, 16 Jan 2024 14:11:43 + > Andri Yngvason wrote: > > > þri., 16. jan. 2024 kl. 13:29 skrifaði Sebastian Wick > > : > > > > > > On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: > > [...] > > > > şri., 16. jan. 2024

Re: [PATCH] drm/i915/opregion: remove unused lid_state

2024-01-17 Thread Ville Syrjälä
On Wed, Jan 17, 2024 at 02:25:46PM +0200, Jani Nikula wrote: > Not sure if lid_state has ever been used, but at least not for a long > time. Remove it. It was probably used when we had that disgusting lid notifier thing, but that got killed some years ago. > > Suggested-by: Ville Syrjälä > Sign

Re: [PATCH 6/6] drm/i915/opregion: make struct intel_opregion opaque

2024-01-17 Thread Jani Nikula
On Wed, 17 Jan 2024, Ville Syrjälä wrote: > lid_state is unused btw. Someone should throw a nuke at it. Done. https://patchwork.freedesktop.org/patch/msgid/20240117122546.1551400-1-jani.nik...@intel.com -- Jani Nikula, Intel

Re: [PATCH 3/5] drm/ttm: replace busy placement with flags v6

2024-01-17 Thread Thomas Hellström
On 1/17/24 11:47, Thomas Hellström wrote: Hi, Christian Xe changes look good. Will send the series to xe ci to check for regressions. Hmm, there are some checkpatch warnings about author / SOB email mismatch, But worserthere are some regressions in the dma-buf ktest (it tests evicting of

[PATCH] drm/i915/opregion: remove unused lid_state

2024-01-17 Thread Jani Nikula
Not sure if lid_state has ever been used, but at least not for a long time. Remove it. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_opregion.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/d

Re: [PATCH 0/9] drm/i915: Cursor vblank evasion

2024-01-17 Thread Ville Syrjälä
On Wed, Jan 17, 2024 at 11:30:10AM +, Shankar, Uma wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Wednesday, December 13, 2023 3:55 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH 0/9] drm/i915: Cursor vblank evasion > >

RE: [PATCH 0/9] drm/i915: Cursor vblank evasion

2024-01-17 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, December 13, 2023 3:55 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 0/9] drm/i915: Cursor vblank evasion > > From: Ville Syrjälä > > MTL seems very good at racing the cursor mailbox up

Re: [PATCH 6/6] drm/i915/opregion: make struct intel_opregion opaque

2024-01-17 Thread Ville Syrjälä
On Thu, Jan 11, 2024 at 07:21:19PM +0200, Jani Nikula wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c > b/drivers/gpu/drm/i915/display/intel_opregion.c > index 26aacb01f9ec..3f5a20f9153e 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.c > +++ b/drivers/gpu/drm/i915/d

Re: [PATCH 2/3] drm/i915: Extract code required to calculate max qgv/psf gv point

2024-01-17 Thread Lisovskiy, Stanislav
On Wed, Jan 17, 2024 at 01:12:49PM +0200, Ville Syrjälä wrote: > On Wed, Jan 17, 2024 at 12:12:18PM +0200, Lisovskiy, Stanislav wrote: > > On Fri, Jan 12, 2024 at 07:35:24PM +0200, Ville Syrjälä wrote: > > > On Tue, Nov 28, 2023 at 10:37:53AM +0200, Stanislav Lisovskiy wrote: > > > > We need that i

Re: [PATCH 2/3] drm/i915: Extract code required to calculate max qgv/psf gv point

2024-01-17 Thread Ville Syrjälä
On Wed, Jan 17, 2024 at 12:12:18PM +0200, Lisovskiy, Stanislav wrote: > On Fri, Jan 12, 2024 at 07:35:24PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 28, 2023 at 10:37:53AM +0200, Stanislav Lisovskiy wrote: > > > We need that in order to force disable SAGV in next patch. > > > Also it is beneficia

Re: [PATCH 3/5] drm/ttm: replace busy placement with flags v6

2024-01-17 Thread Thomas Hellström
Hi, Christian Xe changes look good. Will send the series to xe ci to check for regressions. /Thomas On 1/12/24 13:51, Christian König wrote: From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is

Re: [PATCH 2/5] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-17 Thread Thomas Hellström
Hi, On 1/12/24 13:51, Christian König wrote: Only convert it to ENOMEM in ttm_bo_validate. This allows ttm_bo_validate to distinct between an out of memory NIT: s/distinct/distinguish/ situation and just out of space in a placement domain. In fact it would be nice if this could be propagate

Re: [PATCH 2/3] drm/i915: Extract code required to calculate max qgv/psf gv point

2024-01-17 Thread Lisovskiy, Stanislav
On Fri, Jan 12, 2024 at 07:35:24PM +0200, Ville Syrjälä wrote: > On Tue, Nov 28, 2023 at 10:37:53AM +0200, Stanislav Lisovskiy wrote: > > We need that in order to force disable SAGV in next patch. > > Also it is beneficial to separate that code, as in majority cases, > > when SAGV is enabled, we do

[PATCH] drm/i915: move interrupt save/restore into vblank section helpers

2024-01-17 Thread Luca Coelho
In all cases when we call the new helper functions, we save/restore the interrupts, so we can move this to the helpers themselves. This improves the semantics of the helper functions by having all functionality needed to keep the section tight. This makes a slight functional change by calling the

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-17 Thread Pekka Paalanen
On Tue, 16 Jan 2024 14:11:43 + Andri Yngvason wrote: > þri., 16. jan. 2024 kl. 13:29 skrifaði Sebastian Wick > : > > > > On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: > [...] > > > şri., 16. jan. 2024 kl. 11:42 skrifaği Sebastian Wick > > > : > > > > > > > > On Mon, Jan

Re: [PATCH] Revert "drm/i915/dsi: Do display on sequence later on icl+"

2024-01-17 Thread Jani Nikula
On Tue, 16 Jan 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > This reverts commit 88b065943cb583e890324d618e8d4b23460d51a3. > > Lenovo 82TQ is unhappy if we do the display on sequence this > late. The display output shows severe corruption. > > It's unclear if this is a failure on our part

Re: [PATCH 3/5] drm/ttm: replace busy placement with flags v6

2024-01-17 Thread Thomas Zimmermann
Am 12.01.24 um 13:51 schrieb Christian König: From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ER

✓ Fi.CI.BAT: success for drm/i915: Cursor vblank evasion (rev3)

2024-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Cursor vblank evasion (rev3) URL : https://patchwork.freedesktop.org/series/127744/ State : success == Summary == CI Bug Log - changes from CI_DRM_14129 -> Patchwork_127744v3 Summary --- **SUCCE

✗ Fi.CI.BAT: failure for drm/i915/lnl: Block pkgC entry for performance improvemnt

2024-01-17 Thread Patchwork
== Series Details == Series: drm/i915/lnl: Block pkgC entry for performance improvemnt URL : https://patchwork.freedesktop.org/series/128863/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14129 -> Patchwork_128863v1 Summary