[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Fix Wa_22016670082 (rev3)

2023-11-24 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix Wa_22016670082 (rev3) URL : https://patchwork.freedesktop.org/series/126740/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13914_full -> Patchwork_126740v3_full Summary ---

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-24 Thread Luben Tuikov
On 2023-11-24 08:20, Jani Nikula wrote: > On Wed, 22 Nov 2023, Luben Tuikov wrote: >> On 2023-11-22 07:00, Maxime Ripard wrote: >>> Hi Luben, >>> >>> On Thu, Nov 16, 2023 at 09:27:58AM +0100, Daniel Vetter wrote: On Thu, Nov 16, 2023 at 09:11:43AM +0100, Maxime Ripard wrote: > On Tue, Nov

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cdclk: Remove divider field from tables

2023-11-24 Thread Patchwork
== Series Details == Series: drm/i915/cdclk: Remove divider field from tables URL : https://patchwork.freedesktop.org/series/126883/ State : success == Summary == CI Bug Log - changes from CI_DRM_13921 -> Patchwork_126883v1 Summary ---

[Intel-gfx] [PATCH] drm/i915/cdclk: Remove divider field from tables

2023-11-24 Thread Gustavo Sousa
The cdclk tables were introduced with commit 736da8112fee ("drm/i915: Use literal representation of cdclk tables"). It has been almost 4 years and the divider field was not really used yet. Let's remove it. Cc: Matt Roper Cc: Ville Syrjälä Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: drm debug and error logging improvements

2023-11-24 Thread Patchwork
== Series Details == Series: drm: drm debug and error logging improvements URL : https://patchwork.freedesktop.org/series/126873/ State : success == Summary == CI Bug Log - changes from CI_DRM_13921 -> Patchwork_126873v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: drm debug and error logging improvements

2023-11-24 Thread Patchwork
== Series Details == Series: drm: drm debug and error logging improvements URL : https://patchwork.freedesktop.org/series/126873/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: drm debug and error logging improvements

2023-11-24 Thread Patchwork
== Series Details == Series: drm: drm debug and error logging improvements URL : https://patchwork.freedesktop.org/series/126873/ State : warning == Summary == Error: dim checkpatch failed 7b64df342d65 drm/print: make drm_err_printer() device specific by using drm_err() 45344978bd87 drm/print

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915/psr: Include some basic PSR information in the state dump

2023-11-24 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/psr: Include some basic PSR information in the state dump URL : https://patchwork.freedesktop.org/series/126859/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13921 -> Patchwork_126859v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/psr: Include some basic PSR information in the state dump

2023-11-24 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/psr: Include some basic PSR information in the state dump URL : https://patchwork.freedesktop.org/series/126859/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✓ Fi.CI.IGT: success for DP DSC min/max src bpc fixes (rev5)

2023-11-24 Thread Patchwork
== Series Details == Series: DP DSC min/max src bpc fixes (rev5) URL : https://patchwork.freedesktop.org/series/125571/ State : success == Summary == CI Bug Log - changes from CI_DRM_13913_full -> Patchwork_125571v5_full Summary ---

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2023-11-24 Thread Andy Shevchenko
On Thu, Jan 12, 2017 at 12:23:16PM +0200, Ville Syrjälä wrote: > On Wed, Jan 11, 2017 at 04:51:16PM -0800, Ben Widawsky wrote: ... > > + memcpy(plane->modifiers, format_modifiers, > > + format_modifier_count * sizeof(format_modifiers[0])); > > Looks all right since we do the same for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: do not use cursor size reduction on MTL

2023-11-24 Thread Patchwork
== Series Details == Series: drm/i915/display: do not use cursor size reduction on MTL URL : https://patchwork.freedesktop.org/series/126857/ State : success == Summary == CI Bug Log - changes from CI_DRM_13920 -> Patchwork_126857v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: do not use cursor size reduction on MTL

2023-11-24 Thread Patchwork
== Series Details == Series: drm/i915/display: do not use cursor size reduction on MTL URL : https://patchwork.freedesktop.org/series/126857/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: do not use cursor size reduction on MTL

2023-11-24 Thread Patchwork
== Series Details == Series: drm/i915/display: do not use cursor size reduction on MTL URL : https://patchwork.freedesktop.org/series/126857/ State : warning == Summary == Error: dim checkpatch failed 7c3e726f8b53 drm/i915/display: do not use cursor size reduction on MTL -:19: CHECK:MACRO_ARG_

Re: [Intel-gfx] [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep()

2023-11-24 Thread Thierry Reding
On Sat, Nov 18, 2023 at 04:16:17PM +, Sean Young wrote: > In order to introduce a pwm api which can be used from atomic context, > we will need two functions for applying pwm changes: > > int pwm_apply_cansleep(struct pwm *, struct pwm_state *); > int pwm_apply_atomic(struct pwm *,

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-24 Thread Jani Nikula
On Wed, 22 Nov 2023, Luben Tuikov wrote: > On 2023-11-22 07:00, Maxime Ripard wrote: >> Hi Luben, >> >> On Thu, Nov 16, 2023 at 09:27:58AM +0100, Daniel Vetter wrote: >>> On Thu, Nov 16, 2023 at 09:11:43AM +0100, Maxime Ripard wrote: On Tue, Nov 14, 2023 at 06:46:21PM -0500, Luben Tuikov wro

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp_mst: Use helpers to get dsc min/max input bpc

2023-11-24 Thread Jani Nikula
On Thu, 23 Nov 2023, Ankit Nautiyal wrote: > Use helpers for source min/max input bpc with DSC. > > Signed-off-by: Ankit Nautiyal > Reviewed-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 -- > drivers/gpu/drm/i915/display/intel_dp.h | 2 ++ > drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display/: Add Read/Write support for Adaptive Sync SDP

2023-11-24 Thread Jani Nikula
On Thu, 23 Nov 2023, Mitul Golani wrote: > Add the necessary structures and functions to handle reading and > unpacking Adaptive Sync Secondary Data Packets. Also add support > to write and pack AS SDP. Also, subject prefix maybe "drm/i915/dp: ". > > Signed-off-by: Mitul Golani > --- > .../drm

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display/: Add Read/Write support for Adaptive Sync SDP

2023-11-24 Thread Jani Nikula
On Thu, 23 Nov 2023, Mitul Golani wrote: > Add the necessary structures and functions to handle reading and > unpacking Adaptive Sync Secondary Data Packets. Also add support > to write and pack AS SDP. > > Signed-off-by: Mitul Golani > --- > .../drm/i915/display/intel_display_types.h| 1 +

Re: [Intel-gfx] [PATCH 1/3] drm: Add Adaptive Sync SDP logging

2023-11-24 Thread Jani Nikula
On Thu, 23 Nov 2023, Mitul Golani wrote: > Add structure representing Adaptive Sync Secondary Data > Packet (AS SDP). Also, add Adaptive Sync SDP logging in > drm_dp_helper.c to facilitate debugging. > > Signed-off-by: Mitul Golani > --- > drivers/gpu/drm/display/drm_dp_helper.c | 15 +++

[Intel-gfx] [PATCH 8/8] drm/i915: use drm_printf() with the drm_err_printer intead of pr_err()

2023-11-24 Thread Jani Nikula
There's already a related drm_printer. Use it to preserve the context instead of a separate pr_err(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 6 +++--- drivers/gpu/drm/i915/selftests/i915_active.c| 4 ++-- 2 files changed, 5 insertions(+), 5 d

[Intel-gfx] [PATCH 7/8] drm/i915: switch from drm_debug_printer() to device specific drm_dbg_printer()

2023-11-24 Thread Jani Nikula
Prefer the device specific debug printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_driver.c | 3 ++- drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c| 3 ++- drivers/gpu/drm/i915/gt/intel_reset.c | 3 ++- drivers/gpu/drm/i915/gt/intel_workaround

[Intel-gfx] [PATCH 5/8] drm/mode: switch from drm_debug_printer() to device specific drm_dbg_printer()

2023-11-24 Thread Jani Nikula
Prefer the device specific debug printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_mode_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c index 8525ef851540..48fd2d67f352 100644 --- a/driv

[Intel-gfx] [PATCH 6/8] drm/dp: switch drm_dp_vsc_sdp_log() to struct drm_printer

2023-11-24 Thread Jani Nikula
Use the existing drm printer infrastructure instead of local macros. Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_helper.c | 17 +--- .../drm/i915/display/intel_crtc_state_dump.c | 5 ++-- drivers/gpu/drm/i915/display/intel_display.c | 27 +-- in

[Intel-gfx] [PATCH 3/8] drm/print: add drm_dbg_printer() for drm device specific printer

2023-11-24 Thread Jani Nikula
We've lacked a device specific debug printer. Add one. Take category into account too. __builtin_return_address(0) is inaccurate here, so don't use it. If necessary, we can later pass __func__ to drm_dbg_printer() by wrapping it inside a macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm

[Intel-gfx] [PATCH 4/8] drm/dp_mst: switch from drm_debug_printer() to device specific drm_dbg_printer()

2023-11-24 Thread Jani Nikula
Prefer the device specific debug printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 23 +++ 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topo

[Intel-gfx] [PATCH 2/8] drm/print: move enum drm_debug_category etc. earlier in drm_print.h

2023-11-24 Thread Jani Nikula
Avoid forward declarations in subsequent changes, but separate this movement to an independent change. Signed-off-by: Jani Nikula --- include/drm/drm_print.h | 190 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/include/drm/drm_print.h b/

[Intel-gfx] [PATCH 1/8] drm/print: make drm_err_printer() device specific by using drm_err()

2023-11-24 Thread Jani Nikula
With few users for drm_err_printer(), it's still feasible to convert it to be device specific. Use drm_err() under the hood. While at it, make the prefix optional. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 7 ++- drivers/gpu/drm/i915/gt/selftest_e

[Intel-gfx] [PATCH 0/8] drm: drm debug and error logging improvements

2023-11-24 Thread Jani Nikula
Make drm_err_printer() drm device specific, and add drm device specific drm_dbg_printer(). Switch code over to use them. Jani Nikula (8): drm/print: make drm_err_printer() device specific by using drm_err() drm/print: move enum drm_debug_category etc. earlier in drm_print.h drm/print: add dr

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Implement sel_fetch disable for planes (rev5)

2023-11-24 Thread Illipilli, TejasreeX
Hi, https://patchwork.freedesktop.org/series/114224/ - Re-reported Thanks, Tejasree From: Hogander, Jouni Sent: Thursday, November 23, 2023 1:53 PM To: LGCI Bug Filing ; intel-gfx@lists.freedesktop.org Subject: Re: ✗ Fi.CI.BAT: failure for Implement sel_fetch disable for planes (rev5) Hello,

[Intel-gfx] ✓ Fi.CI.BAT: success for Implement sel_fetch disable for planes (rev5)

2023-11-24 Thread Patchwork
== Series Details == Series: Implement sel_fetch disable for planes (rev5) URL : https://patchwork.freedesktop.org/series/114224/ State : success == Summary == CI Bug Log - changes from CI_DRM_13912 -> Patchwork_114224v5 Summary ---

Re: [Intel-gfx] [PATCH 1/5] drm/i915/psr: Include some basic PSR information in the state dump

2023-11-24 Thread Hogander, Jouni
On Fri, 2023-11-24 at 10:27 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently no one can figure out what the PSR code is doing since > we're including any of it in the basic state dump. Add at least the > bare minimum there. > > v2: Also dump has_panel_replay (Jouni) > > Cc: Jouni

Re: [Intel-gfx] [PATCH 1/4] drm/i915/psr: Don't send a NULL VSC SDP

2023-11-24 Thread Ville Syrjälä
On Thu, Nov 23, 2023 at 07:14:29AM +, Hogander, Jouni wrote: > On Wed, 2023-11-22 at 11:31 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The PSR code is unconditionally enabling the VSC SDP whether or not > > PSR > > itself is enabled. This means if the DP code decided not to us

Re: [Intel-gfx] [PATCH v5] drm/i915/pxp: Add drm_dbgs for critical PXP events.

2023-11-24 Thread Tvrtko Ursulin
On 22/11/2023 19:15, Alan Previn wrote: Debugging PXP issues can't even begin without understanding precedding sequence of important events. Add drm_dbg into the most important PXP events. v5 : - rebase. v4 : - rebase. v3 : - move gt_dbg to after mutex block in function i915_gsc

[Intel-gfx] [PATCH 5/5] drm/i915: Convert PLL flags to booleans

2023-11-24 Thread Ville Syrjala
From: Ville Syrjälä No real reason why the PLL flags need to be a bitmask. Switch to booleans to make the code simpler. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 46 +-- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 22 + 2 files

[Intel-gfx] [PATCH 3/5] drm/i915: Include the PLL name in the debug messages

2023-11-24 Thread Ville Syrjala
From: Ville Syrjälä Make the log easier to parse by including the name of the PLL in the debug prints regarding said PLL. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 39 ++- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/dri

[Intel-gfx] [PATCH 4/5] drm/i915: Suppress old PLL pipe_mask checks for MG/TC/TBT PLLs

2023-11-24 Thread Ville Syrjala
From: Ville Syrjälä TC ports have both the MG/TC and TBT PLLs selected simultanously (so that we can switch from MG/TC to TBT as a fallback). This doesn't play well with the state checker that assumes that the old PLL shouldn't have the pipe in its pipe_mask anymore. Suppress that check for these

[Intel-gfx] [PATCH 2/5] drm/i915: Replace a memset() with zero initialization

2023-11-24 Thread Ville Syrjala
From: Ville Syrjälä Declaring a struct and immediately zeroing it with memset() seems a bit silly to me. Just zero initialize the struct when declaring it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) d

[Intel-gfx] [PATCH 1/5] drm/i915/psr: Include some basic PSR information in the state dump

2023-11-24 Thread Ville Syrjala
From: Ville Syrjälä Currently no one can figure out what the PSR code is doing since we're including any of it in the basic state dump. Add at least the bare minimum there. v2: Also dump has_panel_replay (Jouni) Cc: Jouni Högander Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display